From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150058.outbound.protection.outlook.com [40.107.15.58]) by dpdk.org (Postfix) with ESMTP id 9D0DE1B192 for ; Wed, 9 Jan 2019 08:37:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a0pGBLlUzeC7fFEoU4eNUaHQKFZ69nt5XJZrfalpU0o=; b=jaM1qPQrVOVjjZaeJMijNrpdV70HLas1+Oexitj39G0ZX3IZ3fYZbHJ+a+2c4VWMa+1TnGYLeLZz4JeciVR1jqqX45vOYZg8LorjfdXX+nA4t9q6nrlUIzu28tD/XrJSORwpsuFpsnj0Mn7uV/6/fR4apMt/GZXSv91wMRFVf40= Received: from VI1PR05MB3440.eurprd05.prod.outlook.com (10.170.239.18) by VI1PR05MB6191.eurprd05.prod.outlook.com (20.178.123.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1495.7; Wed, 9 Jan 2019 07:37:05 +0000 Received: from VI1PR05MB3440.eurprd05.prod.outlook.com ([fe80::11e2:9c21:32a7:bc28]) by VI1PR05MB3440.eurprd05.prod.outlook.com ([fe80::11e2:9c21:32a7:bc28%5]) with mapi id 15.20.1495.011; Wed, 9 Jan 2019 07:37:05 +0000 From: Ori Kam To: Jack Min CC: Dekel Peled , Adrien Mazarguil , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] doc: fix MAC address rewrite actions documentation Thread-Index: AQHUpyzuNTlXXeVlOUWI8fdWl1OuZKWmjQOg Date: Wed, 9 Jan 2019 07:37:05 +0000 Message-ID: References: <1546520931-60894-1-git-send-email-dekelp@mellanox.com> <20190108083356.vx73m6ag7lqc2pco@MTBC-JACKMIN.mtl.com> In-Reply-To: <20190108083356.vx73m6ag7lqc2pco@MTBC-JACKMIN.mtl.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB6191; 6:LkSfXzxiYrPVftWvHrKn3EkA3gNKkyLhe3R2L+Pa14ivfYPtR5DsE4LZV6yJtKlnuJYMQYPhM7xAOpRuFP8dSulKq1VqBE/t1htVklzGErC8p5DTAZs/aVqrdWbH50uo+aXXF0A6Zye+32IEUdApltWzmqmh0uef7r6i4naNgGB2QPws+CaHHMcUdQWTGQusdlFc+H0+FQWwaSQXQYIs/TXUw+Sl6NTDj3CLQJEbBrN4m6zwIjhwNwL/jxYZQlH5KaD0sVleiOVXs3jlfiab+l16ih/jSrRToz4xJsES8Y32fIFj72TPvif7W0VHuWfBbsh+MhBqxDv+RYvtpAgJ0kYXKrc+g264bDNn912sjYjytRav6Ulq/A6aWP6PFVyhULRYUtkPRzva8TTnsRNpA87K4vtMJ4pIaH74j7fodQvcfHTjCnMRF58tQdSmxfy+AibArqjVW6fX36Un/NFvDw==; 5:s6nK9E7emb7qgYgXC5E6MjgSo80nrxDjJ/1dU/Z+/Nhr5wvMdIpk6A//i8ztNHmN6yormzkwY0eM0UIJcSc5MH5ySWNixZI+GKG9pmJV+pgQvQpsom2wU+yb5+DwMEtoIRmQV+Le6xbnRG6wx+XTdSYL49PS09qc4oGOd2lTJzGqeUBIhFtTaWGGaE4lqew3yMYWBReWTJk2/lP0NkxB+A==; 7:lk6GjN7OCF5xKXBoawjAPJMe8rj/X1XmCbKrCcukWIQY57BbNrbE7+wPTr7uyPj59yM2izpO5Mb3bkkwdGm0ZQE1gBiE4M+UlmUc0quTM+yNj0MdumXsKnK+Nc3y4X1V/8AGBbpEJLacaDIojUYxuQ== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 89b785c1-7b3d-45de-1cab-08d676054120 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600109)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:VI1PR05MB6191; x-ms-traffictypediagnostic: VI1PR05MB6191: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(8220060)(2401047)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231475)(944501520)(52105112)(6055026)(6041310)(20161123560045)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:VI1PR05MB6191; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB6191; x-forefront-prvs: 0912297777 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(39860400002)(396003)(136003)(13464003)(189003)(199004)(55016002)(33656002)(99286004)(74316002)(81166006)(3846002)(6116002)(54906003)(9686003)(316002)(76176011)(186003)(4326008)(256004)(6862004)(7696005)(53936002)(14444005)(102836004)(7736002)(105586002)(305945005)(106356001)(71200400001)(71190400001)(446003)(11346002)(81156014)(6246003)(26005)(5660300001)(53546011)(25786009)(6506007)(8936002)(8676002)(6436002)(6636002)(486006)(86362001)(476003)(229853002)(2906002)(66066001)(97736004)(478600001)(68736007)(14454004); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB6191; H:VI1PR05MB3440.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: obw8s+nBg1562BLcgmhzJRlggx+8n9HyLYtNFltU4jhCb57QJJ/I/N8Yv35UF7LliS6m8Tja328+Y4gmwFwRXo5fcXy7y4IWmzAAkmOJT4cv2WWP6mEMYQ/e/vLMAtMqPeg4vI1PX4Tjv/7A4rcaMN80pePkJdW6CAaoouYficDfPJSk5r9GWG0ORXzR3a0IqFgml4mEEPwaQXTaSmuwjVuYe0z5ATE3HPZRVfS8uyUfPvY/2KXVCUWtCqNLpZZl375kGEa/9/5hbZaWK+9TKI9x2YSYJpnranrCw+leJsZFaaGWd8IkP2WONpLq/c0m spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89b785c1-7b3d-45de-1cab-08d676054120 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2019 07:37:05.7947 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB6191 Subject: Re: [dpdk-dev] [PATCH] doc: fix MAC address rewrite actions documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 07:37:07 -0000 > -----Original Message----- > From: Jack Min > Sent: Tuesday, January 8, 2019 10:34 AM > To: Ori Kam > Cc: Dekel Peled ; Adrien Mazarguil > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: fix MAC address rewrite actions > documentation >=20 > On 19-01-03 22:20:58, Ori Kam wrote: > > PSB > > > > > -----Original Message----- > > > From: dev On Behalf Of Dekel Peled > > > Sent: Thursday, January 3, 2019 3:09 PM > > > To: Adrien Mazarguil > > > Cc: dev@dpdk.org; Ori Kam ; Dekel Peled > > > ; Jack Min > > > Subject: [dpdk-dev] [PATCH] doc: fix MAC address rewrite actions > > > documentation > > > > > > This patch fixes a typo in SET_MAC_DST action description. > > > It also adds restriction note for set MAC src/dst actions description= . > > > > > > Fixes: 15dbcdaada77 ("ethdev: add generic MAC address rewrite actions= ") > > > Cc: jackmin@mellanox.com > > > > > > Signed-off-by: Dekel Peled > > > --- > > > doc/guides/prog_guide/rte_flow.rst | 10 ++++++++-- > > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > > > diff --git a/doc/guides/prog_guide/rte_flow.rst > > > b/doc/guides/prog_guide/rte_flow.rst > > > index c186375..df1ac2f 100644 > > > --- a/doc/guides/prog_guide/rte_flow.rst > > > +++ b/doc/guides/prog_guide/rte_flow.rst > > > @@ -2314,7 +2314,10 @@ in pattern, Some PMDs will reject rule because > > > behaviour will be undefined. > > > Action: ``SET_MAC_SRC`` > > > ^^^^^^^^^^^^^^^^^^^^^^^ > > > > > > -Set source MAC address > > > +Set source MAC address in the outermost Ethernet header. > > > > This line is incorrect in case we have encap action the modified MAC wi= ll be > the inner. > > > Ori, I think it more likes PMD-specific behaviour and not for API in gene= ral. > What do you think ? Yes this is why the comment is incorrect. We can't say that in all PMD and = in all cases we modified the outer most. The header which is changed it based on the action order. > > > + > > > +It must be used with a valid RTE_FLOW_ITEM_TYPE_ETH flow pattern > item. > > > +Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned. > > > > > > .. _table_rte_flow_action_set_mac_src: > > > > > > @@ -2329,7 +2332,10 @@ Set source MAC address > > > Action: ``SET_MAC_DST`` > > > ^^^^^^^^^^^^^^^^^^^^^^^ > > > > > > -Set source MAC address > > > +Set destination MAC address in the outermost Ethernet header. > > > > This line is incorrect in case we have encap action the modified MAC wi= ll be > the inner. > > > > > + > > > +It must be used with a valid RTE_FLOW_ITEM_TYPE_ETH flow pattern > item. > > > +Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned. > > > > > > .. _table_rte_flow_action_set_mac_dst: > > > > > > -- > > > 1.8.3.1 > > > > > > Thanks, > > Ori