From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0053.outbound.protection.outlook.com [104.47.2.53]) by dpdk.org (Postfix) with ESMTP id 10E867CD9 for ; Thu, 17 May 2018 17:45:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DF2aF4Aw7j8RIr+FFsREgbUbf6/Eh26PrEGRzS6z4/k=; b=eWpGpzYPStXge9ZwfRWV3d+11R9FIleKfaVPJ7JhE3NDFuYxzGWKTqwfGyZOishrh61zqSYs0D4DtFxnGrQNuDRqOK9xNwMRnOUYLzgUuLGgcCy1RwsRMHdc8K8drInrCSY5+53slsiy0z2dt7bZItBnYvbaNtzkb8s9+qCHuAE= Received: from VI1PR05MB4431.eurprd05.prod.outlook.com (52.133.13.26) by VI1PR05MB1615.eurprd05.prod.outlook.com (10.165.235.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Thu, 17 May 2018 15:45:02 +0000 Received: from VI1PR05MB4431.eurprd05.prod.outlook.com ([fe80::1cf0:a1f5:f7c3:ba7d]) by VI1PR05MB4431.eurprd05.prod.outlook.com ([fe80::1cf0:a1f5:f7c3:ba7d%13]) with mapi id 15.20.0776.010; Thu, 17 May 2018 15:45:02 +0000 From: Shahaf Shuler To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= CC: Adrien Mazarguil , Yongseok Koh , "dev@dpdk.org" , "Xueming(Steven) Li" , Matan Azrad Thread-Topic: [PATCH] net/mlx5: fix default RSS level Thread-Index: AQHT7eN6++Yr06kTWk2nnBIB1Ra8ZqQz68bg Date: Thu, 17 May 2018 15:45:02 +0000 Message-ID: References: <20180515132324.192750-1-shahafs@mellanox.com> <20180517133201.vf32khpzv44ds2xb@laranjeiro-vm.dev.6wind.com> In-Reply-To: <20180517133201.vf32khpzv44ds2xb@laranjeiro-vm.dev.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1615; 7:/GspjfbTJtByr6jUk2KEe960PGASNA43slruTAhHpIbld7Tb/oygCWVnX/G2BoTCSe0FFOdpRsJXBgmnKsP9qTULeuzaHtuTBknXomzE7BiOaQGbkk/lK4Dhy6OUFY7m25ak5Vha3EI519DS1C3UpOP7tIdnCxMZeP278sM7khZDQXvAYpS2gB36ktRkJ55ohIq0RGqnU+ZipmXi8vg6nkUJyrx2CawCeFdlZlxsx9pOoyzZ87Pv4uW6FGaR4++p x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:VI1PR05MB1615; x-ms-traffictypediagnostic: VI1PR05MB1615: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:VI1PR05MB1615; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB1615; x-forefront-prvs: 067553F396 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(39380400002)(366004)(376002)(346002)(189003)(199004)(229853002)(3846002)(6116002)(81166006)(81156014)(68736007)(3280700002)(6506007)(102836004)(66066001)(4326008)(54906003)(486006)(25786009)(476003)(6916009)(478600001)(97736004)(8936002)(74316002)(305945005)(8676002)(316002)(6436002)(5660300001)(53936002)(6246003)(107886003)(106356001)(76176011)(7736002)(9686003)(55016002)(446003)(86362001)(11346002)(2906002)(186003)(3660700001)(99286004)(26005)(2900100001)(33656002)(5250100002)(7696005)(14454004)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1615; H:VI1PR05MB4431.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: W5VyR8QJSYmU86/vU/Vyq6H0bU/ifTsK8ej4WgQLK2fLlZt0RWy+hbfri4eUJuwJ9VglfrAu/qy3LRqv+WlXHDQN0SjAoJr6EzKJ5bz3Mh9QZsKcxf7M10dcOKag9Lp6fC1rZ33+49mNPKRNITszoWgPEJgD0X/As43SoQi9PxmFHgSwDA48ujLlPwqbgVFF spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 40d40051-50e6-4c4c-3765-08d5bc0d273f X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40d40051-50e6-4c4c-3765-08d5bc0d273f X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2018 15:45:02.0594 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1615 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix default RSS level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 15:45:04 -0000 Thursday, May 17, 2018 4:32 PM, N=E9lio Laranjeiro: > Subject: Re: [PATCH] net/mlx5: fix default RSS level >=20 > On Tue, May 15, 2018 at 04:23:24PM +0300, Shahaf Shuler wrote: > > Using inner RSS by default for GRE leads to memory corruption as the > > extra flow items added for the inner RSS are not counted in the flow > > attributes buffer size. > > > > Fixing by enforcing the default RSS level to be outer. This much > > simplify the flow engine and more robust. > > Future optimization for out of the box RSS can be done on subsequent > > commits. > > > > Fixes: d4a405186b73 ("net/mlx5: support tunnel RSS level") > > Cc: xuemingl@mellanox.com > > Cc: matan@mellanox.com > > > > Signed-off-by: Shahaf Shuler >=20 > Acked-by: Nelio Laranjeiro >=20 Applied to next-net-mlx, thanks.