From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0084.outbound.protection.outlook.com [104.47.1.84]) by dpdk.org (Postfix) with ESMTP id E68FE7CD9; Thu, 17 May 2018 17:46:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VkcyYuRCPq1OGGYyyR/FjWUj1/Gy9zHxJSLZMomXvC4=; b=qIWqT+105QU9ixxFp++YHoahRPXMysOCZDakBpK2UxgybbCRfE0XyfcSMlTCYKITVfMks3pYPoDafWHKQzYr7sYJfz4EKZtznBUQvwJ1/DboVnx7g29poAdbdg1D7mBwvOgWtAFQyv55ZReJOWZuxG0vb5GD04IaQ1ggJduhQ2c= Received: from VI1PR05MB4431.eurprd05.prod.outlook.com (52.133.13.26) by VI1PR05MB1837.eurprd05.prod.outlook.com (10.166.44.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.776.11; Thu, 17 May 2018 15:46:49 +0000 Received: from VI1PR05MB4431.eurprd05.prod.outlook.com ([fe80::1cf0:a1f5:f7c3:ba7d]) by VI1PR05MB4431.eurprd05.prod.outlook.com ([fe80::1cf0:a1f5:f7c3:ba7d%13]) with mapi id 15.20.0776.010; Thu, 17 May 2018 15:46:49 +0000 From: Shahaf Shuler To: Adrien Mazarguil CC: Ferruh Yigit , "dev@dpdk.org" , "stable@dpdk.org" , Matan Azrad Thread-Topic: [PATCH] net/mlx4: fix shifts of signed values Thread-Index: AQHT7THnCB9x10K4YEKZrlNdg19t3aQz7O8Q Date: Thu, 17 May 2018 15:46:49 +0000 Message-ID: References: <20180516161212.17602-1-adrien.mazarguil@6wind.com> In-Reply-To: <20180516161212.17602-1-adrien.mazarguil@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1837; 7:nZrn5VDFYdsb1m50w0gA/ktnHbJMkwsmeiKKAK8utQy4o7BsK6RAi1MPzK2OxMMViMySJxred5ozq0hHgOIdB45lVojBf2dSDt+2ZIMzy9mIcSROezQkZbEgJwnZuGJYZBfswzAe+BEn40zu4IzbivkVjLWRvU0Swn4sB/GH7SxvgH/3prNhMBHuAFEdYJcv6KWjlCplONXsJZFVWGXlsJLqcWDD1dzlUCojqeZVUf5dwc/sdnjUgzhPNbPy1b5n x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603328)(7153060)(7193020); SRVR:VI1PR05MB1837; x-ms-traffictypediagnostic: VI1PR05MB1837: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3231254)(944501410)(52105095)(93006095)(93001095)(3002001)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:VI1PR05MB1837; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB1837; x-forefront-prvs: 067553F396 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(376002)(39860400002)(39380400002)(346002)(189003)(199004)(3280700002)(33656002)(2906002)(6246003)(74316002)(5660300001)(486006)(107886003)(53936002)(2900100001)(66066001)(81166006)(86362001)(9686003)(8936002)(5250100002)(3660700001)(6436002)(81156014)(7736002)(54906003)(8676002)(305945005)(316002)(6916009)(97736004)(4326008)(55016002)(229853002)(446003)(105586002)(102836004)(76176011)(6506007)(7696005)(11346002)(25786009)(68736007)(26005)(478600001)(6116002)(186003)(3846002)(476003)(99286004)(14454004)(106356001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1837; H:VI1PR05MB4431.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: xrdYaoddxSI1Ysot4t9wWRGV72U6CO0dWL9HmqZrv3jJbirVeTq72sW8YvKPUlSOopNAK8Eoo/SDcCWVHEcO+KzhqTc5zpOv+MFZo9bK/KZVfthT4/hJZ8RihlVuWC4t2uXvKPmmCc3FVG4IPVjWEc5Fs4haO29gFZrAw5MV0m4WW8cZtq3UGaF7wUfSM0Er spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 185808be-b05e-4f3d-95a9-08d5bc0d675e X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 185808be-b05e-4f3d-95a9-08d5bc0d675e X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2018 15:46:49.5923 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1837 Subject: Re: [dpdk-dev] [PATCH] net/mlx4: fix shifts of signed values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 15:46:51 -0000 Wednesday, May 16, 2018 7:21 PM, Adrien Mazarguil: > Subject: [PATCH] net/mlx4: fix shifts of signed values >=20 > This patch addresses the following issues reported by cppcheck: >=20 > [drivers/net/mlx4/mlx4_rxtx.c:266]: (error) Shifting signed 32-bit value > by 31 bits is undefined behaviour > [drivers/net/mlx4/mlx4_rxtx.c:624]: (error) Shifting signed 32-bit value > by 31 bits is undefined behaviour > [drivers/net/mlx4/mlx4_txq.c:89]: (error) Shifting signed 32-bit value b= y > 31 bits is undefined behaviour > [drivers/net/mlx4/mlx4_txq.c:91]: (error) Shifting signed 32-bit value b= y > 31 bits is undefined behaviour >=20 > Fixes: 78e81a9844f8 ("net/mlx4: merge Tx queue rings management") > Cc: stable@dpdk.org > Cc: Matan Azrad >=20 > Reported-by: Ferruh Yigit > Signed-off-by: Adrien Mazarguil Applied to next-net-mlx, thanks.=20