From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42E63A04EF; Mon, 1 Jun 2020 08:11:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 296C11D50C; Mon, 1 Jun 2020 08:11:19 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00049.outbound.protection.outlook.com [40.107.0.49]) by dpdk.org (Postfix) with ESMTP id 24F6C1D505 for ; Mon, 1 Jun 2020 08:11:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ilfVbL+QcHVznYxLbuJ9/vUPfy2gtEhwYL+ZSPCcM+GIIeoKmwScm4HvR9xSow+rwPPJpnQG48lV7t6SUMXzh33rxU+wEbO7n2SDe5pBok+VfzYhI0lFeK4fAUjdPs+AUKvFhCH+WWiOEaRC/OaEv3tGMDrqT8x5PvXEhcZy89pChZHIUcIZnkjBUQInqHflE1okFn41YnFFoqWUHi45/0ivw0OoiWJ58bCWS1IMgh1yco2a7re9IzhjdPxEJfm3Ce/rSesOaw2VH6hinn7q6q1J7tg8dyb1LqevQc5gjSLvBEDjUcNBQ4A2mq/DSNKxY7VN2osa41GOFr8snkBrtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2gxumsuwNtEnOIz86jQn1liOi99G5N3bP7+N+p6AJQM=; b=M8iNqQONxlIguPoPchMpfGanxCc+UGVhPKq6gk71RBPMqXL1D78ubZNzcHbY21++aa4q0XT8hzgONPAwuzsuLNA370GpIAwwpFO8C55zcJoW4YzEX1WXWJ/573FSVFOMvSWucBi6KoeLSQzgy/wl0i+7/V4AzWQbM7LWO9iVmK66kPVPTPcmPY/E7527X7LiuC1oG0dGGrxIyYKaHx/BxzjQScN5SqNA/tE7sWoIiE6dTJx/l9xncyfNpNyU2SmMoOu5kKhHo4PEtDFy/aC5jEqK0rNSxgrChrMhOFfbkG2DgUvFrsaCP7vXzHq27/z5ElJWEJ/jyRRMeTN+G+m8EQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2gxumsuwNtEnOIz86jQn1liOi99G5N3bP7+N+p6AJQM=; b=Hz0z0sTswFzIG/vZFiT/V7BByyVsvI7THmcEpOM6MPsriLueRzoUuUKbvgPiJ+qB/p1LD4uCUFTevJKtljSt5rACTlTxvij4WGEZan4tRkpYJh1822sD0aDhupVXdJ+4MyJvXmN1TKxRsLYqZ8tbWjKr/SjtgglW+pJI8uBuY80= Received: from VI1PR05MB5390.eurprd05.prod.outlook.com (2603:10a6:803:8d::23) by VI1PR05MB3517.eurprd05.prod.outlook.com (2603:10a6:802:20::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.22; Mon, 1 Jun 2020 06:11:15 +0000 Received: from VI1PR05MB5390.eurprd05.prod.outlook.com ([fe80::b9e9:e3f2:7eb1:d325]) by VI1PR05MB5390.eurprd05.prod.outlook.com ([fe80::b9e9:e3f2:7eb1:d325%5]) with mapi id 15.20.3021.030; Mon, 1 Jun 2020 06:11:15 +0000 From: Dekel Peled To: Stephen Hemminger CC: "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , Ori Kam , "john.mcnamara@intel.com" , "marko.kovacevic@intel.com" , Asaf Penso , Matan Azrad , Eli Britstein , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC] ethdev: add fragment attribute to IPv6 item Thread-Index: AQHWN1np6t73uL88VkmopmBWb3gfr6jDPxEAgAAHDtA= Date: Mon, 1 Jun 2020 06:11:15 +0000 Message-ID: References: <5f9b4d30b81fa68ed875106785419a43cc7a6166.1590935677.git.dekelp@mellanox.com> <20200531223832.1cbcd75b@hermes.lan> In-Reply-To: <20200531223832.1cbcd75b@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [5.29.43.98] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 352cae04-435c-4a0f-34e1-08d805f2979c x-ms-traffictypediagnostic: VI1PR05MB3517: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 0421BF7135 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: o1mKlODrw9D7a38QUMc+ZFmYdpsNIU03Dn0qzsWJtOpo53m/+epBiGLHpSjyZcQie1iti7pDcOsCFJUxFNdj4Lnw5JUUwTIYkj5raw1V2ChA0rtcIr3dsoB+BTCBdfc15wRwI+dbgjk5ORZQToLMDhi+ZwaPBO4+sV838hgcF1d2Fz13NiuWIrKOeR1Af5B1hXFqBud0IUliKrT1+E3kGbMjNIRL4ZfiTcIZVeWy+/1EjTfgX0paj2aVue+t20f8iWzer65Ch5vcmPIt8G6m6UnTGtUfqE+mckGOgWsE7OLD2R6YRNRoGqviBxrysobsktpbPere2pm8uCDbk8SWRDmo6U4FNpdFuphVXHhw8MTmtcOpvHTQRuEntkzI3dov5wbhXsffxhYNcoLqZmp0jQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR05MB5390.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(39860400002)(136003)(396003)(376002)(366004)(83080400001)(53546011)(6506007)(66946007)(66476007)(66556008)(7696005)(66446008)(6916009)(76116006)(64756008)(966005)(33656002)(4326008)(26005)(45080400002)(186003)(54906003)(83380400001)(478600001)(316002)(55016002)(86362001)(9686003)(5660300002)(52536014)(2906002)(8936002)(8676002)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: eRv+qbZHseXo1bmXooo/KSWcmlLO64+VP0v+ODSZ6qgggtFMwZZBXOjuiaiXq+R4iWrKzoIq2cGXnA8sgGABp9B6FnCYCp5Hh6T1hJm2RvUoYCleVToDFbQVRBt3Kj7ERx6bJ1eTCGxzP1n2oDmSPo10FdQEQbnseB5TSvxDCnQ2oZJZ648LrR60rzTzSt1jhLo5ArYY40kw1DWAsJDrq7aXcPYJfMp1a2s/O/VVmluILBLchjX9iy9QEalr7nEgXow4KT4ziFe7apgIf+dvlCwDbhIcdPXUMZvKoUCiR/ymYtJfTnEtSt9C2bBLxg9N+9diS0tbBlk2IYFpja1CTslm24UQenxzE8w2oVCuhvNpE40oXieR0OVAzGohnFsfZ6Cm/qmCVMy49v3R3qcf/dZjcZKvo1JufrZYQHDpMo9zsP7uPOw1mUZ+t+KoNwqNfY/cfyRj6aMeTnnMg+RvdDxz5uIVqjfKUUYRdc6TYxY= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 352cae04-435c-4a0f-34e1-08d805f2979c X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jun 2020 06:11:15.5617 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: j4uUnW8orLHNRlZ4qPpraP5VlLuWiksw63g3X7GHQBouCvLATNKvyctXKtrGJKA/jfnBbFxFnUIIVGNHTtCqzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3517 Subject: Re: [dpdk-dev] [RFC] ethdev: add fragment attribute to IPv6 item X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks, PSB. > -----Original Message----- > From: Stephen Hemminger > Sent: Monday, June 1, 2020 8:39 AM > To: Dekel Peled > Cc: ferruh.yigit@intel.com; arybchenko@solarflare.com; Ori Kam > ; john.mcnamara@intel.com; > marko.kovacevic@intel.com; Asaf Penso ; Matan > Azrad ; Eli Britstein ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC] ethdev: add fragment attribute to IPv6 item >=20 > On Sun, 31 May 2020 17:43:29 +0300 > Dekel Peled wrote: >=20 > > Using the current implementation of DPDK, an application cannot match > > on fragmented/non-fragmented IPv6 packets in a simple way. > > > > In current implementation: > > IPv6 header doesn't contain information regarding the packet > > fragmentation. > > Fragmented IPv6 packets contain a dedicated extension header, as > > detailed in RFC [1], which is not yet supported in rte_flow. > > Non-fragmented packets don't contain the fragment extension header. > > For an application to match on non-fragmented IPv6 packets, the > > current implementation doesn't provide a suitable solution. > > Matching on the Next Header field is not sufficient, since additional > > extension headers might be present in the same packet. > > To match on fragmented IPv6 packets, the same difficulty exists. > > > > Proposed update: > > An additional value will be added to IPv6 header struct. > > This value will contain the fragmentation attribute of the packet, > > providing simple means for identification of fragmented and > > non-fragmented packets. > > > > This update changes ABI, and is proposed for the 20.11 LTS version. > > > > [1] > > > https://eur03.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fmails > > .dpdk.org%2Farchives%2Fdev%2F2020- > March%2F160255.html&data=3D02%7C01 > > > %7Cdekelp%40mellanox.com%7C9ee87004dc3943b945c908d805ee0bcc%7Ca > 652971c > > > 7d2e4d9ba6a4d149256f461b%7C0%7C0%7C637265867256841029&sdata > =3Drf1zYz > > > fNLGdqayXLHffO%2FrM%2FeX5op6KO91RDKq%2BYk3Q%3D&reserved > =3D0 > > > > Signed-off-by: Dekel Peled > > --- > > lib/librte_ethdev/rte_flow.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/lib/librte_ethdev/rte_flow.h > > b/lib/librte_ethdev/rte_flow.h index b0e4199..3bc8ce1 100644 > > --- a/lib/librte_ethdev/rte_flow.h > > +++ b/lib/librte_ethdev/rte_flow.h > > @@ -787,6 +787,8 @@ struct rte_flow_item_ipv4 { > > */ > > struct rte_flow_item_ipv6 { > > struct rte_ipv6_hdr hdr; /**< IPv6 header definition. */ > > + uint32_t is_frag:1; /**< Is IPv6 packet fragmented/non-fragmented. > */ > > + uint32_t reserved:31; /**< Reserved, must be zero. */ > > }; >=20 > You can't do this in the 20.08 release it would be an ABI breakage. Please see above, I noted in the commit log that this is proposed for 20.11= .