Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix match on empty VLAN item in DV mode

[Dekel Peled <dekelp@mellanox.com>]

Repo link:
https://git.dpdk.org/next/dpdk-next-net-mlx/commit/?id=40513808b165f7436389bfffcc8a35dbdc93121c

Regards,
Dekel

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Monday, May 11, 2020 8:19 PM
> To: Dekel Peled <dekelp@mellanox.com>; Matan Azrad
> <matan@mellanox.com>; Slava Ovsiienko <viacheslavo@mellanox.com>;
> Raslan Darawsheh <rasland@mellanox.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix match on empty VLAN item
> in DV mode
> 
> On 5/5/2020 1:57 PM, Dekel Peled wrote:
> > In existing implementation, using wild card VLAN item is not allowed.
> > A VLAN item in flow pattern must include VLAN ID (vid) value.
> > This obligation contradics the intention of documentation update [1].
> 
> At this perspective it is not "documentation update" but "flow API
> spec/contract".
> 
> >
> > This patch updates the VLAN item validation and translation, to allow
> > wild card VLAN item, without VLAN ID value.
> > User guide and release notes are updated accordingly.
> >
> > [1]
> >
> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> >
> es.dpdk.org%2Fpatch%2F69207%2F&amp;data=02%7C01%7Cdekelp%40mell
> anox.co
> >
> m%7Ca4d34826f0104f0bfa4a08d7f5cf7090%7Ca652971c7d2e4d9ba6a4d14925
> 6f461
> >
> b%7C0%7C0%7C637248143603832039&amp;sdata=j%2BjcdLaYQ7Kzgdnq454X
> q8RWfdl
> > S7oFBibFgUjruGhk%3D&amp;reserved=0
> 
> Can you please refer to the commit in the repo, instead of a superseded
> patch in patchwork?
> 
> Will update above while merging.
> 
> >
> > Fixes: 00f75a40576b ("net/mlx5: fix VLAN match for DV mode")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> > Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> 
> <...>