From: Fady Bader <fady@mellanox.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Tasnim Bashar <tbashar@mellanox.com>,
Tal Shnaiderman <talshn@mellanox.com>,
Yohad Tor <yohadt@mellanox.com>,
"dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com>,
"harini.ramakrishnan@microsoft.com"
<harini.ramakrishnan@microsoft.com>,
"ocardona@microsoft.com" <ocardona@microsoft.com>,
"pallavi.kadam@intel.com" <pallavi.kadam@intel.com>,
"ranjit.menon@intel.com" <ranjit.menon@intel.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
"mdr@ashroe.eu" <mdr@ashroe.eu>,
"nhorman@tuxdriver.com" <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH v3 3/4] eal: export needed functions for mempool
Date: Thu, 2 Jul 2020 10:24:11 +0000 [thread overview]
Message-ID: <VI1PR05MB5872B08C451BD60CD7F32EA9BF6D0@VI1PR05MB5872.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1983340.Wn3agqbDfT@thomas>
Ok, I'll send a new version today.
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, June 30, 2020 2:29 AM
> To: Fady Bader <fady@mellanox.com>
> Cc: dev@dpdk.org; Tasnim Bashar <tbashar@mellanox.com>; Tal Shnaiderman
> <talshn@mellanox.com>; Yohad Tor <yohadt@mellanox.com>;
> dmitry.kozliuk@gmail.com; harini.ramakrishnan@microsoft.com;
> ocardona@microsoft.com; pallavi.kadam@intel.com; ranjit.menon@intel.com;
> olivier.matz@6wind.com; arybchenko@solarflare.com; mdr@ashroe.eu;
> nhorman@tuxdriver.com
> Subject: Re: [dpdk-dev] [PATCH v3 3/4] eal: export needed functions for
> mempool
>
> 22/06/2020 13:55, Fady Bader:
> > Some eal functions were used by mempool lib but not exported on Windows.
> > The function was exported.
>
> Do not use past for facts which are still true after the patch.
>
> This patch could be merged with next one enabling the compilation.
>
>
next prev parent reply other threads:[~2020-07-02 10:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <'20200531124151.16848-2-fady@mellanox.com'>
2020-06-22 11:55 ` [dpdk-dev] [PATCH v3 0/4] build mempool on Windows Fady Bader
2020-06-22 11:55 ` [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning " Fady Bader
2020-06-29 23:26 ` Thomas Monjalon
2020-07-02 10:25 ` Fady Bader
2020-06-30 10:49 ` Kinsella, Ray
2020-07-02 14:56 ` Kinsella, Ray
2020-07-05 7:00 ` Fady Bader
2020-07-05 8:37 ` Thomas Monjalon
2020-07-05 8:51 ` Fady Bader
2020-07-05 9:00 ` Thomas Monjalon
2020-07-05 20:00 ` Thomas Monjalon
2020-07-07 7:57 ` Kinsella, Ray
2020-06-22 11:55 ` [dpdk-dev] [PATCH v3 2/4] mempool: use generic memory management Fady Bader
2020-06-22 11:55 ` [dpdk-dev] [PATCH v3 3/4] eal: export needed functions for mempool Fady Bader
2020-06-29 23:28 ` Thomas Monjalon
2020-07-02 10:24 ` Fady Bader [this message]
2020-06-22 11:55 ` [dpdk-dev] [PATCH v3 4/4] mempool: mempool build on Windows Fady Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR05MB5872B08C451BD60CD7F32EA9BF6D0@VI1PR05MB5872.eurprd05.prod.outlook.com \
--to=fady@mellanox.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=harini.ramakrishnan@microsoft.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=ocardona@microsoft.com \
--cc=olivier.matz@6wind.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@mellanox.com \
--cc=tbashar@mellanox.com \
--cc=thomas@monjalon.net \
--cc=yohadt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).