From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBB27A0526; Wed, 8 Jul 2020 12:20:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE1761DAF4; Wed, 8 Jul 2020 12:20:03 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40086.outbound.protection.outlook.com [40.107.4.86]) by dpdk.org (Postfix) with ESMTP id B445A1D452 for ; Wed, 8 Jul 2020 12:20:02 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YywEH2yj95cHUdEgRLXORRVJVk0jJVMKX4ZVcAOxhfu3pZHApaWiJUbH1G5a3Duz/BJhcCBC5D8YHPjQOOLF5txaMuOchQeUJGocU2npI+oC1ajFzMbpGKiBy8rEICZ1baMV2dRixVdXZ3aHLH8dao4ig6nEslPVEw8KgQkNWvx3x9m59o03PnQS39dbBjZzj0SL8fx0gp7aEphjRE65ByQGXg6Dze5LLD9gylPGAof7sKfUguLO3Un2iGjs+jmNvqBc83KlgePvdB2pw021+TQT/1hZ6Ud4n0/Vgisb54ss/BXd7mPk7i0Dwa+RIWyal5BlA7OATSqTEDEbAZE4BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ji/6uM7KThVbfPjQrblH65vV3mA/WSableS0xINXMoo=; b=QwLPubyBDlwU7H1pOzjJSKELoZOg/LnhOpXHTiQ1ewoWL3YG9q99ilpV4QeV8XMtYjQS2vkVZzSPjQMjX8axkgVSb9UQYWELkbRQU6BzzRUZ+vKTo7gcMwqF8ej3fS9c92rGo4MrG0bxQlMGHwHaQWHFAk+/TovBtFhJJV21q1AgeVv8gnNUkIdm7baGgA7BVjR0TGVBydAA8eZ5Vvic7SKWApc3ex9gNsW5lalJ/McSrkvl4PM5K1JeQ2bkXiCq9sxG0N3wZSCa6ltiuwjifiQPnqLnLSLuIdOqahWXxR1MJGO16oLlxf4k91b185WrpMZXIuBX4x20JUmueiYE6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ji/6uM7KThVbfPjQrblH65vV3mA/WSableS0xINXMoo=; b=UspyZwP4bWq+vJDWB8xVrfFFOUUOo5zJGQ7CMIEydmnLe2AXzzutnHjA1sObQ9YI5dpYYdYXSiF8Lm8Cd2HGzu3iKTbWg01mAmrXyAys2Yfvzgsht5QaMdPq9PS3rB5Q4alDPKqVZY8/LxBBxQFTTfU82GPwfVZF4Vg9u1t8TR8= Received: from VI1PR05MB5872.eurprd05.prod.outlook.com (2603:10a6:803:de::17) by VI1PR0501MB2575.eurprd05.prod.outlook.com (2603:10a6:800:68::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21; Wed, 8 Jul 2020 10:19:59 +0000 Received: from VI1PR05MB5872.eurprd05.prod.outlook.com ([fe80::ec95:ae9e:77c8:63ae]) by VI1PR05MB5872.eurprd05.prod.outlook.com ([fe80::ec95:ae9e:77c8:63ae%6]) with mapi id 15.20.3153.030; Wed, 8 Jul 2020 10:19:59 +0000 From: Fady Bader To: Thomas Monjalon CC: "dev@dpdk.org" , Tasnim Bashar , Tal Shnaiderman , Yohad Tor , "dmitry.kozliuk@gmail.com" , "harini.ramakrishnan@microsoft.com" , "ocardona@microsoft.com" , "pallavi.kadam@intel.com" , "ranjit.menon@intel.com" , "olivier.matz@6wind.com" Thread-Topic: [PATCH v3 3/3] eal/windows: librte_net build on Windows Thread-Index: AQHWVQeVhsOtKQiVj0S1Bsf3zFa7raj9d2pA Date: Wed, 8 Jul 2020 10:19:58 +0000 Message-ID: References: <20200610120040.17968-1-fady@mellanox.com> <20200708082525.28504-1-fady@mellanox.com> <20200708082525.28504-4-fady@mellanox.com> <10921482.ctDyDSMbzN@thomas> In-Reply-To: <10921482.ctDyDSMbzN@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [79.183.29.26] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 394de8cb-f573-4c28-0697-08d8232877f7 x-ms-traffictypediagnostic: VI1PR0501MB2575: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iHzRf5w7QyMsk3rd24zfam+VHVa/bzruJoBxcgqL18b/G1XXrqdD7Eun4y2zzgkOrtHxKhxG8bTQA9NC8Au7ZwYKyEoN4L2IpI5ADFzbfMsYF+9pbexmEXOWJJgzYw3OPsq9vM7VYA7Q8dwAsEnYUAxHvgcbmYjvSLp911pFB66GuJ9QF/NbZtKO2x+rTMIXp0SXGUCnbOpVKWg5y+f1pKy4JFz7SjieLFlkevXJiGqYB7dODpx+IKCOwpejkIQJzQUeBe7AfFfPhYNwcrkpg7w3ndKwdUzysiX5jOv9roCKhSNds1Dks87m2tGnX6ShU5dH6qVP1uHp32Ry8z7fLA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR05MB5872.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(346002)(376002)(39860400002)(396003)(136003)(54906003)(9686003)(7696005)(83380400001)(66476007)(66556008)(66446008)(5660300002)(6506007)(64756008)(71200400001)(76116006)(66946007)(316002)(45080400002)(2906002)(8676002)(86362001)(8936002)(53546011)(186003)(6916009)(55016002)(33656002)(4326008)(478600001)(52536014)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: TukZC33WUEPo1lQlo2Jgu+3IN+ZAEfuO3jgDSoX4FkES83lD/ckMfbzj7ZNIC6zbjQOwK9ZrervGjYpG6Lyy6g+IVkuyaKyIDkOX6vb6c3GkKeStvd7fr0wCj1XpYRejb27BSMCGwsik6S5M1gOZrpeYryVHAORLPbQklZCCgkhaCFDgKMXJXRnW7A+z3Xh3eLJKkipxx+Z8TTXqL4j5iqrG+OOqbTfAhnAMLw7fsQZn9ZMUmchAC8HONSVVHLZarpT/XwaygADYAEgiWXmYBFm5Namfl4u5iVSg/0TrGHQcFvRFjE7sa4YOg4Kunp554DNWGgqe2OqyjrBaXKJ7hCYK/XT48mBBJNZEk4dy0xotCrbE1fVdTXz9yPlzag7fj2Xx64DqcyWqD1VojBNVMmTQefqykEsaYoDW5Ib5VYQ2bOttSwo4U1n52bmMxeJ02Mjn8YbrG7Rw/iE4OVTQxXfdfzW0QuBh5yGVfvtF+HM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR05MB5872.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 394de8cb-f573-4c28-0697-08d8232877f7 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2020 10:19:58.9727 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eEiq8mCWPtoa+6vDh5PyOiqa8cusnIStRpc4AF0VaSUefRsyPnUDcTzd8+pecR6iqgjWxzHOV2r2U62SVgkEiw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2575 Subject: Re: [dpdk-dev] [PATCH v3 3/3] eal/windows: librte_net build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, July 8, 2020 12:10 PM > To: Fady Bader > Cc: dev@dpdk.org; Tasnim Bashar ; Tal Shnaiderman > ; Yohad Tor ; > dmitry.kozliuk@gmail.com; harini.ramakrishnan@microsoft.com; > ocardona@microsoft.com; pallavi.kadam@intel.com; ranjit.menon@intel.com; > olivier.matz@6wind.com > Subject: Re: [PATCH v3 3/3] eal/windows: librte_net build on Windows >=20 > 08/07/2020 10:25, Fady Bader: > > --- /dev/null > > +++ b/lib/librte_eal/windows/include/netinet/in.h > > @@ -0,0 +1,25 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright 2020 Mellanox Technologies, Ltd */ >=20 > As said previously, the license and copyright are not correct. > Please keep the original copyright. I'll change this. > Given there is no invention here, can we consider it can be re-licensed a= s BSD > with your copyright? > I think we can, but I prefer having this discussion openly. Ok. >=20 >=20 > > +#ifndef _IN_H_ > > +#define _IN_H_ > > + > > +#define IPPROTO_IP 0 > > +#define IPPROTO_HOPOPTS 0 > > +#define IPPROTO_IPV4 4 /* IPv4 encapsulation */ > > +#define IPPROTO_IPIP IPPROTO_IPV4 /* for compatibility */ > > +#define IPPROTO_TCP 6 > > +#define IPPROTO_UDP 17 > > +#define IPPROTO_IPV6 41 /* IP6 header */ > > +#define IPPROTO_ROUTING 43 /* IP6 routing header */ > > +#define IPPROTO_FRAGMENT 44 /* IP6 fragmentation header */ > > +#define IPPROTO_GRE 47 /* General Routing Encap. */ > > +#define IPPROTO_ESP 50 /* IP6 Encap Sec. Payload */ > > +#define IPPROTO_AH 51 /* IP6 Auth Header */ >=20 > Why IP6 for ESP and AH. Isn't it IPsec? You are correct. I'll change accordingly. >=20 > > +#define IPPROTO_NONE 59 /* IPv6 no next header */ > > +#define IPPROTO_DSTOPTS 60 /* IP6 destination option */ > > +#define IPPROTO_SCTP 132 /* Stream Control Transmission Prot= ocol */ >=20 > There are some strange tabs above. I will change this. >=20 > Please replace IP6 with IPv6. Ok. >=20 > Which values are really used currently in DPDK? Or which ones are not? I'll check for each value and send a new "in.h" having only the used values= . >=20