From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF2B9A00BE; Wed, 29 Apr 2020 11:03:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 353ED1D940; Wed, 29 Apr 2020 11:03:51 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2078.outbound.protection.outlook.com [40.107.21.78]) by dpdk.org (Postfix) with ESMTP id D88671D93F for ; Wed, 29 Apr 2020 11:03:49 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PpZ2gcchNWXZ6hkGC0JydkIIELxcLzzUv6FrE36psU5EWpFHreA9txvU1FQ797vADybBP/C01Mno8t84LCNttzYoNX+VRhy8QKOzx08DprRrWIr2iSLpW9IW9O+I93z+MXcVCtwZYkDpfXzRl2Rm8meZZVxe9buUHUBa+c+gzSMD9RINYJbTvl2pIhF1zQbnzum4pb0lZ0yzgAZXj4BM1FDayZQj1kVgH62VHV/0QyDOY9JHwOMur29OTWO0oswEAjehZ0OvpZsza5WYHcJC5ZvCd5IQLiKzwlzrgLyGQo5RR6ZCOCBRA0fzdGhKFYDX/hr+/lxc/+K9nk/eQHvrUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fkaBWnUhUFBr1KGFAh2DCLlvdHbsmbfsOe9yXdFsqYw=; b=DP7ShwQ4YNCZ2XvH9S6mYPgOFyj51aTSsYa671WgCoF4HDTBIu6UPwduondsUagt6guwUpaFrvKE/84W7loYzaOL2zoxIESH3JffTJW3qGK8vO+j/y1d0MAUKrUg6vN7gNecTxI2T0R0n9NhNegol7Yal4/GbEQ9JbPtkOPvag5Cf9Fy7998H+fxpmpKBFBfRLQvn++2c+9Kjw+4umfhRKPl1L9ReB73K2PctZNQGdjNWDUUni11TqQZs9MTmv1m1V0A091KEOmu4CNYD20NjNiAartoW1KVaSnwzGR6SR24ASEHJ31eLyyEfsSJcrridc8zJF0b0XE0Q3aYoa37/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fkaBWnUhUFBr1KGFAh2DCLlvdHbsmbfsOe9yXdFsqYw=; b=LX57gp6Xie7ZU8ENepBV/d64UFexZaCBAtOkz2yG7ebiJhsveECAgHfQji1+2g6Ubm0Uj12r3uMf5zGc7EiF/YOpsMoFD5nNi677r7FdPHyORZCIKLURVQKA6fNk0FuKLghhoihkW7xLyZT65pbaWUJBobmXmQ8byczOiEs7rIs= Received: from VI1PR05MB6718.eurprd05.prod.outlook.com (2603:10a6:800:13b::9) by VI1PR05MB5581.eurprd05.prod.outlook.com (2603:10a6:803:9b::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Wed, 29 Apr 2020 09:03:47 +0000 Received: from VI1PR05MB6718.eurprd05.prod.outlook.com ([fe80::6d6a:e905:6b4b:addd]) by VI1PR05MB6718.eurprd05.prod.outlook.com ([fe80::6d6a:e905:6b4b:addd%6]) with mapi id 15.20.2937.023; Wed, 29 Apr 2020 09:03:47 +0000 From: Raslan Darawsheh To: Bing Zhao , Ori Kam , Slava Ovsiienko CC: Matan Azrad , "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix missing Rx queue flags clear Thread-Index: AQHWFIketHxbzH/+/E6rAAkUQEWsIKiP4OmA Date: Wed, 29 Apr 2020 09:03:47 +0000 Message-ID: References: <1587108210-454878-1-git-send-email-bingz@mellanox.com> In-Reply-To: <1587108210-454878-1-git-send-email-bingz@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [188.161.230.216] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: c2634821-1c3e-456b-db62-08d7ec1c3a23 x-ms-traffictypediagnostic: VI1PR05MB5581:|VI1PR05MB5581: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3276; x-forefront-prvs: 03883BD916 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR05MB6718.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39850400004)(376002)(396003)(136003)(346002)(366004)(8936002)(186003)(2906002)(5660300002)(76116006)(66556008)(66476007)(9686003)(55016002)(8676002)(66446008)(64756008)(66946007)(26005)(71200400001)(33656002)(4326008)(6636002)(6506007)(53546011)(316002)(7696005)(110136005)(52536014)(54906003)(478600001)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2YJb2EnyHRNUPQiC+1wgMOYddI4gviWfeIY8A1AleQXwTmjae/U37dIwY/IXJbJXcT3RQ6wMnollSdBiAlsh+9+CaaFJ8g/weSVRW8hXJ4u9FFfzs7HtqOsGiIe8LO26xSHcUyJG4lwk/jkJIoTzo+ZomcdUujwEBHcY4/H8qPi3MIazXuHL35oWGvQ0qQ6sJgwoKVn3ViKNmQRVf8Vi0OPdcBobf6a/hJeO8zhSr911qM5SYBwgqmMo1xZWlQkanTe6XcmbQ8/Mbt7n8Yf7VORSmgzUoq771fe4rFyswjkMHUrYFB9syzRhVhRYawwASSetkJr6etMkkZsTpX5gzOF6mVJHkL5VC3zIPwbtXFfRupOXhLe8s5R1cEyunVh129nAiOvR1+aQkXCHjxQeu7qG+QwT2IXZVrWDBBJPUDCoXHDcxV2luM8c+cjaHHnd x-ms-exchange-antispam-messagedata: mvBs3jHTaPiAO8llGBlwpXirL2jBYDEPCb5jJyOcbYQzwlhP6F4ezy7pU71nZ9KjDvuIZVvpvkvVEuwXVKmeCXGiZ9NObHn4Gz4MK+GH15/1YHagc+A2x2Ci25Q9SUbnr0QkTwzqbvCkB3n8X6+TwyEOlJfDqHMt2omwLNNb870ZoI64bEWp6D1zKsxejPH4W+Y3hJkz1xv8+rxQbz/eAbicqkP28cCXl69yTgVhbMJsIBDUjtj7qihOGqJAVCmra4U/CYrvV6IBI9R03LF5hn9/c/i67JizrdwqlTPLHfluCpuFtsz9ZrK1D/upQ1ymKOBaezJ/FO+BgpPjpzumxJERFwXWnhQ9ZqNQvUlVhmr8GpamsaRTSH+1Y6rHbx/l57lFBZCjiw9hPDgIKG6d66HNFyOeno2+jZKA+ZwsXWs3TGuHQZ2Mp1/pWN8rl/VXwm5cnvROHxF29ZdK+VY/V1u8sdAhfzOsqksl0fiocA6V4VjFp7+MoIEEeWQW4fVdGBiYhqb58I2fu3kLAoXOUTNOsuq9GzJ/YY+vujF/3/6hf7BlZNBYzToAeUZ1P3fdT2hV7JrlxU9lSGVVigP5WbJ5vT5S7q42eyywRMr1vhyyjr6Xtplo9zhqraLAaol0CoxlF9Wq3uddBar2gFfJZ+1QnaQix3eKm+9ruwB5e5ZVYzSLSwUCmpbb8/xqz687toQYesknCoNnOrYoNc9Znoqvt/O5yKKh33WPmYJyMJxhohDpi49PqT6zNnZLeoZzKqan54PBxjkQ+fwLWlValxZhvdFExv6Q4Z7pDBISYZEgdZJaS+9pyFtd4wV3q2QT Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2634821-1c3e-456b-db62-08d7ec1c3a23 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2020 09:03:47.3269 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UP+E9+0IuX92Um+9dsbEmccb0n/L/BndER3n+JJnQvxXbdlSpMinjxkM8fCy8OK6FSEakCqZpo+FbN7jwQZ8zA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB5581 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix missing Rx queue flags clear X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Bing Zhao > Sent: Friday, April 17, 2020 10:24 AM > To: Ori Kam ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: Matan Azrad ; dev@dpdk.org > Subject: [PATCH] net/mlx5: fix missing Rx queue flags clear >=20 > After inserting an offload flow, the software flag information will > be updated based on the flow. When receiving a packet on this queue, > the hardware packet type bits and the software flag will be used > together to get the inner packet and tunnel header type (if any) from > the global packet type table. > When destroying a flow, the corresponding Rx queue flag needs to be > updated. All flags should be cleared when closing a device because > all control flows and application flows are invalid anymore. > Such behavior is missed when implementing the non-cached mode. >=20 > Fixes: e1f94d51b8f7 ("net/mlx5: change operations for non-cached flows") Fixed fixes line, >=20 > Signed-off-by: Bing Zhao > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index c529aa3..bb7fb1e 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -4653,6 +4653,7 @@ struct rte_flow * > mlx5_flow_stop_default(struct rte_eth_dev *dev) > { > flow_mreg_del_default_copy_action(dev); > + flow_rxq_flags_clear(dev); > } >=20 > /** > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh