From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57ED5A0524; Thu, 30 Jan 2020 14:52:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 89DD81BFFE; Thu, 30 Jan 2020 14:52:39 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70045.outbound.protection.outlook.com [40.107.7.45]) by dpdk.org (Postfix) with ESMTP id 71CF91BFFA for <dev@dpdk.org>; Thu, 30 Jan 2020 14:52:38 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jnCxIMyTt4J+vs/mmY/iDwmwmbrRm1W+MXuFhhRCaq/PDOcA/Ksb0RnVBCeY3fHTxLP8sR2eofGFiMt4io0NXKlel3EubJTI9UQ4bjhbefJ+Vz6UrYrwp4Sq3zTzsOTYzK7IU20sYozWWzrcJRPkDK11ChURbtOzLTvbRh+Kid9nbiac9fhlTH21AY/knlVTL6GAqziudp2d7eRPCwJVYwCL1DqiipgXRl1ABcpvCMAGN56TbL+wXAkTOnvhbScYk6Gw7N2M28b/ZsOxL7mlJTsYgykMue/BBH3ccbNeNOUSBOgU4UcjFzn2nn3/BVPIbwkz84njWnNgeZdFWmIgPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2At8XjRFOOvklPaZB91k4YshejzGqjJ8uZ67pcqCDrA=; b=hSNhJZ+rvRJafI2/xM/oyP5O1NH+z5Ykj/sUdh29NTDr7wEyljR4d7Sk3uHGrD0zn4sIGIRvib+qfjeSMxSknNA/jvoNZHZZBP62yLH6n5n6bcpk9Amne6mVSADBY28O1uwkMaqYMxz2nH+Ue7FP6VAKQdOTZOVfXrAQQW3jPkeGTpSDc/0WEkO0FV11B/VTRJNgMVHs/fDAoOjV79s640m/hC4dt8c8TKF0miQmsrYiavdn8QiLXVSPMUfenqlG4YMKpoHa+K30S01HOR8ZG+k6W2iY1JDCENQSlYhUpWR6H2LXU9Mu9BceMTXvqyVicCYoNJYRRcvQxOfdeFpILw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2At8XjRFOOvklPaZB91k4YshejzGqjJ8uZ67pcqCDrA=; b=a+ApynP3IGF4A1Ee4cOg8A62t8HFLWA8Uxu3QD2aZmx85x1/SSRz5bd5WCOYLSv74b3gYFl9PtTT0PijxvQ6TGDdABYOaek6XCRcrw2ejTCGBELGu5q9+19PEN5Y+9bPP+04qz8VEawt+XQYJ0MLYObmUo+z7jaZRBvgJSSLIpE= Received: from VI1PR05MB6718.eurprd05.prod.outlook.com (10.186.162.137) by VI1PR05MB4349.eurprd05.prod.outlook.com (52.133.13.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.24; Thu, 30 Jan 2020 13:52:36 +0000 Received: from VI1PR05MB6718.eurprd05.prod.outlook.com ([fe80::25a1:c32b:29a1:fe8f]) by VI1PR05MB6718.eurprd05.prod.outlook.com ([fe80::25a1:c32b:29a1:fe8f%3]) with mapi id 15.20.2665.027; Thu, 30 Jan 2020 13:52:36 +0000 From: Raslan Darawsheh <rasland@mellanox.com> To: Slava Ovsiienko <viacheslavo@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org> CC: Matan Azrad <matan@mellanox.com>, Ori Kam <orika@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>, "thomas@mellanox.net" <thomas@mellanox.net>, "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com> Thread-Topic: [PATCH v2 0/2] mlx5/net: hint PMD not to inline packet Thread-Index: AQHV1p6gipPAb7hCuUOMAi0YeknTTagDO5Ww Date: Thu, 30 Jan 2020 13:52:36 +0000 Message-ID: <VI1PR05MB671821FDBABF7F7C878B3272C2040@VI1PR05MB6718.eurprd05.prod.outlook.com> References: <1578907777-194921-1-git-send-email-orika@mellanox.com> <1580300467-7716-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1580300467-7716-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ea10daba-8a28-49dd-a200-08d7a58ba9b4 x-ms-traffictypediagnostic: VI1PR05MB4349:|VI1PR05MB4349: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <VI1PR05MB4349E3D4E7112C01EFBD6FE2C2040@VI1PR05MB4349.eurprd05.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 02981BE340 x-forefront-antispam-report: SFV:NSPM; SFS:(10001)(10009020)(4636009)(136003)(376002)(396003)(39860400002)(346002)(366004)(189003)(199004)(316002)(6506007)(478600001)(7696005)(966005)(26005)(186003)(2906002)(54906003)(71200400001)(53546011)(110136005)(45080400002)(33656002)(66476007)(66556008)(8676002)(86362001)(66446008)(55016002)(52536014)(76116006)(5660300002)(81156014)(8936002)(66946007)(64756008)(4326008)(9686003)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB4349; H:VI1PR05MB6718.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: A429Py40MTxkQ7yuSsdVmts28BOwDfqlPdquPxL0XtvlVD8yRXdZSACGIITdp4lQ8qvWXLSze1qQO3jS/8uCCHxvfZ20OSAoDQs/O6X5giNywMTasT5LuiuF6lr3df30xRcqLc2CfUEuzkJQcS5QtSzEj6ENBRQ340t93S9j+1BCaNL001ZCAaYCyjt34JJzA5rAys5X/Al07hvIdhOpXvfs68N2jre2JQbh0vCsN+yD3cYpa6sxDpLGdKSNFP+qtKeplSKtE50eUVLXE2Cub2bH3scaIsv/OYV+MCn/jHhGiHX8cVd0dhFgwkSgx5T76E1iMyEMrYk+nEJKDlk0yHVGJxBtnhx5M1Vo/Zwf3GtHN4ma6re7SghfXVh3y/gQp0OJfn4Lg1Ju6qVUIjyrAfLt11LW/8Tct4HzCWZSC141n59K8VwRypiv0FppxEzF0RB7wZrHLjPDIVEfhv44GLNSR4iPuQLojMFf7ZF8p9mDjMRbyTBHnQs1bM7RPsntJ+mkvRKFfWXOQt+bJ6U2wyh7YKfhOaTzdZzASE7jGVAzMHwSWZQIEzj9moFGYL40+LBKuHMWPNNUG09frR7A43jnD/CK5Prd9iKTtgvPRKikCDIcKMIHgSbhJ8C/Z5/u x-ms-exchange-antispam-messagedata: vU960RRnOWK/X6UW3OQjyKKmN5ephwuoIz4StfTYW9r+CQsgRZqzQqlDXE6F6wIq37hpweAmdacr/45GFaPufv83lZqzmCXH7hb9IL6H2q6WuuDTJxxpf+8opmcDwe0BAlK+BMGI47jvYVeUeydyRg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea10daba-8a28-49dd-a200-08d7a58ba9b4 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2020 13:52:36.1294 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ut2ds6L96VnpLTud4iJKOkhRFuWXRn0QC1BRabwX1tUF9P/sgcrbmi8je6OHRwA+QkctWT/ENrSwLJYGmNFgBg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB4349 Subject: Re: [dpdk-dev] [PATCH v2 0/2] mlx5/net: hint PMD not to inline packet X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hi, > -----Original Message----- > From: Viacheslav Ovsiienko <viacheslavo@mellanox.com> > Sent: Wednesday, January 29, 2020 2:21 PM > To: dev@dpdk.org > Cc: Matan Azrad <matan@mellanox.com>; Raslan Darawsheh > <rasland@mellanox.com>; Ori Kam <orika@mellanox.com>; Shahaf Shuler > <shahafs@mellanox.com>; thomas@mellanox.net; > olivier.matz@6wind.com; ferruh.yigit@intel.com > Subject: [PATCH v2 0/2] mlx5/net: hint PMD not to inline packet >=20 > Some PMDs inline the mbuf data buffer directly to device transmit > descriptor. > This is in order to save the overhead of the PCI headers imposed when the > device DMA reads the data by buffer pointer. For some devices it is essen= tial > in order to provide the full bandwidth. >=20 > However, there are cases where such inlining is in-efficient. For example= , > when > the data buffer resides on other device memory (like GPU or storage > device). > Attempt to inline such buffer will result in high PCI overhead for readin= g > and copying the data from the remote device to the host memory. >=20 > To support a mixed traffic pattern (some buffers from local host memory, > some > buffers from other devices) with high bandwidth, a hint flag is introduce= d in > the mbuf. >=20 > Application will hint the PMD whether or not it should try to inline the > given mbuf data buffer. PMD should do the best effort to act upon this > request. >=20 > The hint flag RTE_NET_MLX5_DYNFLAG_NO_INLINE_NAME is supposed to > be dynamic, > registered by application with rte_mbuf_dynflag_register(). This flag is > purely vendor specific and declared in PMD specific header rte_pmd_mlx5.h= , > which is intended to be used by specific application. >=20 > To query the supported specific flags in runtime the private routine is > introduced: >=20 > int rte_pmd_mlx5_get_dyn_flag_names( > uint16_t port, > char *names[], > uint16_t n) >=20 > It returns the array of currently (over present hardware and configuratio= n) > supported specific flags. >=20 > The "not inline hint" feature operating flow is the following one: > - application start > - probe the devices, ports are created > - query the port capabilities > - if port supporting the feature is found > - register dynamic flag RTE_NET_MLX5_DYNFLAG_NO_INLINE_NAME > - application starts the ports > - on dev_start() PMD checks whether the feature flag is registered and > enables the feature support in datapath > - application might set this flag in ol_flags field of mbuf in the packet= s > being sent and PMD will handle ones appropriately. >=20 > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com> > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com> >=20 > --- > RFC: > https://eur03.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fpatch > es.dpdk.org%2Fpatch%2F61348%2F&data=3D02%7C01%7Crasland%40mell > anox.com%7C7b9dad01f6f24fc054df08d7a4b5c1aa%7Ca652971c7d2e4d9ba6a > 4d149256f461b%7C0%7C0%7C637158972862376366&sdata=3DGVQd0sNOS > 8Bbi3z33j2USdZpx%2FPE8IzwcfTg4QBj%2BwI%3D&reserved=3D0 >=20 > This patchset combines the parts of the following: >=20 > v1/testpmd: > https://eur03.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fpatch > es.dpdk.org%2Fcover%2F64541%2F&data=3D02%7C01%7Crasland%40mell > anox.com%7C7b9dad01f6f24fc054df08d7a4b5c1aa%7Ca652971c7d2e4d9ba6a > 4d149256f461b%7C0%7C0%7C637158972862376366&sdata=3DwpMH45Orli > mz1y4Bd7Emb%2F%2Fz4hsu%2BLUMN8sortguMUE%3D&reserved=3D0 > v1/mlx5: > https://eur03.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fpatch > es.dpdk.org%2Fpatch%2F64622%2F&data=3D02%7C01%7Crasland%40mell > anox.com%7C7b9dad01f6f24fc054df08d7a4b5c1aa%7Ca652971c7d2e4d9ba6a > 4d149256f461b%7C0%7C0%7C637158972862376366&sdata=3DRAA3Qw104 > dV6rujRoxXIOm0gcAI0DY5DyAdMAwryeb8%3D&reserved=3D0 >=20 > --- > Ori Kam (1): > net/mlx5: add fine grain dynamic flag support >=20 > Viacheslav Ovsiienko (1): > net/mlx5: update Tx datapath to support no inline hint >=20 > drivers/net/mlx5/mlx5.c | 20 ++++++ > drivers/net/mlx5/mlx5_rxtx.c | 106 ++++++++++++++++++++++++= +-- > --- > drivers/net/mlx5/mlx5_rxtx.h | 3 + > drivers/net/mlx5/mlx5_trigger.c | 8 +++ > drivers/net/mlx5/rte_pmd_mlx5.h | 35 ++++++++++ > drivers/net/mlx5/rte_pmd_mlx5_version.map | 7 ++ > 6 files changed, 163 insertions(+), 16 deletions(-) > create mode 100644 drivers/net/mlx5/rte_pmd_mlx5.h >=20 > -- > 1.8.3.1 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh