From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 241C3A0350; Sun, 21 Jun 2020 14:25:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 621AD1C07E; Sun, 21 Jun 2020 14:25:49 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60046.outbound.protection.outlook.com [40.107.6.46]) by dpdk.org (Postfix) with ESMTP id 74C291C06A; Sun, 21 Jun 2020 14:25:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m2JvvBhk8XXXP+dRDCwphLpQjdp6n9jyg9LfnJouI1xR+AdBsXox6u98Lel1GcctEpj66CYUw5hnrwD8X8dtmrFHUN8OIT5RTk8gpUbqOkd9R7gr8UX/KpaThBy3/HbIBAdiabmrbJeq9nXlJfrOKG1kpviQdiCUk2ZBE6lRwcYNPa02fYdjw2+B/k7Y4eupN5JV1NVO6SVBuvxVCmZl7+ymcFw7nNNi0bY8dlKFfyx4vO5+OBKn6nyYqmRckieVQOWGgz6p7ZzrQdyzJnePHqTkv2WHSqLNaGFqtyLRSHSjO+Yen0Y/EiOfMIa6qRV5Z7gTB64cehlVYtpbqqpO6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fc+VmX+zyAV9dZx0OL8UyHCRE8J6bfJdqQd+0jhCOxE=; b=OQbP4cARDDo758i7wUbl5yZvrTr9B2Ny9XlYZkgcFUNhUMpK/58JZD7ZU4Ozg38TRzKdTGS7ovQTcgqu0+n81bS2BxOtFX4Rt/ST2jnrEQPATaTmRT3xeJIL8HkAFih08B9dsMFukr7VWDqtuLbC1mYAoteOfoo6hMt0QsQnUZc0IKVVCb8+OXyLtnuVrDx8GAJ+tfMMleKeXaV9PHKfcMW5rIO3M4YECEw/KU833m5rYj8v/0I9OUrhdNQs5YJuJsu46v6mMHZ+oi1jw3rF6MphwNu5afaacr8uV5Pb35ALhbWMAA7wIGKRZPNxUtKKLIArvRNHjzChu8y79YZ5Cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fc+VmX+zyAV9dZx0OL8UyHCRE8J6bfJdqQd+0jhCOxE=; b=Hg5bagqmJJEM69Ytc5Qb9XSVqJHXaQ6meDtnRBXhJ2nMZCw1p36Zq4gpHIUmhyRQj1CY3iLAPqyeJVCRN73CN5Xb6291CVNx771DoV8OUGWAtTExLmHLThEUg1C5S0x5RwOlgIxBv8gGv/jNTqVAfPCSbK1jjNSx1C6BdEGJ2vM= Received: from VI1PR05MB6718.eurprd05.prod.outlook.com (2603:10a6:800:13b::9) by VI1PR05MB4509.eurprd05.prod.outlook.com (2603:10a6:803:4d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22; Sun, 21 Jun 2020 12:25:47 +0000 Received: from VI1PR05MB6718.eurprd05.prod.outlook.com ([fe80::bc68:25c4:b452:f24d]) by VI1PR05MB6718.eurprd05.prod.outlook.com ([fe80::bc68:25c4:b452:f24d%9]) with mapi id 15.20.3109.026; Sun, 21 Jun 2020 12:25:47 +0000 From: Raslan Darawsheh To: David Marchand , "dev@dpdk.org" CC: "stable@dpdk.org" , Matan Azrad , Shahaf Shuler , Slava Ovsiienko , Bing Zhao , Jack Min Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: remove redundant newline Thread-Index: AQHWRK66DAH+F9STL0uvDUfCtmkkYKjjBBEA Date: Sun, 21 Jun 2020 12:25:47 +0000 Message-ID: References: <20200617135325.9998-1-david.marchand@redhat.com> In-Reply-To: <20200617135325.9998-1-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: edb57287-eaed-4fa5-7cca-08d815de3a30 x-ms-traffictypediagnostic: VI1PR05MB4509: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:849; x-forefront-prvs: 04410E544A x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Mv4LU6ehZvAMx8YKmTzTkmBD5/s2LCI/9La+nHBH5AzYGTDE1eQPna2zysiDfWgwPwSJyYxU1Kc9+KPLwZ2CzzNqzC6JkwlUq9qZsUkEoMGdzia/6ayn9sdaaRP0bqWRxcwzR06zD//JPRrAsT8XyzUKD1kp8sZPvCgIRm1YfedWawIDgNPY8SnjxZJYaEqs/BVZz4QVG4qX/SzcHWZJo1AexJEsjLxV3bmeOEOmQetSk3bC4rDgNyxc8efkv9VglrzW5re/0G5cEt/ZaoL+MhiyKtmGCuIXRvaaYR6Q3jIoMT/kFc9EcNtNwgyW05xh5oBDJgo9Cq52zN/zc5DA/A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR05MB6718.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(376002)(366004)(39860400002)(396003)(346002)(186003)(76116006)(478600001)(9686003)(66556008)(55016002)(5660300002)(107886003)(66946007)(2906002)(64756008)(66476007)(66446008)(33656002)(71200400001)(8936002)(4326008)(7696005)(110136005)(316002)(8676002)(54906003)(26005)(53546011)(86362001)(83380400001)(52536014)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: smw4/Fb0IbJA5D2u4iO0shhgaFqZWKHuHQVTpYcvd4eCwl4+hV9PJvXSKxEOUePd1y09MYW6cmhKJ8nRpXjLf1D52L42xsOD7/aFrhUGJD6aUL0Brlv7oAnYJ5GGwNvB4CFRJE6TbjnBY47Co4W51tugnH5lcw24glgE+w1mNzevSc1DCogGpBspUwH0/Ax9/BPM1aEkjgGLLu0MPKoQLghyxk1DdsZhGJMJf2wy75lMeVjaAmGTyG1hlGN/vT/qqm78q4kPbCHEBRs4++LV0wm1rroISpyN9Aoo4Z6b2hCP/I8kejdHsnrqMONGdHtiXB441eVBcnUspN5VHuJpfIhlDM4SD9KoDHGkLAmYIKW4PJkuNLF+H4UVGUYlO5uMc9OvTRPoOCtVWq584gCdcF4yCSyXDO1VaGzS/680t/CojXLN0hS9mukR5KU4da6rugPAEYMgiTp0HSmggYuGQOl5gVhSxf4+Yw+AuxQF4+E= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: edb57287-eaed-4fa5-7cca-08d815de3a30 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2020 12:25:47.5800 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7pU1QV5y1ehYvos6VrmsU7z06fcOkhkku0bQaOK9PX6vrGbqB9wJhnemlXIBjpxodIBnWKqWpIHq5GRo+Ehj+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB4509 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: remove redundant newline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of David Marchand > Sent: Wednesday, June 17, 2020 4:53 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko ; > Bing Zhao ; Jack Min > Subject: [dpdk-dev] [PATCH] net/mlx5: remove redundant newline >=20 > The DRV_LOG macro already appends a newline. >=20 > Fixes: 46287eacc1b1 ("net/mlx5: introduce hash list") > Fixes: 860897d2895a ("net/mlx5: reorganize flow tables with hash list") > Fixes: e484e4032332 ("net/mlx5: optimize tag traversal with hash list") > Fixes: 6801116688fe ("net/mlx5: fix multiple flow table hash list") > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand > --- > drivers/net/mlx5/mlx5.c | 6 +++--- > drivers/net/mlx5/mlx5_utils.c | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c > index 95a0f337fe..fe7ed4899a 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -1062,7 +1062,7 @@ mlx5_alloc_table_hash_list(struct mlx5_priv *priv) > snprintf(s, sizeof(s), "%s_flow_table", priv->sh->ibdev_name); > sh->flow_tbls =3D mlx5_hlist_create(s, > MLX5_FLOW_TABLE_HLIST_ARRAY_SIZE); > if (!sh->flow_tbls) { > - DRV_LOG(ERR, "flow tables with hash creation failed.\n"); > + DRV_LOG(ERR, "flow tables with hash creation failed."); > err =3D ENOMEM; > return err; > } > @@ -1146,7 +1146,7 @@ mlx5_alloc_shared_dr(struct mlx5_priv *priv) > if (!sh->flow_tbls) > err =3D mlx5_alloc_table_hash_list(priv); > else > - DRV_LOG(DEBUG, "sh->flow_tbls[%p] already created, > reuse\n", > + DRV_LOG(DEBUG, "sh->flow_tbls[%p] already created, > reuse", > (void *)sh->flow_tbls); > if (err) > return err; > @@ -1154,7 +1154,7 @@ mlx5_alloc_shared_dr(struct mlx5_priv *priv) > snprintf(s, sizeof(s), "%s_tags", sh->ibdev_name); > sh->tag_table =3D mlx5_hlist_create(s, > MLX5_TAGS_HLIST_ARRAY_SIZE); > if (!sh->tag_table) { > - DRV_LOG(ERR, "tags with hash creation failed.\n"); > + DRV_LOG(ERR, "tags with hash creation failed."); > err =3D ENOMEM; > goto error; > } > diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.= c > index d29fbcbc83..6f3ba7ca49 100644 > --- a/drivers/net/mlx5/mlx5_utils.c > +++ b/drivers/net/mlx5/mlx5_utils.c > @@ -20,7 +20,7 @@ mlx5_hlist_create(const char *name, uint32_t size) > if (!rte_is_power_of_2(size)) { > act_size =3D rte_align32pow2(size); > DRV_LOG(WARNING, "Size 0x%" PRIX32 " is not power of 2, > will " > - "be aligned to 0x%" PRIX32 ".\n", size, act_size); > + "be aligned to 0x%" PRIX32 ".", size, act_size); > } else { > act_size =3D size; > } > @@ -29,7 +29,7 @@ mlx5_hlist_create(const char *name, uint32_t size) > /* Using zmalloc, then no need to initialize the heads. */ > h =3D rte_zmalloc(name, alloc_size, RTE_CACHE_LINE_SIZE); > if (!h) { > - DRV_LOG(ERR, "No memory for hash list %s creation\n", > + DRV_LOG(ERR, "No memory for hash list %s creation", > name ? name : "None"); > return NULL; > } > @@ -37,7 +37,7 @@ mlx5_hlist_create(const char *name, uint32_t size) > snprintf(h->name, MLX5_HLIST_NAMESIZE, "%s", name); > h->table_sz =3D act_size; > h->mask =3D act_size - 1; > - DRV_LOG(DEBUG, "Hash list with %s size 0x%" PRIX32 " is > created.\n", > + DRV_LOG(DEBUG, "Hash list with %s size 0x%" PRIX32 " is created.", > h->name, act_size); > return h; > } > -- > 2.23.0 Patch rebased and applied to next-net-mlx, Kindest regards, Raslan Darawsheh