From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from emea01-db3-obe.outbound.protection.outlook.com (mail-db3on0129.outbound.protection.outlook.com [157.55.234.129]) by dpdk.org (Postfix) with ESMTP id E4C9D2BA0 for ; Thu, 30 Jun 2016 10:40:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector2-nokia-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=xY6CD9LoIyjuI5jNwDWJ31pBg0AG9BjkR9/HLNeWmEI=; b=lEIfywMkHo2sIK73MvMI1N6F1oZE1aMRN8msWzCBhp9QJbcnXBkxZinqlQD0NTlaDqQxr5xV3LKv4gnSfz6RgZAvFqJmlCBGJvEkCdYkve7tB8/ORRBbHtCjKjH7MdcuYowKZDPvKhYlLF3sCuBTUi8KSP6Nw4X3nWohawSCZ7Q= Received: from VI1PR0701MB1853.eurprd07.prod.outlook.com (10.167.197.13) by VI1PR0701MB1855.eurprd07.prod.outlook.com (10.167.197.15) with Microsoft SMTP Server (TLS) id 15.1.528.16; Thu, 30 Jun 2016 08:40:06 +0000 Received: from VI1PR0701MB1853.eurprd07.prod.outlook.com ([10.167.197.13]) by VI1PR0701MB1853.eurprd07.prod.outlook.com ([10.167.197.13]) with mapi id 15.01.0528.020; Thu, 30 Jun 2016 08:40:05 +0000 From: "Elo, Matias (Nokia - FI/Espoo)" To: Sergio Gonzalez Monroy , "dev@dpdk.org" CC: "ferruh.yigit@intel.com" , "damarion@cisco.com" Thread-Topic: [dpdk-dev] weak functions in some drivers Thread-Index: AQHR0qd+F3ZV/uXuXEWQoWbZm000/KABr0Zg Date: Thu, 30 Jun 2016 08:40:05 +0000 Message-ID: References: <3745bde4-f539-21d4-51e4-369d35697e57@intel.com> In-Reply-To: <3745bde4-f539-21d4-51e4-369d35697e57@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matias.elo@nokia-bell-labs.com; x-originating-ip: [131.228.2.28] x-ms-office365-filtering-correlation-id: dbd9a0f9-26fb-4e28-2951-08d3a0c222f5 x-microsoft-exchange-diagnostics: 1; VI1PR0701MB1855; 6:oUIlrNQOGtBXTCn+wYsCoUaUL8lfAPM5IOqmS/+Ge3fBZvxNeFKP+UOVGCBy2U7AKE8mS9Q5UC39jbMe5qhKmBFjbI0r+uNJv9Z2gOKJt23CDJ5A/HJAzqmxVlH0MKNrboZkk3gNBCkRWdypLJRQWMJvYJxVN6VdF0RUUVe6DjkbUWp3wtEOAYU8JA/qIl9zHaddVeHLaAZD5hlktQxAFX4EwKmIkbEmaZJ7vBEuo6oidyO9ERFAz+z6husjsL0AUv7FNJM14wgW9uStLbPFbID7zQpDH0TgoxV7tmqaoww=; 5:itc4g/wA33oZE2q/r83hsIEBWtYkdbqqpBJZWyUtWHHqm1l8/qEg9/6sRrnMvWqodOcwRVV67j70OswrEgK7v2Bx3iSjIzn/y4GtSpyA7Mu0k8ihVeCffwbggZFi+cD224l0Z3lxjHKIhezzikipJg==; 24:U1z8o9sF2RUojuvcI3cobiXn4lEbBO9AtwRZiM/MEVuUjISU1ps8bKMJ1ZL6xx7Qiv0wQtINonk5kCx+X8WCXZGnUuK8gHhw+f0161T7qtM=; 7:G+f49JqbVkQzRb56tKNRq7fepBD/YDhQKDy59620nEcmHnCdoGmkn2v38hovMmePgZ3zT8CVChOUy/JcpCt3XW5G3s3X+WjFmLE2SpLBfJ1mhU3zX/0ujn2mL5gxtv7uhdHDmzpdc1yN2z4/R4xusqK+QoqoyZmDQ8QwkXdQzJtIg8tpjELkRh4ynSGka5AN8u9zjlxZhlWJIbMGIE7E3klHaxw+JJwvk6S0ibcXmRJFn2Vs/Ay/anZojPrbjwEf x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0701MB1855; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046); SRVR:VI1PR0701MB1855; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0701MB1855; x-forefront-prvs: 0989A7979C x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(7916002)(189002)(199003)(5002640100001)(74316001)(66066001)(7846002)(7736002)(19580395003)(92566002)(5003600100003)(8676002)(305945005)(102836003)(189998001)(3846002)(81156014)(81166006)(6116002)(5001770100001)(7696003)(33656002)(586003)(2900100001)(97736004)(2950100001)(77096005)(76176999)(50986999)(4326007)(106356001)(68736007)(101416001)(9686002)(3280700002)(3660700001)(54356999)(76576001)(2906002)(122556002)(87936001)(10400500002)(106116001)(2501003)(105586002)(8936002)(86362001)(90052001); DIR:OUT; SFP:1102; SCL:1; SRVR:VI1PR0701MB1855; H:VI1PR0701MB1853.eurprd07.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:0; LANG:en; received-spf: None (protection.outlook.com: nokia-bell-labs.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nokia-bell-labs.com X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2016 08:40:05.6811 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0701MB1855 Subject: Re: [dpdk-dev] weak functions in some drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2016 08:40:13 -0000 > >>> What is not clear to me is motivation to use weak here instead of sim= ply > using >CONFIG_RTE_I40E_INC_VECTOR > >>> macro to exclude stubs in i40e_rxtx.c. It will make library smaller a= nd avoid > issues like this one > >>> which are quite hard to troubleshoot. > >> Since this issue seen in fd.io, I didn't investigated more, but I don'= t > >> want to clock your valid question, this is an attempt to resurrect the > >> question ... > > Hi, > > > > We are having exactly the same problem. For us the aforementioned > workaround doesn't seem to work and vector mode is always disabled with t= he > i40e drivers. If I modify i40e_rxtx.c and exclude the stub functions usin= g > CONFIG_RTE_I40E_INC_VECTOR everything works as expected. > > > > We are building DPDK with the CONFIG_RTE_BUILD_COMBINE_LIBS option > enabled and link DPDK library to our application. > > > > Any other ideas how this could be fixed? > > > > Regards, > > Matias > > >=20 > So you have tried to link a combined static lib with --whole-archive > -ldpdk --no-whole-archive and still get the wrong/weak function definitio= n? >=20 > Sergio I actually just managed to fix the problem. In our case I had to add '-Wl,--whole-archive,-ldpdk,--no-whole-archive' to the end of AM_LDFLAGS. -Matias