DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Elo, Matias (Nokia - FI/Espoo)" <matias.elo@nokia-bell-labs.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
	"damarion@cisco.com" <damarion@cisco.com>
Subject: Re: [dpdk-dev] weak functions in some drivers
Date: Wed, 29 Jun 2016 13:26:22 +0000	[thread overview]
Message-ID: <VI1PR0701MB1853F1EBA4E799C595E5B49B87230@VI1PR0701MB1853.eurprd07.prod.outlook.com> (raw)

>> What is not clear to me is motivation to use weak here instead of simply using >CONFIG_RTE_I40E_INC_VECTOR
>> macro to exclude stubs in i40e_rxtx.c. It will make library smaller and avoid issues like this one
>> which are quite hard to troubleshoot.
>
>Since this issue seen in fd.io, I didn't investigated more, but I don't
>want to clock your valid question, this is an attempt to resurrect the
>question ...

Hi,

We are having exactly the same problem. For us the aforementioned workaround doesn't seem to work and vector mode is always disabled with the i40e drivers. If I modify i40e_rxtx.c and exclude the stub functions using CONFIG_RTE_I40E_INC_VECTOR everything works as expected.

We are building DPDK with the CONFIG_RTE_BUILD_COMBINE_LIBS option enabled and link DPDK library to our application.

Any other ideas how this could be fixed?

Regards,
Matias

             reply	other threads:[~2016-06-29 13:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-29 13:26 Elo, Matias (Nokia - FI/Espoo) [this message]
2016-06-30  8:14 ` Sergio Gonzalez Monroy
2016-06-30  8:40   ` Elo, Matias (Nokia - FI/Espoo)
2016-07-01  9:42     ` Elo, Matias (Nokia - FI/Espoo)
2016-07-01 10:05       ` Sergio Gonzalez Monroy
2016-07-01 10:16         ` Elo, Matias (Nokia - FI/Espoo)
2016-07-01 10:19           ` Sergio Gonzalez Monroy
2016-07-14 15:43             ` Zoltan Kiss
  -- strict thread matches above, loose matches on Subject: below --
2016-06-21 15:01 Damjan Marion (damarion)
2016-06-21 16:01 ` Ferruh Yigit
2016-06-21 16:08   ` Damjan Marion (damarion)
2016-06-27 18:13 ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR0701MB1853F1EBA4E799C595E5B49B87230@VI1PR0701MB1853.eurprd07.prod.outlook.com \
    --to=matias.elo@nokia-bell-labs.com \
    --cc=damarion@cisco.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).