From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-oln040092069043.outbound.protection.outlook.com [40.92.69.43]) by dpdk.org (Postfix) with ESMTP id 579D02BAE for ; Mon, 10 Apr 2017 13:05:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=KFQSiDwRawA/7eIgp9JXjYG3N+DdmxlAUJAz4xz5gxo=; b=MEnCAEF0EpqpzhWLdmx7bddL9gb1DBh3jNkt6p05pOO86hdjw8zsUktYwUq4P5RJpbsLifzJ+ERB8Ik8ULqCkWKOJ8wXf0F2Hhg+VtvZXjyA/uGzWbe18vX9i1W7f/+jBvgnVaKIGgGerUv59Ogl+cKn8gE5Oaizr3/aAmimeid7nyQtVT7Mm8v3dYxl5A3xLQBbnaPLUF7D2e40pjglNxJl07UlAVVD3QhfhpTZ45YDwG6QTj8Je5p8fK9YHHTQ8ClN/CZ68YxW607pVtKffIfgIVhxL38ppjY8fu4TNr5dDBfYKqP6OrfrtMTxqRD8HWXclfQ/9vE5H1ZsdQ3G3A== Received: from HE1EUR02FT032.eop-EUR02.prod.protection.outlook.com (10.152.10.60) by HE1EUR02HT079.eop-EUR02.prod.protection.outlook.com (10.152.11.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.1019.14; Mon, 10 Apr 2017 11:05:33 +0000 Received: from VI1PR0802MB2335.eurprd08.prod.outlook.com (10.152.10.59) by HE1EUR02FT032.mail.protection.outlook.com (10.152.10.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.14 via Frontend Transport; Mon, 10 Apr 2017 11:05:33 +0000 Received: from VI1PR0802MB2335.eurprd08.prod.outlook.com ([10.172.14.10]) by VI1PR0802MB2335.eurprd08.prod.outlook.com ([10.172.14.10]) with mapi id 15.01.1019.024; Mon, 10 Apr 2017 11:05:33 +0000 From: =?iso-8859-2?Q?Jan_M=EAdala?= To: Marcin Wojtas , "dev@dpdk.org" CC: "jpalider@gmail.com" , "netanel@amazon.com" , "evgenys@amazon.com" , "matua@amazon.com" , "gtzalik@amazon.com" , "mk@semihalf.com" Thread-Topic: [PATCH 4/4] net/ena: calculate partial checksum if DF bit is disabled Thread-Index: AQHSr4t/zp/PXyFeskKlNeYdWz3V2aG+dBLQ Date: Mon, 10 Apr 2017 11:05:32 +0000 Message-ID: References: <1491562138-2178-1-git-send-email-mw@semihalf.com> <1491562138-2178-5-git-send-email-mw@semihalf.com> In-Reply-To: <1491562138-2178-5-git-send-email-mw@semihalf.com> Accept-Language: pl-PL, en-US Content-Language: pl-PL X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: semihalf.com; dkim=none (message not signed) header.d=none;semihalf.com; dmarc=none action=none header.from=outlook.com; x-incomingtopheadermarker: OriginalChecksum:4A62CE828B5E4C461660861A0E1454F7944B6E1005283F7C10D7EB2A11508BDA; UpperCasedChecksum:E3E8A953FDBB65C7365F7D645670F2D7DC1C4E06D9568668411AA7CDC1138457; SizeAsReceived:8429; Count:43 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [Ixta/27eaBrX+zKQI9Ap5xVcZnhjijE4] x-microsoft-exchange-diagnostics: 1; HE1EUR02HT079; 5:3hINv18T3XXrVZxOZ0oyrPdpge6YweuonXOMd1DvNxSyGdH5AyalRWMOefwPU68LYQTZik31xCUpSdwvUOtLOihYulzO6o76UUMlA12/h+w3NJKW5c5cmDOZNG0kVsKDNCJSl2w3mO8pKY84myMR9w==; 24:qFXVIPf3tOGAlAf09lRKTLkxhSwBaS7PIEkIDeRJG9QvbKIwljx2e/hd5SKYi9W4VbNImL57gMEURApK60eegNcFVjneKlKo/7RqAdRE3s8=; 7:78Hh4j+HhtnSDTvjg17S0/5zD/oeOOkqU1IF23Mefp3JmRz2Ebwb/Wt07Iaw9h8uihjfO6VxMW1lbAxlgA/iQkr/T1UEuYU6HwE0ytXy4ed/sfe2DqVC6TssAt9OsZds2NCU0V3J2UiV8/ixot2+gIBSUosFQT7SF7S+6MqaDl5S9alerX1GpIaUrkBbBDNXug/nmSKpU6OKcy7clWcup/UG5Qmda2Ggg2VR3iYtNRkc+x1oori4vqRysiBnw04sEwSbouqjtJM2bUzFR25BKD1bjB0c0U84SUaxCIF0yZ4jx70v6LeXNY8QRQc9Q49z x-incomingheadercount: 43 x-eopattributedmessage: 0 x-forefront-antispam-report: EFV:NLI; SFV:NSPM; SFS:(7070007)(98901004); DIR:OUT; SFP:1901; SCL:1; SRVR:HE1EUR02HT079; H:VI1PR0802MB2335.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; x-ms-office365-filtering-correlation-id: 56193c6e-afc0-4725-629f-08d48001820b x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201702061074)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031322274)(1601125374)(1603101448)(1701031045); SRVR:HE1EUR02HT079; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(444000031); SRVR:HE1EUR02HT079; BCL:0; PCL:0; RULEID:; SRVR:HE1EUR02HT079; x-forefront-prvs: 027367F73D spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2017 11:05:33.0298 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1EUR02HT079 X-Mailman-Approved-At: Wed, 12 Apr 2017 09:13:05 +0200 Subject: Re: [dpdk-dev] [PATCH 4/4] net/ena: calculate partial checksum if DF bit is disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Apr 2017 11:05:34 -0000 I would recommend to check if packet type is IPv4 before processing IPv4 he= ader for DF flag. This patch can break logic and go to unknown state when mbuf will contain I= Pv6 packet. I believe that in case of IPv6 pkt the loop should be skipped t= o next mbuf, if exists. Best regards, Jan