From: Ruifeng Wang <Ruifeng.Wang@arm.com>
To: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"radu.nicolau@intel.com" <radu.nicolau@intel.com>
Cc: "jerinj@marvell.com" <jerinj@marvell.com>,
Jan Viktorin <viktorin@rehivetech.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH] eal: add experimental tags for write combining store
Date: Wed, 14 Oct 2020 09:30:26 +0000 [thread overview]
Message-ID: <VI1PR0802MB235150A81E847FAE102817EA9E050@VI1PR0802MB2351.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20201014081430.31349-1-david.marchand@redhat.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, October 14, 2020 4:14 PM
> To: dev@dpdk.org; radu.nicolau@intel.com
> Cc: jerinj@marvell.com; Ruifeng Wang <Ruifeng.Wang@arm.com>; Jan
> Viktorin <viktorin@rehivetech.com>; Bruce Richardson
> <bruce.richardson@intel.com>; Konstantin Ananyev
> <konstantin.ananyev@intel.com>
> Subject: [PATCH] eal: add experimental tags for write combining store
>
> Only marking the doxygen declarations is not enough.
> Arch specific implementations must be tagged as well since there is no
> common declaration of those inlines.
>
> Fixes: 8a00dfc738fe ("eal: add write combining store")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/librte_eal/arm/include/rte_io_64.h | 2 ++
> lib/librte_eal/x86/include/rte_io.h | 9 +++++++++
> 2 files changed, 11 insertions(+)
>
> diff --git a/lib/librte_eal/arm/include/rte_io_64.h
> b/lib/librte_eal/arm/include/rte_io_64.h
> index d07d9cb226..f9a1f10ce7 100644
> --- a/lib/librte_eal/arm/include/rte_io_64.h
> +++ b/lib/librte_eal/arm/include/rte_io_64.h
> @@ -164,12 +164,14 @@ rte_write64(uint64_t value, volatile void *addr)
> rte_write64_relaxed(value, addr);
> }
>
> +__rte_experimental
> static __rte_always_inline void
> rte_write32_wc(uint32_t value, volatile void *addr) {
> rte_write32(value, addr);
> }
>
> +__rte_experimental
> static __rte_always_inline void
> rte_write32_wc_relaxed(uint32_t value, volatile void *addr) { diff --git
> a/lib/librte_eal/x86/include/rte_io.h b/lib/librte_eal/x86/include/rte_io.h
> index c035eecc6a..730f958758 100644
> --- a/lib/librte_eal/x86/include/rte_io.h
> +++ b/lib/librte_eal/x86/include/rte_io.h
> @@ -28,6 +28,7 @@ __rte_x86_movdiri(uint32_t value, volatile void *addr)
> : "a" (value), "d" (addr));
> }
>
> +__rte_experimental
> static __rte_always_inline void
> rte_write32_wc_relaxed(uint32_t value, volatile void *addr) { @@ -47,11
> +48,19 @@ rte_write32_wc_relaxed(uint32_t value, volatile void *addr)
> }
> }
>
> +__rte_experimental
> static __rte_always_inline void
> rte_write32_wc(uint32_t value, volatile void *addr) {
> + /* gcc complains about calling this experimental function even
> + * when not using it. Hide it with ALLOW_EXPERIMENTAL_API.
> + */
> +#ifdef ALLOW_EXPERIMENTAL_API
> rte_wmb();
> rte_write32_wc_relaxed(value, addr);
> +#else
> + rte_write32(value, addr);
> +#endif
> }
>
> #ifdef __cplusplus
> --
> 2.23.0
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
next prev parent reply other threads:[~2020-10-14 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 8:14 David Marchand
2020-10-14 9:30 ` Ruifeng Wang [this message]
2020-10-14 9:57 ` Nicolau, Radu
2020-10-14 13:49 ` [dpdk-dev] [PATCH v2] " David Marchand
2020-10-15 8:28 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0802MB235150A81E847FAE102817EA9E050@VI1PR0802MB2351.eurprd08.prod.outlook.com \
--to=ruifeng.wang@arm.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
--cc=radu.nicolau@intel.com \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).