[dpdk-dev] [PATCH] mbuf: remove unneeded EAL header include

[dpdk-dev] [PATCH] mbuf: remove unneeded EAL header include

[David Marchand]

There is no need for the direct inclusion of the generic/ header [1]
now that we don't use the rte_atomic API anymore.

1: https://git.dpdk.org/dpdk/commit/?id=3eb860b08eb7

Fixes: e41d27a68df6 ("mbuf: remove atomic reference counters")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/librte_mbuf/rte_mbuf_core.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/librte_mbuf/rte_mbuf_core.h b/lib/librte_mbuf/rte_mbuf_core.h
index a85cabdd18..9d1609336a 100644
--- a/lib/librte_mbuf/rte_mbuf_core.h
+++ b/lib/librte_mbuf/rte_mbuf_core.h
@@ -20,7 +20,6 @@
 
 #include <rte_compat.h>
 #include <rte_byteorder.h>
-#include <generic/rte_atomic.h>
 
 #ifdef __cplusplus
 extern "C" {
-- 
2.23.0

Re: [dpdk-dev] [PATCH] mbuf: remove unneeded EAL header include

[Ruifeng Wang]

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Saturday, January 30, 2021 4:33 AM
> To: dev@dpdk.org
> Cc: konstantin.ananyev@intel.com; bruce.richardson@intel.com;
> stable@dpdk.org; Olivier Matz <olivier.matz@6wind.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; Phil Yang <Phil.Yang@arm.com>; Andrew
> Rybchenko <arybchenko@solarflare.com>; thomas@monjalon.net
> Subject: [PATCH] mbuf: remove unneeded EAL header include
> 
> There is no need for the direct inclusion of the generic/ header [1] now that
> we don't use the rte_atomic API anymore.
> 
> 1: https://git.dpdk.org/dpdk/commit/?id=3eb860b08eb7
> 
> Fixes: e41d27a68df6 ("mbuf: remove atomic reference counters")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  lib/librte_mbuf/rte_mbuf_core.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/librte_mbuf/rte_mbuf_core.h
> b/lib/librte_mbuf/rte_mbuf_core.h index a85cabdd18..9d1609336a 100644
> --- a/lib/librte_mbuf/rte_mbuf_core.h
> +++ b/lib/librte_mbuf/rte_mbuf_core.h
> @@ -20,7 +20,6 @@
> 
>  #include <rte_compat.h>
>  #include <rte_byteorder.h>
> -#include <generic/rte_atomic.h>
> 
>  #ifdef __cplusplus
>  extern "C" {
> --
> 2.23.0

Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

[dpdk-dev] [PATCH v2 1/2] mbuf: remove unneeded atomic header include

[David Marchand]

There is no need for the direct inclusion of the generic/ header [1]
now that we don't use the rte_atomic API anymore.

1: https://git.dpdk.org/dpdk/commit/?id=3eb860b08eb7

Fixes: e41d27a68df6 ("mbuf: remove atomic reference counters")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
 lib/librte_mbuf/rte_mbuf_core.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/librte_mbuf/rte_mbuf_core.h b/lib/librte_mbuf/rte_mbuf_core.h
index a85cabdd18..9d1609336a 100644
--- a/lib/librte_mbuf/rte_mbuf_core.h
+++ b/lib/librte_mbuf/rte_mbuf_core.h
@@ -20,7 +20,6 @@
 
 #include <rte_compat.h>
 #include <rte_byteorder.h>
-#include <generic/rte_atomic.h>
 
 #ifdef __cplusplus
 extern "C" {
-- 
2.23.0

[dpdk-dev] [PATCH v2 2/2] builtools: remove build flag for header includes check

[David Marchand]

Previous patch just removes the last case of direct inclusion of the
generic/ headers.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 buildtools/chkincs/meson.build | 1 -
 1 file changed, 1 deletion(-)

diff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build
index f345e87551..f28cfd3cd4 100644
--- a/buildtools/chkincs/meson.build
+++ b/buildtools/chkincs/meson.build
@@ -17,7 +17,6 @@ gen_c_files = generator(gen_c_file_for_header,
 	arguments: ['@INPUT@', '@OUTPUT@'])
 
 cflags = machine_args
-cflags += '-Wno-unused-function' # needed if we include generic headers
 cflags += '-DALLOW_EXPERIMENTAL_API'
 
 sources = files('main.c')
-- 
2.23.0

Re: [dpdk-dev] [PATCH v2 2/2] builtools: remove build flag for header includes check

[Bruce Richardson]

On Thu, Feb 04, 2021 at 11:05:20AM +0100, David Marchand wrote:
> Previous patch just removes the last case of direct inclusion of the
> generic/ headers.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [dpdk-dev] [PATCH v2 1/2] mbuf: remove unneeded atomic header include

[Andrew Rybchenko]

On 2/4/21 1:05 PM, David Marchand wrote:
> There is no need for the direct inclusion of the generic/ header [1]
> now that we don't use the rte_atomic API anymore.
> 
> 1: https://git.dpdk.org/dpdk/commit/?id=3eb860b08eb7
> 
> Fixes: e41d27a68df6 ("mbuf: remove atomic reference counters")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

Re: [dpdk-dev] [PATCH v2 2/2] builtools: remove build flag for header includes check

[Thomas Monjalon]

04/02/2021 11:26, Bruce Richardson:
> On Thu, Feb 04, 2021 at 11:05:20AM +0100, David Marchand wrote:
> > Previous patch just removes the last case of direct inclusion of the
> > generic/ headers.
> > 
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

I think this patch is better understood (in git history I mean)
if squashed with the previous one.
Removing this flag is the direct consequence of removing the include in mbuf.

Squashed and applied, thanks.