DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ruifeng Wang <Ruifeng.Wang@arm.com>
To: "thomas@monjalon.net" <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
	nd <nd@arm.com>, "jerinj@marvell.com" <jerinj@marvell.com>,
	"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
	"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
	Vimal Chungath <vcchunga@amazon.com>,
	"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
	"konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
	nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/2] gcc build fix
Date: Fri, 27 Nov 2020 14:08:22 +0000
Message-ID: <VI1PR0802MB2351FE939E0924CA052901FA9EF80@VI1PR0802MB2351.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <6713516.xaRlCRmjY9@thomas>

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, November 27, 2020 9:36 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>
> Cc: dev@dpdk.org; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>; jerinj@marvell.com;
> bruce.richardson@intel.com; ferruh.yigit@intel.com; Vimal Chungath
> <vcchunga@amazon.com>; hemant.agrawal@nxp.com;
> konstantin.ananyev@intel.com
> Subject: Re: [dpdk-dev] [PATCH v2 0/2] gcc build fix
> 
> 27/11/2020 11:15, Ruifeng Wang:
> > This series fixed issues found when building project with Gcc '-O0'
> > option.
> >
> > Ruifeng Wang (2):
> >   eal/arm: fix gcc build for optimization level 0
> >   net/igc: fix gcc build for optimization level 0
> 
> No comment on the v2?
> Ruifeng, why nobody was Cc'ed? You don't want reviews?

Just used get-maintainer.sh to get Cc list. I should have added more people.
> 
> I am not going to accept such last minute fix if there is no strong proof this v2
> is good.

v2 1/2 patch has issue on earlier version Clang (eg. clang-6).
I think we should continue with v1 approach.
> 


  reply	other threads:[~2020-11-27 14:08 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-27  8:09 [dpdk-dev] [PATCH " Ruifeng Wang
2020-11-27  8:09 ` [dpdk-dev] [PATCH 1/2] eal/arm: fix gcc build for optimization level 0 Ruifeng Wang
2020-11-27  8:39   ` David Marchand
2020-11-27  8:51     ` Jerin Jacob
2020-11-27  9:25       ` David Marchand
2020-11-27  9:33         ` Jerin Jacob
2020-11-27  9:45           ` David Marchand
2020-11-27 10:05             ` Ruifeng Wang
2020-11-27 10:28               ` Jerin Jacob
2020-11-27  9:39         ` Andrew Rybchenko
2020-11-27  9:36     ` Ruifeng Wang
2020-11-27  8:09 ` [dpdk-dev] [PATCH 2/2] net/igc: " Ruifeng Wang
2020-11-27  8:53   ` Jerin Jacob
2020-11-27  9:02   ` David Marchand
2020-11-27 12:13     ` David Marchand
2020-11-27 14:50       ` Wang, Haiyue
2020-11-27 10:15 ` [dpdk-dev] [PATCH v2 0/2] gcc build fix Ruifeng Wang
2020-11-27 10:15   ` [dpdk-dev] [PATCH v2 1/2] eal/arm: fix gcc build for optimization level 0 Ruifeng Wang
2020-11-27 13:03     ` Ruifeng Wang
2020-11-27 10:15   ` [dpdk-dev] [PATCH v2 2/2] net/igc: " Ruifeng Wang
2020-11-27 13:35   ` [dpdk-dev] [PATCH v2 0/2] gcc build fix Thomas Monjalon
2020-11-27 14:08     ` Ruifeng Wang [this message]
2020-11-27 16:03 ` [dpdk-dev] [PATCH " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR0802MB2351FE939E0924CA052901FA9EF80@VI1PR0802MB2351.eurprd08.prod.outlook.com \
    --to=ruifeng.wang@arm.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerinj@marvell.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=nd@arm.com \
    --cc=thomas@monjalon.net \
    --cc=vcchunga@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git