From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00081.outbound.protection.outlook.com [40.107.0.81]) by dpdk.org (Postfix) with ESMTP id 95A721B958; Fri, 11 Jan 2019 04:58:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uGgSXAoLOrBFQfDLs1agH6A76WSVK5atLCEJIUA3Lyw=; b=YlInePfLokcyMJ/lvKe9QDqptbtptmMjOYu2GO77QN9qCeX8IOxXSNuedmsdGm4gl/Czj1UICBfcB9qJP2Eygsq+1h+2geox+5WOtIbnXHVXVWuVwtNb7uV0hO3agqu7LQhAWO87xeyGtKhy9G77vQ/MQERd9Fhs7PrSWxmyyv0= Received: from VI1PR08MB3167.eurprd08.prod.outlook.com (52.133.15.142) by VI1PR08MB1008.eurprd08.prod.outlook.com (10.166.144.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1516.14; Fri, 11 Jan 2019 03:58:46 +0000 Received: from VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::8960:6756:4cdc:3954]) by VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::8960:6756:4cdc:3954%4]) with mapi id 15.20.1516.016; Fri, 11 Jan 2019 03:58:46 +0000 From: "Gavin Hu (Arm Technology China)" To: Luca Boccassi , "dev@dpdk.org" CC: "bruce.richardson@intel.com" , "christian.ehrhardt@canonical.com" , "stable@dpdk.org" , Honnappa Nagarahalli , "jerinj@marvell.com" Thread-Topic: [dpdk-dev] [PATCH] build: mention -march in pkg-config description Thread-Index: AQHUqQnhfxhlWim7bkSrpd0yMnLwrKWpcB8A Date: Fri, 11 Jan 2019 03:58:46 +0000 Message-ID: References: <20190110172806.12952-1-bluca@debian.org> In-Reply-To: <20190110172806.12952-1-bluca@debian.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR08MB1008; 6:9sTYStRVNnsfw0GOKXEnhiusCvKSdu7EgeJ4+lTBVpXG/i2PtuoAErKWgagY6vXzKRy99q+smYU/9FA5JtZIO7G9QXxXoQ8OInCvmudPsGMYe8teOtxPIdjKrB3gUCmthlgqasq2J51XWcdoYqmnDN8y7DIWXZk+lrQsr0VjToUIkyS/uAjPVQ6JDpybOnhUskrKY+sUj1Hk27lCg9BBh9Oi6iFWVAVNf7ufof6MbKYE8ERIroxZa8Lvr07xEmKPl+B3CBk6w1zakrXNQ0iuy1aB1lVEi3tGinu+G87lR18X1Upjr5Ft3QaldjxAFB83qO4ha8YOrSHD/hVlxqo2BStcFxsJEvi2G7z/dVC43qAnwDYcFOnfBoWpg0+us2Blm1ngTjWfDcfEQlo3b0d/GcbXBjtKJj4JLoBKiV7YP3Tw1rngTC9snIfKHCA1xV2irRaZD95h7NKPYAO6OMA0yw==; 5:NhotSHJCPyiryZmsOrkhPPfLTscrEucicNZZXvVaT61pLVmFOFQZSmXtrwk5fJP7L9y/6ZUzJ1l/CNz3m/QbN8Gtomrw7Cll/efMGCNcyXiTuJ0c8X2g/Xe8Y2wSe6e+CnDf1l2P9FOjz6mQ3uqNNq+VK9DFZ+LyHolO0aSqr2bLffUy8CZhzviFKbxJmBxe6eGAUE+afLSNUgdjfhz3pQ==; 7:H+GEJfVDfEmTnVIGRbtQyi+TVgwQh1zgV1lkcyEoFokj/IEeTzjLrC4JZ9riP66fZH3Abo6xhE8FLQVD+X0GPYj/QB3uCZkBp9lk6ZiPEh6vO9cvi1LxP9FQ5YmQWuyhFAL7i0SSRwwDBgBAn52MJw== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 74dfd226-e395-44bf-3992-08d677791612 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR08MB1008; x-ms-traffictypediagnostic: VI1PR08MB1008: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(3230021)(908002)(5005026)(6040522)(8220060)(2401047)(8121501046)(10201501046)(93006095)(93001095)(3231475)(944501520)(52105112)(3002001)(6055026)(6041310)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:VI1PR08MB1008; BCL:0; PCL:0; RULEID:; SRVR:VI1PR08MB1008; x-forefront-prvs: 09144DB0F7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(346002)(39860400002)(376002)(136003)(396003)(40434004)(199004)(189003)(13464003)(53936002)(105586002)(8936002)(256004)(14444005)(5024004)(9686003)(8676002)(478600001)(106356001)(74316002)(7696005)(6506007)(55016002)(53546011)(6436002)(71190400001)(76176011)(71200400001)(229853002)(86362001)(14454004)(2501003)(68736007)(55236004)(54906003)(486006)(99286004)(66066001)(305945005)(186003)(7736002)(81166006)(3846002)(6116002)(11346002)(4326008)(476003)(97736004)(6246003)(110136005)(446003)(5660300001)(102836004)(26005)(316002)(72206003)(33656002)(2906002)(25786009)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB1008; H:VI1PR08MB3167.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: fKF6qWXZftIE+Wid1oU+62CU2VqMmGcB7ECQkDxHZ/D6zD05i+g1BVhQAUn8mLySCCkfaNMS1oHPx2e7LEHJM6rzObxsMjCEjJD+sBPpBlzRYyWNQfqWgDIRXm9MHBF5iOopwKAmIEHj2acQNJ/ZjmsKQjh78Y5Js1OlpB02VpWykhmLccvHNV8G3UY5nqhJ0PiDNls+03ctnZ7XRTiwToDnAqO396crqIK+jxAKnOgSMDau7VDwRo3ozp7/kTc5qkY4tbXpz5NPi9aEDu7rLpBjGNphB0oaznrQqRbx/KkhlHnaT0R9g1si1qe9FUtgNh9a1kU27jwG4rUJa2m7S+AK/+m4mW3va6lcHxMfvIOQAl03Bzgm7B0pN1ozTIxn+IjwcYqZIWMP+Dy9mbRnId/k2xPyGWoSqMW01Ov1ZX4= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74dfd226-e395-44bf-3992-08d677791612 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2019 03:58:46.3474 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB1008 Subject: Re: [dpdk-dev] [PATCH] build: mention -march in pkg-config description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 03:58:48 -0000 > -----Original Message----- > From: dev On Behalf Of Luca Boccassi > Sent: Friday, January 11, 2019 1:28 AM > To: dev@dpdk.org > Cc: bruce.richardson@intel.com; christian.ehrhardt@canonical.com; Luca > Boccassi ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] build: mention -march in pkg-config descripti= on > > Applications need to at least match DPDK's -march option to build > successfully due to some static inline functions in the public headers. > > This might cause problems, especially in distributions, so add a note > in the pkg-config description. > > Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja build= s") > Cc: stable@dpdk.org > > Signed-off-by: Luca Boccassi > --- > At the moment there are no adversely affected applications in Debian and > Ubuntu (collectd builds a separate shared object, and OVS/virtio-forwared= er > are stand-alone DPDK-specific binaries), but we thought that having an > explicit notice would be good. > > meson.build | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index f87dc235f..35126106a 100644 > --- a/meson.build > +++ b/meson.build > @@ -83,7 +83,9 @@ pkg.generate(name: meson.project_name(), > libraries: dpdk_libraries, > libraries_private: dpdk_drivers + dpdk_static_libraries + > ['-Wl,-Bdynamic'] + dpdk_extra_ldflags, > -description: 'The Data Plane Development Kit (DPDK)', > +description: '''The Data Plane Development Kit (DPDK). > +Note that CFLAGS might contain an -march flag higher than typical baseli= ne. > +This is required for a number of static inline functions in the public >>From Arm's perspective, this notice is really necessary for some extensions= like LSE to work for performance. Reviewed-by: Gavin Hu > headers.''', > subdirs: [get_option('include_subdir_arch'), '.'], > extra_cflags: ['-include', 'rte_config.h'] + machine_args > ) > -- > 2.20.1 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.