From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20071.outbound.protection.outlook.com [40.107.2.71]) by dpdk.org (Postfix) with ESMTP id 00D602BAA; Tue, 19 Jun 2018 03:44:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eDS+ArdlgWZsR8mnT02aCnrY8Pg66iFK/SNPhmaN424=; b=pqu6NcxWPsr/znPCRFozmwhRi7OrBlDi9T8cwP7kOmaKUOfJ1CWivJsun+rNJoxl8tUu3q2ri/zZzmxTPW4HZ2pQ8arkpnQZaSky1SpaDYfZFjN4PERv8f5m2Zkx0jPjVgz8o7wLfDvXeEOslf2zjv8UWp7WbtpjYkmO66+nhAk= Received: from VI1PR08MB3167.eurprd08.prod.outlook.com (52.133.15.142) by VI1PR08MB3216.eurprd08.prod.outlook.com (52.133.15.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.19; Tue, 19 Jun 2018 01:44:24 +0000 Received: from VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::bccc:7b61:9039:89a0]) by VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::bccc:7b61:9039:89a0%4]) with mapi id 15.20.0863.016; Tue, 19 Jun 2018 01:44:24 +0000 From: Gavin Hu To: Bruce Richardson CC: "dev@dpdk.org" , nd , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v10 6/6] devtools: expand meson cross compiling test coverage Thread-Index: AQHUBJKy8aUUjZGKZUGCMMCI5x8TWKRhXTYAgAV3Z1A= Date: Tue, 19 Jun 2018 01:44:24 +0000 Message-ID: References: <20180615092605.12043-1-gavin.hu@arm.com> <20180615102143.12778-1-gavin.hu@arm.com> <20180615102143.12778-7-gavin.hu@arm.com> <20180615141431.GB11108@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20180615141431.GB11108@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR08MB3216; 7:YBtixkYIPbRdYh5K5ILcsZG5urZsoyu7TZ0LpLnBk/utECG6+u4cgh03WewwsNXYG32kV5XPJKQ+KiazIPHcCtfnngNSwq5g6g1jbyw+6GJ7+vwJSNx7m6C2Ob/mIjmfC6uE+5qUVKIpkLshLrv/0mKdRH9Us9SXUj7rE6inupp1s6L8Y1X4IV77jyEjW3C42Gj44ZnD+zBmrKa3JESFbiUZT5WAy4goda776/phL1xetF1Jwm/e0QsIViSKHUkO x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: f4477662-9b45-4498-bfdb-08d5d5862fcc x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:VI1PR08MB3216; x-ms-traffictypediagnostic: VI1PR08MB3216: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:VI1PR08MB3216; BCL:0; PCL:0; RULEID:; SRVR:VI1PR08MB3216; x-forefront-prvs: 07083FF734 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(39380400002)(376002)(346002)(39860400002)(13464003)(189003)(199004)(97736004)(2906002)(5250100002)(3280700002)(93886005)(25786009)(7736002)(3660700001)(229853002)(305945005)(68736007)(4326008)(74316002)(86362001)(54906003)(6246003)(478600001)(486006)(53936002)(53546011)(59450400001)(102836004)(6506007)(5660300001)(55236004)(7696005)(446003)(9686003)(6436002)(476003)(72206003)(76176011)(11346002)(316002)(106356001)(66066001)(99286004)(8676002)(81166006)(81156014)(14454004)(105586002)(8936002)(55016002)(6116002)(6916009)(3846002)(26005)(2900100001)(186003)(33656002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB3216; H:VI1PR08MB3167.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ML0f14Pi/OyfBPJvh4zLN89kSjpEtVXxILLbprgSb9mzKmlQXOzC72lXYPXSP9euPbm7X5+C0cv7nmhd2AsX6Ar+8qwHE4SBxuMLBfhMZikUKi8I+XSEYD6+TROgzG6cATHC2cgxWn4qiv7z7YaKcEw1b4F9+vIEDKHjB1Xl4PtHtQ88+k1qO7eBqi0gFIsW+NNDTL9bMo0LgP0cuzha60UN0RL7kGTlyITIPb+VsCjQLpihzQKZABXVjkq0jeCFPeFzuohRW3QaoTu3kBttmXlOv9K2guaOLZR8RpD8uelX5Z2jyImNMRAy75hfKk4EefamAyxWgUswtGpyVNMZFA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4477662-9b45-4498-bfdb-08d5d5862fcc X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jun 2018 01:44:24.5273 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3216 Subject: Re: [dpdk-dev] [PATCH v10 6/6] devtools: expand meson cross compiling test coverage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jun 2018 01:44:27 -0000 Hi Bruce, I submitted v11, please have a look, thanks for your review. Best Regards, Gavin > -----Original Message----- > From: Bruce Richardson > Sent: Friday, June 15, 2018 10:15 PM > To: Gavin Hu > Cc: dev@dpdk.org; nd ; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v10 6/6] devtools: expand meson cross > compiling test coverage >=20 > On Fri, Jun 15, 2018 at 06:21:43PM +0800, Gavin Hu wrote: > > The default test script covers only default host cc compiler, either > > gcc or clang, the fix is to cover both, gcc and clang. And also the > > build dirs are changed to *-host-$c, indicating the difference of cc us= ed. > > > > Fixes: a55277a788 ("devtools: add test script for meson builds") > > Cc: stable@dpdk.org > > > > Signed-off-by: Gavin Hu > > Reviewed-by: Phil Yang > > Reviewed-by: Song Zhu > > --- >=20 > Apologies, some late comments inline below that I missed on previous > reviews. >=20 > > devtools/test-meson-builds.sh | 13 +++++++++++-- > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/devtools/test-meson-builds.sh > > b/devtools/test-meson-builds.sh index 9bb5b93bd..f1553b7bd 100755 > > --- a/devtools/test-meson-builds.sh > > +++ b/devtools/test-meson-builds.sh > > @@ -44,11 +44,20 @@ done > > # test compilation with minimal x86 instruction set build > > build-x86-default -Dmachine=3Dnehalem > > > > +# compile the general v8a also for clang to increase coverage > > +f=3Dconfig/arm/arm64_armv8_linuxapp_gcc > > +export CC=3D"ccache clang" > > +build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2)-host-clang \ > > + --cross-file $f > > + >=20 > This might be better just as e.g. >=20 > +export CC=3D"ccache clang" > +build build-arm64-host-clang --cross-file > +config/arm/arm64_armv8_linuxapp_gcc >=20 > to be shorter and more readable. You don't really need the armv8 part in = the > directory name, as it's primarily a test of the clang host build, so you = can omit > it to shorten the command to a single line with all hardcoded values, whi= ch is > more readable than a version with tr filename mangling. >=20 > > # enable cross compilation if gcc cross-compiler is found for f in > > config/arm/arm*gcc ; do > > c=3Daarch64-linux-gnu-gcc > > if ! command -v $c >/dev/null 2>&1 ; then > > - continue > > + echo "## ERROR: $c is missing..." > > + exit 1 >=20 > I think this if check should be moved out of the block, and be before the= test > with clang, since that clang test will also fail. >=20 > > fi > > - build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2) --cross-file= $f > > + export CC=3D"ccache gcc" > > + build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2)-host-gcc \ > > + --cross-file $f > > done > > -- > > 2.11.0 > >