From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40061.outbound.protection.outlook.com [40.107.4.61]) by dpdk.org (Postfix) with ESMTP id DC2EA44BE for ; Wed, 30 May 2018 11:41:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=idknSs4ZErRC7lmKyrkqH94uyayhzJvUdBDoUq2trWs=; b=sDzatSOnSs54GikCZHimthhU2ljMbPoQTpdj0QHr5IA1cotJP7hQcHz5rtkkZYkjziPSC0XYt2MoUg66UT3HA7D381ocwDt53RJDfnTV+qoKPjiUzKUkR886doybYX196CTXWgewIyzqgw+juJJgcSqmwGMF7bMs14m5JGEVbhU= Received: from VI1PR08MB3167.eurprd08.prod.outlook.com (52.133.15.142) by VI1PR08MB1103.eurprd08.prod.outlook.com (10.166.45.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.797.11; Wed, 30 May 2018 09:41:01 +0000 Received: from VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::a105:3320:f324:a919]) by VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::a105:3320:f324:a919%13]) with mapi id 15.20.0797.015; Wed, 30 May 2018 09:41:01 +0000 From: Gavin Hu To: Thomas Monjalon , Bruce Richardson CC: "dev@dpdk.org" Thread-Topic: [dpdk-stable] [dpdk-dev] [PATCH v5 1/2] mk: fix cross build errors Thread-Index: AdP3vrRgN4jjc2YBQu6SVmzHn/eNtAAMgd8AAAJPzoA= Date: Wed, 30 May 2018 09:41:01 +0000 Message-ID: References: <3248809.BvU3dfXijd@xps> In-Reply-To: <3248809.BvU3dfXijd@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR08MB1103; 7:0XzKyIYfFz9FEqY0Ha0BAc8C/CpI33heyzhjA0cRuOHJ42CPUXxMY3uAeB62SPDirbgkE8Vaja5nJaOQrLhBCpZghqv3x+zFnks+I1k9DAX/L6sY5kGZyNDvkMBwtc6k7MKL3RPbqpUrU1AsGmeNY0RdxwgsQLWG0RJ9lUjrNxDXmydRujGCU1yUoeKDEi/PFG76DbH+z1ROW0T+x72Ru1pCd4Mts83kqUgPJQyXZMOmKmlxjI5dlZwKgKouIf+d x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:VI1PR08MB1103; x-ms-traffictypediagnostic: VI1PR08MB1103: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231254)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:VI1PR08MB1103; BCL:0; PCL:0; RULEID:; SRVR:VI1PR08MB1103; x-forefront-prvs: 0688BF9B46 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(396003)(376002)(346002)(39380400002)(366004)(39860400002)(13464003)(40434004)(189003)(199004)(81166006)(486006)(8676002)(6246003)(229853002)(476003)(446003)(55016002)(8936002)(9686003)(11346002)(55236004)(5660300001)(102836004)(33656002)(26005)(59450400001)(53546011)(6506007)(3660700001)(66066001)(4326008)(97736004)(186003)(2906002)(53936002)(6436002)(3280700002)(316002)(68736007)(6116002)(86362001)(99286004)(5250100002)(478600001)(14454004)(110136005)(25786009)(3846002)(2900100001)(5890100001)(74316002)(7696005)(105586002)(106356001)(7736002)(76176011)(81156014)(72206003)(305945005)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB1103; H:VI1PR08MB3167.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: sMgoQNBA6n0jnyGrxTSPlNxI7TMh2R6dCU0ivATPeOtGg7i0uJkoSiao7dzhZxAHOKSnGL2hAUOGu3EUDFwHGIHKyOzFFu56FI8BZFZPixptUpCDj7H7//zUG5Xj+iNCbv6ALJVriKvuPsTFvnvMbY8v8hrXSYD6L8jp0qF5cVWdrl6N2W32yftCbhH1Fuht spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 5bfcbf2a-00c9-4ef3-1739-08d5c611746f X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5bfcbf2a-00c9-4ef3-1739-08d5c611746f X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2018 09:41:01.2036 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB1103 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v5 1/2] mk: fix cross build errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2018 09:41:03 -0000 > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, May 30, 2018 4:32 PM > To: Gavin Hu > Cc: Bruce Richardson ; dev@dpdk.org > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v5 1/2] mk: fix cross build > errors > > 30/05/2018 04:45, Gavin Hu: > > From: Bruce Richardson > > > On Tue, May 29, 2018 at 04:45:55PM +0200, Thomas Monjalon wrote: > > > > 28/05/2018 15:24, Bruce Richardson: > > > > > Would a simpler solution for this not be to put "-Wno-implicit- > > > fallthrough" > > > > > for pmdinfogen? GCC will not give a warning for an unrecognised "= - > Wno" > > > > > flag when compiling, unless there are other errors. This means > > > > > we can just use the flag without bothering with version checks. > > > > > > > > No, it does not work. > > > > I have this error with clang 5.0.1: > > > > error: unknown warning option '-Wno-format-truncation' > > > > > > > Yes, you still need to check for GCC to use the flag, just not for a > > > specific version of GCC. > > > > > > /Bruce > > [Gavin Hu] Hi Thomas, '-Wno-format-truncation' is applied to gcc only, = not > to clang. > > Gcc, icc and clang have their own WERROR_FLAGS, they should not mix up > with each other. > > Now I understand what we missed from the beginning: I am testing with > meson. > This flag is added unconditionnaly in config/meson.build. [Gavin Hu] Hi Thomas and Bruce, then do you have more comments on the v5 pa= tch? Any comments are welcome, if no, can you act the patches for merging? > > > @Bruce, > > Yes, in this sense, I am really concerned about to add -Wno-implicit- > fallthrough option in the pmdinfogen Makefile, as it impacts not only gcc= , but > also clang and icc. > > Maybe this not a best solution, as maybe it is not supported by all > compilers. So should I fall back to the previous patch which check for th= e gcc > version and apply the options for gcc only? > > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.