From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0065.outbound.protection.outlook.com [104.47.2.65]) by dpdk.org (Postfix) with ESMTP id 6ECAF37B0; Tue, 19 Jun 2018 12:41:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J6CzDgKucqFJQKHGL6wDjekCY01A/gty98lEWwFdqbY=; b=ljSjR2DctHqCALSg6Fi5c2UT/zI0hyv2u1ZcpBzwGHztrp7H69k3MwM6JdViOafgoAucil5cT1UuSgZX+AW4ntfXmVtMJa98uDp4Z8CQ6FqWf+UEnKLH/ZToJQxVOHcPx1CoEnb1qf8FHlgo4CT1ne+qhCvaovrvDu5WNfZYkdk= Received: from VI1PR08MB3167.eurprd08.prod.outlook.com (52.133.15.142) by VI1PR08MB0510.eurprd08.prod.outlook.com (10.162.16.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.19; Tue, 19 Jun 2018 10:41:06 +0000 Received: from VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::bccc:7b61:9039:89a0]) by VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::bccc:7b61:9039:89a0%4]) with mapi id 15.20.0863.016; Tue, 19 Jun 2018 10:41:06 +0000 From: Gavin Hu To: Bruce Richardson CC: "dev@dpdk.org" , nd , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v11 4/6] devtools: fix the missing ninja command error Thread-Index: AQHUB24pch/aGqPqlEagi31IIWG3B6RnXScAgAAHUBA= Date: Tue, 19 Jun 2018 10:41:06 +0000 Message-ID: References: <20180615102143.12778-1-gavin.hu@arm.com> <20180619013746.13268-1-gavin.hu@arm.com> <20180619013746.13268-5-gavin.hu@arm.com> <20180619101220.GB23348@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20180619101220.GB23348@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR08MB0510; 7:7flAMcsDJ2GrwFDg5JJyDCquC60ZxOT+VbU2S4LExYYSqzXZxVB00v8PBmBzf5D1l6ve+1nCOj+4P7ki5oni63y001Z2RNmgzvp+HVwegOJZ2tF//1oT1NS43ins7p9xC2+0FMXkjLqhYDEAWZ5Fi1dKfRnmTo6HE4dJuJeCLTYxY0mX3FJCgAZdMTGZiPrNSVQAyRKbrZwbqbrlrvHLP1IAp2Ct9cAXrr6ykeT7Mtjv2DEeLMiD4VWirKFDpw/g x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 4db4b7d3-fb39-41e5-1151-08d5d5d129d0 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:VI1PR08MB0510; x-ms-traffictypediagnostic: VI1PR08MB0510: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(158342451672863)(180628864354917)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231254)(944501410)(52105095)(93006095)(93001095)(3002001)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:VI1PR08MB0510; BCL:0; PCL:0; RULEID:; SRVR:VI1PR08MB0510; x-forefront-prvs: 07083FF734 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(396003)(376002)(366004)(39380400002)(39860400002)(13464003)(199004)(189003)(2906002)(478600001)(54906003)(476003)(4326008)(7736002)(6916009)(93886005)(186003)(305945005)(99286004)(6506007)(53546011)(316002)(74316002)(486006)(102836004)(25786009)(55236004)(26005)(33656002)(53936002)(11346002)(446003)(7696005)(6246003)(3660700001)(9686003)(76176011)(3280700002)(55016002)(6116002)(229853002)(68736007)(5660300001)(14454004)(97736004)(6436002)(3846002)(105586002)(106356001)(8936002)(72206003)(8676002)(2900100001)(81166006)(81156014)(66066001)(5250100002)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB0510; H:VI1PR08MB3167.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: GrGI0Cy2xqqaSGBZHaoLG6fX4qneAWdKmOYDDdjU/pQwm4nkrWBVuNQmD1Wk0Jr99YUVAoLmfzF9qnf3/gHN3bVdAmW3aDPyr8vQAC0KvP7vlU8ySKjuPEPL1NPfnw6HCu+OAbxrcsPOBPz1xMeHegITRRkbvQlvMakqWKYt5mF4LfRaIv8UdBT1bt50Eyuzq6PMv5G5222Fzt9XOh/eMztwTglsqXva95hqCZ3gmiiZMZAB36sxNHlWOWmcQiJxHB0v/vYhdnx377y7I6xhXIIoUIoHQaF76prkxcNbt4pvw8THT3YGL6nsHhRUjV1Bay3w+ptiV+ZbUb12MAQW+A== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4db4b7d3-fb39-41e5-1151-08d5d5d129d0 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jun 2018 10:41:06.7835 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB0510 Subject: Re: [dpdk-dev] [PATCH v11 4/6] devtools: fix the missing ninja command error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jun 2018 10:41:08 -0000 Hi Bruce, Thanks for your review, I submitted v12 patch to address all your new comme= nts. BTW, do you know why pwclient can NOT work successfully today?=20 It worked fine at my side previously, any changes at the server side? The e= rror is below:=20 xmlrpc.client.ProtocolError: Best Regards, Gavin > -----Original Message----- > From: Bruce Richardson > Sent: Tuesday, June 19, 2018 6:12 PM > To: Gavin Hu > Cc: dev@dpdk.org; nd ; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v11 4/6] devtools: fix the missing ninja > command error >=20 > On Tue, Jun 19, 2018 at 09:37:44AM +0800, Gavin Hu wrote: > > On some linux distributions, eg: CentOS, the ninja executable has a > > different name: ninja-build, this patch is to check and adapt to it > > accordingly. > > > > ./devtools/test-meson-builds.sh: line 24: ninja: command not found > > > > Fixes: a55277a788 ("devtools: add test script for meson builds") > > Cc: stable@dpdk.org > > > > Signed-off-by: Gavin Hu > > Reviewed-by: Phil Yang > > Reviewed-by: Song Zhu > > --- > This is previously acked.