From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0054.outbound.protection.outlook.com [104.47.0.54]) by dpdk.org (Postfix) with ESMTP id 2C3621D689; Fri, 15 Jun 2018 11:31:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8SI915QJU0O8eSanKs04HjUGl8p7Zy3mlHDaJwj44GA=; b=Dwwd34WWi+kYI1Tuxu+4iLmwaloZhMpO+ebQNwD9WR2IW0LHDDQpLa7tlmppPnAjlcS3mtUxogzB6eOe3DPwrDagM/JEVTRVkqgUTKHLKLAlZikq4Qth5/K7eO6L6TYXeb5SWPsz9mA7XEpDc9RiXpRfZuDtp8DXviRc2FKqejI= Received: from VI1PR08MB3167.eurprd08.prod.outlook.com (52.133.15.142) by VI1PR08MB3358.eurprd08.prod.outlook.com (52.134.31.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.14; Fri, 15 Jun 2018 09:31:42 +0000 Received: from VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::bccc:7b61:9039:89a0]) by VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::bccc:7b61:9039:89a0%4]) with mapi id 15.20.0863.016; Fri, 15 Jun 2018 09:31:42 +0000 From: Gavin Hu To: Bruce Richardson CC: "dev@dpdk.org" , nd , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v8 6/6] devtools: expand meson cross compiling coverage Thread-Index: AQHUBH8X5G7SbedvyUOBulFxGpYAo6Rg/JSAgAARhLA= Date: Fri, 15 Jun 2018 09:31:42 +0000 Message-ID: References: <20180615070811.18686-1-gavin.hu@arm.com> <20180615080120.29253-1-gavin.hu@arm.com> <20180615080120.29253-7-gavin.hu@arm.com> <20180615082807.GB23520@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20180615082807.GB23520@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR08MB3358; 7:UX05I7B2dMk3Z5w/aWNcBndxRfxLGGKHDGSwLiTeYBBcxpSnnqe+w3CaQW+ks8/Nh+gHfN1vLrGD4ehLDbx/5BKUHS69gg0tTA2v6O/q52KYNhyB1CDYWRZSch3OKMvL5ll7lI15AcrDFIIjpWxuuMKbwNnxaPrNMX1JJy4bxNIG1SmKg55/3pWA4W1rnXrqsKucKuVqNTP21Aq7CezuKqBusB+M5z20GAGBCSQz6pul9GaFOSQkxliyxEsnM0A4 x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: bd66ee46-2d33-404c-57ba-08d5d2a2cdfd x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:VI1PR08MB3358; x-ms-traffictypediagnostic: VI1PR08MB3358: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3231254)(944501410)(52105095)(93006095)(93001095)(3002001)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:VI1PR08MB3358; BCL:0; PCL:0; RULEID:; SRVR:VI1PR08MB3358; x-forefront-prvs: 0704670F76 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(39380400002)(376002)(346002)(366004)(396003)(189003)(199004)(13464003)(476003)(229853002)(316002)(9686003)(6916009)(72206003)(54906003)(2900100001)(86362001)(446003)(66066001)(486006)(14454004)(11346002)(97736004)(55016002)(6436002)(186003)(7696005)(76176011)(59450400001)(6506007)(102836004)(53546011)(5250100002)(33656002)(5660300001)(26005)(105586002)(99286004)(106356001)(74316002)(6116002)(3846002)(53936002)(68736007)(93886005)(4326008)(7736002)(478600001)(55236004)(8936002)(81156014)(8676002)(81166006)(25786009)(305945005)(6246003)(2906002)(3280700002)(3660700001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB3358; H:VI1PR08MB3167.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 3I8KQ48IXfsMBHnLFPpIXsjhi/ChTVVOu3kyV5UWcJkM1aTzJ+JL8kkZbNNZJPN+cK4EtoPsHwqdUsqKDxpNZLb5KhlpS4iL8vkH/f8d8OLZ1Vs22mTkChdpkkYrvgOKCUucBNJGFUIqc9yFUx5McYFHUEWg5RcNH6dlPwMADauA6pAu0wNjbKsj+vr7goai spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd66ee46-2d33-404c-57ba-08d5d2a2cdfd X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2018 09:31:42.3379 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3358 Subject: Re: [dpdk-dev] [PATCH v8 6/6] devtools: expand meson cross compiling coverage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2018 09:31:44 -0000 Hi Bruce, Thanks for your review, new v9 patch set was submitted. Any more comments are welcome! Best Regards, Gavin > -----Original Message----- > From: Bruce Richardson > Sent: Friday, June 15, 2018 4:28 PM > To: Gavin Hu > Cc: dev@dpdk.org; nd ; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8 6/6] devtools: expand meson cross > compiling coverage >=20 > On Fri, Jun 15, 2018 at 04:01:20PM +0800, Gavin Hu wrote: > > The default test script covers only default host cc compiler, either > > gcc or clang, the fix is to cover both, gcc and clang. And also the > > build dirs are changed to *-host-$c, indicating the difference of cc us= ed. > > > > Fixes: a55277a788 ("devtools: add test script for meson builds") > > Cc: stable@dpdk.org > > > > Signed-off-by: Gavin Hu > > Reviewed-by: Phil Yang > > Reviewed-by: Song Zhu > > --- > > devtools/test-meson-builds.sh | 12 +++++++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > diff --git a/devtools/test-meson-builds.sh > > b/devtools/test-meson-builds.sh index 8447c704b..f75ebbdb1 100755 > > --- a/devtools/test-meson-builds.sh > > +++ b/devtools/test-meson-builds.sh > > @@ -50,5 +50,15 @@ for f in config/arm/arm*gcc ; do > > if ! command -v $c >/dev/null 2>&1 ; then > > continue > > fi > > - build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2) --cross-file= $f > > + export CC=3D"ccache gcc" > > + build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2)-host-gcc = \ > > + --cross-file $f > > + unset CC > > + # compile the general v8a also for clang to increase coverage > > + if [ $f =3D config/arm/arm64_armv8_linuxapp_gcc ] ; then > > + export CC=3D"ccache clang" > > + build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2)-host-= clang \ > > + --cross-file $f > > + unset CC > > + fi >=20 > Indentation is different in the new code, spaces vs tabs, perhaps. I'm al= so not > sure the "unset CC" is needed, because I think the build function > automatically unsets it when done. >=20 > One other style comment: rather than having an if condition in the loop a= nd > putting the extra build there, it might be easier just to put the extra c= all to > build outside the main loop, since all values are essentially hardcoded i= n that > call anyway.