From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Gavin.Hu@arm.com> Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80070.outbound.protection.outlook.com [40.107.8.70]) by dpdk.org (Postfix) with ESMTP id DCB3E201 for <dev@dpdk.org>; Sat, 9 Mar 2019 11:28:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4ARUxeevUczrk3Ub1fSleGL5iOHHOMr2B+5ZjwjEb7c=; b=P0FTm6TRv3Xe3bj+Lq5o+PLFkCkMGv8Md7tSDKpGTlQfw2gO0VePbnJdoYQhSoE7nnDxCplx60wswGl1yrgvIJRG8O/CifLsaYEoc+Y1HyF8l+YnyktkgkONGd4t3Fqvz7eqnuCtB2zd2N4tBvg2G+ajJq6oTXSEGrQMcom0Crg= Received: from VI1PR08MB3167.eurprd08.prod.outlook.com (52.133.15.142) by VI1PR08MB2974.eurprd08.prod.outlook.com (52.133.14.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Sat, 9 Mar 2019 10:28:57 +0000 Received: from VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::707a:b455:dcb2:9d40]) by VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::707a:b455:dcb2:9d40%2]) with mapi id 15.20.1686.021; Sat, 9 Mar 2019 10:28:57 +0000 From: "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, "thomas@monjalon.net" <thomas@monjalon.net>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com> CC: Ilya Maximets <i.maximets@samsung.com>, "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>, "jerinj@marvell.com" <jerinj@marvell.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "Nipun.gupta@nxp.com" <nipun.gupta@nxp.com>, "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, "chaozhu@linux.vnet.ibm.com" <chaozhu@linux.vnet.ibm.com>, nd <nd@arm.com> Thread-Topic: [PATCH v2] ring: enforce reading the tails before ring operations Thread-Index: AQHU1LF27vtsQ2Xy+0iZsAZL3+5RW6X/3LWAgAAItaCAAAb/gIAADMAQgAEUeFCAAJmlgIAALgYQgAAOnACAAH0WAIAACFgAgACxm+A= Date: Sat, 9 Mar 2019 10:28:57 +0000 Message-ID: <VI1PR08MB31678059A977790E19406C888F4E0@VI1PR08MB3167.eurprd08.prod.outlook.com> References: <1551841661-42892-1-git-send-email-gavin.hu@arm.com> <VI1PR08MB31670DE4179E1194F5410D428F4D0@VI1PR08MB3167.eurprd08.prod.outlook.com> <2601191342CEEE43887BDE71AB9772580136556F40@irsmsx105.ger.corp.intel.com> <2456717.RLOWIjrx09@xps> <AM6PR08MB367217F20AD2D688AC28039D984D0@AM6PR08MB3672.eurprd08.prod.outlook.com> In-Reply-To: <AM6PR08MB367217F20AD2D688AC28039D984D0@AM6PR08MB3672.eurprd08.prod.outlook.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cb9ffafc-1e46-4b94-ad71-08d6a47a09a2 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR08MB2974; x-ms-traffictypediagnostic: VI1PR08MB2974: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: True x-microsoft-exchange-diagnostics: 1; VI1PR08MB2974; 20:fHO/gslcd+R9R72THOlCqosmSXh3SaN63jGY08IbX8MZeM9AZX/NfD/lzcD2PO1p7kV+O8IN5tMmoZ1g9ee9zXH9FHp/IcZif6KrVcstDCZWWkh3iTLt15PC/ppe+sXoDRcZgXJIs8yYnZwF1rG6gPWYBxtJ6toCV6KwlUwgWKw= x-microsoft-antispam-prvs: <VI1PR08MB29748C3DC0C6506FBBCF14CD8F4E0@VI1PR08MB2974.eurprd08.prod.outlook.com> x-forefront-prvs: 0971922F40 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(376002)(346002)(136003)(366004)(189003)(199004)(51444003)(52314003)(13464003)(256004)(316002)(6436002)(97736004)(81166006)(8676002)(81156014)(14454004)(55016002)(110136005)(14444005)(54906003)(9686003)(105586002)(478600001)(3846002)(6116002)(8936002)(106356001)(6246003)(66066001)(2501003)(53936002)(72206003)(229853002)(93886005)(99286004)(11346002)(102836004)(446003)(186003)(76176011)(74316002)(86362001)(486006)(2906002)(476003)(53546011)(71190400001)(33656002)(55236004)(5660300002)(6506007)(7736002)(4326008)(25786009)(71200400001)(7696005)(305945005)(7416002)(26005)(52536013)(68736007)(21314003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB2974; H:VI1PR08MB3167.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: LcgKg3GxWj2eriiicl/GG87JhLEc+SEZf3oPs4zV6jaB9WP7UXAcjrJJOGZe8V/xCpvSHFLQ1PN+u9gwMfZkGklnEDchC0qp67S+BlTyhQYTcW3mZEU8gN57KZnWC9UH/HLpWEk2y8VRlEc5fO1fILNJvNMNclfQ8jc/4xLH8nfYfI/pMxLrg8QEaXji0QEulaxPAY/Kd6qdVO477TB0RKFIkHDgEuvvnzalprN0Uqvm/aA45CpV9KFdQUyo+0rAhNj/vu6SHyVy2wYdW06D5ZVv+8OdQUR2cha1IFnn2P37eNiAVn8nWdpEGyQPgU1w+5bW2FpLDW5WexXZgMHHaYEpmn6l40JLpMTXE7qG1pGX23A/Z0tNqrDTXElkxytuozXBz41kUrevP9KQzrOSRdx6XdjJO6oIUqip7LiSZ3Y= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb9ffafc-1e46-4b94-ad71-08d6a47a09a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2019 10:28:57.1463 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2974 Subject: Re: [dpdk-dev] [PATCH v2] ring: enforce reading the tails before ring operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Sat, 09 Mar 2019 10:29:00 -0000 > -----Original Message----- > From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> > Sent: Saturday, March 9, 2019 7:48 AM > To: thomas@monjalon.net; Ananyev, Konstantin > <konstantin.ananyev@intel.com>; Gavin Hu (Arm Technology China) > <Gavin.Hu@arm.com> > Cc: Ilya Maximets <i.maximets@samsung.com>; dev@dpdk.org; nd > <nd@arm.com>; jerinj@marvell.com; hemant.agrawal@nxp.com; > Nipun.gupta@nxp.com; olivier.matz@6wind.com; Richardson, Bruce > <bruce.richardson@intel.com>; chaozhu@linux.vnet.ibm.com; nd > <nd@arm.com> > Subject: RE: [PATCH v2] ring: enforce reading the tails before ring > operations >=20 > > 08/03/2019 16:50, Ananyev, Konstantin: > > > 08/03/2019 16:05, Gavin Hu (Arm Technology China): > > > > Anyway, on x86, smp_rmb, as a compiler barrier, applies to > load/store, not > > only load/load. > > > > > > Yes, that's true, but I think that's happened by coincidence, not > > > intentionally. > > > > > > > This is the case also for arm, arm64, ppc32, ppc64. > > > > I will submit a patch to expand the definition of this API. > > > > > > I understand your intention, but that does mean we would also need > to > > > change not only rte_smp_rmb() but rte_rmb() too (to keep things > consistent)? > > > That sounds worring. > > > Might be better to keep smp_rmb() definition as it is, and introduce > > > new function that fits your purposes (smp_rwmb or > smp_load_store_barrier)? > Looking at rte_rmb, rte_io_rmb, rte_cio_rmb implementations for Arm, > they all provide load/store barrier as well. If other architectures also > provide load/store barrier with rte_xxx_rmb, then we could extend the > meaning of the existing APIs. Further looking at rte_rmb, rte_io_rmb, rte_cio_rmb implementations for PPC= 64 and x86, They also provide load/store barrier. It is safe to extend the meaning of t= he existing rte_XXX_rmb API. >=20 > Even if a new API is provided, we need to do provide the same APIs for IO > and CIO variants. Since rte_XXX_rmbs API for all architectures already provide the desired lo= ad/store ordering, a new API is redundant and not needed.=20 > > > > How is it managed in other projects? > In my experience, I usually have been changing the algorithms to use C11 > memory model. So, I have not come across this issue yet. Others can > comment. >=20 > >