From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0071.outbound.protection.outlook.com [104.47.1.71]) by dpdk.org (Postfix) with ESMTP id 4FE533772 for ; Wed, 29 Aug 2018 09:01:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cn0ngkq1LdBfIypiAUfUsGDyYAqeWKClablLFlGHnxw=; b=LJV7UF4LxW6f1qQpMrmghPzRARZXZ7spMFrwOuae8D3q46cxjcQl5T/4NXKkT2BNOvfnD7ZHcjeZO+uz23dleRQRKbZlhTBfrq9zb5C5ZpW0YAkl1+L8F5YiB5FRTIUGktxsMXjKjCHdt70/oj+gyYb6SHKgkROK9B8psxEvkdc= Received: from VI1PR08MB3167.eurprd08.prod.outlook.com (52.133.15.142) by VI1PR08MB2847.eurprd08.prod.outlook.com (10.170.236.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.17; Wed, 29 Aug 2018 07:01:46 +0000 Received: from VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::184d:ac38:254f:3a45]) by VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::184d:ac38:254f:3a45%2]) with mapi id 15.20.1080.015; Wed, 29 Aug 2018 07:01:46 +0000 From: Gavin Hu To: Honnappa Nagarahalli , "bruce.richardson@intel.com" CC: "dev@dpdk.org" , "rasland@mellanox.com" , "therbert@redhat.com" , Honnappa Nagarahalli , nd Thread-Topic: [PATCH] build: enable Arm NEON flags when __aarch64__ is defined Thread-Index: AQHUOij7qiiL9YMitUyHFgpuUP5UNKTWV8lA Date: Wed, 29 Aug 2018 07:01:46 +0000 Message-ID: References: <1534950067-113999-1-git-send-email-honnappa.nagarahalli@arm.com> In-Reply-To: <1534950067-113999-1-git-send-email-honnappa.nagarahalli@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR08MB2847; 6:kJDbBbwTWoEmF1ergpDpQsOEmAUu68D4BHWU2jkVfkUvVx/kT4po6NvX3F2ed2SHa+jcBc4IAEE5q9sfmPlbRvbK3NChZI8PpUCMSamWw7ZTy4t7IG0brmHbX1DLX7B3FFVMNege2Vmv1x34nPiLiHu/ABbRS7GWCpoVZWZ03C+aumPktpshvjZlaZoQbWyqPKaezXxnJ/kfVXQyC5Dxt8a4Dy3Zynt7XU8ORmJ21yp1LlGVuhjaIO3mMltYxu2xIshfO771aiTRVjm53KUJE9Ru/KOplhOuP9fTM/XwhlLxnl1qStfIKnA2cYlwpV8ou4eLQfVNvs2CHpbbk0afRNMbG2y4ZMKfzOO49czuVRm3/LezxrRehO8oWAv/LIIaCCu6SxFucntGPAS+Ij8EmkZzbgg0WQRpXdmAlrNVTcDSu6B90Rt9WYE8wtARCv1Plip09+KgKpXFvP49lQYHmw==; 5:T7+L5b5+yV1lxGtInmAId4NlNk3nDKclKLiPaaNGKf6ghnhj7p8C89DqHX5NNISHnKazBYuRtyUvYc8B+61dN+Sz4WUSRKvK+R9JDYF5KacMJ/EnecXlf1ibdPcH6OvV0986SlKQ8pFlXh1sPo/V40daVY1bxOXasO2+8ASWcU0=; 7:KdfrWQ5CVsSvt/lbxoQMm2gWD3ntBG48UCdYr3Z8uC09gFP/AVnMzpKXo+R/+Xv1Bgob1/i5LRxyYFaU9pCuJHArozxE+m5TC1/zyqgLs7anDeId9MmeGjrbTnDtPmjWhPZEUOdTo/okO+AYwa7mgD/W5X38/nX16+vF/5pOPhfgniSh8ZIrGHprtjrNPtUz0hBVoJA00L+GC+n1tTVlW+np4M/KE2psFhsfN2Lc3HoK7cj/AGRGbNy3Kj7/SLqs x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-correlation-id: 7139fe38-495f-4867-a06d-08d60d7d48db x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR08MB2847; x-ms-traffictypediagnostic: VI1PR08MB2847: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823301075)(3002001)(3231311)(944501410)(52105095)(10201501046)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(201708071742011)(7699016); SRVR:VI1PR08MB2847; BCL:0; PCL:0; RULEID:; SRVR:VI1PR08MB2847; x-forefront-prvs: 077929D941 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(136003)(366004)(396003)(376002)(346002)(199004)(189003)(13464003)(7736002)(74316002)(55016002)(3846002)(6436002)(6116002)(33656002)(486006)(99286004)(229853002)(9686003)(106356001)(5660300001)(76176011)(478600001)(105586002)(14454004)(54906003)(7696005)(66066001)(72206003)(68736007)(110136005)(53546011)(8936002)(25786009)(97736004)(26005)(6506007)(2900100001)(4326008)(2906002)(102836004)(316002)(6246003)(11346002)(81166006)(305945005)(81156014)(446003)(8676002)(476003)(53936002)(256004)(2501003)(86362001)(5250100002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB2847; H:VI1PR08MB3167.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: +RaFvONFjc74TKvqQhbv1x9k+b5gsDu1q+oN+rWcUwAuihizzNeaa29hwQT0g/noKM9vrBw4PH4px7tn+ExF2I60OXxqNPTtNnNoTswS6iKj4iyg2YMNXdG70RZ79Kw1U8Lr2PkZt8JLTt6BZ0nlUbirqvsWcdjUn1D7zxeL+ZXy6sQRXqg8xNvTcZ9sp9Sr/6TSGtaHa9xiXGz4pIjraOwh4Mg7r0yE2tFDrMWXnIXHSikaoQdrA9wdTvdE9XzNQM4ZaXoBJElzzCCwNeM22Vm7KoAb2PO0MMP7CSsriWNF5m9TFlsjd33Sc2bU6IUzTtqya/wntcS1wLTBDSXYXQ8ZPhQBBtmgvdHBpIo386o= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7139fe38-495f-4867-a06d-08d60d7d48db X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Aug 2018 07:01:46.2679 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2847 Subject: Re: [dpdk-dev] [PATCH] build: enable Arm NEON flags when __aarch64__ is defined X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2018 07:01:48 -0000 > -----Original Message----- > From: Honnappa Nagarahalli > Sent: Wednesday, August 22, 2018 11:01 PM > To: bruce.richardson@intel.com > Cc: dev@dpdk.org; Gavin Hu ; rasland@mellanox.com; > therbert@redhat.com; Honnappa Nagarahalli > > Subject: [PATCH] build: enable Arm NEON flags when __aarch64__ is defined >=20 > GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not optional > for ArmV8. Hence NEON related code can be enabled when __aarch64__ is > defined. >=20 > Bugzilla ID: 82 >=20 > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Phil Yang > Reviewed-by: Gavin Hu > Reported-by: Raslan Darawsheh > Reported-by: Thomas F Herbert Acked-by: Gavin Hu > --- > config/arm/meson.build | 3 ++- > mk/rte.cpuflags.mk | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/config/arm/meson.build b/config/arm/meson.build index > 40dbc87f7..94cca490e 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -157,7 +157,8 @@ else > endif > message(machine_args) >=20 > -if cc.get_define('__ARM_NEON', args: machine_args) !=3D '' > +if (cc.get_define('__ARM_NEON', args: machine_args) !=3D '' or > + cc.get_define('__aarch64__', args: machine_args) !=3D '') > dpdk_conf.set('RTE_MACHINE_CPUFLAG_NEON', 1) > compile_time_cpuflags +=3D ['RTE_CPUFLAG_NEON'] endif diff --git > a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk index 60713137d..43ed84155 > 100644 > --- a/mk/rte.cpuflags.mk > +++ b/mk/rte.cpuflags.mk > @@ -89,7 +89,7 @@ CPUFLAGS +=3D VSX > endif >=20 > # ARM flags > -ifneq ($(filter $(AUTO_CPUFLAGS),__ARM_NEON),) > +ifneq ($(filter __ARM_NEON __aarch64__,$(AUTO_CPUFLAGS)),) > CPUFLAGS +=3D NEON > endif >=20 > -- > 2.17.1