From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70058.outbound.protection.outlook.com [40.107.7.58]) by dpdk.org (Postfix) with ESMTP id D2CDD1B5B9; Sat, 4 Aug 2018 08:42:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7Wuszhvi1bdo8R9sH3JwCcILt7NsqmOBgFa6d8OvcS0=; b=isX17TCW6j8xh0BfWgyEOo433RLj+0ECWzlg3+8nnuCDoz47p2P95CP5fLHQ6h9skvmAuRG09ZpCAJ/51a4JtEOkO4IZ07rat63Tk5s5Kv4vv5f5esKS64SO6w3gqj1f0Nq99xn0NtmTfSV3hYTY8fFVwgCSpD0ylkvB8l5tjzY= Received: from VI1PR08MB3167.eurprd08.prod.outlook.com (52.133.15.142) by VI1PR08MB3664.eurprd08.prod.outlook.com (20.177.61.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.15; Sat, 4 Aug 2018 06:42:53 +0000 Received: from VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::e122:5d23:5e33:b62e]) by VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::e122:5d23:5e33:b62e%3]) with mapi id 15.20.1017.010; Sat, 4 Aug 2018 06:42:53 +0000 From: Gavin Hu To: Stephen Hemminger CC: "dev@dpdk.org" , Honnappa Nagarahalli , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] devtools: trap SIGINT is not recognizable to dash Thread-Index: AQHUKVfHo+LoTTO2FkKDTg3drQeS1qSunMeAgACL+ZA= Date: Sat, 4 Aug 2018 06:42:53 +0000 Message-ID: References: <20180801052257.14869-1-gavin.hu@arm.com> <20180803151715.4197d43d@xeon-e3> In-Reply-To: <20180803151715.4197d43d@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [218.83.110.136] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR08MB3664; 6:rovVzgrZ1sdx8GbJBUsUza2HnAxXGLWZKkKtqbuVLL+07TA0c6aeDV1yuzDWyhxqaiBVO2X74JhG86YKIMZxaaBEXgNI7wz/bjrmh966AqnatX/D1i6N+m5uVdlMAwemXCBtHzT47WihIJ/1w/cuUZMR2Fyv8sDHHkJQpQk8m0jpgjnfuDsCpQdyoG81X67m6wbMPHF3Gb5X2MM04Bj1p/ZXWhHSSzrHKvC1boTXEEGeBt+oBVIP+Poj7cRLAYyL9OOv+Pr9c0DoUmR6LKInOjm0nbaR5AhqA6xAHit2llU0lqlvv6JNQtR8+WNYKUn0XXum6RHPoYafkc/+pKgVhjfWansF1rIjp+uD3GIi6sQFjS9GegmqyOpe7Eonm+RZud5QzC3Wq4hDZRsiEEAh5RhDARj3MmC+WmIrfhGQRq607G617uCe7l/wsByCb3V1t0Q0PUdNUUyLeCwgxFRyuw==; 5:6+Vw+tUEeuK50naneqDNFzxWEEOQrO3efW/zOxVvJZDrnWRe8y+3jGfacLylo8Anum5tE79G6l0ACVLbGCM+n4ZEYFHXUdLRrNbQ5S4xqqpvWXlPcmX6kPTnOIrDvPcmGuSWuF2SiycKi7fSYspEO7xpOgxdvYmmG2OsFL21d80=; 7:OHEEe4Lxwd7EIw5ma0KGkJ41VgMrKFOr3nubS7Gi5823ydAmbAFLhifi0Y8ZHT5XD/4SMhQqGUBK/GZDVA4rrqeD41M/pDAfGzKzmmd9/AXoJiNRkEhHR1IIne1P7qwZJTbikK1qhYgSI2nPFp7RdhpIY958okJSGHTu5jlI+9KHys7Av/PiU4ZhhPnEP+j11s/aYMP2o1Z4Rmif1SrhzvhxdXvlygo60FX0r/1LMWFc4l0AzV67A4+4txolDorR x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-correlation-id: 92298815-34f5-45e1-8f67-08d5f9d58154 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR08MB3664; x-ms-traffictypediagnostic: VI1PR08MB3664: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(223705240517415)(788757137089); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231311)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123560045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:VI1PR08MB3664; BCL:0; PCL:0; RULEID:; SRVR:VI1PR08MB3664; x-forefront-prvs: 0754F7E325 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(396003)(136003)(346002)(376002)(199004)(189003)(40434004)(13464003)(8676002)(25786009)(6246003)(99286004)(7696005)(76176011)(14454004)(72206003)(81166006)(81156014)(68736007)(97736004)(4326008)(14444005)(476003)(26005)(486006)(66066001)(256004)(6506007)(5024004)(6916009)(11346002)(186003)(446003)(102836004)(316002)(86362001)(53546011)(54906003)(5660300001)(2906002)(6116002)(305945005)(3846002)(55016002)(8936002)(2900100001)(5250100002)(106356001)(74316002)(105586002)(478600001)(6436002)(7736002)(53936002)(229853002)(33656002)(9686003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB3664; H:VI1PR08MB3167.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 7RgNku36E6OIt+7qUIQtR2EKJ23SRCZT0+nSqvka3vE77NjtmhvvoxAfggHb7TzwpckqA5GhxC1enTV4Tpcu9CVKJ5IsEPlGsaDMUFabYQKCmyN6Yy6vcGMK92S7UKD7LEDwpnuoIIsMEBn0avxRj/EZJ0/nFYkshA+uTzpL7tjW+V0W9vILVagPnbnS06FH25Dagk83gZV9kQ0Wo7V09WSLbs86U9A5ujDeXuP0AJboYXewo9m56ThRaqWxGLifkbjPePPUv9UtNnvibXgZGTfJxrjrkTS19Lkrd/gRuLTdgfY+cOIWSyI8WseXHbcu+LfizoQSZvmjfopyP3FJ6XrB2sd2Bwfax3KjTxjn1F0= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92298815-34f5-45e1-8f67-08d5f9d58154 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2018 06:42:53.3944 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3664 Subject: Re: [dpdk-dev] [PATCH] devtools: trap SIGINT is not recognizable to dash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Aug 2018 06:43:00 -0000 Hi Stephen, I am no sure only supporting bash is acceptable or not. Any impact to freeb= sd? We should seek wider opinions about this. I did not meet your problem, either bash or dash, what's your shell? Best Regards, Gavin > -----Original Message----- > From: Stephen Hemminger > Sent: Saturday, August 4, 2018 6:17 AM > To: Gavin Hu > Cc: dev@dpdk.org; Honnappa Nagarahalli > ; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] devtools: trap SIGINT is not recognizable= to > dash > > On Wed, 1 Aug 2018 13:22:57 +0800 > Gavin Hu wrote: > > > When running checkpatch.sh, it generates the following error on some > > linux distributions(like Debian) with Dash as the default shell > > interpreter. > > trap: SIGINT: bad trap > > > > The fix is to replace SIGINT with INT signal, it works for both bash > > and dash. > > > > Fixes: 4bec48184e ("devtools: add checks for ABI symbol addition") > > Cc: stable@dpdk.org > > > > Signed-off-by: Gavin Hu > > Reviewed-by: Honnappa Nagarahalli > > --- > > devtools/checkpatches.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index > > 2509269df..ba795ad1d 100755 > > --- a/devtools/checkpatches.sh > > +++ b/devtools/checkpatches.sh > > @@ -29,7 +29,7 @@ clean_tmp_files() { > > fi > > } > > > > -trap "clean_tmp_files" SIGINT > > +trap "clean_tmp_files" INT > > > > print_usage () { > > cat <<- END_OF_HELP > > This patch alone is not sufficient to make checkpatch run successfully > > ./devtools/checkpatches.sh: 52: read: Illegal option -d > > It looks like the -d flag to read is also a bash extension. > > I recommend changing both checkpatches.sh and check-symbol-changes to > have #!/bin/bash IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.