From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0072.outbound.protection.outlook.com [104.47.1.72]) by dpdk.org (Postfix) with ESMTP id 6F9E94F91 for ; Thu, 17 May 2018 03:47:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AHPIZVmMkf2MI0mDQa2tca/o/AlochdHDYPLuwuO2AU=; b=Zv4waC2OUGN31CF1nQbcbk6Xtp5B8kYu63TsaglXwTAxsDKeFrwrvemTivWSzK+ua7zLU2e41aq2xS2eYbPYuD5HQ9Uqka2I5stUkcSr1AGJw8WCK+YLJKt6FBu7oAbPqqJxwyZC5AYGsoFklgCT+7dh8CVc+DirK9OMEUZtZ7U= Received: from VI1PR08MB3167.eurprd08.prod.outlook.com (52.133.15.142) by VI1PR08MB0863.eurprd08.prod.outlook.com (10.164.93.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Thu, 17 May 2018 01:47:47 +0000 Received: from VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::a105:3320:f324:a919]) by VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::a105:3320:f324:a919%13]) with mapi id 15.20.0776.010; Thu, 17 May 2018 01:47:47 +0000 From: Gavin Hu To: Jerin Jacob CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 3/3] raw/ifpga_rawdev: fix the clang compiling issue Thread-Index: AQHT7NxV9vJTlD6s3ESVghmf95jMK6Qx6UyAgAE9k6A= Date: Thu, 17 May 2018 01:47:47 +0000 Message-ID: References: <1526372924-28411-1-git-send-email-gavin.hu@arm.com> <20180516060802.36181-1-gavin.hu@arm.com> <20180516060802.36181-3-gavin.hu@arm.com> <20180516064542.GA6418@jerin> In-Reply-To: <20180516064542.GA6418@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR08MB0863; 7:13+v1it6hixpIN3DgKnYOrrMYkDzK2BIOer3R5sLisFbF1y+B/uUFbLCJGHA026tL9pVhifChJ7wU3E+AYQAFZQP3v40FalS2MP8CfqgTuLGHMvOIWdPOa82eQASX2S/Kz/XQeiivGvC2EoOpdaPZQArdnXQKeCwL6kDVqUx+4396N0uo0+rM0FSvU6jtmw/VsoCHFdFRjBr4xb8/Vw2c4pFL/PRPJk/bsoQPxkLEvm6T6pQQ8kGzoAO3PuaTQZW x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:VI1PR08MB0863; x-ms-traffictypediagnostic: VI1PR08MB0863: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:VI1PR08MB0863; BCL:0; PCL:0; RULEID:; SRVR:VI1PR08MB0863; x-forefront-prvs: 067553F396 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(376002)(39380400002)(346002)(366004)(189003)(40434004)(199004)(13464003)(72206003)(6246003)(4326008)(8676002)(486006)(53936002)(26005)(68736007)(86362001)(6116002)(3660700001)(3846002)(186003)(3280700002)(106356001)(5660300001)(229853002)(105586002)(476003)(55016002)(6916009)(74316002)(66066001)(9686003)(8936002)(6436002)(81156014)(11346002)(33656002)(305945005)(2900100001)(81166006)(446003)(7736002)(5250100002)(55236004)(5890100001)(478600001)(6506007)(2906002)(76176011)(59450400001)(25786009)(53546011)(102836004)(97736004)(7696005)(93886005)(14454004)(316002)(99286004); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB0863; H:VI1PR08MB3167.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: kck2uvyzIbrYz2SdcmTcBHe0eyO887IoCprn+QFmco+GdlCsfsBSph4mAbyA8jZxxf+56YZNRdQNQXqqRL466Q8jbfKp7viG2avlzGaU9TeZ9uxTwclpx+QbZTlmJw+6f3I2qvhEmkUloXAxUwZwvmdPadbCxgfVSjM+fWKb8LxQ4GSFuMuqYsZxVw6fX1Br spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: e4c390ac-55c9-44a1-a5ec-08d5bb983128 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4c390ac-55c9-44a1-a5ec-08d5bb983128 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2018 01:47:47.5870 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB0863 Subject: Re: [dpdk-dev] [PATCH v3 3/3] raw/ifpga_rawdev: fix the clang compiling issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 01:47:49 -0000 If the subject changes to raw/ifpga, it will get a Wrong headline prefix(ca= n be ignored?) warning when running git-log-fixes.h Wrong headline prefix: raw/ifpga: fix the clang compiling issue -----Original Message----- From: Jerin Jacob Sent: Wednesday, May 16, 2018 2:46 PM To: Gavin Hu Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 3/3] raw/ifpga_rawdev: fix the clang comp= iling issue -----Original Message----- > Date: Wed, 16 May 2018 14:08:02 +0800 > From: Gavin Hu > To: dev@dpdk.org > CC: gavin hu > Subject: [dpdk-dev] [PATCH v3 3/3] raw/ifpga_rawdev: fix the clang > compiling issue > X-Mailer: git-send-email 2.17.0 > > From: gavin hu > > The patch fixes the compile issue with clang on ARM64. Even ARM64 gcc 8.1 could detect this as an error and this patch fixes too. > > Newly introduced #pragma pack(1) in the header file caused comipiling > issues for the files who included it. > > In file included from ~/dpdk/drivers/raw/ifpga_rawdev/base/ > ifpga_fme_dperf.c:5: > In file included from ~/dpdk/drivers/raw/ifpga_rawdev/base/ > ifpga_feature_dev.h:8: > ~/dpdk/drivers/raw/ifpga_rawdev/base/ifpga_hw.h:8:10: error: > the current #pragma > pack alignment value is modified in the included file [-Werror, > -Wpragma-pack] > ~/dpdk/drivers/raw/ifpga_rawdev/base/ifpga_defines.h:100:9: note: > previous '#pragma pack' directive that modifies alignment is here. > > The fix is to change the #pragma pack alignment locally and not have > effect on other files who included this header file. > > Fixes: 56bb54ea1bdf ("raw/ifpga/base: add Intel FPGA OPAE share code") > > Signed-off-by: Gavin Hu > Reviewed-by: Honnappa Nagarahalli Acked-by: Jerin Jacob The subject could change to raw/ifpga: if Maintainer wishes to do so to mai= ntain the consistency. > --- > drivers/raw/ifpga_rawdev/base/ifpga_defines.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/raw/ifpga_rawdev/base/ifpga_defines.h > b/drivers/raw/ifpga_rawdev/base/ifpga_defines.h > index 0b9622d5f..aa0252720 100644 > --- a/drivers/raw/ifpga_rawdev/base/ifpga_defines.h > +++ b/drivers/raw/ifpga_rawdev/base/ifpga_defines.h > @@ -97,7 +97,7 @@ enum port_feature_id { > /* > * All headers and structures must be byte-packed to match the spec. > */ > -#pragma pack(1) > +#pragma pack(push, 1) > > struct feature_header { > union { > @@ -1659,4 +1659,5 @@ struct bts_header { > (((bts_hdr)->guid_h =3D=3D GBS_GUID_H) &&\ > ((bts_hdr)->guid_l =3D=3D GBS_GUID_L)) > > +#pragma pack(pop) > #endif /* _BASE_IFPGA_DEFINES_H_ */ > -- > 2.17.0 > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.