From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70070.outbound.protection.outlook.com [40.107.7.70]) by dpdk.org (Postfix) with ESMTP id 7C3391D4D6; Fri, 15 Jun 2018 10:08:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sbG0F6xZYgPqEKw3lyjOL1GpybEh2gX86TSLgmZDAhg=; b=W0PKs+Zy81m8P0g+tFx9hPQq95MC21s+PSfHz1Qkhgb0Z5F8GDlaUXmu13PlhUlJBRmD5suWWxalaWGS6c5n2A/lk0ihc2SV1Hzju3UK2qH9J6Iso+QofFlHjybNs06B6GbK567uasvzEdzl0ltCssxZgwyBzbURbh4sNyrUuJ0= Received: from VI1PR08MB3167.eurprd08.prod.outlook.com (52.133.15.142) by VI1PR08MB2765.eurprd08.prod.outlook.com (10.170.236.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.17; Fri, 15 Jun 2018 08:08:42 +0000 Received: from VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::bccc:7b61:9039:89a0]) by VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::bccc:7b61:9039:89a0%4]) with mapi id 15.20.0863.016; Fri, 15 Jun 2018 08:08:42 +0000 From: Gavin Hu To: Bruce Richardson CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v6 5/7] devtools: fix the missing ninja command error on CentOS Thread-Index: AQHUA8wjmlEHUSFOq0mBChpvNb2Ss6Rg+DuA Date: Fri, 15 Jun 2018 08:08:42 +0000 Message-ID: References: <1527590616-28299-1-git-send-email-gavin.hu@arm.com> <20180614095127.16245-1-gavin.hu@arm.com> <20180614095127.16245-6-gavin.hu@arm.com> <20180614104030.GC17264@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20180614104030.GC17264@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR08MB2765; 7:d4xQTa/j1iI+Tv7tTRz03u/GlIsKatb9M11PfG8bP1HUmeL+M4zd0jUO4uO+wVgkEL+l3ZDMHZ9skofrHv8PT/3aQAOhosXrll56etuHE9Z8v8RGPaFEMrIcIhblVcGDY3Hu+JyRNCi2RCT6Kje8GE54A1DkYwGLf3QiRpt2XyXgP1eewbgdtfvw2TL7YSYFHTYw2DsqQdaONPTCsmeepphssXk1lhqzr83JHf6sbmHZPrp+UkDtL2QKbuR3Yrmd x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 77e87d4f-0474-4bbb-4f3f-08d5d29735f0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:VI1PR08MB2765; x-ms-traffictypediagnostic: VI1PR08MB2765: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:VI1PR08MB2765; BCL:0; PCL:0; RULEID:; SRVR:VI1PR08MB2765; x-forefront-prvs: 0704670F76 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39380400002)(366004)(376002)(39860400002)(396003)(189003)(199004)(40434004)(13464003)(6246003)(2906002)(54906003)(316002)(5660300001)(478600001)(99286004)(229853002)(3660700001)(93886005)(3280700002)(6436002)(25786009)(6116002)(3846002)(68736007)(72206003)(14454004)(105586002)(53936002)(106356001)(4326008)(2900100001)(66066001)(86362001)(59450400001)(102836004)(76176011)(81156014)(5250100002)(7736002)(74316002)(55016002)(305945005)(7696005)(26005)(8936002)(53546011)(446003)(476003)(81166006)(186003)(6506007)(11346002)(55236004)(97736004)(9686003)(5890100001)(486006)(8676002)(6916009)(33656002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB2765; H:VI1PR08MB3167.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: cFfWwoBVp+RMrZ0MTNMVxPfnoy9yIreywHdYVeUmvoF6Ub1m0daG9u7pabdRNh+ypGiZS3ETVcqNoUmqn5GJ7WAeR4BGXptTHL7d1cd5Bhr1WXhI1D2zKL9hC07niFiK3jzPNIgRFPp+VN9S69mW73rYsFOLb1J5o/ZzmZ0nY9eKhkNdpxuyh2lpf8UvPXHK spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77e87d4f-0474-4bbb-4f3f-08d5d29735f0 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2018 08:08:42.7988 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2765 Subject: Re: [dpdk-dev] [PATCH v6 5/7] devtools: fix the missing ninja command error on CentOS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2018 08:08:44 -0000 > -----Original Message----- > From: Bruce Richardson > Sent: Thursday, June 14, 2018 6:41 PM > To: Gavin Hu > Cc: dev@dpdk.org; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 5/7] devtools: fix the missing ninja > command error on CentOS > > On Thu, Jun 14, 2018 at 05:51:25PM +0800, Gavin Hu wrote: > > On CentOS, the ninja executable has a different name: > > ninja-build, this patch is to fix the missing command error on CentOS > > as follows: > > ./devtools/test-meson-builds.sh: line 24: ninja: command not found > > > > Fixes: a55277a788 ("devtools: add test script for meson builds") > > Cc: stable@dpdk.org > > > > Signed-off-by: Gavin Hu > > Reviewed-by: Phil Yang > > Reviewed-by: Song Zhu > > --- > > devtools/test-meson-builds.sh | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/devtools/test-meson-builds.sh > > b/devtools/test-meson-builds.sh index 6bce3df7f..4afac76dd 100755 > > --- a/devtools/test-meson-builds.sh > > +++ b/devtools/test-meson-builds.sh > > @@ -21,7 +21,11 @@ build () # > > $MESON $options $srcdir $builddir > > fi > > echo "ninja -C $builddir" > > -ninja -C $builddir > > +if [ "$(lsb_release -d | grep -c 'CentOS')" !=3D "0" ] ; then > > +ninja-build -C $builddir > > +else > > +ninja -C $builddir > > +fi > > } > > Rather than tying this to CentOS explicitly, would it be better at the st= art of > the script to test e.g "which ninja" and "which ninja-build" and use that= to > work out the command to use. It's possible to have ninja installed direct= ly > from tarball on CentOS as "ninja" (as I have in my test VM), and the bina= ry > might be called ninja-build on other systems too e.g. > RHEL, perhaps. > > /Bruce [Gavin Hu] I submitted new v8 patch for this, please help review it. IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.