From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0048.outbound.protection.outlook.com [104.47.1.48]) by dpdk.org (Postfix) with ESMTP id 274262BA8 for ; Mon, 17 Sep 2018 10:25:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pb+gD7JPeHcJrHVEsY9ykTN9BNswSo5aFhHnE9Q5AAw=; b=i8q+Y2wvhckVLBhQVJJVM0wc0OUIR3p/mpepyq50MSHINKi1HvnqRZY7S9r6NTN21Xk2legNoJ8zXjq3veEQ6N2XhfSjF9kDPX/JdDoTSj0hA6tc8yleR414PDY1/eg9czH1dz4a6h2BtFG2XPdjYGceyaj7v6WtD9cJe+o9xok= Received: from VI1PR08MB3167.eurprd08.prod.outlook.com (52.133.15.142) by VI1PR08MB3101.eurprd08.prod.outlook.com (52.133.15.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.18; Mon, 17 Sep 2018 08:25:11 +0000 Received: from VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::b91d:e285:4647:f3e8]) by VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::b91d:e285:4647:f3e8%2]) with mapi id 15.20.1143.017; Mon, 17 Sep 2018 08:25:11 +0000 From: "Gavin Hu (Arm Technology China)" To: "Gavin Hu (Arm Technology China)" , "dev@dpdk.org" CC: Honnappa Nagarahalli , Steve Capper , Ola Liljedahl , "jerin.jacob@caviumnetworks.com" , nd , Ferruh Yigit Thread-Topic: [PATCH v3 2/3] net/i40e: remove invalid comment Thread-Index: AQHUTlq8rizsCnORwEOS4uuoFkBwU6T0IgSQ Date: Mon, 17 Sep 2018 08:25:11 +0000 Message-ID: References: <20180807031943.5331-1-gavin.hu@arm.com> <20180917074735.28161-1-gavin.hu@arm.com> <20180917074735.28161-2-gavin.hu@arm.com> In-Reply-To: <20180917074735.28161-2-gavin.hu@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR08MB3101; 6:FZS6oxsusDu043kd9BmwrXBxnz6xrFya1cR7TCuxEO8NB4FdNhwuw8E1N/7QeGJTGPoO8Z4qASJ9Y3UEqJXljPt+TNoZDNbwfZDdnQAOgR4bF/PIODBQz7WiyG45IrEwke7fBoHiMlCmTdJJSQjFGh6+CEOMGjvYmTq160HUTJlokWLVgUUGFe9ikZOxMTXrncHNqqq9R+1k3Rn5yB95mcYisnzlPaHUVpwj15jbk7eRMlBul+8jLDRJr1dpsCEwP/qOajQSDMNZ41Omiuk5pvg6ulTvZx6XVwyV9Sgnp6yS29KkK+xl0/AqFBwxklATF1xNl7feGNnYUhm2AI5jCPNYLikoW4zzoOsVqS3tSplcMRBcW+tgT8Hdh6B4fY2SOcd27LH/Cw8nDbd2O6pJZxcJGJ7GO2Evqj5q2EeFW0Ik8bbxuEgk9TkNQ+vmJJLo6705WX4SzKd3dAcpYYnXeQ==; 5:WnElnIQhma8ZAzI2OYqI5UvX6hmrg+Z5tl+ShwGVHQ1sZ6DCO0alTTNj3/njxVku898Wb12+5HW1mYRTNFMYZx9mkqwHKqmxiAau8ZorXuBqFgymSpqANQkOek8P57HTibaO+9/NIJwotHCR/EuXPHCah2NrNctNgnv9p/BQ83I=; 7:gh3Wkpr3o61TnIZS5QuEP5csjz3ofQoFOHNsuU4iSEBwC34i9K5FBRqqe0Pw9HzMEaYKOGwybRIWS7OBX+S8XDucfCVZrzWMCaTpsC9pz55QO3lkxIBSgTLzQATlF81nJVmxWsoe/vGMlyIxdMTHPn0ZZYcxxOB8MFP74rcrW/zqV3ijcTkdvTjBYQiV9h1DUhD4PbYrHr4AulBrw9nchq1Kx2Kyblsw65/q1YEpKuq4r7oYvonjMfRy3SBk1l/z x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-correlation-id: df28f4ae-405a-44cb-9239-08d61c7715fa x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR08MB3101; x-ms-traffictypediagnostic: VI1PR08MB3101: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231355)(944501410)(52105095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699050); SRVR:VI1PR08MB3101; BCL:0; PCL:0; RULEID:; SRVR:VI1PR08MB3101; x-forefront-prvs: 0798146F16 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(376002)(346002)(39850400004)(396003)(366004)(13464003)(189003)(199004)(53754006)(53546011)(7696005)(6116002)(55016002)(9686003)(6436002)(33656002)(53936002)(316002)(229853002)(7736002)(6506007)(105586002)(76176011)(3846002)(106356001)(81166006)(81156014)(8676002)(72206003)(478600001)(8936002)(14454004)(6246003)(99286004)(74316002)(68736007)(110136005)(54906003)(5660300001)(2900100001)(4326008)(2501003)(5250100002)(26005)(256004)(25786009)(102836004)(486006)(2906002)(97736004)(476003)(11346002)(305945005)(446003)(86362001)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB3101; H:VI1PR08MB3167.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: xiyz2quvLb5MporDC/z9izFGlP7i4darfc1u2XKXLKKY+ewgCjLMV/1B3v/am6RuAJFT3bN99BWTtBO+I69uTJPCmyc59HTKqrWy09qfTqR2XSuCgytfk9EbemGNtqigIQ8JkBqeyaRgUnSeUQMSQUriocB7hqeJqJSh9FnirdZbN4HQdEQN22w7IJdUNniv8IO1EXvUs+rPzjepdGmkljqEL2FxsF6avZ8T4Rc4UHBT2G0mAwDcyM8JUPWy26/ftmYWfH1p8lPBall6geL4iqKE13pZR/HpMsYwPd9u51ks0sLF0D2DKwEktdOn3zzIOsWP3Z3PFX8QvmeGDQ1wcxXI8R6ZQPt+MksPc7z7uvk= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: df28f4ae-405a-44cb-9239-08d61c7715fa X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Sep 2018 08:25:11.3561 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3101 Subject: Re: [dpdk-dev] [PATCH v3 2/3] net/i40e: remove invalid comment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 08:25:13 -0000 Hi All, I am really sorry I made a mistake by submitting patches from a wrong branc= h and tried to rescue quickly and made another mistake(submitted one more p= atch not mine). Please skip these wrong patches(I already superseded them) and help review = the new 3 patches for rte ring. Really sorry again for the confusion and inconveniences! Best Regards, Gavin > -----Original Message----- > From: Gavin Hu > Sent: Monday, September 17, 2018 3:48 PM > To: dev@dpdk.org > Cc: Gavin Hu (Arm Technology China) ; Honnappa > Nagarahalli ; Steve Capper > ; Ola Liljedahl ; > jerin.jacob@caviumnetworks.com; nd ; Ferruh Yigit > > Subject: [PATCH v3 2/3] net/i40e: remove invalid comment >=20 > From: Ferruh Yigit >=20 > Comments says "no csum error report support" but there is no check relate= d > csum offloads. Removing the comment. >=20 > Signed-off-by: Ferruh Yigit > Acked-by: Qi Zhang > --- > drivers/net/i40e/i40e_rxtx_vec_common.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h > b/drivers/net/i40e/i40e_rxtx_vec_common.h > index 63cb17742..f00f6d648 100644 > --- a/drivers/net/i40e/i40e_rxtx_vec_common.h > +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h > @@ -199,9 +199,7 @@ > i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev) > if (fconf->mode !=3D RTE_FDIR_MODE_NONE) > return -1; >=20 > - /* - no csum error report support > - * - no header split support > - */ > + /* no header split support */ > if (rxmode->offloads & DEV_RX_OFFLOAD_HEADER_SPLIT) > return -1; >=20 > -- > 2.11.0