From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20060.outbound.protection.outlook.com [40.107.2.60]) by dpdk.org (Postfix) with ESMTP id 0FA1C1B8AF for ; Tue, 15 May 2018 12:10:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=cvuwhJCFM5pTFVedzC/JS1UqHOG+voQJk7EYb+9lfaY=; b=jGyb/+QfIjf+cIZAg5Hjyb7QjsTLjRRVeGA8qJ012PwvhhvLrlJB2KJp1iLPQkpL2mV6fjn8ZZG10b/kBO+qpC/7M6zPlp/dh3pxChZCLo3MEGBLQ1xl0xrOHFpvIo3gUqOiZxaK+eQUt5hn72UcVD8m2ZDzGgKcPRJ3C+D0GZQ= Received: from VI1PR08MB3167.eurprd08.prod.outlook.com (52.133.15.142) by VI1PR08MB2846.eurprd08.prod.outlook.com (10.170.236.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Tue, 15 May 2018 10:10:20 +0000 Received: from VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::f1f6:96fa:ad53:1b59]) by VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::f1f6:96fa:ad53:1b59%13]) with mapi id 15.20.0755.018; Tue, 15 May 2018 10:10:20 +0000 From: Gavin Hu To: Bruce Richardson CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/4] app: add LDFLAGS -latomic to link atomic lib Thread-Index: AQHT7CsuZ7FlkvQLH0exyGdGfLiLsaQwkBRA Date: Tue, 15 May 2018 10:10:20 +0000 Message-ID: References: <1526372924-28411-1-git-send-email-gavin.hu@arm.com> <1526372924-28411-2-git-send-email-gavin.hu@arm.com> <20180515090023.GA6272@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20180515090023.GA6272@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR08MB2846; 7:vf5ayFr29R/uMNrPDFq6AxKoy/ZYMwGb9uV+FiKBNv08xbQaXYS7wEcTvUhgbMA0kQVV2UGk5EUtYSfIqOM6BcJd2Dmwe1jGrWjqLkMHH8hY/kpH5espffSKagddTbTV9qG12QnrlFDnEvohBOKT8806MOJKclFNUM0ks6MXnxGkGTDqnM9zihcwcoA/RsWByRCXrbMpHzHOw3jaQYqCWGu2fawD/vpZ3DWQ/Hn7UKYlNwkJBJhD3TvumWsdyINc x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603328)(7153060)(7193020); SRVR:VI1PR08MB2846; x-ms-traffictypediagnostic: VI1PR08MB2846: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(262104967686372)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123562045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:VI1PR08MB2846; BCL:0; PCL:0; RULEID:; SRVR:VI1PR08MB2846; x-forefront-prvs: 0673F5BE31 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39380400002)(396003)(376002)(366004)(39860400002)(40434004)(13464003)(189003)(199004)(55236004)(229853002)(14454004)(25786009)(105586002)(86362001)(3846002)(6116002)(68736007)(3280700002)(6506007)(316002)(26005)(53546011)(66066001)(33656002)(3660700001)(102836004)(7696005)(97736004)(4326008)(106356001)(6246003)(53936002)(2906002)(9686003)(59450400001)(72206003)(6306002)(99286004)(76176011)(55016002)(966005)(8936002)(305945005)(486006)(6916009)(7736002)(8676002)(81166006)(81156014)(5250100002)(2900100001)(5660300001)(74316002)(5890100001)(6436002)(11346002)(186003)(478600001)(476003)(446003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB2846; H:VI1PR08MB3167.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: OvU8mxAkcm2Y4+9mWub9Duam7wf/3hE810NSYQ8cZvLtxbzcwMdjtDf442qVBaguCDkIilYkU9iHTppZKed4cIFtahuStmGMdEgSz9CmhiZbjeORP+m8g6x4RTl3dZRDVoXZVLD7bjH4dQbuQ5fGdzPRy/+7NaSVmm9KgyXRwyrPWrk3DYhwHdcqV8ymrnGf spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 4b58d8db-21ca-490e-a102-08d5ba4c1101 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b58d8db-21ca-490e-a102-08d5ba4c1101 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2018 10:10:20.7455 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2846 Subject: Re: [dpdk-dev] [PATCH 1/4] app: add LDFLAGS -latomic to link atomic lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 10:10:22 -0000 Hi Bruce, CC=3Dclang Meson build did not hit this issue. The GNU Makefile using clang hit this issue: make config T=3Darm64-armv8a-linuxapp-clang Best Regards, Gavin -----Original Message----- From: Bruce Richardson Sent: Tuesday, May 15, 2018 5:00 PM To: Gavin Hu Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/4] app: add LDFLAGS -latomic to link atomi= c lib On Tue, May 15, 2018 at 04:28:41AM -0400, Gavin Hu wrote: > For ARM64 platform, libdpdk.a includes the > librte_pmd_octeontx_ssovf.a, which requires the libatomic.a > support.The atomic lib is built-in in the gcc toolchain, but for clang it= has to be explicitly linked. > For more details, please refer to > https://clang.llvm.org/docs/Toolchain.html > > ~/dpdk/build/lib/librte_pmd_octeontx_ssovf.a(timvf_worker.o): In function= `timvf_timer_cancel_burst': > timvf_worker.c:(.text+0x80): undefined reference to `__atomic_fetch_add_8= ' > /home/gavin/arm_repo/dpdk/build/lib/librte_pmd_octeontx_ssovf.a(timvf_wor= ker.o): In function `timvf_timer_arm_burst_sp': > timvf_worker.c:(.text+0x200): undefined reference to `__atomic_fetch_add_= 8' > timvf_worker.c:(.text+0x244): undefined reference to `__atomic_store_2' > timvf_worker.c:(.text+0x278): undefined reference to `__atomic_fetch_add_= 4' > timvf_worker.c:(.text+0x30c): undefined reference to `__atomic_store_2' > > Signed-off-by: Gavin Hu > Reviewed-by: Honnappa Nagarahalli > --- Is an equivalent change also needed for the meson build too? /Bruce IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.