From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55FABA2EFC for ; Tue, 17 Sep 2019 04:08:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 793B21BFC2; Tue, 17 Sep 2019 04:08:07 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20085.outbound.protection.outlook.com [40.107.2.85]) by dpdk.org (Postfix) with ESMTP id 176101BFBF for ; Tue, 17 Sep 2019 04:08:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GRxmIZewMbDph6VKQfF4AxgLnLTuXJ9zXg6KpHUq/qQ=; b=XdBhxSSNnn4KjnmspzeKScQ+rM4eQ/L3Pf82j8SSSu+mBmoHKPA5RV36JdSbbbsug7GeE4f1y29AJn7Zc88Oyo69F6lyeWTFn3D0FXbu9Uiot53+T0UKh0k0l7crjfa8h8Y1lZCIr4uiu7Nb8MJ7ywhbdpf5LmE3ejJsFbDlqC0= Received: from DB6PR0801CA0043.eurprd08.prod.outlook.com (2603:10a6:4:2b::11) by AM0PR08MB3361.eurprd08.prod.outlook.com (2603:10a6:208:db::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.17; Tue, 17 Sep 2019 02:08:03 +0000 Received: from VE1EUR03FT020.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::204) by DB6PR0801CA0043.outlook.office365.com (2603:10a6:4:2b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.18 via Frontend Transport; Tue, 17 Sep 2019 02:08:02 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=none action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT020.mail.protection.outlook.com (10.152.18.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.14 via Frontend Transport; Tue, 17 Sep 2019 02:08:01 +0000 Received: ("Tessian outbound 0d576b67b9f5:v31"); Tue, 17 Sep 2019 02:07:58 +0000 X-CR-MTA-TID: 64aa7808 Received: from 838859483a0c.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.14.57]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 72D62F21-48EF-448C-95EB-4E8F691A0FB0.1; Tue, 17 Sep 2019 02:07:52 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2057.outbound.protection.outlook.com [104.47.14.57]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 838859483a0c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 17 Sep 2019 02:07:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IM2V+hroB0B2q4clgtASeU8K568vgxzEgXqcklbXmuCnwjyMtPyFnszeB8mT6rfQQHQrd/QpSwU05W6z6hUcXkNp7p1o/ZWlrGHZN2TaB2uObYzaW/mC45bsPiFkw/lg+oVTn4DPb17CYDCbgieqntS6wzmNfUTH7pG79q/Ndbd7OgfjbrH9Nz4xIKO9VjgL9gyB4LeWE6oXmlHBIMowPgZ7cd8O3JUQ9GkCqywHFJl/NcDWfh5eqKgAK+Dis32V1oYFS6WOCdtMcAFyHRQD8T5fh7NdAoROLQNm5A5pnQFZ3M52aiB6x8n3bs4ny2rG7Y5W81laBzQhXoRekp68Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GRxmIZewMbDph6VKQfF4AxgLnLTuXJ9zXg6KpHUq/qQ=; b=nAaU8uKrRPXLQUF8dgVVS3m5pvQkTwM+HiQjMwr+sweB70QeJo+wYEiXVKTnGkdyZY3HphT5AKYB4ATTvG270ViA2AOX9wDtn1ZV/wZ6UjSTZgjdSJKxQxyHD3dvACc1mc1Nz+cOMZB/RuPhMtOY72kE+T82Wbtitpe4JnHoHDfmjpa27GyczejjbPDzcR/KeXE+BIz7QOVfhIEQUHF5ZxkiJD8381Ve51dploLbg4pvg1ghMTh3extH515rPtp9tl5vV83jh1/sLG1qPI8l9SLFs8SGquTrg+034uXSWDOcKd54RxH7s5TOVIMbb9DA7BEKIfka3XdcGSWXju9yGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GRxmIZewMbDph6VKQfF4AxgLnLTuXJ9zXg6KpHUq/qQ=; b=XdBhxSSNnn4KjnmspzeKScQ+rM4eQ/L3Pf82j8SSSu+mBmoHKPA5RV36JdSbbbsug7GeE4f1y29AJn7Zc88Oyo69F6lyeWTFn3D0FXbu9Uiot53+T0UKh0k0l7crjfa8h8Y1lZCIr4uiu7Nb8MJ7ywhbdpf5LmE3ejJsFbDlqC0= Received: from VI1PR08MB5376.eurprd08.prod.outlook.com (52.133.244.200) by VI1PR08MB4414.eurprd08.prod.outlook.com (20.179.26.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.26; Tue, 17 Sep 2019 02:07:50 +0000 Received: from VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::c09a:49d3:eab2:f707]) by VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::c09a:49d3:eab2:f707%3]) with mapi id 15.20.2263.023; Tue, 17 Sep 2019 02:07:50 +0000 From: "Gavin Hu (Arm Technology China)" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: nd , "thomas@monjalon.net" , "Richardson, Bruce" , "Liu, Yong" , "Wang, Yinan" , "ajit.khaparde@broadcom.com" , "somnath.kotur@broadcom.com" , Honnappa Nagarahalli , "Ruifeng Wang (Arm Technology China)" , Steve Capper Thread-Topic: [dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and remove duplicate barrier Thread-Index: AQHVbIHDAYCwRhXlDEWQcEpHH8UhQ6cvHFIAgAAD1cA= Date: Tue, 17 Sep 2019 02:07:50 +0000 Message-ID: References: <1567751873-15964-1-git-send-email-gavin.hu@arm.com> <1568633238-47888-2-git-send-email-gavin.hu@arm.com> <039ED4275CED7440929022BC67E7061153D97A8A@SHSMSX105.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061153D97A8A@SHSMSX105.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 4567b776-69ad-4f57-b065-6c58e698af2c.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 52251de1-69af-483e-e646-08d73b13de50 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(711020)(4605104)(1401327)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:VI1PR08MB4414; X-MS-TrafficTypeDiagnostic: VI1PR08MB4414:|VI1PR08MB4414:|AM0PR08MB3361: X-MS-Exchange-PUrlCount: 1 x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:2043;OLM:2043; x-forefront-prvs: 01630974C0 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(136003)(376002)(366004)(396003)(346002)(199004)(189003)(13464003)(66446008)(64756008)(55236004)(66476007)(102836004)(25786009)(9686003)(6436002)(2906002)(6246003)(6506007)(53546011)(3846002)(76176011)(229853002)(6306002)(55016002)(6116002)(446003)(476003)(11346002)(186003)(256004)(486006)(4326008)(26005)(66556008)(2501003)(316002)(52536014)(71190400001)(66066001)(305945005)(71200400001)(99286004)(74316002)(54906003)(5660300002)(110136005)(7736002)(33656002)(86362001)(14454004)(966005)(76116006)(81166006)(81156014)(7696005)(66946007)(8936002)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB4414; H:VI1PR08MB5376.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: 7F5h5iwQymCpgsdTQsuz4f1E5q5NCf9QqbldzKtjxKtk31aNZzeOxs87qQ3vWZDX37aeEoNqgyrxWBnp8YeXbzdxUeCgyMM+oVqj2BX7fK704pSgXKUOgS13igtN03A6W8OZ1mFGnEqly390OkHYQ70fFUP0J4oYVKUVszezPQn28KP+PVWdebv5FBsjmbE9RknR6zGqUXgJILHooK8Y0Ljutg61rjW6TneDiG1h6dqJOw3nN7foCk6x85BbandkX+AUDS7QUaUq6YueYXrDXCWIrPNSi0t1miJpJDtY59y9KknMCHYmBzjR8sf8XDUynBi2gHt3vm/qB1Mt9hCIWT3dwDkF9hUNf+4/dzXtnj7pmhlfGteSGFGeWhDzrZ7spe3jivyZLy7dmNq92mEjp+kSELAqb8ilCvlnq0GjkwI= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4414 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT020.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(376002)(39860400002)(396003)(346002)(136003)(13464003)(189003)(199004)(81166006)(86362001)(2906002)(7736002)(7696005)(305945005)(3846002)(6116002)(23726003)(54906003)(36906005)(446003)(22756006)(63350400001)(316002)(110136005)(46406003)(5660300002)(4326008)(33656002)(97756001)(126002)(53546011)(76176011)(6506007)(476003)(486006)(102836004)(6246003)(74316002)(11346002)(8936002)(25786009)(70206006)(70586007)(229853002)(76130400001)(14454004)(336012)(52536014)(9686003)(478600001)(356004)(26826003)(50466002)(2501003)(26005)(6306002)(186003)(47776003)(66066001)(8746002)(966005)(99286004)(55016002)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB3361; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; MX:1; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: d36ecaf2-2850-456e-e3a1-08d73b13d7bf X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(710020)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:AM0PR08MB3361; NoDisclaimer: True X-Forefront-PRVS: 01630974C0 X-Microsoft-Antispam-Message-Info: mRzoRQOTtXV07GxG3xtT7gwFTzP0Bn8PhX325BR9wY4NcxkEllP9teqg5x54mErtHps2vZ3+FlCUaH30z+UwkeAtVO9VpLoHG2qEABHaAxOyXmdA8fNFVLp9RQAc2Stx/7kKS+S6jd8PGgpkuHQULKGx+WhwBTGBW03yQ0Wvo8rlwCyH5kXY2yAEYnoAhvBGbHxMHMIU7RHXnPpHKVat4DyBs3Y3H3XtyVjOMEyCdjPwkJiEC3488KxD1kGByKxcKspIQdPPjt1YdHpMbL0KErZpauMu0c/hl496OWzLIdNMqQmpeWeSkqHbrQrtox/aoO07YXDweN38cA1TDObVo9XEkMdxcuuMXnIktwfSFx0pF6SgZJdoN2Dq9CSTOLu5K37qbhMfQl51uztWTzS+FE07MGvobZ9bj02KDUttr6Y= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2019 02:08:01.5484 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 52251de1-69af-483e-e646-08d73b13de50 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3361 Subject: Re: [dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and remove duplicate barrier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Qi, > -----Original Message----- > From: Zhang, Qi Z > Sent: Tuesday, September 17, 2019 9:53 AM > To: Gavin Hu (Arm Technology China) ; dev@dpdk.org > Cc: nd ; thomas@monjalon.net; Richardson, Bruce > ; Liu, Yong ; Wang, Yinan > ; ajit.khaparde@broadcom.com; > somnath.kotur@broadcom.com; Honnappa Nagarahalli > ; Ruifeng Wang (Arm Technology China) > ; Steve Capper > Subject: RE: [dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and remove > duplicate barrier >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gavin Hu > > Sent: Monday, September 16, 2019 7:27 PM > > To: dev@dpdk.org > > Cc: nd@arm.com; thomas@monjalon.net; Richardson, Bruce > > ; Liu, Yong ; Wang, > Yinan > > ; ajit.khaparde@broadcom.com; > > somnath.kotur@broadcom.com; Honnappa.Nagarahalli@arm.com; > > ruifeng.wang@arm.com; steve.capper@arm.com > > Subject: [dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and remove > > duplicate barrier > > > > To guarantee the orderings of successive stores to CIO and MMIO memory, > a > > lighter weight rte_io_wmb [1] can be used instead of rte_wmb, and since > the > > I40E_PCI_REG_WRITE API already has an inclusive rte_io_wmb, this explic= it > call > > can be even saved. > > > > [1] http://git.dpdk.org/dpdk/tree/lib/librte_eal/common/include/generic= / > > rte_atomic.h#n98 > > > > Signed-off-by: Gavin Hu >=20 > Can you also capture the one at the tail of i40e_xmit_pkts? Thanks for your review, I will fix this in next version. >=20 > Otherwise > Acked-by: Qi Zhang >=20