From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40F43A2EFC for ; Tue, 15 Oct 2019 13:20:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AF1C41EADA; Tue, 15 Oct 2019 13:20:08 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130082.outbound.protection.outlook.com [40.107.13.82]) by dpdk.org (Postfix) with ESMTP id 4EF131EA5D for ; Tue, 15 Oct 2019 13:20:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z/JDDqWp6HCzDfKKng2YfgmSMj5T1vFe9cMxkfYW/oc=; b=sT9KYYIVd1r8tM93NaZXxbmeBmjhITnrCF8UHZNG3e96EaB2yVoMJnMg81fnLq5evyRoIsksjK031SuHYoJK4lohO20Z6/4bgUQskl1Rt71eLsluU23vBRfMrbSXUKtosTFnLzdKJlOWaa3Qnwbl1jbF5frfS8rCHwu8Mgimf7A= Received: from VI1PR08CA0156.eurprd08.prod.outlook.com (2603:10a6:800:d5::34) by AM6PR08MB5064.eurprd08.prod.outlook.com (2603:10a6:20b:e6::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.19; Tue, 15 Oct 2019 11:20:03 +0000 Received: from AM5EUR03FT006.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::208) by VI1PR08CA0156.outlook.office365.com (2603:10a6:800:d5::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2347.18 via Frontend Transport; Tue, 15 Oct 2019 11:20:03 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=none action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT006.mail.protection.outlook.com (10.152.16.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2305.15 via Frontend Transport; Tue, 15 Oct 2019 11:20:01 +0000 Received: ("Tessian outbound 081de437afc7:v33"); Tue, 15 Oct 2019 11:20:01 +0000 X-CR-MTA-TID: 64aa7808 Received: from cd40831e9536.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.4.51]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id CCB4540F-F006-4125-9CFA-F946FBC78DE2.1; Tue, 15 Oct 2019 11:19:56 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2051.outbound.protection.outlook.com [104.47.4.51]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cd40831e9536.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 15 Oct 2019 11:19:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JNos8Tc6wNphf9raak05jO+abP3dXt5k/sJtY+SsvIDjfzDORWtbd8T1T9xc6AW6veXOanzMdTlXQ19J0VJuQrHs6usPUpNPqOtCJo8NohiWHt5ntTXRaIiPyj4cHwdxGAxKpy4WaTuZhj2fIMj1aOP5KQGP9vodJJp7z/WBFPnCXxwwNytK/7jWcpjGBB5tumowLdaarjfuBDLvUhWrrCGFW6lpi11tFZe8NVo+hvCYTyp5LEVxmzbfjpUPrfQw/cEqAFLvhYs6p2iPkWDkfo1lvfaCOP5ymD0IlGv1gZRUodhl5OU5bhzb/LA6+S4ZHRvIhrVlbAdapDEE8qIzyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z/JDDqWp6HCzDfKKng2YfgmSMj5T1vFe9cMxkfYW/oc=; b=faPrXoeUeAHG1YAi9Tc/KD/GImC+h6AGgkRRC70bckB82jDx1p35bBL3jBj2PxqULw1dcEwV0y1J7nCxg+vVKvxDZ4d88fuQxeoRsMcvzlGj6fthfoAZqUJCBM4E8xv7OXJyOaukxQuAjtTsvjagCbtYq+dEn3CURnxGonUmVVYLt9XIQv/vyXs659JkMjwR9YU3EVxYk3FbUqtjkVwRFTsot7Z9UHc5tuPk+Cz2HZuYFlUQkIayGCHXcAL4SWlw2WW1rFoBxGwMrPEH/HhhkDGFNIfXMgjlB+PEMnOOV9aeFaN0pxv09W9N1d0fdKC3bfJwAMrDLWAbio3e0zmkKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z/JDDqWp6HCzDfKKng2YfgmSMj5T1vFe9cMxkfYW/oc=; b=sT9KYYIVd1r8tM93NaZXxbmeBmjhITnrCF8UHZNG3e96EaB2yVoMJnMg81fnLq5evyRoIsksjK031SuHYoJK4lohO20Z6/4bgUQskl1Rt71eLsluU23vBRfMrbSXUKtosTFnLzdKJlOWaa3Qnwbl1jbF5frfS8rCHwu8Mgimf7A= Received: from VI1PR08MB5376.eurprd08.prod.outlook.com (52.133.244.200) by VI1PR08MB4318.eurprd08.prod.outlook.com (20.179.26.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.19; Tue, 15 Oct 2019 11:19:52 +0000 Received: from VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::f8ea:be13:4728:f5fc]) by VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::f8ea:be13:4728:f5fc%4]) with mapi id 15.20.2347.023; Tue, 15 Oct 2019 11:19:52 +0000 From: "Gavin Hu (Arm Technology China)" To: Anoob Joseph , "Akhil.goyal@nxp.com" , Pablo de Lara CC: Fiona Trahe , "jerinj@marvell.com" , Narayana Prasad , Shally Verma , Ankur Dwivedi , Kanaka Durga Kotamarthy , Sunila Sahu , Tejasree Kondoj , "dev@dpdk.org" , Honnappa Nagarahalli , nd , nd Thread-Topic: [dpdk-dev] [PATCH v2 07/12] crypto/octeontx2: add enqueue/dequeue ops Thread-Index: AQHVgcOWv2J5fYdzPkGjWR7YEsc1W6dbjMjA Date: Tue, 15 Oct 2019 11:19:52 +0000 Message-ID: References: <1567146501-8224-1-git-send-email-anoobj@marvell.com> <1570970402-20278-1-git-send-email-anoobj@marvell.com> <1570970402-20278-8-git-send-email-anoobj@marvell.com> In-Reply-To: <1570970402-20278-8-git-send-email-anoobj@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 6a53943c-458f-48dc-921b-5dc760126b64.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: ec87c07c-c83e-4c7f-7bfc-08d751619ec8 X-MS-Office365-Filtering-HT: Tenant X-MS-TrafficTypeDiagnostic: VI1PR08MB4318:|VI1PR08MB4318:|AM6PR08MB5064: X-MS-Exchange-PUrlCount: 1 x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; x-forefront-prvs: 01917B1794 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(376002)(39860400002)(346002)(396003)(136003)(366004)(189003)(199004)(13464003)(66066001)(11346002)(4326008)(71190400001)(256004)(26005)(476003)(186003)(71200400001)(446003)(86362001)(316002)(66946007)(66476007)(66556008)(64756008)(66446008)(53546011)(102836004)(6506007)(14444005)(55236004)(2501003)(55016002)(9686003)(6306002)(76116006)(7696005)(6116002)(3846002)(76176011)(229853002)(966005)(25786009)(5660300002)(52536014)(305945005)(2906002)(81156014)(7736002)(7416002)(14454004)(74316002)(110136005)(6246003)(99286004)(54906003)(486006)(33656002)(478600001)(6436002)(8936002)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB4318; H:VI1PR08MB5376.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cQDYKrmyp2zf0eBxHQ6TU4WQ/K/MnOrivDM8pNPXYrsduntoo57Wie7g+2QL/Uz5aSxWZLzG9MYF+xBFLN/QYDp/b+mEK5fFttg6p01QukqfYJL0gn4+UVsN5I4pThcp/QqT246V0y/8INuKwRqcrMcwYDAUBe3ItqOBmKBEzkvlji9Pe4x2KQMoxYpASQ/V650EKWRD3OH1bcSOTDNWpSRpEcx8AUDrsjNGITBbRo3fvq/obJ05FCwi42oTDblmNdl1joLKjHQ5PcNhXw3DlpFLAYZE5TyXsQ0SUe3rrU5KaPpKdi69Y5PxrD/cprIrB86NIuLr/7S/xt140OV5wkh5uwJraFLbFndHQa1yKroKSH94l6C2vI8e2sP2VbyA6StDn0Q9XDP19A033wQ+69KXrGRTyqYiT4/ftG7fGprZEkiTghMlBNFhsfEaXNvtOKPyxJWzrN/YSJEmZISINA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4318 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT006.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(376002)(346002)(396003)(39860400002)(136003)(13464003)(199004)(189003)(26005)(110136005)(74316002)(6116002)(86362001)(3846002)(76176011)(305945005)(2906002)(50466002)(97756001)(53546011)(6506007)(102836004)(99286004)(52536014)(7696005)(7736002)(23726003)(336012)(63350400001)(36906005)(316002)(54906003)(9686003)(966005)(6246003)(486006)(478600001)(126002)(476003)(356004)(55016002)(46406003)(6306002)(446003)(11346002)(26826003)(76130400001)(70206006)(70586007)(2501003)(66066001)(47776003)(8936002)(8746002)(33656002)(14444005)(14454004)(22756006)(5660300002)(81156014)(81166006)(25786009)(4326008)(186003)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB5064; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 3abdd86f-a026-4630-c2fb-08d75161997e NoDisclaimer: True X-Forefront-PRVS: 01917B1794 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oKB3RTYJGAuTnFyieL9naSaVeCcuGzvBpjB4xNhTBCGvbQybKqvOjP0D8020MAd40IAiqw9iXhEYpwbUP/zKO5hQbn6Y4FG9+WuthDErQ2jofLMXgiSJPlTsqnAOBZE4OFl04PSMtuedBo/L5ZQK+4GrkuBrIL7Fp3SMTfGGljc+7en5Ufi/px99SFGoHZOz68Z2YmNcJiyL5n/rKsXZtxxchvJPbE8Mq5sT2TPVVzzh0vfM69574T5+327DjADjOLgNE3MIiMaKy2d38W2dvQg39UTXboqfaCyjlZ8rHBWl9NeHzrjE+QaEYEqxGFPsf4/3/uvnRsUcAfUsoYcXQUgd6xI0FpmFtxzJAgA/20S3VekcDWbWvA2OUr7p/NDWhjoFD0J4bxS1WusfxXepGF2OBRCo4SDVbgEvkIhfZgrtr7RNagOqHmvrs5ZdZdaAElpVksUC57SXimUmR2v/kQ== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2019 11:20:01.3250 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ec87c07c-c83e-4c7f-7bfc-08d751619ec8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5064 Subject: Re: [dpdk-dev] [PATCH v2 07/12] crypto/octeontx2: add enqueue/dequeue ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anoob, This is a typical producer-consumer case, enqueue and dequeue operations mu= st be conducted in a synchronized way, otherwise stale or earlier-than-arri= val data will be got.=20 Out-of-synchronization issues are more prone to happen on weak memory order= ed platforms, like arm and PPC, if execution in the program order is assume= d.=20 I see in this patch MOD_INC() and other reads/writes of the indexes might g= et reordered with regard to real enqueue and deque operations, this may cau= se synchronization errors. I have a fix for rte ring using C11 to keep synchronized operations, please= refer to: http://patches.dpdk.org/patch/47733/=20 /Gavin > -----Original Message----- > From: dev On Behalf Of Anoob Joseph > Sent: Sunday, October 13, 2019 8:40 PM > To: Akhil.goyal@nxp.com; Pablo de Lara > Cc: Anoob Joseph ; Fiona Trahe > ; jerinj@marvell.com; Narayana Prasad > ; Shally Verma ; Ankur > Dwivedi ; Kanaka Durga Kotamarthy > ; Sunila Sahu ; Tejasree > Kondoj ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 07/12] crypto/octeontx2: add > enqueue/dequeue ops >=20 > This patch adds the enqueue burst and dequeue burst callbacks for the > OCTEON TX2 crypto driver.