From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A9D6A2EFC for ; Tue, 17 Sep 2019 05:23:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1A4661BFD0; Tue, 17 Sep 2019 05:23:58 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130081.outbound.protection.outlook.com [40.107.13.81]) by dpdk.org (Postfix) with ESMTP id 8C2BB1BF61 for ; Tue, 17 Sep 2019 05:23:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NbRm5cOHYljrILMUcxuGqNV6UH08ja8gjCkzAIVCHyQ=; b=NPUSGKHTt8yyiZ9R3rrh8F3U+i6/Qh2NNMkxqdFhJ3E1FJVoX0GJ8IcDl5/1tpeFX80WAeCbOmY1zA6d1kxIpJdLNEpMyft3GqWwh/WxaxgiEKCGPq76tMxQThoyiYJC5iStt6pEYYrs3NJAHW0aUsDFQrnib3gNmRhTBucoSLA= Received: from VI1PR08CA0085.eurprd08.prod.outlook.com (2603:10a6:800:d3::11) by VI1PR08MB4190.eurprd08.prod.outlook.com (2603:10a6:803:eb::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.14; Tue, 17 Sep 2019 03:23:52 +0000 Received: from VE1EUR03FT053.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::206) by VI1PR08CA0085.outlook.office365.com (2603:10a6:800:d3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.18 via Frontend Transport; Tue, 17 Sep 2019 03:23:52 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=none action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT053.mail.protection.outlook.com (10.152.19.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.14 via Frontend Transport; Tue, 17 Sep 2019 03:23:50 +0000 Received: ("Tessian outbound d5a1f2820a4f:v31"); Tue, 17 Sep 2019 03:23:48 +0000 X-CR-MTA-TID: 64aa7808 Received: from 77d575caf4ad.3 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.5.53]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3A7D83F3-2C5F-497E-9099-0E8124E94790.1; Tue, 17 Sep 2019 03:23:43 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2053.outbound.protection.outlook.com [104.47.5.53]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 77d575caf4ad.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 17 Sep 2019 03:23:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RM6kyxbOOxwvyr2oWk6DHc+jSgFk/flX2TIC9QZqc0pBSSJzZw+FkPzP6TPZSQ8KVVAOtpYz6c2RVyof9JQ7ZAFlEoroUxE/3iYxTL3W5IthipxyKP97OscufvDkjI5tFxm/6ydD1mrIGbb2clpKyzUgpGLVawEZJ4YBYGwsae9+mJqXidn+0bD0sPgxB6xxcLIgp9SYenOF4nRiiChKdT3okuJeiHYxnYchN11p/8+1d2MUqC8naCpvNBhz9ot8s8MNDZJxEa2fNIZIQXMVnMo4tddmWRvf3VCnrWVCLO4a3dywb/l4Jn4wegZGhElZKKT+5ECFk7ub66MN88fIwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NbRm5cOHYljrILMUcxuGqNV6UH08ja8gjCkzAIVCHyQ=; b=VqQv88LzX/xo0X/UeF+/CUstCsFBGppl/Q+9cuGBVX1z7GT5sfRW+stE0s9Z8NxbsbgFFPwu84qp008Cv1G1DxaSmcmVIl46c56/ajokHXo6LTEES0OMsybyCMhhbIrqWzJ7lSWv7FGf57DzCNxR973GYa3FChzpJ2ig1fa1/buUqyuxiZdL5FCr4PztQfDEALew7t4d8UCfWKnQCA6yQkCubyW4nroXCz/wUVFlNOtjtl8r3Z3wqZ7A2w7hWfPRKA/WFqHZ1uyLKyAmKAeXBDvogX9RaHQ4DU5Fwp+EjYaPx0oCdBMDGIqMPcvQxD1wV69EzJFp5fO7RZhDZ3ccOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NbRm5cOHYljrILMUcxuGqNV6UH08ja8gjCkzAIVCHyQ=; b=NPUSGKHTt8yyiZ9R3rrh8F3U+i6/Qh2NNMkxqdFhJ3E1FJVoX0GJ8IcDl5/1tpeFX80WAeCbOmY1zA6d1kxIpJdLNEpMyft3GqWwh/WxaxgiEKCGPq76tMxQThoyiYJC5iStt6pEYYrs3NJAHW0aUsDFQrnib3gNmRhTBucoSLA= Received: from VI1PR08MB5376.eurprd08.prod.outlook.com (52.133.244.200) by VI1PR08MB3008.eurprd08.prod.outlook.com (52.133.14.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.21; Tue, 17 Sep 2019 03:23:39 +0000 Received: from VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::c09a:49d3:eab2:f707]) by VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::c09a:49d3:eab2:f707%3]) with mapi id 15.20.2263.023; Tue, 17 Sep 2019 03:23:39 +0000 From: "Gavin Hu (Arm Technology China)" To: "Gavin Hu (Arm Technology China)" , "Zhang, Qi Z" , "dev@dpdk.org" CC: nd , "thomas@monjalon.net" , "Richardson, Bruce" , "Liu, Yong" , "Wang, Yinan" , "ajit.khaparde@broadcom.com" , "somnath.kotur@broadcom.com" , Honnappa Nagarahalli , "Ruifeng Wang (Arm Technology China)" , Steve Capper Thread-Topic: [dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and remove duplicate barrier Thread-Index: AQHVbQdMcldqdFeO90OOwtsTkMXOtw== Date: Tue, 17 Sep 2019 03:23:39 +0000 Message-ID: References: <1567751873-15964-1-git-send-email-gavin.hu@arm.com> <1568633238-47888-2-git-send-email-gavin.hu@arm.com> <039ED4275CED7440929022BC67E7061153D97A8A@SHSMSX105.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: cc8b5bef-5947-4b23-ba86-188545d491bb.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 500ffa37-0ff9-4026-1da2-08d73b1e75cb X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(711020)(4605104)(1401327)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:VI1PR08MB3008; X-MS-TrafficTypeDiagnostic: VI1PR08MB3008:|VI1PR08MB3008:|VI1PR08MB4190: X-MS-Exchange-PUrlCount: 1 x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:4125;OLM:4125; x-forefront-prvs: 01630974C0 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(366004)(39860400002)(396003)(376002)(346002)(136003)(189003)(199004)(13464003)(33656002)(229853002)(7696005)(102836004)(54906003)(6306002)(6246003)(186003)(2501003)(14454004)(9686003)(71200400001)(7736002)(305945005)(8936002)(66066001)(486006)(81166006)(81156014)(55016002)(4326008)(86362001)(74316002)(966005)(52536014)(26005)(76176011)(2906002)(66556008)(66476007)(64756008)(11346002)(6436002)(446003)(5660300002)(66946007)(66446008)(6506007)(71190400001)(6116002)(55236004)(256004)(53546011)(2940100002)(316002)(3846002)(478600001)(25786009)(110136005)(76116006)(476003)(99286004); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB3008; H:VI1PR08MB5376.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: /190ciN1bFpYfxr/3LRVwtgJQW1GiNiSJIaoL8Lz+Bo2ZcEa7y1q4NSGWCAYYl3TcQVzO+ch8VlG0ZZM/qIjcZDGKVaxmpw+VXPHyCuZszi+WVHPQHO/W/k4IauOZ3lrskSkMS8Jzy+tzJuYSUeGR3320p06tVeCh1cW9nfV8FeHKIr6EynGBlg5AusHQyE6OOPkD1zNgeCfm4YUe5/pPjHaE/CoXDX/q6RGN1Heh/dEew6o1aEkURwUcJ46a+fRk+/ItYgLWifj2FQ/J8BHRljxCh3FIGFPgIlN5pJEnJq05DXpXlSqfohUzx/MlSCbSeaX/7FYg2XEcUKK+eTbbq9jQ/fwNGOVHwXglRryLOk5CZjh3LhXmXFJIFnkxrtv0FXZhsxxzVKZMpPPB2CG/tPUCcx1ry71QS12/z++SDM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3008 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT053.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(346002)(376002)(39860400002)(136003)(396003)(13464003)(199004)(189003)(316002)(46406003)(356004)(7736002)(76176011)(50466002)(81166006)(86362001)(54906003)(25786009)(8746002)(63350400001)(110136005)(26005)(102836004)(81156014)(2906002)(8936002)(22756006)(6246003)(6506007)(52536014)(229853002)(446003)(53546011)(966005)(126002)(97756001)(14454004)(486006)(99286004)(36906005)(4326008)(33656002)(305945005)(66066001)(11346002)(336012)(2940100002)(74316002)(2501003)(26826003)(5660300002)(478600001)(9686003)(6306002)(76130400001)(6116002)(186003)(55016002)(3846002)(7696005)(476003)(23726003)(47776003)(70586007)(70206006); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB4190; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: f3a08afe-e769-4ee3-2f01-08d73b1e6f43 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(710020)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:VI1PR08MB4190; NoDisclaimer: True X-Forefront-PRVS: 01630974C0 X-Microsoft-Antispam-Message-Info: teDNMFt0NIpYppLWMceHioKRPetAhFSzhc8sX5vclwW2dBUO1Ys6/8rJhm93tyzZMax8yLq+yrbBUh8BeIeJcg9tOlnEVcP/wqZlHHBSMKS7+msqD3USmBeuP+CCRtkONZm38d3Dvr7JmS+WbpscFJZDkZbR4Ok2VUU5js9vKg1drj+gsoulOe7SwUeiV3dSGdlSsPhUBOCF4tLzsRCiVh5ymZlXp1i3tgK296QliuX0XEYlc3McsdNtgTYwPisSjG78nh45wl/fpcnamjj++RZWRA1KLhYvHIV9asdHjLbPkdUwH39k6fiC/vf3Z0SiTQkuyfhc5EnUYa7RFSdcM/B2SbfyHxYCDYOTommprxP353LMQn3AOyitGW0WmlcUhbjlUXQJ6CL1Uy1ne2usN4+bL/d4zhZM2TaApLKVeXk= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2019 03:23:50.6517 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 500ffa37-0ff9-4026-1da2-08d73b1e75cb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4190 Subject: Re: [dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and remove duplicate barrier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Qi,=20 > -----Original Message----- > From: dev On Behalf Of Gavin Hu (Arm > Technology China) > Sent: Tuesday, September 17, 2019 10:08 AM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: nd ; thomas@monjalon.net; Richardson, Bruce > ; Liu, Yong ; Wang, > Yinan ; ajit.khaparde@broadcom.com; > somnath.kotur@broadcom.com; Honnappa Nagarahalli > ; Ruifeng Wang (Arm Technology China) > ; Steve Capper > Subject: Re: [dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and remove > duplicate barrier >=20 > Hi Qi, >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Tuesday, September 17, 2019 9:53 AM > > To: Gavin Hu (Arm Technology China) ; > dev@dpdk.org > > Cc: nd ; thomas@monjalon.net; Richardson, Bruce > > ; Liu, Yong ; Wang, > Yinan > > ; ajit.khaparde@broadcom.com; > > somnath.kotur@broadcom.com; Honnappa Nagarahalli > > ; Ruifeng Wang (Arm Technology > China) > > ; Steve Capper > > Subject: RE: [dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and remove > > duplicate barrier > > > > > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gavin Hu > > > Sent: Monday, September 16, 2019 7:27 PM > > > To: dev@dpdk.org > > > Cc: nd@arm.com; thomas@monjalon.net; Richardson, Bruce > > > ; Liu, Yong ; Wang, > > Yinan > > > ; ajit.khaparde@broadcom.com; > > > somnath.kotur@broadcom.com; Honnappa.Nagarahalli@arm.com; > > > ruifeng.wang@arm.com; steve.capper@arm.com > > > Subject: [dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and remove > > > duplicate barrier > > > > > > To guarantee the orderings of successive stores to CIO and MMIO > memory, > > a > > > lighter weight rte_io_wmb [1] can be used instead of rte_wmb, and > since > > the > > > I40E_PCI_REG_WRITE API already has an inclusive rte_io_wmb, this > explicit > > call > > > can be even saved. > > > > > > [1] > http://git.dpdk.org/dpdk/tree/lib/librte_eal/common/include/generic/ > > > rte_atomic.h#n98 > > > > > > Signed-off-by: Gavin Hu > > > > Can you also capture the one at the tail of i40e_xmit_pkts? > Thanks for your review, I will fix this in next version. I checked again, in this version, the rte_wmb at the tail of i40e_xmit_pkts= was already removed and the following I40E_PCI_REG_WRITE_RELAXED was replaced by I40E_PCI_REG_= WRITE, which has an inclusive rte_io_wmb.=20 > > > > Otherwise > > Acked-by: Qi Zhang > >