From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A14E741CE5; Mon, 20 Feb 2023 12:56:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E3F643029; Mon, 20 Feb 2023 12:56:19 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 797AF40395 for ; Mon, 20 Feb 2023 12:56:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676894177; x=1708430177; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=+nloH6fXRtYqgJQ+MQlXAuZK1AnF3053UhmejNGraS8=; b=RvNgVQUGRhZpXZjoB9YwSz+RA6nysJadcWrY085ZRz6j9eexW2zv9amK WSXycfa+2j2fhG7Z9ddjgivEMYUv8Z1Vr2KMolDOqtmJIAOzVR1oCDqLG RcaiBqrX8/SitfeKCB1p0giiDvQrW5yNhSDAzHEX2xthYrYcIUt8/Cili OB/3uuzvogoZKLWqSMDTgov/b1ZlwT9sZNbWiCe7Gl+G16BI0jvU6SMXb g7vQYMph1SAWBhLzsFgAM5swPLOKRVmvArTAGvdoIp+Tf8sCn8qr70v+H attc9o2swe3qoUWL7xTVo86MVNWuCf+7H6uXX6SUIB5hQcA9A3FmZoNNi Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10626"; a="359849691" X-IronPort-AV: E=Sophos;i="5.97,312,1669104000"; d="scan'208";a="359849691" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2023 03:56:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10626"; a="735103705" X-IronPort-AV: E=Sophos;i="5.97,312,1669104000"; d="scan'208";a="735103705" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga008.fm.intel.com with ESMTP; 20 Feb 2023 03:56:16 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 20 Feb 2023 03:56:15 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 20 Feb 2023 03:56:15 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 20 Feb 2023 03:56:15 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 20 Feb 2023 03:56:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GWOEDel42s7w7PGI3AVMGzNnG678VMnY9OIRlJ/L4p6Sgxvq9iUwI+D5RoxvCJDVQJziIr+GsbY94PB759+urdc3N9koGhwJfywCx/jmNMyvZFmtTEeWESp3hlIrEk/ZPMBZBMf3GbfXFfy27YvtASpaEUkADiJEW7q761UnYNFtIHZcz93dO6VbftrAG9S0V6A72obd0hYsxJNIbq1sSLfQ+iZYJFb7hZiDVE/VMleTfkb0pnjevyeZlDSdz4gvqDVAsO4zlBVb6NVMR9Kz1Ss6Gsg4z+88Ev8ame1gHL2RHTraXk1hQnVKB1j2cCnrXaU4Eu8bAOXkj46/f5gRKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dTz7+gfcVnF+eyNCBI7Lpqg5n/bU5zi8i/bwKgsBUho=; b=G3JWs81PEdT9AaB2nWnSmVN36F3nKpy5Y5MRaThEF4hbdr2AZ29VzuSL+r3yyRxAJ9IYMMqwkam3MGVtKKVjzrNEL4O/wGFJJ0upCbn07Q+ILHQscPOswJvLeDpffbB7xpYkR9j3DSEjoa8sNP3ssP9LLIW/IM10+AwVMFblCCIid84ueoznsjwaTvLXcSjhDPF0xKVoI83166TCUC3fYC+agEjOsXTYjzoo2i645+S3JUlAGB7nZCoSqCBKIzaP102EJhFsuh0pxjQSitHai6DDVsFscrcMlpSPzdU0XUKZI6Q5Dws+Di3Xt4JRRdTuM+enjfQzsM+8Qw2A2lIqOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MN0PR11MB6183.namprd11.prod.outlook.com (2603:10b6:208:3c5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.15; Mon, 20 Feb 2023 11:56:13 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aaba:abb7:8794:def]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aaba:abb7:8794:def%9]) with mapi id 15.20.6111.013; Mon, 20 Feb 2023 11:56:13 +0000 Date: Mon, 20 Feb 2023 11:56:05 +0000 From: Bruce Richardson To: Juraj =?utf-8?Q?Linke=C5=A1?= CC: , , , , , , Subject: Re: [PATCH v4 00/10] dts: add hello world testcase Message-ID: References: <20230117154906.860916-1-juraj.linkes@pantheon.tech> <20230213152846.284191-1-juraj.linkes@pantheon.tech> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0425.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18b::16) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MN0PR11MB6183:EE_ X-MS-Office365-Filtering-Correlation-Id: 3497d755-29b5-451b-b1b7-08db13397689 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eEAMj/zQ/r+AIL5AtNwNOnsqxy/P4uozyfkTxfVj3kmiYw8mGUQLOP+s7XjGuwlD7aUg+RDR3y99POxqq87YYaVR+nmT9+jtZ0UPste+vob7iTMuqw0lV5Kk89y2ahmizhZ2uwM7Ekxa0+c9fOUaqA8MsA4JvLkz+pmhgHgEzVvkg53AYZ4wvgpbH4tFsczedjny3XWkzEOGFR/T+Iz8LMYh9RJi2XFpMX/plTIJn/ZM3YiGYjhZz6U/6cpP7va14ltHq5hILBxajYxxoTwhKDVTqx/Xlbmw85hP6YUVk9+O4nKyNPS1oLBTDO0GMGS+0ehPf/GfXD4bvfNm0qkeTsOgFl6/PGSNdv6o7nHgtM8y+qc05AC7++aFP3PIGwzV17orShAZiC0H8ndi++hOkfqYvyiEgdN6mq4zd6TI5QHfJgZu4KVcKadGCrJEfVIMCugtia2hb5AH9jOpE6cfEL0UqBGwyMDdZxyywET0613+fU1qbzrdTqQBz0LXTbkvgoFnBLq3YP5+oehPQC6oWh29xpZQYZ0tUcfzYQDWhB963Pe0+C/irHYGX+QqywAiSeYqm97dRNDwG0F+ZZH/vvARDkKVbSJ34viyfpFxgMuYToKUEfpjJ3TTyMdrYZYT X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(366004)(346002)(376002)(396003)(39860400002)(451199018)(186003)(38100700002)(26005)(6506007)(5660300002)(83380400001)(8936002)(6512007)(53546011)(6666004)(82960400001)(316002)(66946007)(966005)(478600001)(6486002)(2906002)(6916009)(4326008)(41300700001)(66476007)(44832011)(66556008)(8676002)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnlaWTlLTEwyOVZzd0srbVNJUHlGUm16c2hIL3dEQUF2OS9PeElQKzJVRmVL?= =?utf-8?B?ZFpmcEY3L01nd3ZCN3pHQWhSY1Y1VkVBZ3UxSzJOS1h4bW5vNGJXVW1xSjNQ?= =?utf-8?B?VEVhVzBQZFpHU2gycDVVd3N5TWM0dU5SR2paMlJhOHFFREFiR2wwSzhmQS96?= =?utf-8?B?dVExQUdPck9JMDZoejNkSVc2YWJFUUovU0wvNitrR0hEcnBKWnU4dHUxdVQy?= =?utf-8?B?ajhxOUc3Yzl5Y3lWZi85ZTZnTW5VcElTRkNaYlV0MVlMMC9pd2lGNU5OTlFh?= =?utf-8?B?Q1FXS20rS1czY05yaVpqUUtuUjhhUzdMb3U1TTBMclFTSlZNWVljdVNybHNa?= =?utf-8?B?QVNhRGR5R0kzMFBPYW1yYWdqeDJRZFBIMGJZTS95ZFd4Z3FudHdZajBLS2wv?= =?utf-8?B?N05kaFJueWs1Tkt1QVlVODl2c094MXhIam8rUm9qOU5IZXNlRytjZmRRVE1I?= =?utf-8?B?d0dPNS9uVXQ2RDRyd3AyLzRhc2I3TkY1K2xxaW54bzFOM1haa2Y5MFRVVEVP?= =?utf-8?B?TmFmeEdhREg3UVYyVS9wQldQYnlDTkJWeDExMXdEWlA1SElCelNiODE5dkYy?= =?utf-8?B?R2I0SC9tN2RJeUNVeFFYM0R6aUFxOTB2a3ROWlF3MWdQR25QZUJLTWxNUDVy?= =?utf-8?B?dVVUaDNTTjZwVnBIZEgyTTJYazlEU1RLdGFUV0x3N0owdmZwZHBycDhxQ0Mx?= =?utf-8?B?VHFXSDd2ZHhhSEY4SWh4QjZra3drKzJFbzU1b3JXRTFBT3d1TmhmZWxBeXE5?= =?utf-8?B?VVo4U1YxMDN4R0dnV0tna2xLcDBvY1RmYlI2eGJmdTRMWUU3K2I3UEl0T0d6?= =?utf-8?B?MFpiQmEzWlVDL21sWEJyaHQ5K0JqcmZidUtXV0pHbHJUNVAwSFJNd0pYNkJD?= =?utf-8?B?cmNIVlovUWMwc0cyR1NiWjFVQUYwOVYzelJiNWpOcXZIQTNUamFvTExrMEhh?= =?utf-8?B?aC8rblV0YXUvWm8wNkROaFQ5WEluMVc5cXJDZWNTWWI1OGdVeDhtVmdiTFVP?= =?utf-8?B?YmpQcUwzVkZBSWJrdWNHQlZDOWNKYkVZajZWSkFneWwwd080M0lWL1lCTm12?= =?utf-8?B?SlZOMDhKTklncXNRalduMFNIeEgwWUtoSXlJVnZNYlFkS1BxMXFjZ0Q5ellp?= =?utf-8?B?VlVkRlNVUHF2VWRUblN3UnJzQ2o4MWN5Rlp2WEdnaXV0QkxTZjY1b2krdlRy?= =?utf-8?B?cWQzK25QK1k2WTNBMmE2dW9BaldCMVMvZU5wcmpjcDhFQk1pclNqbS95cUZV?= =?utf-8?B?OURvamMzcVp3ZFJUUHJXRFg0TWlBT1FPdDB4Qnp1OXZxQ2oraFRMZ1hlYVlx?= =?utf-8?B?dGZxY0loYkNaVGY2eEp3aHRja0wyVUNuRGZGYXh0dVhPWHQzWUJDOEFYMytV?= =?utf-8?B?Y0lnNk1iajlHd2tsV0Z2RVVocWIrclBPanVHUysvY2lHcXpwNHpEU2k4clFR?= =?utf-8?B?cVo1MFNMbzNmbmhZZHB2V0VIU3lIMVhzUWx6TmRPeDBvTzF6c2x4cit3alIz?= =?utf-8?B?eitCS3JCTzFhaWZlRXJtQ0ovSzdJTWI3UXdTRzFLMlRlU3QrYWJhb2ZYaDNE?= =?utf-8?B?RVluTlJSZUVVa3BhOHkzQ1hXUFJ0U1huYzVEY2FFb1lYaEVNdG1HSkYrV2Mz?= =?utf-8?B?d3A2OWZISTQyZW5mYTlOTVdvQmxLRjRsZnpCQm8yd1lUN21DMDVzdUZyemxO?= =?utf-8?B?N2VHT3k1ay9qN2pVU2pGa2hHMU9TWU9JVTZMWTN6MWhOTDRFY3FraGxxK2hP?= =?utf-8?B?RGRvQ0pXVlVoRURJbzZKVEpNd05RMmRWTXZyQm9zUGdMNTUwbzJMSTdXYVNx?= =?utf-8?B?d1RCZmdRSGxEMVc4STk3WHV3ZXcxVVR3YWxUOVhpTmFadldZVmNaM1Mxcmdn?= =?utf-8?B?aDFWRXNJS1RmV285ejNoYmRzanhhQ2N6b3krM2VyNEo1L1pkeVFzbHlEVzcz?= =?utf-8?B?ZGtwYVgxeklQT3RrWTlrclJIYWZDUWc0VTNFT2pmTEVlRHNMZG02M2VqaG82?= =?utf-8?B?eTczR0pxbDZmR2tINlF0a08xVGZBNE14bVFRSFlJZ3Z1cGNDY0NxRU9VQms5?= =?utf-8?B?SGdHSTV5TVVERHpBenIyQktkdlZONzRITWhGY2VuUm1IMkRManVPaVVIRk9Q?= =?utf-8?B?VWJ1WVh0SGNKTEV3eDNyWW90eVA5dStJK3Z4ektCbDJxaTVUSGZjLzFFeFlU?= =?utf-8?B?Tmc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3497d755-29b5-451b-b1b7-08db13397689 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2023 11:56:12.9450 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /V49BxE0n8S5uXI+oEqbEq3tc03TMolztxPCauz7YBeIhn+eLQqCq6LpULDbGX3el45rYcwmuDZmOJx0JZAp8YicoAfmvswmH8UNFRmIFf0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6183 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Feb 20, 2023 at 11:13:45AM +0100, Juraj Linkeš wrote: > Thanks for the comments, Bruce. > > On Fri, Feb 17, 2023 at 6:26 PM Bruce Richardson > wrote: > > > > On Mon, Feb 13, 2023 at 04:28:36PM +0100, Juraj Linkeš wrote: > > > Add code needed to run the HelloWorld testcase which just runs the hello > > > world dpdk application. > > > > > > The patchset currently heavily refactors this original DTS code needed > > > to run the testcase: > > > * The whole architecture has been redone into more sensible class > > > hierarchy > > > * DPDK build on the System under Test > > > * DPDK eal args construction, app running and shutting down > > > * Optional SUT hugepage memory configuration > > > * Test runner > > > * Test results > > > * TestSuite class > > > * Test runner parts interfacing with TestSuite > > > * The HelloWorld testsuite itself > > > > > > The code is divided into sub-packages, some of which are divided > > > further. > > > > > > There patch may need to be divided into smaller chunks. If so, proposals > > > on where exactly to split it would be very helpful. > > > > > > v3: > > > Finished refactoring everything in this patch, with test suite and test > > > results being the last parts. > > > Also changed the directory structure. It's now simplified and the > > > imports look much better. > > > I've also many many minor changes such as renaming variables here and > > > there. > > > > > > v4: > > > Made hugepage config optional, users may now specify that in the main > > > config file. > > > Removed HelloWorld test plan and incorporated parts of it into the test > > > suite python file. > > > Updated documentation. > > > > > Hi, > > > > just trying this out by reading the docs and trying to follow along. Couple > > of high-level comments thus far without getting into the patches: > > > > * In the "configuring DTS" section, I think it would be good to: > > - say that the config file should be named conf.yaml by default. It's in > > the next section, but I think it should be called out earlier. > > - say that there is a template conf.yaml file in the dts directory > > already. On my first reading I actually thought that the sample config > > file was dts/framework/config/conf_yaml_schema.json (and I was going > > to comment on the name being weird! :-)). Only when I opened it did I > > realise my mistake. Therefore, downplan the schema, and put more > > emphasis on where to find the simple conf example to start with. > > Good points, I'll rewrite that a bit. > > > - if hugepage config is now optional, as you say above, remove that from > > the sample and the docs. > > > > The optional part is just that users may choose between DTS either > configuring the hugepages or not, but hugepages still must be > configured (if not by DTS, then beforehand). I'll document this a bit > more, but I'd like to leave it in the sample config with a note saying > it's optional. > > > * The code thus far seems to imply that you are always going to use root. > > When I configured it to log on to bruce@localhost, it timed out waiting > > for a prompt, I believe because it was looking for "#" which is the > > default only for root prompts. > > > > True, I'll add this to docs. This will not be a requirement in the > future though - we want to do passwordless sudo. > > > * When running as root, things progressed further but I hit an error when > > DTS was trying to get the CPU config. No idea what is happening here, > > because running the same commands manually over ssh seemed to work fine. > > Below is the error. Any hints as to what is the problem appreciated. > > > > I remember running into the same issue as well. I think it's related > to the bracketed paste feature of some terminal emulators: > https://askubuntu.com/questions/662222/why-bracketed-paste-mode-is-enabled-sporadically-in-my-terminal-screen > Please try disabling it and see whether that helps. > I haven't gone to great lengths to harden this part of SSH > implementation as we'll be moving to Fabric (from pexpect) after this > patch (which uses a mature Python SSH implementation instead of > expect). > Ok, thanks for the explanation, I'll try that out. /Bruce