From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 149AC41CEE; Mon, 20 Feb 2023 18:52:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3159430B9; Mon, 20 Feb 2023 18:52:03 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 8101840395 for ; Mon, 20 Feb 2023 18:52:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676915522; x=1708451522; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=qJG82SGV50shgbX9XuG98UjhIC/cNytA+X43yFmnnZ0=; b=GnXpxL2BWdkWJOcR94/FOEAkalZShOAn+fmUgBhSdvF6fEMys27iTUY8 SgVSgGYVM7GCkSapfU+sEQaFT6KfzMreqJPo6Xhr31ZRuUUayGFgfZ0Wq vUiyPp19tTA6dbDzLbGJUE90vD+u7L8ZAIzeo8SljrKRU/wCaSSaFyLGG dS1sAY1IlSn0GtWtGSnKwTpMNyCGivEY/YQd45Y1Xu3YBZtkLtDy77MpB pIpuAKvZmC3lrlM3tzv0w0J6vM4epKqFQlUt9xnxUMM2pP0o8V533IpPJ 6OLjO3HlN9wZL2HyP1Jb35nN81X6HejXRWaClJiXmMNZJJ+ZDYaqipVms w==; X-IronPort-AV: E=McAfee;i="6500,9779,10627"; a="312086889" X-IronPort-AV: E=Sophos;i="5.97,313,1669104000"; d="scan'208";a="312086889" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2023 09:52:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10627"; a="701748202" X-IronPort-AV: E=Sophos;i="5.97,313,1669104000"; d="scan'208";a="701748202" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga008.jf.intel.com with ESMTP; 20 Feb 2023 09:52:01 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 20 Feb 2023 09:52:01 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 20 Feb 2023 09:52:00 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 20 Feb 2023 09:52:00 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.43) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 20 Feb 2023 09:52:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KPcXrPumEZhOfNUYj1ThZe4LSlmEGraYDeG3xJIAkv8CH+FafGttAuzMo46kuC4c4UqZ8QcSRZgkxOsXEziN8rEeimkCuUOZXkNLxYBWMfl/7Vda/2gaySvEGcHP+HN5SzjtvS9LlUw2LtgKgKP8lmcokxLSji7HNpdbiLsoGKxyLVSnSAJN6vc50SypCcUl14MqVDBNxS6PbVLqYLfcfKMLqmWvN48k6h9hvB1mxP4RUzdOxk77OkMHyMDekaqJMun6pX0B24Ivi5WGbb0sOnhGQn236WjmMEmURtgRl8LOcJSCH/rmU+0GWrNA6TaikmYglqdffVtuOuhJnptQvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=laMDh2j4I5AEtM/XjsYNGsP69hW/s7t6w8chwL+087k=; b=DgxifEdOPN3KpXAnVM+6lvC6mAnIhdFH0NZSgUQ/tH9Q0tzcrDNPSDMlBVrUkaitEk/UE++rwOso8l9eaQMq/RXTpcFQb4oOC5GCTOXh3FzqB/z2IrhwpmwvxPpawPHXTsdmzDwlhINfRrqcRrn06nlxjr38vwybPOQeYVkI4GlBVDeL1Y7xJS9q1GcS3dHLsIEpoXcvzefCpBdc8ACmS4Dw+50/GeLw7YS6/G53zcVyY+I+2XdrjvDhP00zt2An1VTeXHuKsYVW237lpZ/5F89bKyymXeunBYsk7A89y2asAe2x0IL7MJ/4oz887LSWuRDSFGhZAv8IO0QpNrIxdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA0PR11MB7791.namprd11.prod.outlook.com (2603:10b6:208:401::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.20; Mon, 20 Feb 2023 17:51:53 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aaba:abb7:8794:def]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aaba:abb7:8794:def%9]) with mapi id 15.20.6111.013; Mon, 20 Feb 2023 17:51:53 +0000 Date: Mon, 20 Feb 2023 17:51:46 +0000 From: Bruce Richardson To: Thomas Monjalon CC: Bili Dong , , Sameh Gobriel , , Subject: Re: [PATCH v3] hash: add XOR32 hash function Message-ID: References: <20230215105442.3878441-1-qobilidop@gmail.com> <3296424.9LS3J3VOpE@thomas> <16442264.0ZKypZ73Fx@thomas> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <16442264.0ZKypZ73Fx@thomas> X-ClientProxiedBy: LO4P265CA0191.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:311::19) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA0PR11MB7791:EE_ X-MS-Office365-Filtering-Correlation-Id: 58428162-a500-4011-9ef8-08db136b264f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sWyDBmDzcZp0ASgpTLbcJ9Dd0mC+dmiMIu73LjOmWV2Zau1ysR1DCHBDIjjZcnHoWU/9c0hadoVBperrbjCi2qQeDh958049k0RQGW17CBTuGiTCTqXwiYbt3RcwQjXA6dWgByRXtMiF5+9ji4TTmbL6dM4OrN6x4AwbeADdg6c3NdjyfyyFIVDCUgpLCL2TKhciGfaXVGiqMfSZ4Ps0akHbR6gI/mTyO659T1fcuoZMiuDx8k1R+X0jwRSOWmcLDw0+SpkmrnWaz++hJfqkawt7KA/3QfvWcjeY5e55prEPVJqHVOkeVm/GnSq0NVzb7ZIChws7iKIhzr5k3M/0R1iYmZaKyDWGZwU5WtvX8zNmch6nXhmCy1nSPUkXyPmbIddqsvCqYyWX/PuJUPG9NecdCOMbMTvRoX79PbiutUCUDG51zlPBImjDOBcmAEDSuXyu8ikECYRrjDifHLWMPirjjDnaWwow/pt09OlbXTDCUYpX3gFlPzRCMP69hLSyDADbvj77DptJWVLmJBG1ygP4Hj3jysxReh+LVFGWdTh5Oa3ePAfZqSMFfpvaWFiLRFNj3eiKZiqzuZqfmka7N/4oI4YIVourc55OGmrVN5N7KT+LBkZOUdLp/sgptRHZ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(396003)(346002)(136003)(39860400002)(366004)(376002)(451199018)(86362001)(5660300002)(2906002)(44832011)(4744005)(82960400001)(38100700002)(54906003)(4326008)(66946007)(8676002)(6916009)(66556008)(8936002)(66476007)(41300700001)(316002)(6512007)(186003)(6486002)(478600001)(26005)(6666004)(107886003)(6506007)(966005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5sSYPbX4KFw58I/X1pyMPLoN53biamECb+1s7TlVeSk5rgpR237J/Y9XAZoV?= =?us-ascii?Q?2mGn0V6eA1MBbXdJqVkTINbBfcZjA/V5YXWrJSkmEY91qsNWYR1W/Xfg9bf5?= =?us-ascii?Q?QzB/rJcEbdKhYVRiVaOu+znVtjX97/fRrbjV+XfW9aqykQVQt37f8QjZ+b6J?= =?us-ascii?Q?kBhsY3FiutfMrfg1alL3iFduGTIptWIPnS6hCZvjv7rdl3Z2yi+scu9LUA1y?= =?us-ascii?Q?Omh6h86JZy5e+Gf/WyqvrqJKwpeWpTC/LJ5mvTfVc5McUKWDVLmNmOu3Njdz?= =?us-ascii?Q?TM8uKwF7IrZGzMS8TAuz14qqW/4qLomBRgmQ3PLZVfVzFNGYlIDGh1DZmO77?= =?us-ascii?Q?9xrdeTk7mKOcP5C6MJJcvhd7/dbIE0Iy/6JnPDguPkdK3+byvM9RMuKJr1wE?= =?us-ascii?Q?zMrcAVQ2GxC9M+n0B9wIhHkkJ5ThCL/ve3JgXvm1mxqQbOnpftR6ucIKkc0Y?= =?us-ascii?Q?4omdk/1zb/DAsdwVEpmwpJkJbyCX19v4nXIZ3TkBJRzrCLBT+2GmNuLuMxUj?= =?us-ascii?Q?Xq5dFsIt6Q8kclL8XaeHJHHQ9GarpiBbwHc98AF6hndi8TfdmoyCVGR8O0Ln?= =?us-ascii?Q?8dM+VubN3hZ74nN0go0uRZzg7uFvEE2tcUHrFxkemNf++ch1fL8LZBOIiP1U?= =?us-ascii?Q?PFkzOA6bja40pKZuDDqOFhxhkq4WCeVQu3pUpZ5R+9LJ2xoaQL61ap/wNF7C?= =?us-ascii?Q?bCh6+aP2BPogDnH5+lvdI9SbVSp5/KBSnjIeYamyPCAhyQ+HrFBzuzl3kNhS?= =?us-ascii?Q?anbxHBHUhcp0u63jiBdEMCOmYOkcMsIaXePqT0ApIIqfYYpQaneLUmF8dcv9?= =?us-ascii?Q?URjPeApcOtnb72dyL1zcIHfX0jYVGD1PtBekK1xQPyaJmjwTLGWZkeluCm/t?= =?us-ascii?Q?UW+h4sCqVyPvs1tpe8DTTwa/jZ6v8C2z1a7Qft2txwAudQaqJufcVCXAY+lD?= =?us-ascii?Q?DxXswX3FYGkgECBid4Exo7n2VnsOnfwn6ApT+ds/tIHjFmeVP5fcI+sQnQGR?= =?us-ascii?Q?l10veYEMOHVk/1PG/rwIjR/bL/eCHjikVevwSxQpDdMNyjTsiG4SsT2oM0kv?= =?us-ascii?Q?nF96rSb1G0jUgTpvHwWhKRvnmaB3W+AZhQsxHa5iP80uJmXyAfXlGs1rfbCB?= =?us-ascii?Q?lCsen82EwemnMzqLqhwxRhJEUs+/dKeDsA4bDkxrncCmgnLzwDNJPuLeCBNY?= =?us-ascii?Q?KDUa536kGvElvs2E/ScbpAK05YeBRIbVl8+Sy/ncwQbjJV9dULPFThFx9oC5?= =?us-ascii?Q?3bnN6yqHkqBlDvdEiaMdwWZLYevTCnPQSAWBXaYdYtNBZOC1Yy4sLvrrdH52?= =?us-ascii?Q?A5RszcQsFdNFKYflqY/KA82lcRM1Ud7yeIBKa/ZENqG//hXy+CCarSTWD0Ro?= =?us-ascii?Q?9D6y1+gwvkfcFk46SVUuOa51w2Wt9YuikHcU6foocUfbD9FGrEqK3EJoXYz2?= =?us-ascii?Q?2vpDQMtY9tYivHd1BfZqMosVNDpnZrbGkj7AX8OpOkNbBZph5SqYhwJ/+UZP?= =?us-ascii?Q?hsBq077GluDlgCnn4IrqMO061X0+PzOfruAlKS/LlpRuA2FHT830/nbLavnR?= =?us-ascii?Q?Brm4SmmqVpNgGdVaC4xnG5lmRSO1bvFKLLylZUig2BeJCy+SWWrAUtQNNAWE?= =?us-ascii?Q?NrVQeWArrhzboO2Fp7muiig=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 58428162-a500-4011-9ef8-08db136b264f X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2023 17:51:53.1519 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q8AAplhPg4o60gB0LgDEQ+MS9pqrCUAZQIyyQFvziL2QVrlk7m4/E3ntaNYMOkxrYKFJXFcQedxr2WNDFGXCK5EAe6qR34ChKpk58EvqTsc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7791 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Feb 20, 2023 at 06:38:23PM +0100, Thomas Monjalon wrote: > 20/02/2023 18:21, Bili Dong: > > The naming is following the existing CRC32 hash: > > https://elixir.bootlin.com/dpdk/v22.11.1/source/lib/hash/rte_hash_crc.h#L168. > > I believe all existing hash functions in DPDK are 32 bits, so "32" didn't > > appear in other hash function names. If we add "32" here, we probably > > should also rename rte_hash_crc(). I'm fine with either option. > > Why all functions would be 32-bit? > I don't think we need to rename all. > We can just make the right thing when adding a new function. > > What maintainers of rte_hash think? > +1 to adding the 32 for clarity. If we want consistency, it's easy enough to create some aliases for the existing functions with the "32" extension on them. No need to remove the old names so there would be no compatibility issues.