From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E46D241D40; Wed, 22 Feb 2023 17:43:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D62BC43013; Wed, 22 Feb 2023 17:43:10 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id B495F430CE for ; Wed, 22 Feb 2023 17:43:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677084189; x=1708620189; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=+2ZFlEHUI5ZnjORrKDrGdO7oBGoAKiJppzU8U3e7aFc=; b=BtMnpyKzOC7uoHxF2uuB592y1WwDChRL8NLxSNLOC6mxN0NmOL0ZjfoT Hu+tbGewPV6DunhSIyGcA8/qJtEndAelBAkzU20ONxh4B1wEeG3Fe3cca 4yP66O7NlkRVG5w9QVkXS+oRZ7ZZYkWhJnx3gdtM8wiWh0/leThJjpMc1 n7uxBdORS4M2rEWucPFrYlBal6t8ZtkmOF2Sjr6+Y0Fj2BEQY6zrkrjaX o0HfkmLOdg9W/ETC0lbGNix0+hDtK/gxoat2TNoTZ7AoF4zLY5aSuMBFq VODHYrpMgdvkw59NNOoqaj/HW7jT+SgWQqz4Qgd7Ch7qyBbtWM9h0hoiI g==; X-IronPort-AV: E=McAfee;i="6500,9779,10629"; a="397657322" X-IronPort-AV: E=Sophos;i="5.97,319,1669104000"; d="scan'208";a="397657322" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2023 08:40:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10629"; a="846199137" X-IronPort-AV: E=Sophos;i="5.97,319,1669104000"; d="scan'208";a="846199137" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP; 22 Feb 2023 08:40:08 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 22 Feb 2023 08:40:07 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 22 Feb 2023 08:40:07 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 22 Feb 2023 08:40:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W2LD3zTkFRgS1HPcVfDqQF8T8lwC3wTSW/tc2qQMjgwkunVDkcSfo0f7HUpiS/zqRt4PRbk1v6evMcCRMNs+NW4sX+dDTxA+hgDT6fDlAkcCjptyB1lm1fpEt3XZ4R2VVCwHrpgXNC6hlUvU9WUagoVhJk1Ap1wQgBAd4LfFmrYxJ0bL+1v3t80laaukfyXaQUvHJx4kKQIb6BtYZCc6UeimZiRUNAtZcYi3aQ3xK70a2GWRUFAaXOVFI3GyujpYzahzq+PAfS4Vg9zQ5H8xQLGNVuNijM1hxFPxSkm+pV6vbZLCiXID5Qe5fSeOfr6p7tz1uEA7nf7J8l+eLI15jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tmzJv9436nnfcWxx/yXEQt/kJhVmJW7LjcpQ7EB+6nI=; b=MVdLx+mSmSY9/67T3bGVMz2Zdq8FKhtgM5JkV5u84B2QjSuPCQxRFceFuZbYWL+wB5pFsNrr1OHwvCXcKFPo2jxHfgqfI3+13DR3aUcUddzADWGrLonG4oL9pJLI8nTiZg+/6LdtVvhi0rbOnq6oQJaWTr43e6BKlqdV+BRy7/mD0/3ZJr9FeNBtqHblrYmrYvjF1ckUAC7Ykb+cO1wV1Z9IHpKJ0Gpo1DnSctMwhmC+tG8pdTSsHZTz9w4cj+BbqMr/+dvh9IHk6tIor2ntqEx0TOEElvmaF4oNtcpQRxYKvFIp6Kspe899R/uocjizt15FV+7792xNVocaiCjeTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by BN9PR11MB5324.namprd11.prod.outlook.com (2603:10b6:408:119::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Wed, 22 Feb 2023 16:40:05 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::18d0:ac53:aa1d:d19c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::18d0:ac53:aa1d:d19c%6]) with mapi id 15.20.6134.019; Wed, 22 Feb 2023 16:40:04 +0000 Date: Wed, 22 Feb 2023 16:39:58 +0000 From: Bruce Richardson To: Juraj =?utf-8?Q?Linke=C5=A1?= CC: , , , , , , Subject: Re: [PATCH v4 00/10] dts: add hello world testcase Message-ID: References: <20230117154906.860916-1-juraj.linkes@pantheon.tech> <20230213152846.284191-1-juraj.linkes@pantheon.tech> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0256.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::28) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|BN9PR11MB5324:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d159d45-f08c-4d80-5977-08db14f3732c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AIPMGnK+f8UeuIM7LolqUJ/evj24TotMy7IdV0sc2doyV7PgWrcO+z+YzB5U1LLwNL0iz4ypOxgoz3e5r+vLGFGLh447kPvS6/igORVAr/F0dMHvmFKO3JFdTutX84GG/DOg2HHwmTtmsObDgESo4DzDyFbOaH4dpDdi7G8ww7CkvN2n20nCPCXe0hzsmfKy5U3/aIxLjBWKvcBGEPHtoiuTRlgriu/xZcvigv4ZEV2jmdfMrqk9e2pzqzOwCL1+r53yo4rsH1ObJdNmnxkk0QnwOnMzlCdnLmzEK9UO+6QSc7B4SXS6RWj9gHj5hk6unTalKUNzXWz2cnk2nGD9OoN/zztDf4ns5EZgz/PLKI9zcjTEgYseFsy1nexvhOTKZjPvhk0+x8mPT/tQF7TSeYjX9z+fbl1LlzzVyWoXOy4IAI4FF1JKTbYaP2xGlLTAZG0QJraOI0LsVPVBhfEOaHeYuvLSgv0oPDEHXAEFiC9ag0EsH1ErEqGbsrgpKTT2n/VAROq4MQ8M/ZePc1njpN/ZQZluRYqa07TUdy7DLhTZMpB0BIsbeHGweSaqLRTo0H37KGP/aKcej8JAXiTQ3TRxNXOIGqhTJWv/wGtTq8N7YF7s5bj/V4zmT9/G3o25 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(376002)(396003)(346002)(39860400002)(366004)(136003)(451199018)(44832011)(5660300002)(8936002)(86362001)(41300700001)(2906002)(38100700002)(82960400001)(6486002)(966005)(66476007)(478600001)(53546011)(26005)(6512007)(186003)(6506007)(316002)(6666004)(66946007)(66556008)(83380400001)(6916009)(4326008)(8676002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WGcvS0s2VGpqUFZ3U2JRa0pLa1dwTDlWN0Y1dUMvTDl0cmRZZ2t6MmkzNWhh?= =?utf-8?B?dEc4MjFsMng1TWN6YjNXbmNCQmR1R1p2R2d2dUY3WGhwN1NRQzRtaG9ZbjU2?= =?utf-8?B?WFZlb3NyRHlPUFVUSEN2VEdrVkMwQmlFc3M1NFlaMmI3aWpyVmZwUWVhS09Z?= =?utf-8?B?MVNYRWdXa0lseHlYSGZRRkU3K2VmVEdWRWppU1p0eUN3U2NobCtLeXIyNitE?= =?utf-8?B?Q2NxeGVDa2wrL3ZDb2hxTE1CVGdMZ2VWdW9La1ZHSlZwUjZlV0JYQXkzRzlG?= =?utf-8?B?RHVSdk9FK3dVOUJ5ZUg3dU9idlBKODVVRHQvNGt4a05tdEx0Uk14YjFlSUpV?= =?utf-8?B?ZXcrT3BhMW9XVnNJYXdRZkp6QXg0dkRweThUOTR6YTRXMkNHc3h5YzQwdngv?= =?utf-8?B?Y2FhaVBYVHZLUVR5L0p4ZVFBYkhwWVYwWGJabjhtbEhSS20wOEZ3WTc5Y2M0?= =?utf-8?B?MGVCeElYaHdzVEdEVTRqSG50alcvTXhOQkNKUnJWVGh1MnpVQ01rOTVsRnpY?= =?utf-8?B?M2ZsSUdveFN4RnRDbnlMYXB4dnZWOS81OXUvS3QrSjg3TWZZQmtSWnFmOXlB?= =?utf-8?B?YUdkYlBocnVNWHpaRE1ETTAwZVg3VjcwRS81Z1dpZk5CSXdiNisvZUdMRjlr?= =?utf-8?B?Y0wrM3dweGQySU9wa1hTSEFvR01zUjdUeitqNGwzcW0wVHlQWkZ3TURXYTQx?= =?utf-8?B?cEdnWGluS2V0dndKeGJ3eEd3bWZwUk1YeWtWMU5xb0h5REtQZC96Wm9YM21k?= =?utf-8?B?TW1TL0NaNVNwVE5vVDNYcVB0SDNxQVVqMVd3VEc5dzlnb1lldFA3SGNMTmQ3?= =?utf-8?B?Q1oyZG9aTEdTRG9LV21kRFpYeFQwWlNtQUNtMGlPVVd4ekhXa2FGRURCRTRo?= =?utf-8?B?QXNQVlNmTnJMM3NlaDlYVmk3Vm9iSjZzTTNEMWJyVERrcUh2ZDRqZFBUSm1Q?= =?utf-8?B?ZGw1S2NuMHpjWk93UEppTlRXbmJGcUZxeVdaZkgwQ3VlYnZ6Ny85WmliQVZL?= =?utf-8?B?TWxCdzFFanI3anZ6TWUva0FVVmtNZEdzRWdWa2p2OXB4L1l2VXJIeW0xNGpQ?= =?utf-8?B?b0s3dlJNSk0wMVF2MDd3VUt0SVNzbEFlejFhc2J2QU9yWXJIZE9YS0l5eitI?= =?utf-8?B?T21DL2NxcU95NEdrZWlMbjl3U2pJMHh0TVBmdnh4Qk5pOExsb3pGeEJsL3ps?= =?utf-8?B?S1RLamhmK2VTTm5vY24vcnJMRmVuZXp0ZG9IWjhpcVNIdHJHSEI0WHB1RCtC?= =?utf-8?B?d1VmOE43VXNRcDZERzhkYlpwR3JuVG9GUUYraFpicUUrZ1JDdWxVaklxd2Jx?= =?utf-8?B?NkNraW9RclVCRDdiOGw3MTJET1ViNWYyVkdqU3o4T2t2MlZSR1puZ2RRYWVT?= =?utf-8?B?QkhRcG9MYUdnL3Y4RVB4WWVEZUx5S016c2l0WnI4TDUvNzA1MVRKY2dsOFJt?= =?utf-8?B?UUJEMXk1UHN5RlorTWNrS3hVeDArdnhNdytMd1poSHdFTGtxOFZzMFc3SkNy?= =?utf-8?B?VloxMk42eUxzbU1OY1hLTUpZdFBOQ1RNeFN5c3hjSTJVTFRMYlBpWjErWitr?= =?utf-8?B?UUtPYXppOWtucDRINTBZb3JmM1U5TDE2Y09yejlXN0JCMjZtZVlHbzlab1FE?= =?utf-8?B?d2VRTDFqb0g0ajhmOGNsYkUxcXFGNGhPQno0NUdrZVF3R1R1UUZZVzUwd0JB?= =?utf-8?B?TGFZT2trQ3VsZmNDT1lSRUxQTWVLdnVIK1N4amRTNCt6K2xwL3dBRWtDcXlN?= =?utf-8?B?a3p6MHNoMFFhQTRVaGdvSXNqOW9WN2kyaldlb0pteDFKcXM2ZHFjOWU2TitW?= =?utf-8?B?U1ZEM21KT2JkVDk3c3p4cE5WUUg2bzdrcm5uSlBQN1pRMWg0YjdIMHpwc1JE?= =?utf-8?B?aDY2b1R6TFduT3FpRUQxdVpRUkF0QUJwOEhnUFNKNVhuYWgxdVRramVWWjhH?= =?utf-8?B?cC9kRkFEcTR5eFNJc1pjZ2M3anh1QmFWdHBSY3FLRWQ2Z0diM043V2c2d2Zp?= =?utf-8?B?K0Q2cS83K3dBa09GZ1pGVGhVOGd5ZXo5Nk1zY1ZLaXZsUU1aOU5uWEdobHIx?= =?utf-8?B?SFFuRHlMQWhJWUpEZ1NPbUl3TXVXUnV3Ync5QW9sUU8xNnh4T2dubmh4UEgw?= =?utf-8?B?STRLdGpzTXR5NktPY1pjSUgzTGtJN2VKTFVIV3U3NXZURVFha1NnMG9oYXJN?= =?utf-8?B?blE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8d159d45-f08c-4d80-5977-08db14f3732c X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 16:40:04.7921 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uvr1lYDR8YE+u/UMiG4oqarjF+HTGjgZJkuDcS95fN+AaX7UX8z+Aa46Cs6QQZ7ndeFQFfaQFmaj1yRkg6KkqP53ydDvnDrn6HIGTTndJHU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5324 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Feb 20, 2023 at 11:13:45AM +0100, Juraj Linkeš wrote: > Thanks for the comments, Bruce. > > On Fri, Feb 17, 2023 at 6:26 PM Bruce Richardson > wrote: > > > > On Mon, Feb 13, 2023 at 04:28:36PM +0100, Juraj Linkeš wrote: > > > Add code needed to run the HelloWorld testcase which just runs the hello > > > world dpdk application. > > > > > > The patchset currently heavily refactors this original DTS code needed > > > to run the testcase: > > > * The whole architecture has been redone into more sensible class > > > hierarchy > > > * DPDK build on the System under Test > > > * DPDK eal args construction, app running and shutting down > > > * Optional SUT hugepage memory configuration > > > * Test runner > > > * Test results > > > * TestSuite class > > > * Test runner parts interfacing with TestSuite > > > * The HelloWorld testsuite itself > > > > > > * When running as root, things progressed further but I hit an error when > > DTS was trying to get the CPU config. No idea what is happening here, > > because running the same commands manually over ssh seemed to work fine. > > Below is the error. Any hints as to what is the problem appreciated. > > > > I remember running into the same issue as well. I think it's related > to the bracketed paste feature of some terminal emulators: > https://askubuntu.com/questions/662222/why-bracketed-paste-mode-is-enabled-sporadically-in-my-terminal-screen > Please try disabling it and see whether that helps. > I haven't gone to great lengths to harden this part of SSH > implementation as we'll be moving to Fabric (from pexpect) after this > patch (which uses a mature Python SSH implementation instead of > expect). > Adding things to my environment, e.g. bashrc didn't seem to work for me, but the following change fixed this particular error. Might be worth including in the code to avoid others hitting an issue? index d0863d8791..936d5f4642 100644 --- a/dts/framework/remote_session/remote/ssh_session.py +++ b/dts/framework/remote_session/remote/ssh_session.py @@ -68,6 +68,7 @@ def _connect(self) -> None: self.send_expect("stty -echo", "#") self.send_expect("stty columns 1000", "#") + self.send_expect("bind 'set enable-bracketed-paste off'", "#") except Exception as e: self._logger.error(RED(str(e))) if getattr(self, "port", None): Unfortunately, things still aren't running correctly for me. The code gets copied over and builds, and then the first hello-world test case runs ok. However, things don't work after that - something seems wrong with the lcore detection or filtering logic on my system. File "/home/bruce/dpdk.org/dts/framework/testbed_model/hw/cpu.py", line 206, in _filter_cores raise ValueError( ValueError: The amount of logical cores per core to use (1) exceeds the actual amount present. Is hyperthreading enabled? To the suggestion on hyperthreading, I then checked, and yes, I have HT enabled on the system. Any suggestions what is wrong? BTW: suggest the following changes to the error message: * s/amount/number/ - as cores are countable. * "Is hyperthreading enabled?" -> "This test requires SMT/hyperthreading be enabled". By asking if it's enabled, you don't make it clear whether it should be enabled or not. Since I had it enabled, the question implied to me that it should be disabled. It's only on reading the code I see the comment that it is meant to be enabled. /Bruce