From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C21E41D4F; Thu, 23 Feb 2023 10:45:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EEF7243150; Thu, 23 Feb 2023 10:45:19 +0100 (CET) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id EC7E0427E9 for ; Thu, 23 Feb 2023 10:45:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677145518; x=1708681518; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=S/mBkLsjE5yHNI30D33upa31Uq+5jjch3JTolKj1xb8=; b=mbjNlD0wPKAnvYxR/cjf8uqygc/pM1sbOkCTvS7EpMChSDyIz95MHOi8 cKF1OLaPAy6yDpZSGXt1pXHE03PO8gBzLLlGQxh/+N1lt1DQHxncl9wHY W4kyPRmBqzOmfv7kmxL82xRAr2oI5MgG6iuVVk46BR6canoOLwyGHMO8Y hqZ+xfUYFf2QpJe0Ng7JIYp2rosCCxC+1BcM37CI00bpA3VQajI6hLIr/ 0SuIK5iZBBnFUlNzcNkOAXvIBndJ+Mow7wXajA0UthBGOvSCfs0gGuhuQ sV5vHcLRogLgsspEMbnQUwLrX77A97+aLfmUNnOy8Zjqfmyicj9Tafh1/ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10629"; a="395648799" X-IronPort-AV: E=Sophos;i="5.97,320,1669104000"; d="scan'208";a="395648799" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2023 01:44:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10629"; a="796235747" X-IronPort-AV: E=Sophos;i="5.97,320,1669104000"; d="scan'208";a="796235747" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 23 Feb 2023 01:44:57 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 23 Feb 2023 01:44:53 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 23 Feb 2023 01:44:53 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.170) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 23 Feb 2023 01:44:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gIFvJcVV5AK5ynXNgohAHevFjaqlsw0PRolWYGA4DkXPB9pvEV6FFDMfse3cA/4YswPkcIcD4a8dydElh0FqANkSyTn3ExLrsX39gAWv6/ppsnxayX3SEV8nas7DOmOKHOf5DDr4298Lv3VnUB10uVskxhWQTtoqlMUK82cDa3RtVSHvTM2mdHm73ibt4jmb2QGmrkWRwAUYGoWf3fob6kf8CuZfBin3ADO5XIhf+erR5KKW3Tea2gzIKgiKJjJpgl2CvnZy5QXMnKBChpM/wAv9dZypKTGNokLmrecj9tJFJflTs05+vI12lDgAtCuRLYVBYO0l8PLm6U7XzSFZBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MxqMZ2lopKe5KpRWbJlbCc8pHSPgpPsrqh4p09F2ay4=; b=nTYefi5c7mjfzUYZ29R+t/Jqa8DCW26Z6RoFm2lkt33xNY/2LCanxUt2KGurO9yPu5raA+Z4wx5kXP73vmyT9Zo0zID7Amyn1Ahbvej06WSga4VK5BozeGrRWN7qhbEfqkZSK7iPDmXt17rUX+4HdKETOjUuZU5QVaUYP/H/aRzkyAcaaxq3nay/ng3AVgfcYImG00X1NuPgZIWH8w7TLQXAim+aDxUpCM6EgoaPCXCGzQy23wOeZZje+crHwDHKhBQpIyKrAJVfWOejZ6vokS8eTpp9FyA/gJSPhB2+scdf74MRdv27VbBhPKQeKowm4eHi1ecIc6ezkmXThNccIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MN2PR11MB4517.namprd11.prod.outlook.com (2603:10b6:208:24e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.21; Thu, 23 Feb 2023 09:44:51 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::18d0:ac53:aa1d:d19c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::18d0:ac53:aa1d:d19c%6]) with mapi id 15.20.6134.019; Thu, 23 Feb 2023 09:44:51 +0000 Date: Thu, 23 Feb 2023 09:44:45 +0000 From: Bruce Richardson To: Tyler Retzlaff CC: , , , Subject: Re: [RFC PATCH 0/1] Specify C-standard requirement for DPDK builds Message-ID: References: <20230112113556.47485-1-bruce.richardson@intel.com> <20230222185344.GB2702@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230222185344.GB2702@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-ClientProxiedBy: LO2P265CA0352.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::28) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MN2PR11MB4517:EE_ X-MS-Office365-Filtering-Correlation-Id: 6acfc6c8-0ee2-4b5b-f67e-08db15829bde X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CkWzENnbEdEz/1dTMj64uivRnA9cxZ/XvUMa598Lj+WHnpEIVT28UhSWXbv6Qh4vhHX1b7gnkwMQBItlWw17tl/NlSrGBvqWJqfJy8X7H+90qqkgZxsnthAMYJQs0NNhcqf8DugmBFz9A8hLEUKQE6ix6kww0rLLTw+/QsyXPSdJPG/Tbm9JRSDz7ZK6y+TguZ6slNJiX8sLVPeaSMfzRtLdGGINunRVNVyNy4Vl5lfwETs+A72Q1DsrKtcSoO7lBcvg5g2gY0hFtWafTFxdJ4ZIJ4+ul1LSCtk+xfso9GdIORWgBEnj11hfliNbGOjhY8oTajVXzCvtYbHI0qx3/UKB9rOHGX2ZaB6BuRkQ2br261o9VkWGnNGYGR8eUc+075EEXbN3XhqhiAsakdRylGWfyk0pes+25qwuHQfLey++/bC4JaqntyD6RqtpqHatqy9IbU1sTDWnoUGRe0YO3ZEjiOAELVzEcO3aP82+crnigA7Weu9eFsFKhiLdot1HNYBum7yANqT5+p4OjjssgBFFegcdVdDhAfESJe9+mmSJPok/7OR25j/orNwnfl17KU1VeI2kp+g6nbn5qJna9FsDMZR806Z+pgd7l1dgw3xMovIkd3ca6RZnQTMBpDH1bjMumXqIzACkLzqjOP02/g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(396003)(376002)(366004)(346002)(39860400002)(451199018)(6486002)(8676002)(44832011)(5660300002)(8936002)(41300700001)(83380400001)(2906002)(66476007)(66556008)(66946007)(6666004)(6512007)(6506007)(4326008)(26005)(6916009)(186003)(478600001)(316002)(38100700002)(82960400001)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?d3IGOWqDtefsHsUaWCWdGK1XAhM4zuvxuc8y1Kr6zdsNDHm9tTfAznBKf5X+?= =?us-ascii?Q?7zlZcgfDULlooAu2b0XokFvSS5sMI3HYDrDwruI1PD5bnqyGSfegsDNi2rES?= =?us-ascii?Q?ghnDctqMlcXQa0G2WpxXYA/4cLaPMRn5VClaOw9AkVp+j7WrjhlsD68B+8Fi?= =?us-ascii?Q?MBgwZRP3n9xdYARBJ3sT3szGmoV/EnYGRUTKoiEi4y4zXg5qKtQVVlR712FE?= =?us-ascii?Q?ICOdXXl+Cptwbjh6An06fcmued1izBY+OS8Czb4dvZRXRSB+8ZnAx6DbbLEe?= =?us-ascii?Q?X5a0r+6T8pqYCtko8Bu33qGqEm66KW4ztTYAPawBA59n9OLQqcGiuxButvm/?= =?us-ascii?Q?yQ9voGUKPoaXQZKB3FP8WfyfYxMjLQ521gZjOOm1GMJjbZKgLFUz3jxaN0td?= =?us-ascii?Q?kyZiZpUVOUIUE1/ZQls0ZnN2ISrVgH2mzAZB3wJhMe7Md5cyDNBcx0PaPFlI?= =?us-ascii?Q?Y44JiMEkzCiwURzxZopsfXE3w/WMXckzng1oaaPF20GQYamrffADjVvY2dJo?= =?us-ascii?Q?jhPf/cad+SolJ0QC3kd26XVfsKnVnZ5PYn2trXQVygnMIB767SGntaq/12cY?= =?us-ascii?Q?GKrYjP752drPn+6yUgCTha5Mb5baVboUlexHV+P5j0iJti+nY792b1YHbMHQ?= =?us-ascii?Q?peyf5t+vrot6YOSEvnddTPQ3yedmgjEhzTjwxciu1ictJIcKFz6Ea5KscpLz?= =?us-ascii?Q?n8ttxf7+LxZLtgS1XHSGE28RXUHMrCkE4NmusG2Vl2Zg4+7Q9jWKVYE5pyNy?= =?us-ascii?Q?kZv3xvWybwsPnfL0Q5kUFOA1p6zKvB3nUP6k4iiqcI8Zi1FRBwYMjYIHA68t?= =?us-ascii?Q?Y3r03q2h2x8XbCJs1xh4UvhiINDzGP1S73VssQCU3VBchJw78eZse2NdBCV/?= =?us-ascii?Q?r105vOnmIwOmdikmmuYLzvLIl55vOHAIzlVqRbHuxaeSLlZGMdDczLuM7LoD?= =?us-ascii?Q?a84MNNYC7Jb4217dISdxikP83jcesvEt070u3GQjfuxvpMDNidUhQYSiXubV?= =?us-ascii?Q?OQskV/PPwEohruDgxBR//GCo0vEkSiYLNyC71lh04piZcPmIf4rJgtFwyqNG?= =?us-ascii?Q?Zxfv+B35Aq3lCT0Kisx+/3WwppaZlKgP5nL6Jgsh1rsIR19jIC0qGV5fq/eV?= =?us-ascii?Q?X2DTFoGiNrNQjBU9JLWDIRc3nyzykauhy8bCW02S+LwDWvUadQ/OKhyaGKcK?= =?us-ascii?Q?BKdobOB2Yx/Md4Jzx4gjo4k3X2+TLOageB+7ObE4RuViLDB1gShpSIZ4Yddc?= =?us-ascii?Q?+adu6IAvoe6tja0FWX9nh7NzFR6PfFuE7PSHvQ38/037zIEzWQi3OX22mzye?= =?us-ascii?Q?Vhlsw9toaYrmIMbuSYnXLLqZ+esXneH0Cye1EqTBDMFInOJeyKZ6tRuX+UI3?= =?us-ascii?Q?NpnYwZQb2CaP0jF3tcmeTd6ne9d3Bdes/t52S+D9HQ4YtHd3i7x8Q+GVetDk?= =?us-ascii?Q?v45yeVnRK0cLYVyCmT+TcSLpLPgnv6cWoMzF+7q/v64vkpAa+JQ51F2kLw4G?= =?us-ascii?Q?VE0EnkVTTs5D3/lO08zIgK+Q4ip4BI8vLbWEgeMoLkCky1HPReW4uIrW2P6L?= =?us-ascii?Q?4ASF3JvOwuhyjI2syX8ESGARs7Kcm+4ueP+jj0acCHAQjymQD+DZU0fhUMGg?= =?us-ascii?Q?fA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6acfc6c8-0ee2-4b5b-f67e-08db15829bde X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2023 09:44:51.0726 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xBU9JX60/lwizIYL7hGjZg91mYilaT5gURvuPrntd0q5OtbLVIU7uJcwGSRvS204ebJxzx/n35W37KrndntZWK8G/jT30d6ScYesSt2YPLg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4517 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Feb 22, 2023 at 10:53:44AM -0800, Tyler Retzlaff wrote: > On Thu, Jan 12, 2023 at 11:35:55AM +0000, Bruce Richardson wrote: > > Traditionally, DPDK has never specified a minimum C standard used either > > in DPDK builds or for applications using DPDK. Following discussion > > on-list about C standards, this RFC attempts to start the process of > > codifying what our standards expectations are. No code changes are made > > by this RFC, instead only the build parameters are changed to explicitly > > specify: > > > > * C99 standard is used to build DPDK itself. This is supported by all > > supported compiler versions of GCC and Clang. > > * The headers are checked for compatibility with gcc89 standard, which > > was the default standard used by the oldest supported version of GCC. > > DPDK headers do not build with the official C89 standard, and, to the > > best of my knowledge, have never done so. > > subject to the technical board meeting 2023/02/22 in relation to atomics > and adoption of C11 starting in 23.11 does anything stop us from > conditionally enabling/defaulting -std=C11 for all platforms immediately > except for RHEL/CentOS 7? > > so long as we don't actually start using C11 features we should be able > to do this? or would we be worried that C11 feature use would creep in? > > just curious. > Actually, if we don't do anything, the versions of gcc (and clang AFAIK) already default to C11 or later from GCC 5 onwards. If we were to specify a version, I think it would have to be gnu11 as we may still be using some GCC extensions. However, feel free to do up a patch for c11 if it works. The change to the header checks probably don't need to be included, only a change to the default options in the top-level meson.build file. Incidentally, even though it is missing support for the c11 atomics, gcc 4.8.5 on RHEL 7 does have the -std=c11 flag that can be used, so adding that shouldn't break anything. /Bruce