From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D318241D4F; Thu, 23 Feb 2023 10:17:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7CD94310B; Thu, 23 Feb 2023 10:17:33 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id A4D41427E9 for ; Thu, 23 Feb 2023 10:17:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677143851; x=1708679851; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=as6ZP7XFHlS/tcJPvsmt34A8vjkyVgI5UE5rwWGwMec=; b=Y/P6EXXSPoeoNqTsN0CYR7bvfPXUuD7lQIgERL9Cc0SziT64vrChLFA5 ouLsxMi5nFmnzKkvjmaeilOfUS1aryhEXpaJf6vNzL6CXzWsee7U0v5Oy v1fr29Goe8SlYd9pW+LdhhSEnY8shXyoutcmxEaqzrw3p0RD46OC4ywMP Qce7PNPJjStf5MJPBpQU2B2lC1JVTZgpbnQZy9yqQnSce7LvVYGr5hPiJ XoMj/9VACctvDGI5Gikem2OEFA8NsIbqv+BVS1AGcKDDRM7WIqSLqHy2H GbKUXfIe5noZjM6gW4C8EZnvPJgLzk9flWKvjBi/NQJ2ohUf8MrxQf/AK g==; X-IronPort-AV: E=McAfee;i="6500,9779,10629"; a="331829110" X-IronPort-AV: E=Sophos;i="5.97,320,1669104000"; d="scan'208";a="331829110" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2023 01:17:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10629"; a="815258523" X-IronPort-AV: E=Sophos;i="5.97,320,1669104000"; d="scan'208";a="815258523" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 23 Feb 2023 01:17:29 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 23 Feb 2023 01:17:28 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 23 Feb 2023 01:17:28 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 23 Feb 2023 01:17:28 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 23 Feb 2023 01:17:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IEUSpMGgNhJRlE+LnYupdftzbZvwb//w1Fzn88kUNy3vAuBFoZ5pr7Yf/SKTnwlbsvb08zlbIpse1FW0Af9k9YEX3y7IvVIUEkNVDtRMHIK/PKbUjqpcpJ5MR8AN6/WHsCteYYB3SYRGAPgpHQD49wiITNmrq8SeZTTnfLh9dyBVq2DvZ9omGSCEB43Pmfh7WO7qFZo7qhljA9pTKGhe1ps46h9FWcGmbW5Umueq9UT01lCI/JDD9kYodFECMNE+VGPpGqAYC7XDL7wYyjsOuAvQe5iRm99o3Bw4JC2sV6yF+/kYyQOeEid8lVjpCJTlpOjR7OyaUm20GcdK7Ei7Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XLsKHE1vnJEHsbnrcjJyUX6wAmF64RWb3kXoP/1Fgq0=; b=OTWvnASXUZ1RqXLgAiMgHdhuTbi062cy8vn28ayDZd3hOLT1BB2ABJn9kxWB9ggaBlIGqVyTBQ4grAYs9gEE53ODzeTUgHYQpg98/GRQfWPtpMa4yQkd4EJiSFMfLQk8+JH3Rwt/8lkHkYRdgtvL+xvn15AHY5R71fQAl2qauvkh5n7mocelQeBtb5+Zio5jxjdwwx0vhZogkixmOifpQlqx77kN43PCeh401pF/uaHgxNWZsMIsy6Kid1rX1MW3J/79hMBV+NIXRePXz1AWyZpfzBbXKWMf0/mMTj/nL80na4KBFkTAhLVbpEKM3pT5lWUEj5dPqOqrYszhhsG6rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA1PR11MB5947.namprd11.prod.outlook.com (2603:10b6:806:23b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.21; Thu, 23 Feb 2023 09:17:26 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::18d0:ac53:aa1d:d19c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::18d0:ac53:aa1d:d19c%6]) with mapi id 15.20.6134.019; Thu, 23 Feb 2023 09:17:26 +0000 Date: Thu, 23 Feb 2023 09:17:19 +0000 From: Bruce Richardson To: Juraj =?utf-8?Q?Linke=C5=A1?= CC: , , , , , , Subject: Re: [PATCH v4 00/10] dts: add hello world testcase Message-ID: References: <20230117154906.860916-1-juraj.linkes@pantheon.tech> <20230213152846.284191-1-juraj.linkes@pantheon.tech> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0104.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::19) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA1PR11MB5947:EE_ X-MS-Office365-Filtering-Correlation-Id: e4d7b4e5-a271-4dcb-69d0-08db157ec780 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Afhn0Y7J8TRVqsKsjdQbIIUcRUPMbAD9u2LMb+E6mpleS2P/KV7NNYbo3ycsQpprmve93E5FwIwnAZ55b2HZVSvRzA9TfvkAw5shruVF2aFhW6eAgCzYQCwCJb74HrYWQv07KlS5+oJJzQEXqz1ZhWQBPciMQehDOqFtcL2rbP27IvBfHo8fz993YJ8/yIHIbJGlxhBq5KZSK/nzlA5a6iZinme9aH3XlvGm2Gy46+/9YPgvYxqeKP/4K2X6Da8EQMx9E8EGBGeZo5mUWwntPTEya8VoBcmRpfOqgBEYjCM+rnzlImHxEWmnXkpnviXU/epS+E7MjkXi0+OKSqkBYIvxh62jKfrsxFoJsQApx2Hiqaq5Nrb+2e1YjsynLBzGupDOtK4SRIz4vIJPCBULDcs8B16QbPeZq8/i60pqVIQFnb995X1eoBULskrquHSuOKa7gGkOAc575H/OVXV37s7mNX9w71loPksXmsTw2SL4V5eU4raJukoXroVplhsLBtOOM93mCUpy9u4QqvwfhC3/woMLKSyfzbtnq5SP5XzlkshIioOmfcoBT0QHccULfNxvHHCcJI41PRz5X77OsMyOsIkJ5qclbUV3EePMV2JhZdyyOo4L9hCRV1CYC23x X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(366004)(136003)(346002)(396003)(39860400002)(376002)(451199018)(66946007)(66556008)(66476007)(83380400001)(316002)(8676002)(8936002)(5660300002)(6916009)(4326008)(41300700001)(6506007)(6512007)(6666004)(53546011)(26005)(186003)(478600001)(966005)(6486002)(86362001)(2906002)(82960400001)(44832011)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjBqTDZocFJOTy9MVTJzL2I2K1ptamU0UEpTcDRLTS8rUEJmNFlSU25STjRX?= =?utf-8?B?ZHlHWkJoL3dQM1BLdjJndnZrVm9NNzBHY2w4ejFWT1Z5M3p4UU1DY2cxdmg3?= =?utf-8?B?eHBVcWMxbUhCMjlhNlpGemg3OWhNb2RQMm5oZ05RQUQrRzdlSm5FTDZQUHNT?= =?utf-8?B?TDdwNi9jNkY5Z2oxU0Vma2dsRGY4Znlyb1owdDVWaFBXUkgwMmRnbnMyc2k4?= =?utf-8?B?cVNHZ0lMcGIzSXVXWmg4NG1MVlJod0lzblRwd0NnbkVoeU0zcURpRnBBclox?= =?utf-8?B?VHRhUUpIWjhKOXJjK3NHckw3S2ZJZkZLTG9XTTRPQ2VRcEJrWXR0dHdmZUky?= =?utf-8?B?UXZnbTEzODZtOVlUUHc1TW95ZTZGSjdGbTJZTkJvZUlJbWNOd3NRbTQyc25U?= =?utf-8?B?YnhudHhSRUxwK3RMd0lMeDJGL24rSElrUmZZbTluY1R3RmZISkdhMWJVQU5x?= =?utf-8?B?RlU3ZjBaY0pEclNxVlZBejZ2ZnhvTSthM0lIbE5DRDFNZmx2UFFQVDRlUHJX?= =?utf-8?B?YVNRZTlVN0xnM3lGOUg5dkpPSGgrK3MzREg3WGcxc0FTQmhnZithdlFVRUtO?= =?utf-8?B?YXRmSHMvQlF2SURMMHY1WDhnMlJDcGowcWxmVW1MNmdPRlhpbWdtOFBrR0VQ?= =?utf-8?B?TXlHL3N6Z05FS0hhWVprMXJ0Y1IzcFhCMTYrU2tjWm9tMndud1NrRnNDMnhV?= =?utf-8?B?THZOdHFZWW8zbGMvUE9SRG1Ld0tET092NktUK2trdU9SdjdMTlM1dDlxZHhr?= =?utf-8?B?YkYvSCtDeldkY3YvbG5MclU0NG5WdWRYK2Rac1htSFYxeml0bFczbUp0N1Bs?= =?utf-8?B?cTFLWjZzSG9ud0g2K1A3OXpSUlRJVFNSaXlCckV5bTdlK0FwNVF1dklwaFdm?= =?utf-8?B?eU1vUDJpdWVialZPaUxsM1FGdEFsU3hMdjBxNjlQK0tXTUswRTJrRGhSVVJH?= =?utf-8?B?SzdvQ3Z2c1N0RU5UTldycEZpR2tLcFR4MDl2WURXZ0lpN252U2FjOHY5ZE1B?= =?utf-8?B?ZWZ2UEFydWxvek1HUnVMV0JvRDlpMkRPK2ZzUUZlazRQcUFXdXEwK09jTzFn?= =?utf-8?B?UXFNYmJlTUJRZjY4ZnVoSVVTbnIyTVVxMXJpWnlqZitrY0lzaENnL2ZRMlg0?= =?utf-8?B?Y3ZSclMya1paRklveUFYTWxndUtwSjZUc29iMXNIZ3VSRFNGamJqQmNBcndL?= =?utf-8?B?bVpTZVNOUWxEdEFmR1paVHdXdUl0MStHcDVaVVJyaGtwN0xadVNsVy8xYktR?= =?utf-8?B?VXZmVU85MGxtTDVkcVdFUU1OTWQ1WnF6UzB0Zi90VzByRHVuT3I4b2I5YWJJ?= =?utf-8?B?ZzY1bGFtbitranRZNEh5WTRhRTJQcWtOZHhFOXplTVRDM0grR29ydW81Y212?= =?utf-8?B?engxb05Pdm1uMnlqTDdXU1hnbitKeFJQN0pSOGpVRVdkckdzOGFGdTZLV3N5?= =?utf-8?B?Q3AxK2JCN3dqdk5IbkJ1cnVaVmRUKzBlNTloOThkamlPVmxpd2JuRHM0OGhI?= =?utf-8?B?YWZUS21VNGdQVFBMaVIrcWEzNERtcmxuVVl3UDc3bUFnQmZaWmNMSHVhRUVN?= =?utf-8?B?OXVzV05qcWFZYkVwOGNraXQ3eDZmM0RRZ09kWFNDTnl3VHI1UUh3b2taZ2F1?= =?utf-8?B?Nk8xS2JZYzRmSW9sMVowRE5CMXdDZ3RXNVVycWc3RmpKcU93UVdUVzFaNCtE?= =?utf-8?B?N0I1eWJKeFA0MUh3amNnNEg1cVBqazBub2l5dGVUS2xEUjhzZXlsVFByL0lu?= =?utf-8?B?Q3UxNUJucVoycXJkUlQ3MUNiTlJ2c3dMK2FnTVFRa0xvdjJzU3ZKN1hzVG8x?= =?utf-8?B?cXJBQ1daSmFtVlF0czUxMnZraWE2V0M2Q3J2emRZZkFCWmh3UVRnd0VYd3Fn?= =?utf-8?B?SFJiRytuY2MvMzZSaklNQXlJaU0yNFhXYUtQV09jMElFSEdQVTZMVWlIU0V6?= =?utf-8?B?Rk1VZTBLd2dVUkpIYzRYTTI2WFlvSi9kY2xWZ2tKS1J0K3o5UWlGR3pMKzZS?= =?utf-8?B?aHZLRk5RZTZBZDNiTGoyRXJ2b2VlTlpVeHFlSnhTZ1ArZUJ0Y1VQN2szSzIz?= =?utf-8?B?RXdEbFVSamJYYWc5UXJOWmVwUDVGZm02dkx5dnordG1JY0U4MGl0ajVqSlhz?= =?utf-8?B?UXVlR3QxSVcwZ242WDVqWnQ3NU9vZndsSkE2OVRYenI2d1BoVjBCc2ZWSGZT?= =?utf-8?B?K0E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: e4d7b4e5-a271-4dcb-69d0-08db157ec780 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2023 09:17:26.3014 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LZwZpE27K068w1LJ12wp1B5TRaKuJfroE9C8gfB1jmwYELKaSltNoVA9kd77A1RIWwvSQFYs3P2FX4lG299Cn/KClzqfq9QrMKji1AxddF4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5947 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 23, 2023 at 09:27:05AM +0100, Juraj Linkeš wrote: > On Wed, Feb 22, 2023 at 5:43 PM Bruce Richardson > wrote: > > > > On Mon, Feb 20, 2023 at 11:13:45AM +0100, Juraj Linkeš wrote: > > > Thanks for the comments, Bruce. > > > > > > On Fri, Feb 17, 2023 at 6:26 PM Bruce Richardson > > > wrote: > > > > > > > > On Mon, Feb 13, 2023 at 04:28:36PM +0100, Juraj Linkeš wrote: > > > > > Add code needed to run the HelloWorld testcase which just runs the hello > > > > > world dpdk application. > > > > > > > > > > The patchset currently heavily refactors this original DTS code needed > > > > > to run the testcase: > > > > > * The whole architecture has been redone into more sensible class > > > > > hierarchy > > > > > * DPDK build on the System under Test > > > > > * DPDK eal args construction, app running and shutting down > > > > > * Optional SUT hugepage memory configuration > > > > > * Test runner > > > > > * Test results > > > > > * TestSuite class > > > > > * Test runner parts interfacing with TestSuite > > > > > * The HelloWorld testsuite itself > > > > > > > > > > > > > > * When running as root, things progressed further but I hit an error when > > > > DTS was trying to get the CPU config. No idea what is happening here, > > > > because running the same commands manually over ssh seemed to work fine. > > > > Below is the error. Any hints as to what is the problem appreciated. > > > > > > > > > > I remember running into the same issue as well. I think it's related > > > to the bracketed paste feature of some terminal emulators: > > > https://askubuntu.com/questions/662222/why-bracketed-paste-mode-is-enabled-sporadically-in-my-terminal-screen > > > Please try disabling it and see whether that helps. > > > I haven't gone to great lengths to harden this part of SSH > > > implementation as we'll be moving to Fabric (from pexpect) after this > > > patch (which uses a mature Python SSH implementation instead of > > > expect). > > > > > > > Adding things to my environment, e.g. bashrc didn't seem to work for me, > > but the following change fixed this particular error. Might be worth > > including in the code to avoid others hitting an issue? > > I didn't really want to modify the code that's about to be replaced, > but this is a small and bening change, so I don't mind. > > > > > index d0863d8791..936d5f4642 100644 > > --- a/dts/framework/remote_session/remote/ssh_session.py > > +++ b/dts/framework/remote_session/remote/ssh_session.py > > @@ -68,6 +68,7 @@ def _connect(self) -> None: > > > > self.send_expect("stty -echo", "#") > > self.send_expect("stty columns 1000", "#") > > + self.send_expect("bind 'set enable-bracketed-paste off'", "#") > > except Exception as e: > > self._logger.error(RED(str(e))) > > if getattr(self, "port", None): > > > > Unfortunately, things still aren't running correctly for me. The code gets > > copied over and builds, and then the first hello-world test case runs ok. > > However, things don't work after that - something seems wrong with the > > lcore detection or filtering logic on my system. > > > > File "/home/bruce/dpdk.org/dts/framework/testbed_model/hw/cpu.py", line 206, in _filter_cores > > raise ValueError( > > ValueError: The amount of logical cores per core to use (1) exceeds the actual amount present. Is hyperthreading enabled? > > > > To the suggestion on hyperthreading, I then checked, and yes, I have HT > > enabled on the system. Any suggestions what is wrong? > > Interesting. The first test case runs hello world on all cores > specified in conf.yaml (or all system cores if lcores is empty). > The second one tries to run it on just one core and, interestingly, > that fails. It's definitely related to hyperthreading, which I've > tested a bit (or I thought so), but apparently missed something. > > Looking at the code, there's something wrong when checking the number > of lcores per core (with hyperthreading, more than 1 core per core > could be present) requested by filter (in this case, the test case > supplies the filter) and the lcores on the system. > > I'll try to fix it and send v5 right away. If the fix doesn't work, we > could look at what "lscpu -p=CPU,CORE,SOCKET,NODE | grep -v #" returns > on your system. It's also captured in dts/output/suite.log. The lcore > config in conf.yaml could also be relevant, but I assume you didn't > change that. We could also check the test case output. It's also in > dts/output/suite.log > > > > > BTW: suggest the following changes to the error message: > > * s/amount/number/ - as cores are countable. > > Thanks. I've used it inappropriately in a number of places. > > > * "Is hyperthreading enabled?" -> "This test requires SMT/hyperthreading be > > enabled". By asking if it's enabled, you don't make it clear whether it > > should be enabled or not. Since I had it enabled, the question implied to > > me that it should be disabled. It's only on reading the code I see the comment > > that it is meant to be enabled. > > I see where the confusion is. The question is just a mere suggestion > as to where the problem could be, but the logic in code is faulty, > leading to this unclear error message. I'll fix the logic and probably > modify the message so it makes more sense. > Thanks, if you do a new version I'm happy enough to retest today. /Bruce