From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E90B41CC1; Fri, 17 Feb 2023 18:26:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CCD5640F18; Fri, 17 Feb 2023 18:26:55 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 84B1F40EE3 for ; Fri, 17 Feb 2023 18:26:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676654814; x=1708190814; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=GLSSoMfvhXVlvPIp1rzkHk0sfTrkxdVY3Fb8rWTEJ/U=; b=b34e6m4xs1BHlNjR3TyVIZVRsRIZ+NNReKKpQ6JkN5w2lf/2PC02F/D7 /3Uis8wnlWz6zrHvRrFUhEBntarbFbSjRjxUYmyEAzaNqycVFuJU52UO6 VwrcVIEoL+d5fIAJzn/4yId8kmA1OibkP2wuMbJEQ0x4jJu3xiy/TsHfT 5+A4DciwbQUjoOvIbR3g25Mwzxo/hDOs0hDeYHyQBajpSn4XjVV7KzGCl g7wHp7qckmy2LkHCajHaJSU6qNa3RBq568yRBdgRhsyOETUAtjRXCZvQf po2W9/vbjIHC+CWwW7EZoQcSMORvLUX1Y3xO6sc08T8moGEswnMgjVODl g==; X-IronPort-AV: E=McAfee;i="6500,9779,10624"; a="333396043" X-IronPort-AV: E=Sophos;i="5.97,306,1669104000"; d="scan'208";a="333396043" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2023 09:26:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10624"; a="844644788" X-IronPort-AV: E=Sophos;i="5.97,306,1669104000"; d="scan'208";a="844644788" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 17 Feb 2023 09:26:53 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 17 Feb 2023 09:26:52 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 17 Feb 2023 09:26:52 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 17 Feb 2023 09:26:52 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Fri, 17 Feb 2023 09:26:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i7wWBCdZ0QuF1Hcr9fDm1yEu3vaZw49Kp0ycepFxneXtrGurEQIkwl9u2xWeBrdzfoZQVxKM+k9ZZwQ5KgE+3Uymil85inuAMmHioyv79gRJhH0xIeNPEkmqV4oQgGqAi3o0FWc8gjZC8AYaxBbDxRIpDEE6OfTiCT22HHw9+qvEis2D/zhW1vJybtWZb3bKwSa21K05UdDfgG5v+wsCqJEu6+1aLCx84Qe26TLfzBCtZTOipwWJ3ivPG8fnzS097A6g0aAVTr0fMuC7Aue2YtPLArSEP/ga9sbM726j3QS1bqPEFq+XUDlKJqfUJo2elNxHmkOtRg8Cpw3aV79+/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iILrKqOvSj/xzOu9LL8gU58atLqIX2uM4ENcvBqvwsE=; b=nNs2299SlPQ7B3USD2bm4RcP7KlGJuCsNdSIr0DvcCp5PFB17yd1hMyf17d075Q8DeycH1Md66lrLZo4IIIFfzN5Nb1QqLokGNYxoGtsgO/6LXcxvn+DhX88LULuWA8wYTKgwsymsNt0uzqjcLJ6iAmI9D01BILXOKBr9UoO4NrYjYv+u0PFdvBOZvAdJ/Ne9EGjnojgdT9P4M1SvqZAs6pKjC20cmeE/NNEuh9250vaX04+VHxtynfRSqelcH3rrzQd8FnsT0f/h34dpvu2L58SPMkchN2EptlFRKhA9poFRbFPAITVEb/YKH0DJKreYlqGA9RaMu53FQ+65NSqbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by BL3PR11MB6386.namprd11.prod.outlook.com (2603:10b6:208:3b6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.17; Fri, 17 Feb 2023 17:26:50 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aaba:abb7:8794:def]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aaba:abb7:8794:def%9]) with mapi id 15.20.6111.013; Fri, 17 Feb 2023 17:26:49 +0000 Date: Fri, 17 Feb 2023 17:26:41 +0000 From: Bruce Richardson To: Juraj =?utf-8?Q?Linke=C5=A1?= CC: , , , , , , Subject: Re: [PATCH v4 00/10] dts: add hello world testcase Message-ID: References: <20230117154906.860916-1-juraj.linkes@pantheon.tech> <20230213152846.284191-1-juraj.linkes@pantheon.tech> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230213152846.284191-1-juraj.linkes@pantheon.tech> X-ClientProxiedBy: LO4P123CA0146.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::7) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|BL3PR11MB6386:EE_ X-MS-Office365-Filtering-Correlation-Id: e28bedec-3870-4da0-d8e8-08db110c271c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hO+OFty82syCu6jyzx8lN4tXt9uCRAphtWlHzl8djDp21p3+Zlt0EwUUUNHTVDo96G0/EVRWWYWHYTIf1p2DVl+ZHSBHFNKsxQHzG2R91ULv2YQ+FwJelqpkG16OphkPMoVj45cSonMGxrYAi+7zV61UHg6uo9uyxoqg/VbdbNoED3s/IJ+sikvnZN8eLGVxnCcGRnWW+lqqGrUe0TbKOlbrINFoTMt+Yz9W/LYtXWfWm4Tu+ozv5Krf5IEH5Nptw5q1bz0SoW5lKL3IAEHJVyYm/le9Wznood5E9NVlbP9YUv+aNpFFjJx4EOlcd6f9y3pQ2VMGwjcym0eExf2Fzd7V/JDacPh+c+OvjHk/ekFt3Wh/T44R9SgjoNVvvyJrJsLdeMmphZ7F7OeT7tXsExvO40x/AxlwNvGKeRKkcnc3gz1OGX2lFbKEHmcMXSQCIMG+7HioOHUnKfjyIrSC4y0qFOtZ4qyxSjrboVl/tkJcUYUiHgXXOjHz4tCxXGB62I9QkeV2VgQSAlaWyEUHE26LOQXm+ZxWYGKmOeQ7a435pFEu0H0Ctg6Zpc9HBgkpwe6yHYmTZrQPDeX8Fw0PcWe3v71t3mUKfMBUzoKLTuZCA2/P+BsBsTQ5nbdnUkWqLXq+cApfO/Y8CpDrEWVR0w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(346002)(39860400002)(136003)(366004)(376002)(396003)(451199018)(316002)(6486002)(8936002)(44832011)(5660300002)(2906002)(8676002)(4326008)(66556008)(66476007)(66946007)(6916009)(86362001)(41300700001)(83380400001)(38100700002)(82960400001)(6666004)(26005)(6506007)(6512007)(186003)(478600001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODhvWWM2NUVtV1d1K20wVXVQcTJiLzhoamJGbEtPVEsyZEdQdkthVVJLTmNM?= =?utf-8?B?ZytISGRUV0h0Wm5ma1MyeWFMQkhuL1dGcnNaYlg4RzZ1dXRkNDY1eEdNUk5p?= =?utf-8?B?cER6WVVLdzFIcXhiaG9pSnJOdTVuVU1iMW1wNjhYYk5lRmdLZCtYbUxkTDN1?= =?utf-8?B?RXZGU3l2b0pmdzA1RkhZeWNFaEJzaEdaaTY2ZzJIb1BoTU5QZ0dHLzYxVFdW?= =?utf-8?B?YWgzTGsrSDNqWHI4aUhmcWxtSFZVT2tDcHRRTGVzdVFKVTVkTXpvSjVYRVZ4?= =?utf-8?B?aFhDZ2hXdjRHd1hIV2NsVnFWcVZ2aFhqd2hRbVFTYnA2L0dTNk8raURKMDcx?= =?utf-8?B?cnVBdlJpeGM5RzV6MHk4YnBLOFZtZnRWc0JEVVQ2Z3JYd2xxOUpFOEEySW1i?= =?utf-8?B?RlZ6SktGRlIvbnFZekIyTWVWTGJ0VTVUU0lhdllQR3V1SFpITzhDWXozZDl0?= =?utf-8?B?SEpqd1dOdG5PRThyZzE2SEh4b25kQ0M1SFZ3cjYvZURiY0N1Q3RJRXVCQ3ZI?= =?utf-8?B?OGNNVDA3VGFuMEs4aDU2NVF4WkloSE45TkxZKzNmUFcyZk5oTzJmV25iaHBQ?= =?utf-8?B?VzNVc1N1MFBZY3QxcGZpdVZXZi9pSzRBVE5ZemphcXY0cW9nWVAydG5hVjhr?= =?utf-8?B?N2dQS2dzUSsyVnk4emJKdDJ0V0dkMVN5dkE1WGM0REVCOVQ5TmxwYnlxVTJP?= =?utf-8?B?ZldadnlBZkVFZnJnMDN4MDJZWThpelhhU1VKb2tsK055ellpdFNCSThlNldn?= =?utf-8?B?YUxtMWYwbnpFdjFtNUNDQ2ZOaGZIVnd2c2lVd0RoWVBMMTNWRjVETVQ4T1J4?= =?utf-8?B?MU1vQlZHSXN4WFNwbm1hc0tvb0gwTlB6MVozY01ML1NMWUxTLy9Pam4zYlpr?= =?utf-8?B?MUxGdnVJeFJ5SmdNUFFzYTBDc0R2L0lIaGozc3NIMSt4dGhhRjFra01BU1ZS?= =?utf-8?B?OWoxUWUwTU9oczRORkJndGIxSm9MV0NkK3ZmVVJialp3S0prZ0JVTEk5eTEr?= =?utf-8?B?YVEyUlJhQnYzcVpxOE9IdEdUcjBlYVUvTlltOEFSOWNnUG5UbDVjZ1AzOXJU?= =?utf-8?B?Q0pIWU5VTmtObVUzb05vQ1pNNUJKaHVnNE93L0ZQa2RERSt6WUtCOWtVQWlH?= =?utf-8?B?VkdoYTY0RkNEODNRYm00MmwvL0hHdG5kdXIwcnRVSHphaEhreDUxK043dmhl?= =?utf-8?B?bjdhckdaQVNSOW5nWnBCY2JDbVk2RmZKT2lwa1hoaXRjVUFsemxQdXNHNUll?= =?utf-8?B?d2VVTUl5RU5VOFltNU1TOS80V3lwSXdoWkhLOTB3K3BDQ09aNFR3MHlib05v?= =?utf-8?B?ckdmSzM3YTMxUmcrT0ZNcVJFN1Q4dUhySzM4aHM1TjJYRGx2ZTByRkJ0SmNQ?= =?utf-8?B?NkY1ZTE1ZVRpK3l1YmtYYkppK0tFYXJRcDMxU2ZOZXNCUnBDNS9XdjV1QlV3?= =?utf-8?B?TkhQTFZnV0hLd0xKekpZT0dPYjh1RG5CdjhhOU5RNHVYbWFpUkNId3lpQ1NC?= =?utf-8?B?d1BwS3JORUVOUytudER3RU8wcjBVODlWRmZBRmdXYXlyd3FiMVh3MXpIWCtH?= =?utf-8?B?TWljUnNZMEFoc1VwUkxHVjZyNmxPS2N4STZLc2tweS84ZXlDMUtoVExXQjlX?= =?utf-8?B?Qk16TU1PWU0zZkI3RTJmcGVOc0dMbHZWdklMeEUxOHdGN1N0OFVvMU0wQXVU?= =?utf-8?B?MEw3dlh6LzZhUm9mNDY5V1dqZm41NXBPUmQ2WG8wdzR0a0pleDlremZ0dllJ?= =?utf-8?B?Z3ViT1VyNWVETXMyMElaVTdHZ0ZPcGF2NldUWHd3clBUbUtzNUJFMXpjWUVx?= =?utf-8?B?eFdnd0Z1OFhiL09SMmJFTzZEUmZzc3k2dDdsb2pKbjhGb1h5cUZCY1JCaXdZ?= =?utf-8?B?SzBsdDRBbVNDTVV3QTFVbzk5MEdSU1djMjZ0YU5TbzUwOGd1Slc3cFVIMFp6?= =?utf-8?B?dXlPdU8xc3BWdEVYNGtYVTJrVC94a2VqQnIvZ3FIbzhIVW9ZL3RNZ1dHNWhl?= =?utf-8?B?Qmx5K3U5WGdHZllWVWZqWU16MkI4a3NndlRVdjduTUFjYjIva29PV1pHM3Zn?= =?utf-8?B?cWhQSGR3Ulp4MUxuZjFSbFhxQ3NHYnEvUmZlaU15VmUxclUyR1lKOExsRm1Q?= =?utf-8?B?NEhVeW9ITDRJcEFvdzFPSHBXd0JUMGM1aXF6MlFEUG1VL3RQY2VBK0NhcFRM?= =?utf-8?B?b2c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: e28bedec-3870-4da0-d8e8-08db110c271c X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 17:26:49.8257 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EF4pKHICgE8m4FGUumY8zPwiBuqoCI2HufeZZm9GpWXMSMEkLavhInM70hwHBEvA8ouxD3VjVInLrli0hZEDcbF6e7GViiG+/sgCRqZx1dY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6386 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Feb 13, 2023 at 04:28:36PM +0100, Juraj Linkeš wrote: > Add code needed to run the HelloWorld testcase which just runs the hello > world dpdk application. > > The patchset currently heavily refactors this original DTS code needed > to run the testcase: > * The whole architecture has been redone into more sensible class > hierarchy > * DPDK build on the System under Test > * DPDK eal args construction, app running and shutting down > * Optional SUT hugepage memory configuration > * Test runner > * Test results > * TestSuite class > * Test runner parts interfacing with TestSuite > * The HelloWorld testsuite itself > > The code is divided into sub-packages, some of which are divided > further. > > There patch may need to be divided into smaller chunks. If so, proposals > on where exactly to split it would be very helpful. > > v3: > Finished refactoring everything in this patch, with test suite and test > results being the last parts. > Also changed the directory structure. It's now simplified and the > imports look much better. > I've also many many minor changes such as renaming variables here and > there. > > v4: > Made hugepage config optional, users may now specify that in the main > config file. > Removed HelloWorld test plan and incorporated parts of it into the test > suite python file. > Updated documentation. > Hi, just trying this out by reading the docs and trying to follow along. Couple of high-level comments thus far without getting into the patches: * In the "configuring DTS" section, I think it would be good to: - say that the config file should be named conf.yaml by default. It's in the next section, but I think it should be called out earlier. - say that there is a template conf.yaml file in the dts directory already. On my first reading I actually thought that the sample config file was dts/framework/config/conf_yaml_schema.json (and I was going to comment on the name being weird! :-)). Only when I opened it did I realise my mistake. Therefore, downplan the schema, and put more emphasis on where to find the simple conf example to start with. - if hugepage config is now optional, as you say above, remove that from the sample and the docs. * The code thus far seems to imply that you are always going to use root. When I configured it to log on to bruce@localhost, it timed out waiting for a prompt, I believe because it was looking for "#" which is the default only for root prompts. * When running as root, things progressed further but I hit an error when DTS was trying to get the CPU config. No idea what is happening here, because running the same commands manually over ssh seemed to work fine. Below is the error. Any hints as to what is the problem appreciated. Thanks, /Bruce $ ./main.py --tarball ~/Downloads/dpdk-22.11.1.tar.xz -v Y 2023/02/17 16:59:57 - SUT 1 - INFO - Connecting to root@localhost. 2023/02/17 16:59:58 - SUT 1 - INFO - Connection to root@localhost successful. 2023/02/17 16:59:58 - SUT 1 - INFO - Getting CPU information. 2023/02/17 16:59:58 - SUT 1 - INFO - Sending: 'lscpu -p=CPU,CORE,SOCKET,NODE|grep -v \#' 2023/02/17 16:59:59 - dts_runner - ERROR - Connection to node NodeConfiguration(name='SUT 1', hostname='localhost', user='root', password=None, arch=, os=, lcores='3,4', use_first_core=False, memory_channels=8, hugepages=HugepageConfiguration(amount=256, force_first_numa=False)) failed. Traceback (most recent call last): File "/home/bruce/dpdk.org/dts/framework/dts.py", line 41, in run_all sut_node = SutNode(execution.system_under_test) File "/home/bruce/dpdk.org/dts/framework/testbed_model/sut_node.py", line 39, in __init__ super(SutNode, self).__init__(node_config) File "/home/bruce/dpdk.org/dts/framework/testbed_model/node.py", line 47, in __init__ self._get_remote_cpus() File "/home/bruce/dpdk.org/dts/framework/testbed_model/node.py", line 155, in _get_remote_cpus self.lcores = self.main_session.get_remote_cpus(self.config.use_first_core) File "/home/bruce/dpdk.org/dts/framework/remote_session/linux_session.py", line 18, in get_remote_cpus cpu_info = self.remote_session.send_command( File "/home/bruce/dpdk.org/dts/framework/remote_session/remote/remote_session.py", line 103, in send_command result = self._send_command(command, timeout, env) File "/home/bruce/dpdk.org/dts/framework/remote_session/remote/ssh_session.py", line 172, in _send_command return_code = int(self._send_command_get_output("echo $?", timeout, None)) ValueError: invalid literal for int() with base 10: '\x1b[?2004l\r\r\n0' 2023/02/17 16:59:59 - dts_runner - DEBUG - Summary of errors: 2023/02/17 16:59:59 - dts_runner - DEBUG - ValueError("invalid literal for int() with base 10: '\\x1b[?2004l\\r\\r\\n0'") 2023/02/17 16:59:59 - dts_runner - INFO - DTS execution has ended.