From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F185341CA5; Wed, 15 Feb 2023 12:58:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE1C94302E; Wed, 15 Feb 2023 12:58:14 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 2FB3D4302E for ; Wed, 15 Feb 2023 12:58:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676462293; x=1707998293; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=OT/a4McI9ms7ZvBh9pvajVsZs8WY+RTq8EQhXrUsMi8=; b=I7vkoiEIUICAgUfFcdL/Eb1G5g8pJd0C9WbQJUY0odROXBAFkomoI+xr pyhal8yjsNJeN2uizbsnmptLfaUahxFSXShCSodAj5bsrXA3sS2ZkMqRi ezHp/Vfbx0FJ1ls6lnjE4Bvye6Apcp/xm3j/QB6dfasfKHYGQfa65x/6S PwFcpA18sdshnbT8hOhKXispPLYTApjntoGuvN3gdovtCZubxO1vcY3i9 8Y2/zkuE751cCr4dFnrsH4mGBVrkpElFM5m5KJfgIRE3bmEX35VpnUqyv oDvYAPSx0T/J5ZsM+vMSR1BXhy0ZMDkpXjUK6b0BJyIxhjwcE1z9jZOEs w==; X-IronPort-AV: E=McAfee;i="6500,9779,10621"; a="315064145" X-IronPort-AV: E=Sophos;i="5.97,299,1669104000"; d="scan'208";a="315064145" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2023 03:58:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10621"; a="738300353" X-IronPort-AV: E=Sophos;i="5.97,299,1669104000"; d="scan'208";a="738300353" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga004.fm.intel.com with ESMTP; 15 Feb 2023 03:58:11 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 15 Feb 2023 03:58:11 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 15 Feb 2023 03:58:11 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 15 Feb 2023 03:58:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F/F4gCEH9dtorRJ6tJw1U48Msnzv7qZooab2Jy440S95VfFl0gW0EIY7Ksl9w5K57lwxAg4mHzWx+gT+vZ5ZDKAJhMnfFx+AWITKXEfX5xy4aOBQp6Vj3TMsaqcD4SIq2xTIy+RPDzyBslvmvfoaCZsiVFlmZyIEwgw9CjfPOzF9wThWghRznk72ngV0r7tTjsGU1So09bWnPI1SA1rNWnAP5R9bUOVoC8loj03mwcZ5lyw/VMoh6QatGJE3bUJv03jY+XtYYdCctNoGecaf0nFBWTGwyBfe9+kHyOVECwjtXRrTCuqdqjIw9CuAdWP5pSiONLG5XY7F+fAZdaG8rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ym7czVPlMBEfnaadR9xV2K0N+10dUceLuGrSV6tkOWU=; b=OFSLVcqbJwo+bVr7kDtuapkvso+GZR0QLVEqR8M299CVHvzOeCWuEyAWLg8L7tXchbOVWFJ/IzWeFwkH8Bs+52T55adG09VrHEzjSJfTuC6wU1blneNU8AB8IHmoO9PJ9SRDoH6VVxgQ3uSVxwwYgt2GSgjJcTIkm4tNe2rBizErmybV7E1S3C3voPRitjaqSpOOWoRVMr5bqCzcwVhRfAbRrkc6jlGf4smsDxzieRWpvhx2P3EXH9uT2jEuEvDVPczWe13yyz7f3Xb/ZPRlb+ODVmu7KvWkfvIzM3rxI7bXffxovpcotyWT7bq1ZroyxpPNtEDe3eFQFwvdIhwvvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CY8PR11MB7396.namprd11.prod.outlook.com (2603:10b6:930:87::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Wed, 15 Feb 2023 11:58:09 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aaba:abb7:8794:def]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aaba:abb7:8794:def%8]) with mapi id 15.20.6086.024; Wed, 15 Feb 2023 11:58:09 +0000 Date: Wed, 15 Feb 2023 11:58:03 +0000 From: Bruce Richardson To: fengchengwen CC: , Kevin Laatz , David Marchand Subject: Re: [PATCH v2 4/6] test/dmadev: check result for device stop Message-ID: References: <20230116153714.554470-1-bruce.richardson@intel.com> <20230116173738.562322-1-bruce.richardson@intel.com> <20230116173738.562322-5-bruce.richardson@intel.com> <48d0d433-a054-fae7-7b32-e7f4d0cba236@huawei.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <48d0d433-a054-fae7-7b32-e7f4d0cba236@huawei.com> X-ClientProxiedBy: LO4P265CA0184.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:311::10) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CY8PR11MB7396:EE_ X-MS-Office365-Filtering-Correlation-Id: 1cecf095-0f1a-487c-172d-08db0f4be7ff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bNEBXlFB+Z0jD26VsBqYsmAnK+gti77B9HUXmInrfnzIhJDC7U1GNzdO4jTQ//JRRJ8MYxYjWlIbVHlezkg80SSvhZhWqSaj3XqNTDwO1iwYgxClz/xJAYndcjbG7A7HnOvY+BCHmaCWwcNw6CF4TPhhqwdcesm/+hJRhaOhLDG7rCXVtLf3FseUpz3srvLb9gMAmewYKxi0pV9NhpzLJUvebWYUOVdvuloZEe4DZbKt9fALt0mc2nGopDDjXrIqnXfte9BrqRnCFnnavhmq3Yqlorh1EvrYigsBDyGo3+SFl5GWRKyR1TlpZKH8HBw+j/3139+9ECdBzdjWGezROymHHd/yKZeGB8v2hqb8VpnNoDk5oOebsn5470ga3RsuNtlo8W258WM9QD85CQwifvRIOnRBrXOKjNKkIXpPcqWtQ+8Z2lQ1NEShVyZ6SYAAb1GWnWjG1r8twqveAUwgryxhVPKJiFeH2EKQfLEEe8rtTuI1G3Se76XcT52SpI2F4g+BLMRY0A7mVWZoV3Z4eUP+ZvqMfSbRpQg0syE9dDJfVAGCcRV9o/mhpR5bZ8Z57ZcBw1p5YF1WqOAFej3n/9RjL6+Xh2itWBh+TYOKPZSa+myVBiH1gIoVKY/NyPIm6dW9r4XNcJQSaYo94NRMDA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(376002)(136003)(366004)(346002)(396003)(39860400002)(451199018)(66476007)(66946007)(2906002)(86362001)(66556008)(4744005)(53546011)(6506007)(5660300002)(8676002)(8936002)(6512007)(478600001)(44832011)(82960400001)(54906003)(6916009)(4326008)(41300700001)(6486002)(316002)(6666004)(26005)(38100700002)(186003)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Y0jMwL81HfdemccZQMEaN3+kPrg2uC4/1jURxpKf1D/mMtIz3We8RPzTkUSO?= =?us-ascii?Q?9h6TkKXJ8lMOM5SNJ7DfFpTII0Rx3OvIUY+bIIyTAA2i45iidUEAkHGckWSf?= =?us-ascii?Q?JuIb7C516NzIlctrlQdzTgEFxua7B8XUZ/lFCRQyg532I6pd8KVMqri1oBwX?= =?us-ascii?Q?j6/FUZ5rugdbERRosMRfL7VbXbQCTTRW8EQ1GoTpt5GbJk1+YcuI9zO07qwb?= =?us-ascii?Q?Rya48QIH2jdNrcmOuM1fdW0JHli5PgrGYeYDvmT+BMltZDU5baWhnAzVZxzx?= =?us-ascii?Q?oLyfmlwkjmFD0Zi1lrJd6dKJ0EXOJC+AW4LrN5VfmvgAdIzcx9Q96zd2jIiu?= =?us-ascii?Q?1k3Kv8uuvnp2AxsK68ug5rhGyEpVYTebdEc9p1xUjwMUHjmG7c5eaBcYHh3O?= =?us-ascii?Q?oCU354z8spO5dT4L/RxC8NTggVVpmeHpTLec7072ty4wVZiwBJ7mSlH001h/?= =?us-ascii?Q?bFTaCIh+ZtNIu7sVA6dHUq/f8VgtjdhAH048cMSF126v0ga9wG67JImmPELE?= =?us-ascii?Q?ajlY4Zotrq9vhkKQDUCSOVzZckpLckaHXOe5qvSIaJ5ZsK2xhEubhJSQzdKm?= =?us-ascii?Q?NE2SvJDSosK4YfY/5QZp47Rjgk4fdpaRNmSx0/nBMRh89GDIaCSQpxgCx+dB?= =?us-ascii?Q?SufxKwhWbjv8beJPpjedXs6um0yJApmoJIbzO4c9FUHA6EQ140ZtH9DclhE8?= =?us-ascii?Q?YI6ec+qIPEbJ5OnRI+HNQk3BM1SvHJVuUCPycUVczLTEPyBl1KnvDNboHGoL?= =?us-ascii?Q?ooOue8Rd/9jaEG99Iv8C4YnShHOZlMnL4bJ3MB/kSgEbtVY6RcUZki33E4K9?= =?us-ascii?Q?4bEsLTCclsRcHVqwVQriaXof3MzoJ522OI7AGYYOons1t6fX9hDdIG0s6nbf?= =?us-ascii?Q?9U/9Znu44fcAqHaDHuWSZm4UaR06t43kaQ0MlHLBshjekjPqb4dvi5/nCYNs?= =?us-ascii?Q?s6PqTaJDp6/eGn8k/jFb2SBd4RSlyM3SogfsOXhMqHYRU6VmTmjrp5QYK7ZA?= =?us-ascii?Q?8gJAFAJCg7jNdjewJ/crrJMPg64ZkhbObYpOtfi/kzXwciJNEoymK15PpFlf?= =?us-ascii?Q?XoDTkUueO9V+XjXB6nOGWxzAEfyiJI1gPdENfb2iWT1TRX1jWqDqDj7cPQxE?= =?us-ascii?Q?ITBXmS8OJSS7C//1omOBMutIbn0vEiWPZX6OFzcTt9jzNdO9753Gu6eWFNEJ?= =?us-ascii?Q?EoBVF34tto8GUvYAsqOJHzbaJ8dVgqm/4e5c8tRUxLGxJwBL1wUqLhTptvzR?= =?us-ascii?Q?pTyZgC4dBQzcnnD807k3O1nJ3LSyKNgJG2C/AQSKk3ZJs07OeJwACsb0ixBS?= =?us-ascii?Q?btm0Kln+JYgtW8/LxXel6p/qh15AyBtax6VmRNtLRcqpl84lAHxjaHKBJvo8?= =?us-ascii?Q?YLALJ5BM4skO0Ho5wlLMc4d3GEcSz7aFOdG93/MsKcdapKZB2cYIaF99zZ/N?= =?us-ascii?Q?NeAsxoBb+q3i2DyD+mQ7YuZ+WYX2aGC+c8o5kbpQ+iYZe2frBS2yu9amv+Df?= =?us-ascii?Q?v3TcZwzDDN7pYSOch6XyUAOb0UbB3WmtYejLAeMm+c+pREYZGmy69ISA8YNh?= =?us-ascii?Q?WGeSSHYqVqpuaK5Z78T/niTjKdohVi62OQl0+hDs9CqqnNV79zUHUhu2mbr4?= =?us-ascii?Q?nw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1cecf095-0f1a-487c-172d-08db0f4be7ff X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 11:58:09.3681 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wZ8VUgvfHSPsGQ2Rtprrjg/vwH917SBDKk4XuUTvjUk5Z3qF5q3E4qHBYA0mMbDn9DVIvaps/1DnGkZa0VCeb91Hwq2Zf+uu59o8CyI3exg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7396 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Feb 15, 2023 at 09:26:01AM +0800, fengchengwen wrote: > Sorry late to see. > > On 2023/1/17 1:37, Bruce Richardson wrote: > > The DMA device stop API can return an error value so check that return > > value when running dmadev unit tests. > > > > Signed-off-by: Bruce Richardson > > --- > > app/test/test_dmadev.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c > > index fe62e98af8..4e1dbcaa19 100644 > > --- a/app/test/test_dmadev.c > > +++ b/app/test/test_dmadev.c > > @@ -837,7 +837,11 @@ test_dmadev_instance(int16_t dev_id) > > goto err; > > > > rte_mempool_free(pool); > > - rte_dma_stop(dev_id); > > + > > + if (rte_dma_stop(dev_id) < 0) { > > + rte_mempool_free(pool); > > The pool already freed in above. > I think just add ERR_RETURN here. > Yep, good catch. Will fix in v3.