From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5A17A0093; Fri, 7 Oct 2022 12:34:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A80D427EE; Fri, 7 Oct 2022 12:34:26 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id A4BC040042; Fri, 7 Oct 2022 12:34:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665138864; x=1696674864; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=Y+hh2hOVJ/lu1UW43gGDu5aMWDNwLF2/NVH/2YQ0bM8=; b=CpBbA5uy+aBYTx4FvRwHCaR8cpNX5kORjkIk/Xnu2TLa4ZJZMUF7+gju oKDw/dRj5kR12Tqyq61o6qPLNtQANL6qQXYiBM4MHwAQW6+jxRDY5BvfH Vz9ElRE5kXElT9aQqWqNxZnWBthRjcny5CpnBCa2PWSRcyI7NiYsh+SJR +t4h8kBc3pBE+a45hOC/rtJD1DtF2Fo71ME15PvFAQ77cnGeBPCVIiWfG XLc1jn35+1yHeAmKD20gKI6ntcXHAbmsEHeWSxAq62ma0qxnntXPUrPOe j7sg5m93gDdbUQyh24inTRKUlWhaj2AZW1o7Ra2i5K7Ocq8pgo1px+TuL g==; X-IronPort-AV: E=McAfee;i="6500,9779,10492"; a="367832717" X-IronPort-AV: E=Sophos;i="5.95,166,1661842800"; d="scan'208";a="367832717" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2022 03:34:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10492"; a="602825914" X-IronPort-AV: E=Sophos;i="5.95,166,1661842800"; d="scan'208";a="602825914" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 07 Oct 2022 03:34:22 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 7 Oct 2022 03:34:22 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 7 Oct 2022 03:34:21 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 7 Oct 2022 03:34:21 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 7 Oct 2022 03:34:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VgUje8ODDXiIMG2JsBJO+Y+E/CZeRqymkTZcuNJAquwwjY73zHeAEswcHAClbWpXcoEH41/wqP2pYBVspBZv9rNDjRrpUhSpbVb+KxMzfVXTJgLA6m0Gvf5gZjnRiwxOiZE8EprxaNPT/OuAT9D5y0ik+jxwNfoK/wuoYHA69JYkj2zrRCqp9wyeKi3WER76Ma3BPsuvdh09E0GhZvOGqTUfpOrP9a0rTcRn4MCtRgTLVvSVxKjeexnE3litUC5CuQ/7T8jLaHVlaww1RjqwUIyXxWEP6hH6jo4XCFsR/IkkXDeqOLZohFiFEiCgdrxu0zWavAg8ll1uQGR7Kp7eaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2OWgIOVE0b66I6ZgHaJkKSrUBMXOfTdaiINomQLxKsY=; b=lRqTKk9qwPhgjCtFC6FDNACBApCiB7h2r5+tYgAbt38g3sI/E8SNc+ByZD0odOoQ57gaS1QFeqbRIgpSKKSh8XPw5BaCAf7/tYLd+SUBO5wzryua0O9dh4drmuVraJUE1yPuo5rfj7bXlIVtUPyANsEFLeyvX51qzDw7tJO5P7oVkkTIz7e1/SsVhAvbWXUAGhIhsPKNVhceoAuqP1Zs0+eXTz3hPf0iN58Qrh8DowD6VK4OrAeAGl53unaV48DQgLkDWBj5aij2IXns0CQZimPpc0IUi6ulcOqQJ517azyv3NPgzbjHY+Ti9lwI6jXgZm0rqHIfFRPWrHvOkk53Gg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by SJ0PR11MB4862.namprd11.prod.outlook.com (2603:10b6:a03:2de::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 7 Oct 2022 10:34:18 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1%12]) with mapi id 15.20.5676.036; Fri, 7 Oct 2022 10:34:18 +0000 Date: Fri, 7 Oct 2022 11:34:11 +0100 From: Bruce Richardson To: David Marchand CC: , , Morten =?iso-8859-1?Q?Br=F8rup?= , Thomas Monjalon Subject: Re: [PATCH 1/2] kni: flag deprecated status at build time Message-ID: References: <20221005143451.157613-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P265CA0167.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::12) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|SJ0PR11MB4862:EE_ X-MS-Office365-Filtering-Correlation-Id: 3cfdae7e-f30b-449b-cc5f-08daa84f7cdb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LwNvS6oWLCBaLehODSiLydT+0RL6FrMt0VCOHveIEop6hNYlTUiHB0DXwSIC/IHZU9sWKN7T9KiFRv5DmpHopHk2oFsFKYNHwZ9rhceYZHdXI1hWkYBVaKMBgg1g8ptmfVdkIXQ5AlRhFzRLnZcJfqPHQAW21hpkQ2p4XVzUqNep9NB9tAdgPUtmfLUEfVUwMqy52D6Z5ZmyW4jEQE6U+pN+TAEwsQZAnApEuDJbObxDh2mEXMA+O5w9X0p5uyUMWmg1EeUyEcxIbSl+BljzuYCTnBY+XD9JluYlrcP5F5ATZAg5060xVWYXgB6fM7CH0SjVDrLlRbul7Z+48C90o8UJsNHzdkhUshyHQpsPNAHWAv5xS0HszihEiq+aTz8QTpnAwlQyVdn91UyMhw1HdoVOEH3Lt848k6wamZ4H2GhKhqDcj4aPoWdb9woun0ociyOln1NOXHd+ciG9QTXlaIgxJiORwnCipub97Gz2dWk6/QCrq9xIXDAN+9yTH0ukeLRFk8BTcaNMe0D9H0LMdDA88bx6IcP2aGtfxrcY+iQNNaaJXJQzd82uvjoTkUgyMMIPrxCN3BkKRnoWrdvorwt0Pnlm+A/gLAMtDM7dGf/UrvL6ZiX6mc1iExBuTIYi0LEkSj4G/m0ldryApIXsj/NnWYLXlO7l5CnDJl1o/oGgiscTqIcODAjuoUCeiKcYtzN/2OwmiInS1EYjmXfP6mwjnNFRIbwE3n/zkW5jrxCOmnFJZUkwam+Zj+r7fm8HRJ3LjVHrGeDQepf04t0CmQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(39860400002)(396003)(136003)(366004)(376002)(451199015)(6486002)(83380400001)(86362001)(186003)(82960400001)(38100700002)(66946007)(316002)(44832011)(5660300002)(41300700001)(8676002)(8936002)(4326008)(66476007)(66556008)(6916009)(54906003)(6506007)(6512007)(26005)(53546011)(478600001)(2906002)(6666004)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4ox48vClYvZtd5FlBg7g1d6by17awn5ZskLXncw4HJkmlhgB3g9P2GNJUEGe?= =?us-ascii?Q?djQZYs2CeqWUR2RUEtxIq7MMWWlMmwc7Wk23+c0msxhK5DvAjoKV9XyBLExi?= =?us-ascii?Q?ShmJSn/Q8MliQCaKTkB9ZQ9QhdfUJ2YRGwa9cPY8qLuKfJEsLpKi89qiZSrw?= =?us-ascii?Q?PjqKIhmhC+ctKCIe13TcQ/ZwsC88E8g9u62A2hJvmAt5WymJ42Mf16uWzJ79?= =?us-ascii?Q?hkzSKsAIONoYidnfiPuFhIWeuyMhTdWGVE8mxEIyA1E41LmY/o7tcWCEqA0R?= =?us-ascii?Q?lppKvqtjJTX2XKMcC0PQEe7JiouQtnp/VbXp2gVfLjYmA/6siByAEUMzgCgv?= =?us-ascii?Q?7vzxUTkh4nbX7WreKwdqKsgHtj3BTLiiOR+yOcGx1j0X8QmINfMpVAJjG4Uo?= =?us-ascii?Q?uBAK8v6v/vPUaUeBns9rhFaL8JAWDIF/pYbbio/vamUfqrjKA5mjChDhxHMI?= =?us-ascii?Q?E64DGGP7M6Do9R/Qt6g/dlCqrRteGVl8VKmGx7bZzV5WDV+ZbETbJ7btNans?= =?us-ascii?Q?NLjRO1NAVoW8kW7i7OlVm3DVgl1cmbjty1KqhGiXRnrs5QCTI1nzNWZOjB+1?= =?us-ascii?Q?ymEFhtF15Ih5IWxTagOcIHf9Q4PawUBt15SR0yumWLrE+gnuu8JNShR8okPc?= =?us-ascii?Q?IGegjnw+KZexfiM2Mt27T9fUDh1M22EaKBXrwwowWKx7xrpX0SCz3ePDl7/R?= =?us-ascii?Q?gmUkR1u2vvs4awreW5Hf+k3Q+YYi0HEgsAPIcTTE4USEdO0+5gZTbxgSUK3w?= =?us-ascii?Q?U8dbqN56HAtZTwkDv+MNZ/uonEarD5UsUfbNUAwcyMrEXXJYOS9vEkXnvSoK?= =?us-ascii?Q?0wGcJjHYLojURkA8/gI6zEOInVi+ZKfgNGn7FF/BUgnfuZpsq3cdziYVAVAy?= =?us-ascii?Q?fDQoGbrY27tVfv4av7KDS0jhRaFT4/iK+ZEVra92Z46uI2CbMlXGIRmVJVh8?= =?us-ascii?Q?sCj/ABITp/Epzvd13N9IFZy9bwtqo/NkkLgfEk+zY6YvzUl4d3ldhCoOJSPv?= =?us-ascii?Q?+CivbNzDGJqo8wFOL3JjdAlJMxit75KZJ4BxqAivRq9FRPL1Ka22esbCBqz2?= =?us-ascii?Q?vxFz9WNqdNVXGfd62verxBUmvRQpqrPoxnJovRJJgiBJqmWgF21mZReiDgmh?= =?us-ascii?Q?cYRsKVwbi0BVM37B58CPVrvHHNvSVciza9q4NmLfADJcSigT59PPdoKqixWX?= =?us-ascii?Q?2Pp4SYJyIfcExO//Ioxo9NAGzhMzc9p/cX9+PMzmz5pGR6L/xYJ8MAffKHh5?= =?us-ascii?Q?9JWHaqTskJObUlgWl4kXjhGpniIBZUk/AlBXCeQzxjr2x5kGCdlDEFSGbGlC?= =?us-ascii?Q?P1f3wJ+N7ZMZOLZr39NhR+lNt6hR2u9UwVcT7PK2USA0K/Z2oLZ8NXgngRy8?= =?us-ascii?Q?DM4CmVma+0FfE0et9ApriRJS+d4gOfmfpHmk4UO42HfaOoj9xJUN8l/MjPqb?= =?us-ascii?Q?BFrXI90HK9RIsC2mErUIiuNNtbll0QddM7LVLmh4fbtMd/5v5wOcUKWVsd3Q?= =?us-ascii?Q?L80tfSfcW1P/RR6q/ClVe3ae94bonbYJiyfsDWBliIA9PBAcy01boQeMPCwE?= =?us-ascii?Q?2OSWdNrd1S5mY+Ce7Qf4fJW7zA/BxGpjchr95dXnchfi5DzCB1/bbsRGdoTT?= =?us-ascii?Q?3w=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3cfdae7e-f30b-449b-cc5f-08daa84f7cdb X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 10:34:17.9821 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dmqFSAflfHrGuVwNLdUcuHiBLE90xDudiwA4Q9lqBAV9Tjv6R5/Vy/8ixbfGz71Pbxmwb7coWnPAAliMJYfRtPqRh4LJ4M/vZbDVcb3Zauw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4862 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 05, 2022 at 10:10:10PM +0200, David Marchand wrote: > On Wed, Oct 5, 2022 at 4:35 PM Bruce Richardson > wrote: > > > > To ensure all users are aware of KNI's deprecated status at build time > > we can take the following actions: > > > > 1. disable the library by default. It can be re-enabled by setting > > disabled_libs to the empty string (or other string not including > > 'kni') > > > > 2. add support for a list of deprecated libs to the lib/meson.build file > > so the error message for KNI being disabled includes the fact that it > > is a deprecated library. > > > > 3. for the dependent NIC driver, drivers/net/kni, modify its disabled > > message to also reference the fact that KNI is disabled. > > Let's say I want to re-enable the net/kni driver. > How should I do this? > > Passing -Denable_drivers=net/kni results in only getting net/kni. > Passing -Denable_drivers=*/* gives the same result as passing none: > net/kni is disabled because relying on a deprecated lib. > Well, the error message still says that the library part is missing and that is why is has been disabled. In terms of enabling the library itself, from the doc part of the patch: +.. note:: + + KNI is disabled by default in the DPDK build. + To re-enable the library, remove 'kni' from the "disable_libs" meson option when configuring a build. I can similarly add a note to the net/kni documentation to say that it will be disabled by default because KNI is, and to re-enable it just enable KNI lib as described there. Is something like that needed, you think? /Bruce