Re: [PATCH 1/1] build: increase minimum meson version to 0.53

[Bruce Richardson <bruce.richardson@intel.com>]

On Fri, Oct 07, 2022 at 03:17:57PM +0200, David Marchand wrote:
> On Mon, Sep 12, 2022 at 7:08 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > This patchset bumps the minimum meson version from 0.49.2 to 0.53.
> > Rather than specifying a specific point-release of 0.53, as was done
> > with 0.49, the version specifier is kept to the major release number
> > only for simplicity, as new features are not introduces into bugfix
> > releases of meson.
> >
> > Some new features of interest which can now be used in DPDK with this
> > new minimum meson version:
> >
> > * can do header-file checks directly inside find_library calls, rather
> >   than needing a separate check.[v0.50].
> > * can pass multiple cross-files at the same time when cross-compiling
> >   [v0.51].
> > * "alias_target" function, to allow use to give better/shorter names
> >   for particular build objects [v0.52].
> > * auto-generation of clang-format [v0.50] and clang-tidy[v0.52] targets
> >   when those tools are present and config dotfiles are present.
> >   Similarly ctags and cscope are added as targets when those tools are
> >   present [v0.53]
> > * meson module for filesystem operations, so meson can now check for the
> >   presence of particlar files or directories [v0.53].
> > * "summary" function to provide a configuration summary at the end of
> >   the meson run [v0.53].
> >
> > Plus many other features. See [1] for full details of each version.
> >
> > [1] https://mesonbuild.com/Release-notes.html
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> - We have an issue with mingw cross compilation.
> https://github.com/ovsrobot/dpdk/actions/runs/3039251235/jobs/4893964186
> 
> + meson build --werror --cross-file config/x86/cross-mingw
> -Dexamples=helloworld -Dplatform=generic --default-library=static
> --buildtype=debugoptimized -Dcheck_includes=true
> The Meson build system
> Version: 0.53.0
> Source dir: /home/runner/work/dpdk/dpdk
> Build dir: /home/runner/work/dpdk/dpdk/build
> Build type: cross build
> Program cat found: YES (/usr/bin/cat)
> Project name: DPDK
> Project version: 22.11.0-rc0
> C compiler for the build machine: ccache gcc (gcc 9.4.0 "gcc (Ubuntu
> 9.4.0-1ubuntu1~20.04.1) 9.4.0")
> C linker for the build machine: gcc GNU ld.bfd 2.34
> 
> meson.build:4:0: ERROR: Unable to determine dynamic linker
> 
> 
> - I reproduced locally, it looks like meson is trying to pass some
> -fuse-ld option that is not understood.
> 4577  write(2, "x86_64-w64-mingw32-gcc: error: unrecognized command
> line option \342\200\230-fuse-ld=x86_64-w64-mingw32-ld\342\200\231\n",
> 101) = 101
> 
> 
> - Upgrading to 0.53.1, I don't see the issue anymore for mingw, so I
> pushed a branch in GHA to get a status for other targets.
> https://github.com/david-marchand/dpdk/actions/runs/3205007946
> 
So minimum should be 0.53.1 rather than 0.53 then?