From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EECBFA0543; Fri, 7 Oct 2022 22:20:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C75A400D5; Fri, 7 Oct 2022 22:20:00 +0200 (CEST) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mails.dpdk.org (Postfix) with ESMTP id 839F840042 for ; Fri, 7 Oct 2022 22:19:59 +0200 (CEST) Received: by mail-wm1-f48.google.com with SMTP id n35-20020a05600c502300b003b4924c6868so4900710wmr.1 for ; Fri, 07 Oct 2022 13:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rLe6Du6xejw1DN83FcPZQEdw7u+1QPpf9cQtgtpKHbY=; b=IKYrb2i6+TfEeVbMCXQt0+ux+H1DWGYPdl//t8Mi/rBsGhIXjxyjS8KhI8suioLSIA j5oedkQB6DsBlKAHqRxtHEKApZFIsHD3JXDe8tSTqk/miC+6AYYafJ1LYtUwqxgNIIlI Z6agjuCJVkB6As+zthpUytkKBZkX4rDcBgDpDEy/8XOkBBDeWT4gAIGknv3fiwM+U/Ka 7RYwHxIIVkd0lSt5bKkF/Vg76+90M931XYuQ4Y3EcTqdfQfEYTHUiZsY4mI1bstswNSw +DVvoXYC/iaDGlXBK8pYJRJp53YBeYfn0OA6tLucxqnxjWG6ytNOji1vV0JLYg/VF3n/ va1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rLe6Du6xejw1DN83FcPZQEdw7u+1QPpf9cQtgtpKHbY=; b=iUIt+81pHEJMTTG3bE+r0YP5v0wRXO/XjKAibLu6VDc3ERX1PnUFM7l/GmanuJ07b9 oKAvgkV9R37KSdw+UgFDYCV27H4Px7HD7q+SFSy3V+/5jvr8S0HM4QkfvTB9Jcj8iXdk 2kgtRVtxuFyJPePj7CnAlYjrtnYA8muhENPvs36uorpbgewYDqN5rBjZpLMf520MCOGN 9gSveuvD2WnxiaHqiPiORZ3rOLMe3hJukR8NIqzFSZwFtYMmR17lOeCi4Wj/xAbYb9eS FdF39nyFatrhzNl4HyePyHpf3t7q8gSj+DzMzjVEGB7G6/izUmiUWZXfqkAn8fuVElTQ S3tw== X-Gm-Message-State: ACrzQf00CjPxNkJ6pN/V99ljvYuphMTNmLubbGLr0vRC+6tvehqr4x8/ AXUa0A4CWcU7wo+KXAsDlwCtxw== X-Google-Smtp-Source: AMsMyM42be1GkIA2pRHQFWYYEFekyDdDKGtMvF0cG/bXKPkv8N4vXwVhbVHrPFeeB8lpI11y81xhvQ== X-Received: by 2002:a05:600c:a09:b0:3b5:2f6b:c7c5 with SMTP id z9-20020a05600c0a0900b003b52f6bc7c5mr4412781wmp.141.1665173999292; Fri, 07 Oct 2022 13:19:59 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:7be5:dd98:fb1:278]) by smtp.gmail.com with ESMTPSA id l2-20020a05600c4f0200b003a682354f63sm9604388wmq.11.2022.10.07.13.19.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Oct 2022 13:19:58 -0700 (PDT) Date: Fri, 7 Oct 2022 22:19:58 +0200 From: Olivier Matz To: Shijith Thotton Cc: dev@dpdk.org, Honnappa.Nagarahalli@arm.com, bruce.richardson@intel.com, jerinj@marvell.com, mb@smartsharesystems.com, stephen@networkplumber.org, thomas@monjalon.net, ferruh.yigit@amd.com, pbhagavatula@marvell.com, david.marchand@redhat.com Subject: Re: [PATCH v4 0/7] mbuf dynamic field expansion Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Shijith, On Sat, Oct 08, 2022 at 01:00:22AM +0530, Shijith Thotton wrote: > This is a continuation of the discussions[1] to add mbuf physical address field to dynamic field. > Previous version was to add PA field to dynamic field area based on the EAL IOVA mode option. It was > deemed unsafe as some components could still use the PA field without checking IOVA mode and there > are drivers which need PA to work. One suggestion was to make the IOVA mode check at compile time so > that drivers which need PA can be disabled during build. This series adds this new meson build > options. Fourth patch adds mbuf PA field to dynamic field on such builds. Last two patches enable > Marvell cnxk PMDs and software PMDs in IOVA as PA disabled build as they work without PA field. > > 1. https://inbox.dpdk.org/dev/57d2ab7fff672716d37ba4078e2e3bb2db126607.1656605763.git.sthotton@marvell.com/. > > v4: > * Restructured changes to multiple patches. > * Moved to #if scheme instead of union. > * Updated release notes. > > v3: > * Cleared use of buf_iova from cnxk PMD. > > v2: > * Used RTE_IOVA_AS_VA instread of rte_is_iova_as_va_build(). > * Moved mbuf next pointer to first cacheline if RTE_IOVA_AS_VA = 1. > > Shijith Thotton (7): > mbuf: add API to get and set mbuf physical address > test/dma: use API to get mbuf data physical address > build: add meson option to configure IOVA mode as PA > mbuf: add second dynamic field member > lib: move mbuf next pointer to first cache line > drivers: mark cnxk PMDs work with IOVA as PA disabled > drivers: mark software PMDs work with IOVA as PA disabled > > app/test-bbdev/test_bbdev_perf.c | 2 +- > app/test-crypto-perf/cperf_test_common.c | 5 +-- > app/test/test_bpf.c | 2 +- > app/test/test_dmadev.c | 33 ++++++-------- > app/test/test_mbuf.c | 12 +++--- > app/test/test_pcapng.c | 2 +- > config/arm/meson.build | 8 +++- > config/meson.build | 1 + > doc/guides/platform/cnxk.rst | 3 +- > doc/guides/rel_notes/release_22_11.rst | 3 ++ > drivers/common/cnxk/meson.build | 1 + > drivers/crypto/armv8/meson.build | 1 + > drivers/crypto/cnxk/cn10k_ipsec_la_ops.h | 4 +- > drivers/crypto/cnxk/cn9k_ipsec_la_ops.h | 2 +- > drivers/crypto/cnxk/meson.build | 2 + > drivers/crypto/ipsec_mb/meson.build | 1 + > drivers/crypto/null/meson.build | 1 + > drivers/crypto/openssl/meson.build | 1 + > drivers/dma/cnxk/meson.build | 1 + > drivers/dma/skeleton/meson.build | 1 + > drivers/event/cnxk/meson.build | 1 + > drivers/event/dsw/meson.build | 1 + > drivers/event/opdl/meson.build | 1 + > drivers/event/skeleton/meson.build | 1 + > drivers/event/sw/meson.build | 1 + > drivers/mempool/bucket/meson.build | 1 + > drivers/mempool/cnxk/meson.build | 1 + > drivers/mempool/ring/meson.build | 1 + > drivers/mempool/stack/meson.build | 1 + > drivers/meson.build | 6 +++ > drivers/net/af_packet/meson.build | 1 + > drivers/net/af_xdp/meson.build | 2 + > drivers/net/bonding/meson.build | 1 + > drivers/net/cnxk/cn10k_ethdev.c | 4 +- > drivers/net/cnxk/cn10k_tx.h | 55 +++++++----------------- > drivers/net/cnxk/cn9k_ethdev.c | 4 +- > drivers/net/cnxk/cn9k_tx.h | 55 +++++++----------------- > drivers/net/cnxk/cnxk_ethdev.h | 1 - > drivers/net/cnxk/meson.build | 1 + > drivers/net/failsafe/meson.build | 1 + > drivers/net/hns3/meson.build | 6 +++ > drivers/net/memif/meson.build | 1 + > drivers/net/null/meson.build | 1 + > drivers/net/pcap/meson.build | 1 + > drivers/net/ring/meson.build | 1 + > drivers/net/tap/meson.build | 1 + > drivers/raw/cnxk_bphy/meson.build | 1 + > drivers/raw/cnxk_gpio/meson.build | 1 + > drivers/raw/skeleton/meson.build | 1 + > lib/eal/linux/eal.c | 6 +++ > lib/kni/rte_kni.c | 3 +- > lib/mbuf/rte_mbuf.c | 12 +++--- > lib/mbuf/rte_mbuf.h | 37 +++++++++++++--- > lib/mbuf/rte_mbuf_core.h | 26 +++++++++-- > lib/mbuf/rte_mbuf_dyn.c | 3 ++ > lib/meson.build | 3 ++ > lib/pipeline/rte_table_action.c | 2 +- > lib/vhost/vhost.h | 2 +- > lib/vhost/vhost_crypto.c | 25 ++++++----- > meson_options.txt | 2 + > 60 files changed, 210 insertions(+), 151 deletions(-) > > -- > 2.25.1 > for the series: Acked-by: Olivier Matz There are few minor comments but I think it can go in rc1 anyway.