From: "Niklas Söderlund" <niklas.soderlund@corigine.com>
To: dev@dpdk.org
Cc: oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,
Peng Zhang <peng.zhang@corigine.com>,
stable@dpdk.org
Subject: Re: [PATCH v2] buildtools: ensure the NUMA nodes are counted correct
Date: Mon, 10 Oct 2022 09:52:06 +0200 [thread overview]
Message-ID: <Y0PPJgj7yIazv47s@oden.dyn.berto.se> (raw)
In-Reply-To: <20220922080642.315800-1-niklas.soderlund@corigine.com>
Hi,
Genteel ping on this.
On 2022-09-22 10:06:42 +0200, Niklas Söderlund wrote:
> From: Peng Zhang <peng.zhang@corigine.com>
>
> The method to fetch, sort and read the last entry of a list to figure
> out the total number of NUMA nodes in the system fails with 10 or more
> nodes. The reason being the usage of string compare while sorting, hence
> node 'node10' will be sorted before 'node2'.
>
> Solve this by sorting the list based on integer comparison of the
> numerical part of the node name.
>
> Before this change on a system with 16 NUMA nodes,
>
> EAL: Detected CPU lcores: 128
> EAL: Detected NUMA nodes: 10
> EAL: Static memory layout is selected, amount of reserved memory can
> be adjusted with -m or --socket-mem
> EAL: Detected static linkage of DPDK
> EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
> EAL: Selected IOVA mode 'VA'
> EAL: VFIO support initialized
>
> With this change on the same system,
>
> EAL: Detected CPU lcores: 128
> EAL: Detected NUMA nodes: 16
> EAL: Static memory layout is selected, amount of reserved memory can
> be adjusted with -m or --socket-mem
> EAL: Detected static linkage of DPDK
> EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
> EAL: Selected IOVA mode 'VA'
> EAL: VFIO support initialized
>
> Fixes: 8ef09fdc506b ("build: add optional NUMA and CPU counts detection")
> Cc: stable@dpdk.org
>
> Signed-off-by: Peng Zhang <peng.zhang@corigine.com>
> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> ---
> buildtools/get-numa-count.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/buildtools/get-numa-count.py b/buildtools/get-numa-count.py
> index 1b7787787f71..2f243886cd21 100644
> --- a/buildtools/get-numa-count.py
> +++ b/buildtools/get-numa-count.py
> @@ -6,11 +6,12 @@
> import glob
> import os
> import subprocess
> +import re
>
> if os.name == 'posix':
> if os.path.isdir('/sys/devices/system/node'):
> numa_nodes = glob.glob('/sys/devices/system/node/node*')
> - numa_nodes.sort()
> + numa_nodes.sort(key=lambda l: int(re.findall('\d+', l)[0]))
> print(int(os.path.basename(numa_nodes[-1])[4:]) + 1)
> else:
> subprocess.run(['sysctl', '-n', 'vm.ndomains'], check=False)
> --
> 2.37.3
>
--
Kind Regards,
Niklas Söderlund
next prev parent reply other threads:[~2022-10-10 7:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 7:54 [PATCH v1] " Chaoyong He
2022-08-29 10:41 ` Thomas Monjalon
[not found] ` <MWHPR1301MB1997EA5A5CF4A320A13493E4EF769@MWHPR1301MB1997.namprd13.prod.outlook.com>
[not found] ` <3155813.0WQXIW03uk@thomas>
[not found] ` <MWHPR1301MB1997910EB07FA86DE33053C2EF799@MWHPR1301MB1997.namprd13.prod.outlook.com>
2022-08-31 8:47 ` FW: " Nole Zhang
2022-09-20 10:11 ` Niklas Soderlund
2022-09-20 13:22 ` Thomas Monjalon
2022-09-21 7:19 ` Nole Zhang
2022-09-21 8:07 ` Thomas Monjalon
2022-09-22 8:06 ` [PATCH v2] " Niklas Söderlund
2022-10-10 7:52 ` Niklas Söderlund [this message]
2022-10-10 23:11 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0PPJgj7yIazv47s@oden.dyn.berto.se \
--to=niklas.soderlund@corigine.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).