From: Bruce Richardson <bruce.richardson@intel.com>
To: Omer Yamac <omer.yamac@ceng.metu.edu.tr>
Cc: <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@amd.com>
Subject: Re: [PATCH 1/2] drivers: suggestion on meson without version file
Date: Mon, 10 Oct 2022 09:34:40 +0100 [thread overview]
Message-ID: <Y0PZIBl3zAPoBd2d@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <aee4500cb78b5ba07f305c72b4b69737@ceng.metu.edu.tr>
On Mon, Oct 10, 2022 at 10:41:57AM +0300, Omer Yamac wrote:
>
<snip>
> > Beware that the shared_lib calls use both lk_deps and lk_args
> > parameters,
> > which are only set inside the "if" block you added.
> > This will cause problems in that:
> > 1. If the first driver doesn't have a version.map file, these variables
> > will be undefined and you'll get a build error.
> > 2. For any subsequent drivers that don't have a version.map file, the
> > old
> > values of the variables from the previous driver will be used.
> >
> You're right, I missed that part and I will add a "else condition" to set
> variables as empty. Then everything is OK?
Don't add an "else" leg as it will complicate things. Instead, initialize
them to empty at the start of the per-driver block, where we initialize
the other variables. It doesn't matter having them assigned twice in the
one block.
Thanks,
/Bruce
next prev parent reply other threads:[~2022-10-10 8:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 6:52 [PATCH] drivers: suggestion on removing empty version.map files Abdullah Ömer Yamaç
2022-10-03 9:19 ` Bruce Richardson
2022-10-03 13:59 ` Omer Yamac
2022-10-03 14:01 ` Bruce Richardson
2022-10-04 6:30 ` Omer Yamac
2022-10-04 8:07 ` Bruce Richardson
2022-10-06 7:19 ` [PATCH 1/2] drivers: suggestion on meson without version file Abdullah Ömer Yamaç
2022-10-06 7:19 ` [PATCH 2/2] drivers: remove the unnecessary version.map Abdullah Ömer Yamaç
2022-10-07 10:30 ` [PATCH 1/2] drivers: suggestion on meson without version file Bruce Richardson
2022-10-10 7:41 ` Omer Yamac
2022-10-10 8:34 ` Bruce Richardson [this message]
2022-10-11 11:08 ` [PATCH v2 1/2] build: make version file optional for drivers Abdullah Ömer Yamaç
2022-10-11 11:08 ` [PATCH v2 2/2] drivers: remove the unnecessary version.map Abdullah Ömer Yamaç
2022-10-11 13:10 ` David Marchand
2022-10-11 19:21 ` Omer Yamac
2022-10-12 10:29 ` [PATCH v3 1/2] build: make version file optional for drivers Abdullah Ömer Yamaç
2022-10-12 10:29 ` [PATCH v3 2/2] " Abdullah Ömer Yamaç
2022-10-12 10:42 ` [PATCH v4 1/2] " Abdullah Ömer Yamaç
2022-10-12 10:42 ` [PATCH v4 2/2] drivers: remove the unnecessary Abdullah Ömer Yamaç
2022-10-12 11:32 ` [PATCH v4 1/2] build: make version file optional for drivers Ferruh Yigit
2022-11-14 14:19 ` David Marchand
2022-10-11 12:00 ` [PATCH v2 " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0PZIBl3zAPoBd2d@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=omer.yamac@ceng.metu.edu.tr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).