From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C489A0543; Wed, 12 Oct 2022 17:19:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2554243027; Wed, 12 Oct 2022 17:19:33 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id A537C42EF7 for ; Wed, 12 Oct 2022 17:19:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665587971; x=1697123971; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=H9rtNhkIBvrJZIyd4cVMbgisnds1/fNxcAMUP96lfQs=; b=EHmlB29rdQd0p887DP5dYEHsgMPkAYaEN2ll7Slsl3EqfFdS7tG6UX8k 0oy1CgbRiLsW9fiBNf3UJXx5An8xfNbfEtL3aGISJil/ILfvKiUpxr9x3 0UjcbGQ2LlsZv77pTTZkql6nniH+YAbgBQnPftXWeRvTUazEY81aspBy5 e5mIzHNaJROPvbSdJ3x++QvpptPyGcHX5MPzcWjMR7Ya39SX6iul2O0hy zgzKSfx7Hbafx90xE1uUpTbeSidyFdBSwjrIU+h+R2HQbjikTUfN1kZNZ xj1mR3YKFVKo5Wl0Ji0R21LkepHrH9SU8XlmvCScRGoRk/VUTFxzYE/jV A==; X-IronPort-AV: E=McAfee;i="6500,9779,10498"; a="305879249" X-IronPort-AV: E=Sophos;i="5.95,179,1661842800"; d="scan'208";a="305879249" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2022 08:19:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10498"; a="955790479" X-IronPort-AV: E=Sophos;i="5.95,179,1661842800"; d="scan'208";a="955790479" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP; 12 Oct 2022 08:19:30 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 08:19:30 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 08:19:29 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 12 Oct 2022 08:19:29 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 12 Oct 2022 08:19:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H3Oaa7XuXsnlSRmj0/xutLPNnCBw4zV/SlN9fc5cQ725Cv9pbjxVc+FnjVhWtD/+7rDRtRrts5e93/DhDl8ybfr2tAjVnnRoDyyRd+dkLoPMnYBB6AXWztM5cU1uF+qcMm2zvu2haIicG3ITnInEr9cG6GcpZzWgHNV6a7J4GxnxuCHwwBuE/1vBZ/ZSmYbjOQs52CqqlnTmCUWlUcjW9PJkJUacL7Z93M0R3sgKunekCA9svIfuJ7tKLCQxvc7ODWpLp3pngKB0Ax6mkAk7C0VhdAmKp4yVy2rqVftnlmD64W/jM4g4IA65WdJTdgsf4PKiF7wupvB2K52vZlCTwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o6uBp5oS6oen8qSUDdrIuEh1nIY6l/srmMzTdjwFYsc=; b=FaTmIwofKkDgCgV5clFBjZ0Oa5emlTQ0OLdOFnrt3eJBRp930QlDr29DQ27w5V9WiyjBRKef+17DDGBAbDsjCKQ/pCG7BW/JsHrPw4d7XQTsawOutCEDb0Aei/05MMyUXHbtGElFjdHipQmF+vZbAWDDQoUS79OaG1sQFjBA6tnRZ5zMilZrzBtf55gaE0PdyGQdZ4LDuRzojkC24g2UV+r5ssT+F/xpdrvUJU1EL7PzX6ci6nulLyval5wEf/UQQZRT0vspNQTHwxR+BcGYZPbxf8pqRBeggzRS+AK8uLm3nwViUe6S0S4MVbBtyDUJcga6NuqsZNrhjf4tWbeSNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by PH0PR11MB4901.namprd11.prod.outlook.com (2603:10b6:510:3a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct 2022 15:19:27 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1%12]) with mapi id 15.20.5709.021; Wed, 12 Oct 2022 15:19:27 +0000 Date: Wed, 12 Oct 2022 16:19:21 +0100 From: Bruce Richardson To: Markus Theil CC: Subject: Re: [PATCH 1/2] build: allow to conditionally build apps Message-ID: References: <20221012144704.77973-1-markus.theil@tu-ilmenau.de> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20221012144704.77973-1-markus.theil@tu-ilmenau.de> X-ClientProxiedBy: LO2P265CA0252.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::24) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|PH0PR11MB4901:EE_ X-MS-Office365-Filtering-Correlation-Id: fed9ca84-580c-4d47-fd22-08daac6526d1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CAe6vEVs8zRdbyKI1eE20VHh7VGS+RMosU816MtdIhPCDGcAEca2VuLWDbv2kCTu6C0weut7MfJ+tIjGkTeuYI9XAMp1L4V9QnPffuYO+FipvXvJQwcjqIx0Xi55QPLzqXypI7EhMVjhVjn8mkai8dc3k9tN+kKzhamNeq/dwtnst/hSEvW5F89P+T+aeHTJujtbSrijwq/wrLchHRkBB6Z4mhZSQyF0FoIDPLgKEGxnFPMuzxrVuHEK1Suy1+EcTkQc23yl57aDEuTQhoKmu7/AtKpOy1jM/AcU+giP4eHbmnzRW9PTCYWLBkib5xcCw58/Hdxq0t2b+mJn9N+XriQvVo8qX1tJI5OPmwwPc2+taiaxzed936OcIF4zIzJqcKXhvmArzfh0mppOZYS50X/M/81oeq65U4eNHxFAWrxGG/r1y0g0Fs8RctFfYCoVrO/XP3SxKmreKtzrS7aYntqWdS3zaF8q32+aUBm4+rvXr2Mdd0YaI6OCxO4Z454yOri8U28bP5KTkMCVXIeXvJO/beG80a1JghVylL/U8CgM5hYTekl08C9qDFpoGm4Xo/B8SK5f0R+Gllua+PZp8LChnbrPDaDxL1u4H9ArT341zCLskYqO3tOGvQCug+6oi8EZ6J97JLXtGUsrowB64wv2VdTTufE7V8y5wTqD/ZPFS5WP7Q8VLPrArqams+sNmHqW63JUIEhjahfsYdSOFfrp05XbJFHcalvq676wb799Xj3ewm3EUXS8vioM1B+XgHe4lBeeBGj6E/RclTpJJQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(346002)(136003)(39860400002)(366004)(396003)(451199015)(44832011)(6666004)(186003)(41300700001)(6506007)(86362001)(8936002)(5660300002)(2906002)(478600001)(6486002)(38100700002)(6512007)(82960400001)(6916009)(83380400001)(66476007)(4326008)(66556008)(26005)(8676002)(316002)(66946007)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/LZrZ0RdXjUeh9Q8IVIbt5iV45rV8L01LHHPUmzX7Mzr/+tbJhrunn/oKJGx?= =?us-ascii?Q?PXHqla8w25alv4iND1lsrVeyFvWjYbT86e6Vfq1sYx+OeuIWaB8phyPz87QK?= =?us-ascii?Q?PzDMraJXNEN+eXu96mSWm5eZ1EkeVIXvn7R/I3pJdwBXvHHaGboMrj5U9DAE?= =?us-ascii?Q?6exDodwH+Y53nYLOW+MPLVZ9HpIJp+dttPkPkuvrM+YENlMfw+6NiHoYTtCQ?= =?us-ascii?Q?k8yVvJ7PT0Y28oOOc8Rb573mdStcDcOSzGJ5mzHrfBwHldMH/9IbmNCMWW4P?= =?us-ascii?Q?+niEGdN6nHbOOvnzzeDJJJHZW40yEBYCLP1MFS5/Iy8RAFrvLXRztTrXQbmi?= =?us-ascii?Q?6/+a03iNQDcCbWMBbsSX+biQM+0ZAb9sO7atb27OQ6xEMh2FaQdMFx3Jw1Vt?= =?us-ascii?Q?qhwFZ5VIvoWldfUwezVIMSY4KM3InrtpcCfxh9Rav4SSq6S+P2+ZRU3lhkyO?= =?us-ascii?Q?XyVo7FyhH4t5xPtsJnJanXt/+7D9uaUbQKp9XTFYbO5HUr0b8HbKLinuApDG?= =?us-ascii?Q?d7E3SUGedY/p4BGxLAcYXzrKkiV7PMm4pTJBxg4spO7v3EX04uvbkIXTz8eO?= =?us-ascii?Q?/7rMCAO1wQFyxPKlL91ks3X7gNcb18csdhoeGcQbfRS6nl/XpE7jQF2b0XeN?= =?us-ascii?Q?mak6ElDXgG6MZUCPddM6/QQULsGqQIx8uLnu9WESCV6qJQtDyQlITLuxCJH5?= =?us-ascii?Q?Yb9nYzzeR13nsV9YeXde3USc2+AJW21NnbO5WDxIL796+0JOascCBOPmmPe1?= =?us-ascii?Q?/wF+kHxf5lsbBHqcTv+zUlKczmY10SBdKGrjSKtY6QCA0WtpOmwUXfFa8RHQ?= =?us-ascii?Q?QLh7pciwZ/kRqhWIY6jDXoxNFeDcjMQEaigpqEuCK2YlXxRhRdPxApmyjiPz?= =?us-ascii?Q?2U/9MC0jd8nC2/cpPbhV5leX6TDFdMyRLQ1yfYO8Aud/FIWZiPE2QuVadsTD?= =?us-ascii?Q?Buc4sQej37slPmzMSYC6/J09TTYo1jWMvDRTWmfV4g+HpssHANdt7p/S7wnL?= =?us-ascii?Q?fWdVCRHHRnhlQWjRBxvy+oxnwZnoFg2Jv2TbQn1WLxH10C4cz5RY+uFGApz3?= =?us-ascii?Q?gBWxrofUgXBU4L2NvO3INC+VUNZjIu/zAa04Z6QeO5wKwnywbbMgnN3mEBCM?= =?us-ascii?Q?7EaFEZyyHK9Z2tz5oNEe/GzkQ4Voycx2kw8C12KdAvqQhMZGGbSMozCg2OjK?= =?us-ascii?Q?niNpnb9nl1D93Gm/9sgb8DxIO/dpUPonskRC+DYBMMPRZIXQcBg3qjtNFVwp?= =?us-ascii?Q?TIOzo3Z/Bs1GtxIlPqnEDCBlaGLridcwyrcAr5iDk0SfSwD7yOL3Q81Por2X?= =?us-ascii?Q?8v8hXsh38YGSipYmcwVEQIDSq302eW3/nUDEDRqN/36pVx3Sgcpwqcl1f8l3?= =?us-ascii?Q?VW/DCtTEoYap65rxo+uIgTkPeICW0B47BJooxKX99JlrESfy9llY5viKdtU6?= =?us-ascii?Q?i/0YFnhCf99OsQZy6lx5ed6QaNhi9xEfqbSJs0ebWDN+ZZOg6f59AeQpFFbz?= =?us-ascii?Q?y2fav5zJS4wpeYuYsgBtmIlfsOv0p11Vlja0wDj2QwwaBpJXFfNOR79sJtIT?= =?us-ascii?Q?qFL+77Uc0pjxh5ol6UrZuxYK6GIf5TcvLTd7U07ZUi1uNo+dDENSByEZSgOm?= =?us-ascii?Q?5Q=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: fed9ca84-580c-4d47-fd22-08daac6526d1 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 15:19:27.3066 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /b+mW0uG8rxABS2znkesoa1w0cYmmSKD4qm7zBN9Wx2wv5NF4VAtxWFk18GjpApxFG9lGPkXpNRzbHGnAUDbTAbUMZZ+1EkxkZVAE6v7EdQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4901 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 12, 2022 at 04:47:03PM +0200, Markus Theil wrote: > Makes apps configureable from meson, like already > possible for drivers. > > Signed-off-by: Markus Theil > --- > app/meson.build | 17 ++++++++++++----- > meson_options.txt | 4 ++++ > 2 files changed, 16 insertions(+), 5 deletions(-) > > diff --git a/app/meson.build b/app/meson.build > index 93d8c15032..4d9c8ee814 100644 > --- a/app/meson.build > +++ b/app/meson.build > @@ -1,6 +1,9 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017-2019 Intel Corporation > > +enabled_apps = get_option('enable_apps') > +disabled_apps = get_option('disable_apps') > + > apps = [ > 'dumpcap', > 'pdump', > @@ -27,7 +30,11 @@ if get_option('default_library') == 'static' and not is_windows > endif > > foreach app:apps > - build = true > + build = enabled_apps == '' or enabled_apps.contains(app) > + # let disabled_apps override enabled_apps > + if disabled_apps != '' > + build = build and not disabled_apps.contains(app) > + endif > name = app > sources = [] > includes = [] > @@ -41,6 +48,10 @@ foreach app:apps > ext_deps = [] > deps = [] > > + if not build > + continue > + endif > + > subdir(name) > > if build > @@ -56,10 +67,6 @@ foreach app:apps > endforeach > endif > > - if not build > - continue > - endif > - Does this block not still need to be kept? Is it possible that build could be set to false in the subdir or other logic? /Bruce