From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 945E5A0543; Wed, 12 Oct 2022 17:21:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6EF2E43027; Wed, 12 Oct 2022 17:21:44 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 927EF42EF7 for ; Wed, 12 Oct 2022 17:21:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665588102; x=1697124102; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=Wq62t3sjxjoIjhMnHb6kKBD3pfzsrvzuFmpE1h5T9Bw=; b=Q7ptL4wVHzLdVqiCDLBF1Ceiu4PkoAwxzgOXA3fNUY4quWPU6bDbiu8Q PompO4eWfXauJSxkhRyNTpfRUfLQ6DG4xb6vdpwXaLNQdZ5zcvFGvHgv9 0TKfL8lEHjgC5X4/YMzQDCTetWrXiQI1TsaJtLLMx4Q18jbqqfZ0ZE3Z2 QwypxMB+P/sTcigXGqr0LCyxhfWwNw44XuhRjBoBaH5zcdsX2I2VuJgWn HcHFLLD0FdhRSnCXvNPOZtqRzjhP3nLqcaZXcMObWVR0UY9CWF09kxitV wk63xj4Beh1P+UqUIfzK8RnqB9Rs9wkWayYXSgqfxulToNX2MFFC6fzZ5 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10498"; a="303559691" X-IronPort-AV: E=Sophos;i="5.95,179,1661842800"; d="scan'208";a="303559691" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2022 08:21:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10498"; a="769248791" X-IronPort-AV: E=Sophos;i="5.95,179,1661842800"; d="scan'208";a="769248791" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 12 Oct 2022 08:21:41 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 08:21:40 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 12 Oct 2022 08:21:40 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 12 Oct 2022 08:21:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BN1hGITdhYrYNnauZL/tHakaPSPZYqjaYeKT3oUeU8E/4IzD/UF+n/TrGRGj6dQn3VS68JoAE1pVWTRSZGuGc6ivQH2qfY7WD6lN6YI45vHKh1U5HZ5hTYgeuZVrF4xncgTrJZqs+Q/FIMYy34XoKmNPA1K6AmZRfHptHgP05TfdzedMfaaUJeSkujjRHxdzQaOHAGBHon9NRj9s7fElZxZmGYdIePbeYtydzhERzkwcnVQaqEZFrtgQLqS5SHgTjFOYUbocBZWwhlDQFpmTAzm2U7yBvFwDuSiFCRCSsfTwNIZA0FGfeAcUPt6spCJ9pZ+FTmavQnrn5tF6IQGQcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TfZkN8QQFA4aBsm+bAKWYmwi8B0elrmSReQT1MUWIaw=; b=KwBDJJ5M+u4GyLIJxfRN8boqy672zdYtyBqgIj4qlE7kUgJR/nQZXmx017/EZ93a0rZa1RQv7KgNtj9/eCBVMgZ3YOuf4cHD5lSgt6K99KKiRJE6RlZPaCWhrzjxlBscFf09Cvf0vYLCBWNEWLIz9L21iOgcvBSSRaWAHtZeyGJpPTK/8B4w4pnsl0489Wn+sBGaUqIueUkjeOdxA41Dj9V/o7q+ydSoMtu5yYK0ZEyF5mC5lacGrIZHRllIQZ+n4j3WFlC6ox4DAZ978QAXJIN4EWX4HLOw/fe0RoFfemyXmrBrDmpx/JvfhPMI8T2RMQsHkDh4Qb8jPeliF/o+sA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct 2022 15:21:38 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1%12]) with mapi id 15.20.5709.021; Wed, 12 Oct 2022 15:21:38 +0000 Date: Wed, 12 Oct 2022 16:21:32 +0100 From: Bruce Richardson To: Markus Theil CC: , Thorben Roemer Subject: Re: [PATCH 2/2] build: export dpdk_includes for subproject usage. Message-ID: References: <20221012144704.77973-1-markus.theil@tu-ilmenau.de> <20221012144704.77973-2-markus.theil@tu-ilmenau.de> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20221012144704.77973-2-markus.theil@tu-ilmenau.de> X-ClientProxiedBy: LNXP265CA0005.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::17) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|DM4PR11MB5994:EE_ X-MS-Office365-Filtering-Correlation-Id: 83cf2cb5-1691-43ae-3834-08daac65750d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BtrZCy7maclcSrXQPTDzQqe10w+ADJSGY6v//dDGLsQhQnquUkOWuahnzkC6dseHFihHlCBzzmL/yFm67fKaUtaad/WNnV3hojvIwWC+qCsCKSeLFqk/ztq5MMxYmECMBCsmQZjV9BURrboWFz1rywxP/v0tXJ9IdqdTOVngcoUe3qf6eR1aIorwrQvgW/4RRYLgEWb2ZCQa4F7UqFlswDDZZyKMX12xbY/6JIgSgTSbZNohLCObWeQvJNx7pjEuoFDI1v0jxVv1AM+Iv2NwubRucxySh2ZpJNyxdqB4H0lLrbL8+m5ZgNonSJKWbYnDTnWLpgZBWcgo8oxRqNd9EiA3zYxb4coNbKN/3K25FD4cAWtCugHQ1ynl8y2TXj7tHGIgtqxsL72FfP0TBWuwAPOC2t2EEIOFrG5Ox9aQ4boPrRHJ6nCbqsimT/3RTq23/B21AYC37LQBdyWSweZfN/0ESBTYr5+0Aa4bcYf8U55QkuMRJTElviv6I/qPymHfiq4g6/CR7a5YNpT6WASRmEOd1s3b/zwnuMW62HTVmJUGEq61gpSCS9ixwlA3d4ZV5U6/dJR8pIOs2g/wpiquu6dSlrIoe/c90i12FhCUI8vAmYt3iyJTxwwTxS8ttF4x0mqZCvHcgQgLCiAbHJpeE236qZg9CwDpw7N/tRQIH+9IoG5ddiko0xX+3qULJQ3dkH8UHGx49ZHIyRh/vlCB7Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(346002)(39860400002)(396003)(136003)(376002)(451199015)(8936002)(83380400001)(44832011)(5660300002)(4326008)(2906002)(6512007)(66556008)(86362001)(41300700001)(186003)(66946007)(8676002)(66476007)(316002)(6666004)(6916009)(26005)(6506007)(82960400001)(478600001)(38100700002)(6486002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5Uwl88FHf88mGq09cssBqq+M9lL3DbjZKigLcjnKRb6wgW/38DFJWFBT0Fui?= =?us-ascii?Q?myIXK8MVt74R5d5AXrqdbALWGPorPhEKFuE0OogRxJIgfuRWcV+PwVm7Qfp/?= =?us-ascii?Q?7npShZ2c0n/HoiJc0W25K8f7e45qh1ld7oSWW6KENaHdkU/OyjXns9ZCpBwX?= =?us-ascii?Q?CL+0MdXNfHAQGNHJHUNRMdeq+b7KiKO6XCcugXEn5bMzfotpxkj6rs2wkN43?= =?us-ascii?Q?AylP/13OgI4SEhhkHxJMt2UzWQEhzwPmWVFEPOHEIH/c26tCuii59eMQdsxf?= =?us-ascii?Q?cPmKcBSCuJEXyTQlXnoirnMJ6Ok1JocCilW1yyvQZPByyo6PfHTruSB/4x+j?= =?us-ascii?Q?hbC8rQI1bWg/2DBPqzCh3Qbp2w/iUPd3VbbevMEXJz/bbmZXD5NBMaPhGxPt?= =?us-ascii?Q?plSBp2lnvnB3uGF0oKzmRkUCPE0Gjvj+l4BBuDmvlFZZ5TGDnHn3bOJ52RZs?= =?us-ascii?Q?IdMjHjU1zxKaQxE6C8mhKd4LaTw84MAqM9lHmlFv4yHVe5Dk7sQinLEBAag7?= =?us-ascii?Q?I+1NAhd5otzcI82cBmsyiv3EzNhRJeQxI27kmm49lpTFtEOARzGBTIle3kxm?= =?us-ascii?Q?gmZtmlY+1bGa2hW+soBmz37fsJ+bkeBNWSByUbb+2dEPH1BVFSUbL25j7vWK?= =?us-ascii?Q?nxKcrEVd6U4wOalq5wG1OhoqWu3yndTd1TcJDcBEc5HtJ9Ewv+TBSz78XaOy?= =?us-ascii?Q?3XtujjG7qMkOKsR86DXwVu+83VFvT+7cuf3X8LvdIHdJMXNFhoo8/E2sRTfJ?= =?us-ascii?Q?bjARqkSzcWg5G1yQM8N6zhYL6RZ9gbKEQCCveOmlCC+Ss/+0VxW2WMuL1Tby?= =?us-ascii?Q?RK4OD8o5ufBdVDBcvpKKTjTg61Iufvo47X6lR3P7DbPEhjqmhuDZ1SrIuORP?= =?us-ascii?Q?HIYJ7yLhAQzNqYwCmB+9dAUF6IczB+uhSFXstEqj9HwP35KRT92I4PQvKFzf?= =?us-ascii?Q?dAtpVn9Y0Uf9F2DXcVKhOh0X0Q7NIM8QqajwVt5Pe6LnwZ/yaLZSfTrNmZVH?= =?us-ascii?Q?dR9W3sWlt9PlycQEmTi4SnhSywUz0Xi9pV/03ximTgj9kwQmVP8QhS3XlPIR?= =?us-ascii?Q?4MRsSz1AvUWqx1VOGrlYpcdhiOo+vYs3kvvu94uae9uh2KGITZHOeEWmbvBA?= =?us-ascii?Q?DHzM6PwEoTyJXnzSOREqWET2IHL+mj+jwU3eLqS5KtzAJBh/DP8v6Zh5Mwlb?= =?us-ascii?Q?lj7+bjtwLcjFglZbmCE3rRkBIwAdMm2CB4sXBo7r2o0AO3Ca0jGYlR7tccBT?= =?us-ascii?Q?04yrXt+OOinG0KLrfdwqiZaSiX0lLAcIj/INZvJt4AmNZpYZKKPBFztfVmoi?= =?us-ascii?Q?b56p+zui1PWVCR7/QElXv0EabhfuGLq+NfeYoPTYBC6CZlIacuc7P0YMjNR2?= =?us-ascii?Q?Y4OZhkKNNnlTm/LekPI3sfvZrMhf/lfx+g5CxlvbjUd84GXPMiPtw53272M5?= =?us-ascii?Q?ELLaYSKOGiInynBZQON45NohF/yTkeK1NFZw/Vrla9ATbYA0KZvyTxqYmb0L?= =?us-ascii?Q?L6Him1J2ueDdfPBzIlR4o3DUnY7t9BSkfsgaojG0NW6YS2fNvQz9/SHeCHbM?= =?us-ascii?Q?Og9R00d7b2J+NZ+fve50XGaPGyzGzVHJnxKYD+Y0yGxNiOFeY3ambvhzXhQv?= =?us-ascii?Q?Gg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 83cf2cb5-1691-43ae-3834-08daac65750d X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 15:21:38.4321 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wVALwyER/Uhfl0LvOVIkEWKRWkeKqfL0Ko0Fznc1OTOOgbEjo3/GN2sa7jeJmQdk+BsefzR74d77nmClmfwEeYPbuQZtuqOGwt0n8UjrWCg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5994 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 12, 2022 at 04:47:04PM +0200, Markus Theil wrote: > From: Thorben Roemer > > In order to perform things like LTO more easily in > our DPDK applications, we use DPDK as a meson subproject. > Also export includes in order to be usable in this context. > > Signed-off-by: Thorben Roemer > --- > drivers/meson.build | 1 + > lib/meson.build | 1 + > meson.build | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/drivers/meson.build b/drivers/meson.build > index 216971f4e2..d19b47df12 100644 > --- a/drivers/meson.build > +++ b/drivers/meson.build > @@ -95,6 +95,7 @@ foreach subpath:subdirs > objs = [] > cflags = default_cflags > includes = [include_directories(drv_path)] > + dpdk_includes += [include_directories(drv_path)] I am not sure that by default we should include all the driver directories. At most, we should only include those drivers which have header files to be made public. I think initially though we should only export library paths. /Bruce