From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id D4963A00C2;
Wed, 2 Nov 2022 13:10:15 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id BCD6E40223;
Wed, 2 Nov 2022 13:10:15 +0100 (CET)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by mails.dpdk.org (Postfix) with ESMTP id 569CC40041
for <dev@dpdk.org>; Wed, 2 Nov 2022 13:10:14 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1667391014; x=1698927014;
h=date:from:to:cc:subject:message-id:references:
in-reply-to:mime-version;
bh=fa9/Y68TIZcN7Yj1PJ3VM5JiCYJv6qJRMIdLF9QUbv8=;
b=ggxOQ+HRgo//kwnDZW8UWjBR3coHv1U1nowMQ4/O+7L+pIVzgiBsRHwb
XwXIYxdnswQSTQkQ6BzupNuaopA/PMUeDrZ9rqA9FqYVcs/nFs/sOH3DQ
H2e3atOV1VgiqfYoCHTLjbZUVVp106zj+szazSLfvzvXlc9lqSQ+H1PAo
RpLI3u8uVJeYIcb+rNxi2YGTqBgUIM0kwDl1cQPxNfs2rsOz7JksgYK4+
hoZju4AofnrLfIDbVWnb4rM72hhrAUtwSUEmsXjoQUJqXwE2haofCtEdv
sm3QN7c/39C0df0AfozOG0A6WQjh8lX5M1mtdncFubrd9thAEXNAdcHWe Q==;
X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="336067947"
X-IronPort-AV: E=Sophos;i="5.95,232,1661842800"; d="scan'208";a="336067947"
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
02 Nov 2022 05:10:13 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="963504160"
X-IronPort-AV: E=Sophos;i="5.95,232,1661842800"; d="scan'208";a="963504160"
Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82])
by fmsmga005.fm.intel.com with ESMTP; 02 Nov 2022 05:10:13 -0700
Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by
fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2375.31; Wed, 2 Nov 2022 05:10:13 -0700
Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by
fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2375.31 via Frontend Transport; Wed, 2 Nov 2022 05:10:13 -0700
Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.49) by
edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2375.31; Wed, 2 Nov 2022 05:10:12 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=ctIgL90WdMvR9UNjwuH36TfTT9FX/sK5LExcyC4Q00aP6YyvhwIOXYYPNYn6fzjpYsRzom+dfVSYKvGqxKDJfyVzL6HGUoC8YxxaOFmURPSoipVoqY4wwRs3FonBzHVHshpj5Z3Aoz4IFvPDn1QGMMhVA5DB6M5a1EqZvDvLJ5ekvzpQGxy9Jebg40PnLe2C967f2r1epLjc0tukEcfUAbQ0PC5NP+BrFxUGZ/YP/ftfzr1Hl7vN5C9hqMlljPeAWrBBs9rtN9z+TSp9uDeyhaBluVoqQ07/8+ekoK9bcxIUR3j7mx3h41xUcj1I08AsqfIU19QncblyaXle9Cq4Lg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=WBrO5PWBt6XlVvvUTv1iNgjUWzVuIKSLBDy/17dn0w0=;
b=DO4Ld78iQtOJrPBJqaS7VaXUdhddI3qC9JNLFobPWfvw5bEvkoP8NYgM/BC8VAC+SJK8nErEyhSWV+VixyRjF02cUaRDbiUSL3XPrg5FZniuuxlJL6q132/NrKun0XmxAO0LDCs4yP6SK3zxGHqCtnrSPSr3mR6wyGtQNf1PcQbkUn6AF16IWrxk3p1w3Hp4buNc1eR+/4AdsFBUxJCFyazJU8//ZFZdB/Vov1Ac/2JF+o4K+ayevUvY5bc6/zQOKp1LrxPVE0EaJqKAcV2OXewef/6tZb7TLVpgBergsBOvRExkRkYw11Lk7609A60xreoOB6GrH01RFX3STXM+zw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
Authentication-Results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=intel.com;
Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21)
by MN0PR11MB5962.namprd11.prod.outlook.com (2603:10b6:208:371::18) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Wed, 2 Nov
2022 12:10:10 +0000
Received: from MWHPR11MB1629.namprd11.prod.outlook.com
([fe80::55af:6b82:6c7f:6c]) by MWHPR11MB1629.namprd11.prod.outlook.com
([fe80::55af:6b82:6c7f:6c%2]) with mapi id 15.20.5791.020; Wed, 2 Nov 2022
12:10:10 +0000
Date: Wed, 2 Nov 2022 12:10:03 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
CC: <dev@dpdk.org>, <valex@nvidia.com>, <ferruh.yigit@amd.com>,
<andrew.rybchenko@oktetlabs.ru>, <rasland@nvidia.com>,
<david.marchand@redhat.com>, Matan Azrad <matan@nvidia.com>, Fan Zhang
<royzhang1980@gmail.com>, Ashish Gupta <ashish.gupta@marvell.com>,
"Viacheslav Ovsiienko" <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>
Subject: Re: [PATCH v2 1/2] common/mlx5: fix build disabling
Message-ID: <Y2JeG+XZ0bXcrPfS@bricha3-MOBL.ger.corp.intel.com>
References: <abaa5419-b66e-ff21-a5b8-da953a8542ec@oktetlabs.ru>
<20221030082722.1333530-1-thomas@monjalon.net>
<20221030082722.1333530-2-thomas@monjalon.net>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221030082722.1333530-2-thomas@monjalon.net>
X-ClientProxiedBy: LO2P123CA0084.GBRP123.PROD.OUTLOOK.COM
(2603:10a6:600:138::17) To MWHPR11MB1629.namprd11.prod.outlook.com
(2603:10b6:301:d::21)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|MN0PR11MB5962:EE_
X-MS-Office365-Filtering-Correlation-Id: 238c07b4-f7a6-4eed-0024-08dabccb3079
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Z5rPY+5rCUm2dzbKGk+4uqEfUU2TOVSKKXqFn/hQ5hX3RG18HQoA9xqgK4+aG+Z9LHAmPV8RMj16FntyVNJ2NerJeIu1WOJmgjgpgwxI2szY0rZWbpYiwt08DHGM6DW9D1e6+PHGYrmgxCJGShmw21dL/lRFghsPzKHrGhegqSnQxkLGg0ICoKRb4TPI2xOBokAcoTFJ4XtorClc+mQsZcutOMmpdo7UDiB8uHeZL3fcigq3CtbsftzQ9kU9a5MwPSD8v2Df8L50STm/Kp+1zE3/IeTwTqdX40fg4aO+ZtJZnk3ETgGQFq9Zyo/99UZRUNIM5Jm6VVvp8uyP062aHZu/BUvFpe1VN+56mDcRI+JxLcJWIojQEBUnNIKn8KNFW22JYVnIEgY3wWL7JFs13zTdzrwmQNCDgFeJr0HdGolhW8ymQOcAoCUyDYfDOD+dAxGPQpph6bajmkUY1yOUUYdIXYwiRQ42jnuRv2rIjxiqizyUTSBUNA/Rbr0J7rzzvB1elUZo/HeGvaPIWtfSFtEyFHNtaz9MVOn5cs4BpoCsD58/GI0EhZ8rt7UnJmmq8PnG/N8PWACagKCpdoNQIBnz+sl0eAb4Q/GsfN+hxiEskWCw2TFlq+FaaDDR6dhYjrXcipVPlJOyHTmqPXnwadycWWakaQRxLqsCXMBxQpUu+XQ2pXRQlhrLBxFZHt8b4MXICb0K39GuybYfkjb0sCGo+9TCPMc4jUCndnrhZiwNhsvGtJ62qIZJOnTynqio
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230022)(346002)(136003)(366004)(39860400002)(376002)(396003)(451199015)(6916009)(316002)(478600001)(6666004)(6486002)(66556008)(54906003)(8676002)(66946007)(4326008)(66476007)(44832011)(6512007)(8936002)(5660300002)(7416002)(2906002)(186003)(26005)(86362001)(41300700001)(83380400001)(6506007)(82960400001)(38100700002)(67856001);
DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lcgKhBMRrE389Ts3Ia2j50AoexkQSKCtqyC/pddsvHrAswhIIXcG5vt7ezl9?=
=?us-ascii?Q?8FrYuu9akmTOLvSgjkNOcSRGfmEoc0fGv8JS8IM3W7POisdHlArOPKVywXUj?=
=?us-ascii?Q?rpcmnPn7jwv4gV6VwNWS1mTAGBgXD0OvnhWs/OsD9PgzIUq41IdCB7bCmjMp?=
=?us-ascii?Q?mlll5xwYj8vqzeuxD3ik3Smj8nv0VNIQ8D0EpIixgOXyhJAZMeqf61H5+Lyo?=
=?us-ascii?Q?VJi0vyw8TxvX7/9C9osxO4Dpi1euKzRlzQQT8vkFsPYCSPhidRx0NzqoeCdU?=
=?us-ascii?Q?Y4A5H1iNaBP3oll7xGktqyLowlbknAFu4M9p7+sTEqUWFsHwhKf4guheRnnJ?=
=?us-ascii?Q?zmdPypMoCzXqf24Jn1Dltiu9Ia9AmQKXyVVQsJ10gjH4aRQ4vN3riIidxTNs?=
=?us-ascii?Q?8Pj2RiuPZ09cjQJHpTn3xHoO7EIxjgQiPx/P8s5HUL+L+0sneqqAGE+A0F3+?=
=?us-ascii?Q?stMCXyHFJ3REavKhVe5nEipBZxKaOLAFnDBDt24ZRdGiUh938G1dnuduUfsG?=
=?us-ascii?Q?0aj+AdsY6zBtDd1SeTcCL6oL6sc4BmQVYk0Sl93L082GcgeS5Akh42FwVvKx?=
=?us-ascii?Q?aT1nylzZBDnnDSgmvTd19g2sQhUAqMk89tFceRhqsdZbVCowR8kvaT4skBjn?=
=?us-ascii?Q?jfiFpZrZ2wVR2zKpiF9Padn1g3WdThPBj31YwJx4ax/GXa/gre3d1bObgqId?=
=?us-ascii?Q?YCdH4y556/ibrn246wDKGEQeLP+8c16PSkKk8CPayQZ1D78b35O1sZ/ZlLz1?=
=?us-ascii?Q?46EvqD3i4eEBBLGe4M1kYVVFiIBVeI1XdasOdN5GstkVoIsbCRKWM3A6fHQm?=
=?us-ascii?Q?jzUhuwoLCSR06hvrEvdnhF9k4GWx7fqopMWNv+9eu/ecOoWZiOfTTqTdAKPj?=
=?us-ascii?Q?VDsF6y4XK+TBk7BZfvW1zYxmHDqii2YcvhThXPABSaiXJHrC7UgbXK9D01no?=
=?us-ascii?Q?yn1FFjsOL2ChpGTOn3b/JdNlMMrFWo0+QzG5/flVb1K4xxGBolRjMgkjiPjk?=
=?us-ascii?Q?41Lp9zNhIOIThTWNgObXM225RKciz9F6phuJMNEGEkIIDWR3/YV3MzxcU7Ar?=
=?us-ascii?Q?fq6zjhESzpBoJ3G4FViT1K+TTBKqedThyr0LQeJOHm/xYYO2JdC0TEpDXjSX?=
=?us-ascii?Q?ZeV+XUThUin+TP+yXWA6ZToKB4xW2IzVJlDdFqdYl6QWW74+bwKzPNHOy30Z?=
=?us-ascii?Q?W92hqKNQrYESoaVfes3i4WsmDNjo4x9nnAR8BZ7hKh1IW47mzkv2+eHi65N8?=
=?us-ascii?Q?EndUxwsaKG4gn+yHtZgnwmROUuDhbzx5Pk2rCeb1Hr18149krczOUPFnmQfP?=
=?us-ascii?Q?PfyOJPTT7FxCAHh1AJ7ACFbvDducwVkzzNMZIMlHmTrztdqoCn8YxFHdrBBj?=
=?us-ascii?Q?5vPCAugkfZ43U2cNEbKk7tj3piym0CQmirfEdoYmGX7pVxJ3OFyGw0oPPhKS?=
=?us-ascii?Q?/Dg5h/1J4tIBeCAwpqOsjAF+OjW/3aotkk/EIwCcCmhs06RnnLdVtPJLrt+T?=
=?us-ascii?Q?QiuQh8ID3Zmcro927bwN/4ZCISOEO2lAx91J3MxTSQLCvLqAGuH3O/KLTu7m?=
=?us-ascii?Q?XQsy64t15J6ekI1uxiaLly8n62i1vnig14/MG06m0S1B1ii8+WMt8s+nmXnK?=
=?us-ascii?Q?AQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 238c07b4-f7a6-4eed-0024-08dabccb3079
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 12:10:10.7090 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0vCuMeuNLJD7Ii29tY5mrENtjWy2eYHUf9b4a6GFZtqiXZlXdPT300t1Q7Cp0SDA5koHCeRWP+n6NIA0uDxzlpxYzcllDcGe7K7NPhttiPE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB5962
X-OriginatorOrg: intel.com
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Sun, Oct 30, 2022 at 09:27:21AM +0100, Thomas Monjalon wrote:
> If the dependency common/mlx5 is explicitly disabled,
> but net/mlx5 is not explicitly disabled,
> Meson will read the full recipe of net/mlx5
> and will fail when accessing a variable from common/mlx5:
> drivers/net/mlx5/meson.build:76:4: ERROR: Unknown variable "mlx5_config".
>
> The solution is to stop parsing net/mlx5 if common/mlx5 is disabled.
> The deps array must be defined before stopping, in order to automatically
> disable the build of net/mlx5 and print the reason.
>
> The same protection is applied to other mlx5 drivers,
> so it will allow using the variable mlx5_config in future.
>
> Fixes: 22681deead3e ("net/mlx5/hws: enable hardware steering")
>
> Reported-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Tested-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> ---
> drivers/compress/mlx5/meson.build | 5 +++++
> drivers/crypto/mlx5/meson.build | 5 +++++
> drivers/net/mlx5/meson.build | 5 +++++
> drivers/regex/mlx5/meson.build | 5 +++++
> drivers/vdpa/mlx5/meson.build | 5 +++++
> 5 files changed, 25 insertions(+)
>
> diff --git a/drivers/compress/mlx5/meson.build b/drivers/compress/mlx5/meson.build
> index 7aac329986..49ce3aff46 100644
> --- a/drivers/compress/mlx5/meson.build
> +++ b/drivers/compress/mlx5/meson.build
> @@ -9,6 +9,11 @@ endif
>
> fmt_name = 'mlx5_compress'
> deps += ['common_mlx5', 'eal', 'compressdev']
> +if not ('mlx5' in common_drivers)
While this is fine as-is, I think the more usual way for checking the
presence of a component in DPDK is to check dpdk_conf. In this case the
check would be "if not dpdk_conf.has('RTE_COMMON_MLX5')". You may want to
consider using that for consistency.
/Bruce