From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00CC3A00C2; Wed, 2 Nov 2022 17:09:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 944DA40694; Wed, 2 Nov 2022 17:09:24 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id F33D040693 for ; Wed, 2 Nov 2022 17:09:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667405362; x=1698941362; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=G78bDBXp0O85KW86lk7gYTX+AYmCz33bnQQsdDYNw9A=; b=FNFnKBPaJUy4uIJVuB9ZXjR769C/FPs83W22Zv/EXfVGdmOlyQoIQFjz wzcpnwULdr0qKxLvvXR9n069Y/GsfKHRzoFF5wmrX17Nump8AN+6SZVPu 6cOZVpjB3xWO9VTQV7CdFjDvkaxdp/VIaTr3Bx4k5wdKdyurvjDGe/ok5 TlR4Ynuctdu5TDSnmvoA0UJxSJ5aYHcn/PID/+kX3TsDTo92tD5DMrDPO NwC5fSIZwE2o/V6tIdolIbYuqaRLSjkwvcANCqUD1efTlyW4HYY9ZqAUm 5jusikyNSxBeWiGIAxAv61YlHmFxPX6Dnko0AXkunA4aPW8QoQurZPwT9 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10519"; a="296897935" X-IronPort-AV: E=Sophos;i="5.95,234,1661842800"; d="scan'208";a="296897935" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2022 09:09:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10519"; a="703326569" X-IronPort-AV: E=Sophos;i="5.95,234,1661842800"; d="scan'208";a="703326569" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 02 Nov 2022 09:09:18 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 2 Nov 2022 09:09:18 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 2 Nov 2022 09:09:18 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.45) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 2 Nov 2022 09:09:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EALavR8X06jcoFHnfinoJWPAJIIGvgqzP8kdISIi5MEDZBSXqvauXd5yK2XmI2ZxWQBtCCfXPRR4RWqfocOL1R8LzWeWPauhx1CsXhYzY1BcMDLg+luM91vZoM7q5i0niyxO27ZVFDw6Td+sioLDRPN+ASYFYxf/TJUQ5ox2kQE7alg/S6f4J9jIE6iZc/nVkbRufk7gHJMM7kFxoXuS1+HQBE1D7StCUFAV7Zz9alchgEJg1DvUiDRYl1O+Ntn3KjBJlGaqeRA/XEFPvsxaWpfb1FTr+dNUxD2u3whWh/o1Xcln6gR/GqRQk963kukS4EJFlM23jP3JbyUHD8fHfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hrkv+PRKLZBHAYjaG9H6oJoj3PDQNeJkCP3n9oRMk3E=; b=IncEzyitWvx0L/Y53lCuXuYnybmuFuw6M9FJB1vpyl93ydBXLhq6akifeg8oVa0VvPX9qdN4Yf2KnYrpyvTqBW9PNjQ4D3K7hIMiymwcUZulUEMu1723CzNnQ9Kc6Bu2FaZ/J4/Cw8IeQ6Us1HFOnF57RbbVkhXdcTCAUhpwrKqdi4sMDu3+/EIFF66t5zJzHrNTPRwET6DIKTK/CYLS7SR88xf+B/At8MigJm/Z7w7oiDNnpAqrZDjcfb5axLmSJJjAZIheS7SirHGGVRH9TNzGd2IJ1BwY8qHADwr0UqeFefEfO0f8zJF21Zmm50DHvmR/MtDAGPCv8KfDxepnrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by PH7PR11MB6794.namprd11.prod.outlook.com (2603:10b6:510:1b8::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Wed, 2 Nov 2022 16:09:02 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::55af:6b82:6c7f:6c]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::55af:6b82:6c7f:6c%2]) with mapi id 15.20.5791.020; Wed, 2 Nov 2022 16:09:02 +0000 Date: Wed, 2 Nov 2022 16:08:55 +0000 From: Bruce Richardson To: David Marchand CC: , , , , , Subject: Re: [PATCH] cleanup compat header inclusions Message-ID: References: <20221102150828.2161307-1-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20221102150828.2161307-1-david.marchand@redhat.com> X-ClientProxiedBy: DU2PR04CA0069.eurprd04.prod.outlook.com (2603:10a6:10:232::14) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|PH7PR11MB6794:EE_ X-MS-Office365-Filtering-Correlation-Id: 40b09552-dc87-4ac0-f296-08dabcec8edf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6jrW+i2hs0uqwblIGCIj6LiARusugWZBbiJqxEMnatZToc7VJCcLxrtuqJwi72LeLpy7U9X+JPzdA89cU7tC69YYSztNrVagdui5BpAZAcLI0D0AVpDiKQ40tPc4Ewv2CCxSG4h6XLMT+6mbE+lsvjm4M+ICAHnRrsr1sGtTe6mieB0eqvxgp0nqcoprdtb1AkBWcFi9U2MdZSNg/+maXTEQ0H0Bj59zzqb/23tbJhMBKv47U6/fiM4AJNFZ3b+kyvDXa5aVKUTNDK9LkcUzi+2eXy27vLB+jpbG0oXYzCf1jC2MprDG6mR1lSnUrn+em92KRRwEOSASOdNdri/nBDqxw2hlKBXFSqEd0j92jIhG4Z8uiDM/GoeFZSyD+aAcWg1j6HOeyWa4uvHJJ69ce5zLQikAT0KbcCqcghiFObA4xwGnJ14kQ/UHXb10V3TskfwWqLNiDPfV8L5bpnHaWZuDYxjXjHgSYjq1GetDpWxVK7kl+pAgEvLRTJ4EOIIczY175dGE8QLJi2/1QLpp30QmaXVNx9BUhFo2ncYe9nfMdvDi8DRxiFu8+HRIgXvHcydZDjmRrJTf2ADmIWs5OqhZPMNyyTmhQ/4zzmzc6oP3l8S5BgAj2yaaZfZr+87Kc8W6lAws83Bouisgu2AUh4wvROCp2LlqdmKs+4atI+MFVWVTgC9L3RYKN0SEc1V4W01EFOytCihq3n0v7+2nWA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(39860400002)(346002)(376002)(396003)(136003)(451199015)(26005)(66476007)(38100700002)(41300700001)(4326008)(8676002)(6512007)(6506007)(8936002)(6486002)(5660300002)(6916009)(186003)(66556008)(478600001)(66946007)(6666004)(316002)(44832011)(82960400001)(2906002)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+t3OxSRl9GtKswe94+Xrjiu6EijXsaupkaY01nFlExHLW3CNumd0rPyMy5PB?= =?us-ascii?Q?g+Idsbrum3mE8wTA+j1P+LDcKq7zFLd1cLMoED2ShJYasRDdmAK3crWwsTPH?= =?us-ascii?Q?C33iZitPoW7dbPfTwq4Q5To226dF6Pvqr0qigk1tqJx3gt7XftnlamMOkBj/?= =?us-ascii?Q?NO5iRL/Akancmjp4m1cjUpWzjYsLas2u6E2Q7/Ga41WUAYXrsIBJ9rBg+34k?= =?us-ascii?Q?yTd5mrIPZw1/qI89VUDWGbFZYjvI1g3eVEzkCXiEcapt8PqICXSN7q0NAapn?= =?us-ascii?Q?DZMaWkkkcq66yUxxyvii/ZYAB9sHdkzlgzEZb4AXpqaC7tj2dP99VvOpqmwV?= =?us-ascii?Q?QSVXm1EI6u0OmHkytSyYfMNWZjyEdaOXFqzEfpfEXUayLtOgrOJu7iu79TRI?= =?us-ascii?Q?h/2wazBcC+nzN2pwSt48aqmrclLpov9kXe/ZxYZSRfS/okOBBU9B1lTKUn4G?= =?us-ascii?Q?j6wHOY29fEYP8kuI3p4DDZRtsrb6B6itrNEFT+fpMlgQ9K40Cz4olLRky8dY?= =?us-ascii?Q?8xbIlHUSsTUqD6ACneeG0jDiM8JfnQpVQqQym8fvwQnf4n9j96hAdYzPCMiY?= =?us-ascii?Q?c1kUcuKh/tmBKy7ARGLCM3icbV6Ow1IZaCWcD2vEEuPK7+hQeR8TQKTO7Qrc?= =?us-ascii?Q?Z9NGY8Q3TOiP1BMXB43hs8vG8P7PCErE/xpoxvboRceqBEdOiXdT6g6gwRxJ?= =?us-ascii?Q?DAuvUmimtGqzPrtkUs+JOuhT0PwcY0Pn1xSQCorXpXY9IbO9lhb1gYgVreWZ?= =?us-ascii?Q?esHy0xuVWu33cp0jw7+4BYCTmhwqqoBw/B00vFdDrIOM7ArReE5ShO1BdMM1?= =?us-ascii?Q?oEGKQwZ6fReN0OkDFOvoOBNL4dVZbxKRDjte97KBerSQJ/n+XShWwUAVhkPF?= =?us-ascii?Q?wUfPizzhGr0yKDK3yKkeVFQfvSTK86Q4m1dkg58Tcivrko2W3eInTqacfG/r?= =?us-ascii?Q?QwFMvyNqO9bzCnP2AMu9bsVHkaz3CD5b71bJZBVx9T6f2BkJy+7+rfBjdfHe?= =?us-ascii?Q?FH+EdX6xTMkTNjS98y9SNp70EK1kRjHwbAU7/tFjODym5Uz9lKxDn9sNscUc?= =?us-ascii?Q?+83RSrjd6UlLC1dZQ23Xs4uWpO3nUN89h0TOwP1NgOhcLz+2apu5msKir9Mt?= =?us-ascii?Q?zwj8UhC1Y+cVmjcGZsLjfK6LF4knzV096E9LI1Fz+772ILlmOgh2triTsmTs?= =?us-ascii?Q?8ZWXiQ6NcbjxjmAAQUMzpqCZpzgX/4avG8MNBRhbGzKhU/PNaQ9a9E/7LTm8?= =?us-ascii?Q?hcux4pFYVlX4N33rWPvJagLMGs3Pgs5inUyISRezXlxL80mtU9z1f6doDaXz?= =?us-ascii?Q?8zi8+Q9Ds1vq/tmcKu37FLmd5d3LGoDlQzd25MdGrFfzfoDccKm3XHhxQxzD?= =?us-ascii?Q?GRyroGjOYVS+wO+jUSx2/oXPIDZlT+yQQoagwwJWSZPSHkt8X7ZdsEFYSuH7?= =?us-ascii?Q?A+ONt3ispYeLitLj8KaDgfaXIiFM8u91WXv88Kae/EKirTGbfw8cfuwAZqPc?= =?us-ascii?Q?sP+uCHp8vYOt6ztE8/8i2mqxLYcGO8MUu9SSBkV4aRKvxkh7k0iVEer3cq9C?= =?us-ascii?Q?z/OeVwMEaEo2cqx0KU43c/bSHEsIq3fHamXxCrkmpJkWXh2SLYgiMFU5C3ci?= =?us-ascii?Q?ZA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 40b09552-dc87-4ac0-f296-08dabcec8edf X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 16:09:02.3878 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J+d0bKYxydU0OZONpakmsZFKrwNIJbw6Uvn/gBi0H0y6m6ZoYbryFT92T7BfOSolbhyiXC8ZO9+9BLTVnLrSdsergOguudb3WVMGf/0lqFc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6794 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 02, 2022 at 04:08:28PM +0100, David Marchand wrote: > With symbols going though experimental/stable stages, we accumulated > a lot of discrepancies about inclusion of the rte_compat.h header. > > Some headers are including it where unneeded, while others rely on > implicit inclusion. > > Fix unneeded inclusions: > $ git grep -l include..rte_compat.h | > xargs grep -LE '__rte_(internal|experimental)' | > xargs sed -i -e '/#include..rte_compat.h/d' > > Fix missing inclusion, by inserting rte_compat.h before the first > inclusion of a DPDK header: > $ git grep -lE '__rte_(internal|experimental)' | > xargs grep -L include..rte_compat.h | > xargs sed -i -e \ > '0,/#include..\(rte_\|.*pmd.h.$\)/{ > s/\(#include..\(rte_\|.*pmd.h.$\)\)/#include \n\1/ > }' > > Fix missing inclusion, by inserting rte_compat.h after the last > inclusion of a non DPDK header: > $ for file in $(git grep -lE '__rte_(internal|experimental)' | > xargs grep -L include..rte_compat.h); do > tac $file > $file.$$ > sed -i -e \ > '0,/#include../{ > s/\(#include..*$\)/#include \n\n\1/ > }' $file.$$ > tac $file.$$ > $file > rm $file.$$ > done > > Fix missing inclusion, by inserting rte_compat.h after the header guard: > $ git grep -lE '__rte_(internal|experimental)' | > xargs grep -L include..rte_compat.h | > xargs sed -i -e \ > '0,/#define/{ > s/\(#define .*$\)/\1\n\n#include / > }' > > And finally, exclude rte_compat.h itself. > $ git checkout lib/eal/include/rte_compat.h > > At the end of all this, we have a clean tree: > $ git grep -lE '__rte_(internal|experimental)' | > xargs grep -L include..rte_compat.h > buildtools/check-symbols.sh > devtools/checkpatches.sh > doc/guides/contributing/abi_policy.rst > doc/guides/rel_notes/release_20_11.rst > lib/eal/include/rte_compat.h > > Signed-off-by: David Marchand > --- Very nice work, thanks! Acked-by: Bruce Richardson