DPDK patches and discussions
 help / color / mirror / Atom feed
From: Taekyung Kim <kim.tae.kyung@navercorp.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, chenbo.xia@intel.com, andy.pei@intel.com,
	stable@dpdk.org, xiao.w.wang@intel.com
Subject: Re: [PATCH v4] vdpa/ifc: fix update_datapath error handling
Date: Wed, 9 Nov 2022 19:45:14 +0900	[thread overview]
Message-ID: <Y2uEuvTXaUCtMDLW@dev-tkkim-git-send-email-ncl.nfra.io> (raw)
In-Reply-To: <a3a4e77b-0fee-6df0-a049-6ac071e48b72@redhat.com>

Hi Maxime,

Thanks for your review.

On Tue, Nov 08, 2022 at 02:49:39PM +0100, Maxime Coquelin wrote:
> Hi Taekyung,
> 
> On 11/8/22 09:56, Taekyung Kim wrote:
> > Stop and return the error code when update_datapath fails.
> > update_datapath prepares resources for the vdpa device.
> > The driver should not perform any further actions
> > if update_datapath returns an error.
> > 
> > Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Taekyung Kim <kim.tae.kyung@navercorp.com>
> > ---
> > v4:
> > * Add rte_vdpa_unregister_device in ifcvf_pci_probe
> > 
> > v3:
> > * Fix coding style
> > 
> > v2:
> > * Revert the prepared resources before returning an error
> > * Rebase to 22.11 rc2
> > * Add fixes and cc for backport
> > 
> > ---
> >   drivers/vdpa/ifc/ifcvf_vdpa.c | 27 +++++++++++++++++++++++----
> >   1 file changed, 23 insertions(+), 4 deletions(-)
> > 
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> Thanks,
> Maxime
> 

  reply	other threads:[~2022-11-09 10:45 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18  7:22 [PATCH] " Taekyung Kim
2022-11-02  9:12 ` Maxime Coquelin
2022-11-07  5:34   ` [PATCH v2] " Taekyung Kim
2022-11-07  8:59     ` [PATCH v3] " Taekyung Kim
2022-11-08  1:46       ` Xia, Chenbo
2022-11-08  7:30         ` Taekyung Kim
2022-11-08  7:39         ` Pei, Andy
2022-11-08  7:56           ` Xia, Chenbo
2022-11-08  8:27             ` Taekyung Kim
2022-11-08  8:56             ` [PATCH v4] " Taekyung Kim
2022-11-08 13:49               ` Maxime Coquelin
2022-11-09 10:45                 ` Taekyung Kim [this message]
2022-11-09  2:39               ` Pei, Andy
2022-11-09 10:47                 ` Taekyung Kim
2022-11-10  1:53               ` Xia, Chenbo
2022-11-10  4:02                 ` Taekyung Kim
2022-11-10  9:20                   ` Maxime Coquelin
2022-11-10  9:34                     ` Ali Alnubani
2022-11-10  9:38                       ` David Marchand
2022-11-10  9:45                         ` Taekyung Kim
2022-11-10  9:42                       ` Maxime Coquelin
2022-11-10  4:09                 ` [PATCH v5] " Taekyung Kim
2022-11-10  6:12                   ` Xia, Chenbo
2022-11-10  7:02                   ` Xia, Chenbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2uEuvTXaUCtMDLW@dev-tkkim-git-send-email-ncl.nfra.io \
    --to=kim.tae.kyung@navercorp.com \
    --cc=andy.pei@intel.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=xiao.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).