From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BD54A00C4; Wed, 9 Nov 2022 11:45:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 432DC410EF; Wed, 9 Nov 2022 11:45:18 +0100 (CET) Received: from cvbackendsmtp001.nmdf.navercorp.com (cvbackendsmtp001.nmdf.navercorp.com [125.209.246.148]) by mails.dpdk.org (Postfix) with ESMTP id 492CD400EF; Wed, 9 Nov 2022 11:45:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=navercorp.com; s=s20171120; t=1667990714; bh=aCdcoy9nYLU9wXPUF2ZxQPTkSgHfaju32CJ3eg49B8s=; h=Date:From:To:Subject:Message-ID:From:Subject:Feedback-ID: X-Works-Security; b=ze9Pux2wcgYVnazKFawViufQnKJenuojiBm1kadpbIsSCDVtB0CZ3JNkl5P7W4ZNc iXL6F0Lbc9HJNB6r/9FebK8c77HUGDY5FRsLwRDeEkeeOYEFWjGmuvxuRpqqZz9aPy U4UI1o0F07u7NEyQeImSBpgLZc5uffiMUflJGbmDsyT6wsq+QfJs77BNLSucyLmrn5 rf4l4QmZyWXyKqH+2fLE4USOctH/I0a+EQCAABKO/ItDjYAdxWq8280HoPwYxiWcyS N31CpBTl1qvpB29O760/oTAk6eI7t6EIjhRDdA1Vo7RAcx5R6AwoI+RzEtcKI/RCQ9 SHnz80yBedt9w== X-Session-ID: XxIORHm5SRmH-oH0HRAimg X-Works-Smtp-Source: V9Y9axbrFoJCpNmdKxK/WHF0 Received: from dev-tkkim-git-send-email-ncl.nfra.io ([10.113.149.62]) by cvbackendsmtp001.nmdf.navercorp.com with ESMTP id XxIORHm5SRmH-oH0HRAimg for ; Wed, 09 Nov 2022 10:45:14 -0000 Date: Wed, 9 Nov 2022 19:45:14 +0900 From: Taekyung Kim To: Maxime Coquelin Cc: dev@dpdk.org, chenbo.xia@intel.com, andy.pei@intel.com, stable@dpdk.org, xiao.w.wang@intel.com Subject: Re: [PATCH v4] vdpa/ifc: fix update_datapath error handling Message-ID: References: <20221108085624.53989-1-kim.tae.kyung@navercorp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Maxime, Thanks for your review. On Tue, Nov 08, 2022 at 02:49:39PM +0100, Maxime Coquelin wrote: > Hi Taekyung, > > On 11/8/22 09:56, Taekyung Kim wrote: > > Stop and return the error code when update_datapath fails. > > update_datapath prepares resources for the vdpa device. > > The driver should not perform any further actions > > if update_datapath returns an error. > > > > Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") > > Cc: stable@dpdk.org > > > > Signed-off-by: Taekyung Kim > > --- > > v4: > > * Add rte_vdpa_unregister_device in ifcvf_pci_probe > > > > v3: > > * Fix coding style > > > > v2: > > * Revert the prepared resources before returning an error > > * Rebase to 22.11 rc2 > > * Add fixes and cc for backport > > > > --- > > drivers/vdpa/ifc/ifcvf_vdpa.c | 27 +++++++++++++++++++++++---- > > 1 file changed, 23 insertions(+), 4 deletions(-) > > > > Reviewed-by: Maxime Coquelin > > Thanks, > Maxime >