From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6AE75A04FD; Thu, 10 Nov 2022 05:02:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D3E1400EF; Thu, 10 Nov 2022 05:02:24 +0100 (CET) Received: from cvbackendsmtp002.nmdf.navercorp.com (cvbackendsmtp002.nmdf.navercorp.com [125.209.242.245]) by mails.dpdk.org (Postfix) with ESMTP id D95A4400D4; Thu, 10 Nov 2022 05:02:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=navercorp.com; s=s20171120; t=1668052940; bh=CXyPqEegIWXZOvQuhY3/IGQ9RtCs75L5ip4+92GmFEA=; h=Date:From:To:Subject:Message-ID:From:Subject:Feedback-ID: X-Works-Security; b=olr9TOvjsJI6aXQsCBm5H1vb/6tpYAKW1FDCOD/5l86BkRhqIry8wvsFcXvpi4Zdo uXoNCE4RUuTIHt384kGAhkDZGGN5u1S9EG01qGLvKQgLFhpXNtBYskjq33sYsIzhjQ WYUCiMxWdhgDuVSwNX4TXM/Ou9Lr5crddVJpD0et+gE9ngs45m8mA5tgR1HIL3QQQ9 SZQ/MMdk2CaKS1XAVzkj5NIoFYYhUQC0Q+X0cgoRTQvWdhgGpMj0AVKbXmoGjF8GxJ xywmqlsXiHgPDf+aLnp/fdAdgzVUrJ+cme6DJSawRm5w8mcZFesLheOuzK8sXKX7Ij gDwlJPQg1oSoQ== X-Session-ID: TYc0XHKXQdShSkL87JfIgQ X-Works-Smtp-Source: XdKZKA2rFoJCpNmmFAEmWHF0 Received: from dev-tkkim-git-send-email-ncl.nfra.io ([10.113.149.62]) by cvbackendsmtp002.nmdf.navercorp.com with ESMTP id TYc0XHKXQdShSkL87JfIgQ for ; Thu, 10 Nov 2022 04:02:20 -0000 Date: Thu, 10 Nov 2022 13:02:20 +0900 From: Taekyung Kim To: "Xia, Chenbo" Cc: "dev@dpdk.org" , "Pei, Andy" , "maxime.coquelin@redhat.com" , "stable@dpdk.org" , "Wang, Xiao W" Subject: Re: [PATCH v4] vdpa/ifc: fix update_datapath error handling Message-ID: References: <20221108085624.53989-1-kim.tae.kyung@navercorp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 10, 2022 at 01:53:50AM +0000, Xia, Chenbo wrote: > Hi Kim, > > > -----Original Message----- > > From: Taekyung Kim > > Sent: Tuesday, November 8, 2022 4:56 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Pei, Andy ; > > kim.tae.kyung@navercorp.com; maxime.coquelin@redhat.com; stable@dpdk.org; > > Wang, Xiao W > > Subject: [PATCH v4] vdpa/ifc: fix update_datapath error handling > > > > Stop and return the error code when update_datapath fails. > > update_datapath prepares resources for the vdpa device. > > The driver should not perform any further actions > > if update_datapath returns an error. > > > > Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") > > Cc: stable@dpdk.org > > > > Signed-off-by: Taekyung Kim > > --- > > v4: > > * Add rte_vdpa_unregister_device in ifcvf_pci_probe > > > > v3: > > * Fix coding style > > > > v2: > > * Revert the prepared resources before returning an error > > * Rebase to 22.11 rc2 > > * Add fixes and cc for backport > > > > --- > > drivers/vdpa/ifc/ifcvf_vdpa.c | 27 +++++++++++++++++++++++---- > > 1 file changed, 23 insertions(+), 4 deletions(-) > > I can't find your patch in patchwork: > > http://patchwork.dpdk.org/project/dpdk/list/?series=&submitter=2877&state=*&q=&archive=both&delegate= > > so it's difficult to review and merge. Do you know why or is it possible > that you send a new version to make it show on Patchwork today? > > Thanks, > Chenbo > Hi Chenbo, First, thanks for your review. I will send a new version for this patch soon. I think the mail for v4 is lost. Whenever I send a patch, I received "Your message to dev awaits moderator approval" from dev-owner@dpdk.org with the reason "Post by non-member to a members-only list". Maybe, the reason is that this is the first time that I submit a patch. Thanks, Taekyung